puppet-lint 1.0.0 → 1.0.1

data/lib/puppet-lint/plugins/check_classes.rb

@@ -256,7 +256,7 @@ PuppetLint.new_check(:variable_scope) do
         end
 
         unless token.value.include? '::'
-          unless variables_in_scope.include? token.value
+          unless variables_in_scope.include? token.value.gsub(/\[.+\]\Z/, '')
             unless token.value =~ /\A\d+\Z/
               notify :warning, {
                 :message => msg,

data/lib/puppet-lint/plugins/check_whitespace.rb

@@ -120,6 +120,7 @@ PuppetLint.new_check(:arrow_alignment) do
         elsif token.type == :LBRACE
           indent_depth_idx += 1
           indent_depth << 0
+          level_tokens[indent_depth_idx] ||= []
         elsif token.type == :RBRACE
           level_tokens[indent_depth_idx].each do |arrow_tok|
             unless arrow_tok.column == indent_depth[indent_depth_idx]

data/lib/puppet-lint/version.rb

@@ -1,3 +1,3 @@
 class PuppetLint
-  VERSION = '1.0.0'
+  VERSION = '1.0.1'
 end

data/spec/puppet-lint/plugins/check_classes/variable_scope_spec.rb

@@ -31,6 +31,37 @@ describe 'variable_scope' do
     end
   end
 
+  context 'class with no variables declared accessing local array index' do
+    let(:code) { "
+      class foo {
+        $bar = ['one', 'two', 'three']
+        $baz = $bar[1]
+      }"
+    }
+
+    it 'should not detect any problems' do
+      expect(problems).to have(0).problems
+    end
+  end
+
+  context 'class with no variables declared accessing local hash key' do
+    let(:code) { "
+      class foo {
+        $bar = {
+          'one'   => 1,
+          'two'   => 2,
+          'three' => 3,
+        }
+        $baz = $bar['two']
+      }"
+    }
+
+    it 'should not detect any problems' do
+      expect(problems).to have(0).problems
+    end
+  end
+
+
   context 'class with variables declared accessing local scope' do
     let(:code) { "
       class foo {

data/spec/puppet-lint/plugins/check_whitespace/arrow_alignment_spec.rb

@@ -236,6 +236,20 @@ describe 'arrow_alignment' do
         expect(problems).to contain_warning(msg).on_line(4).in_column(19)
       end
     end
+
+    context 'resource with multiple params where one is an empty hash' do
+      let(:code) { "
+        foo { 'foo':
+          a => true,
+          b => {
+          }
+        }
+      "}
+
+      it 'should not detect any problems' do
+        expect(problems).to have(0).problems
+      end
+    end
   end
 
   context 'with fix enabled' do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: puppet-lint
 version: !ruby/object:Gem::Version 
-  hash: 23
+  hash: 21
   prerelease: 
   segments: 
   - 1
   - 0
-  - 0
-  version: 1.0.0
+  - 1
+  version: 1.0.1
 platform: ruby
 authors: 
 - Tim Sharpe
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2014-08-18 00:00:00 +10:00
+date: 2014-08-20 00:00:00 +10:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency