puppet-lint 0.1.3 → 0.1.4

data/README.md

@@ -38,6 +38,7 @@ At the moment, the following tests have been implemented:
 
  * All strings that do not contain variables should be enclosed in single
    quotes.
+   * An exception has been made for double quoted strings containing \n or \t.
  * All strings that contain variables must be enclosed in double quotes.
  * All variables should be enclosed in braces when interpolated in a string.
  * Variables standing by themselves should not be quoted.

data/lib/puppet-lint.rb

@@ -5,7 +5,7 @@ require 'puppet'
 class PuppetLint::NoCodeError < StandardError; end
 
 class PuppetLint
-  VERSION = '0.1.3'
+  VERSION = '0.1.4'
 
   attr_reader :code, :file
 

data/lib/puppet-lint/plugins/check_strings.rb

@@ -25,7 +25,9 @@ class PuppetLint::Plugins::CheckStrings < PuppetLint::CheckPlugin
       token = tokens[token_idx]
 
       if token.first == :STRING
-        warn "double quoted string containing no variables on line #{token.last[:line]}"
+        unless token.last[:value].include? "\t" or token.last[:value].include? "\n"
+          warn "double quoted string containing no variables on line #{token.last[:line]}"
+        end
       end
 
       if token.first == :DQPRE and token.last[:value] == ""

data/puppet-lint.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name = 'puppet-lint'
-  s.version = '0.1.3'
+  s.version = '0.1.4'
   s.homepage = 'https://github.com/rodjek/puppet-lint/'
   s.summary = 'Ensure your Puppet manifests conform with the Puppetlabs style guide'
   s.description = 'Checks your Puppet manifests against the Puppetlabs

data/spec/puppet-lint/check_strings_spec.rb

@@ -48,4 +48,11 @@ describe PuppetLint::Plugins::CheckStrings do
     its(:warnings) { should be_empty }
     its(:errors) { should be_empty }
   end
+
+  describe 'double quoted string containing newline but no variables' do
+    let(:code) { '"foo\n"' }
+
+    its(:warnings) { should be_empty }
+    its(:errors) { should be_empty }
+  end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: puppet-lint
 version: !ruby/object:Gem::Version 
-  hash: 29
+  hash: 19
   prerelease: 
   segments: 
   - 0
   - 1
-  - 3
-  version: 0.1.3
+  - 4
+  version: 0.1.4
 platform: ruby
 authors: 
 - Tim Sharpe