puppet-lint-world_writable_files-check 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8b2909f71fa762b4d7e478b53f5dadd7b45e0d3f
-  data.tar.gz: f6af4485074efc3167488d9453a0eebee01f49e1
+  metadata.gz: c422e5c547b8970aee127701ee500069b8c193f4
+  data.tar.gz: 6da18f952ad84ddee2abfac90a3b6b38ae6e6353
 SHA512:
-  metadata.gz: a1894c08b740718a36019f57194d137b7efcca2768e74428a14e86a15eae655eac2e77286065423493e91cb5216ccad226016333fcf4b7860bf6a23ce731b045
-  data.tar.gz: 9721fe6ed35fc6f4b56fc26f3f651eff712841731beaaf2476209c3cb92d2bd0432fcbb25a6a7f015c9310865e2203f8b74e8cf19e2ccc8af87671704a2cc95f
+  metadata.gz: 3a0272ad88bf4076fda75064cbd21091aa5c307899607399e097f6254639dfdba7cea5f501ccc59ef82c594b95f3a80b57b4de5626276f3fe3d67ab75abb6f4e
+  data.tar.gz: 46b547b06f15095eef5351c7cce136abc404cb973e275daecce29a88cf9b803bf51479155d4fd3558b9dcd7d1c4f515901efa49abf84fc8b40966287c09d458f

data/README.md

@@ -1,4 +1,4 @@
-# puppet-lint world_writable_files check #
+# puppet-lint world_writable_files check
 
 A puppet-lint extension that ensures file resources do not have a mode
 that makes them world writable.
@@ -15,7 +15,7 @@ This plugin currently only checks octal file modes, the
 `puppet-lint` check ensure this isn't a problem for my code bases but it
 might be a consideration for other peoples usages.
 
-## Installation ##
+## Installation
 
 To use this plugin add the following line to your `Gemfile`
 
@@ -23,7 +23,7 @@ To use this plugin add the following line to your `Gemfile`
 
 and then run `bundle install`
 
-## Usage ##
+## Usage
 
 This plugin provides a new check to `puppet-lint` that warns if it finds
 a file resource that would be created with a mode that allowed every one
@@ -41,5 +41,10 @@ of the system and so will raise:
 
     files should not be created with world writable permissions
 
-### Author ###
+## Other puppet-lint plugins
+
+You can find a list of my `puppet-lint` plugins in the
+[unixdaemon puppet-lint-plugins](https://github.com/deanwilson/unixdaemon-puppet-lint-plugins) repo.
+
+### Author
 [Dean Wilson](http://www.unixdaemon.net)

data/lib/puppet-lint/plugins/world_writable_files.rb

@@ -9,6 +9,8 @@ PuppetLint.new_check(:world_writable_files) do
           # get the file modes value
           value_token = param_token.next_code_token.next_code_token
 
+          # we only work with octal for now - also stops file { mode => undef }
+          break if value_token.value !~ /^\d+$/
           break if value_token.value =~ /\d+[^2367]$/
 
           notify :warning, {

data/spec/puppet-lint/plugins/puppet-lint-world_writable_files_spec.rb

@@ -18,6 +18,23 @@ describe 'world_writable_files' do
     end
   end
 
+  context 'file with a mode of undef' do
+    let(:code) do
+      <<-EOS
+        class undef_file_mode {
+          file { '/tmp/undef_file_mode':
+            ensure => 'file',
+            mode   => undef,
+          }
+        }
+      EOS
+    end
+
+    it 'should not detect any problems' do
+      expect(problems).to have(0).problems
+    end
+  end
+
   context 'file with a world writable octal mode of 666' do
     let(:msg) { 'files should not be created with world writable permissions' }
     let(:code) do
@@ -39,4 +56,6 @@ describe 'world_writable_files' do
       expect(problems).to contain_warning(msg).on_line(4).in_column(23)
     end
   end
+
+
 end

metadata

@@ -1,29 +1,35 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint-world_writable_files-check
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Dean Wilson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-01 00:00:00.000000000 Z
+date: 2016-08-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puppet-lint
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.1'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.1'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -132,6 +138,6 @@ signing_key:
 specification_version: 4
 summary: puppet-lint check to ensure file resources are not world writable
 test_files:
-- spec/puppet-lint/plugins/puppet-lint-world_writable_files_spec.rb
 - spec/spec_helper.rb
+- spec/puppet-lint/plugins/puppet-lint-world_writable_files_spec.rb
 has_rdoc: