puppet-lint-wmf_styleguide-check 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 827734026504a15ef6e6c2e3003499a467f3a222
-  data.tar.gz: ba471ad1f7f634ca080cc5c0a1d93e9877343420
+SHA256:
+  metadata.gz: 7980b85ac1476eb1cfd7107a024a8d01f56d3aaa13bc4adf6542b52edeb862a8
+  data.tar.gz: f5b71a6c23db3e26deec5d4f2a2d036ad4dbaeb26e0aa80d2049bf6e95e830eb
 SHA512:
-  metadata.gz: 4460a00a245dbfad6e9105287f76479e7182ade5a47bf6f12a0804983a55cbaee7db026c6cd765e31279f211c8d12a09f4576042c56d6ffdc4f0bafadd268fd4
-  data.tar.gz: 6877ce5a41f58aa4055fd01b0cdbb151cdf0620fd5336c419e4e1c6c7dcbd16a70c7adea13ca0c992f8b080ba3f5284d8edb39be11c29b6621dcd2ed6bd37a51
+  metadata.gz: 814e0b269f85a970e883534f42a12f201e0afaf530f47474e7bbfaf685dd0ae549a529de9c639768c6e34f11d53bb66425e7c31a4a25cf0d6bb6d60f9c614238
+  data.tar.gz: 8b85af51045fc558202c404ce87f20c0ca14dc76538ea30bde1abd68c3eac4ac154e1a77a309ff08b9e96ed93aca6945e870d117553259a68aa09d45d7b68b91

data/lib/puppet-lint/plugins/check_wmf_styleguide.rb

@@ -1,4 +1,8 @@
+# frozen_string_literal: true
+
 # Class to manage puppet resources.
+# See how we extend PuppetLint::Lexer::Token below to understand how we filter
+# tokens within a parsed resource.
 class PuppetResource
   attr_accessor :profile_module, :role_module
 
@@ -49,63 +53,89 @@ class PuppetResource
   # rubocop:enable Metrics/CyclomaticComplexity, Metrics/MethodLength
 
   def params
+    # Lazy-load and return all the parameters of the resource
     @params || parse_params
   end
 
   def profile_module
+    # Return the name of the module where profiles are located
     @profile_module || 'profile'
   end
 
   def role_module
+    # Return the name of the module where roles are located
     @role_module || 'role'
   end
 
   def class?
+    # True if this is a class,
     @resource[:type] == :CLASS
   end
 
   def name
+    # Extract a normalized resource name (without the :: prefix if present)
     @resource[:name_token].value.gsub(/^::/, '')
   end
 
   def path
+    # Path of the resource
     @resource[:path]
   end
 
   def filename
-    puts @resource
+    # File name of the resource
     @resource[:filename]
   end
 
   def module_name
+    # Module containing this resource
     name.split('::')[0]
   end
 
   def profile?
+    # True if the resource is in the profile module
     class? && (module_name == profile_module)
   end
 
   def role?
+    # True if the resource is in the role module
     class? && (module_name == role_module)
   end
 
-  def hiera_calls
-    @resource[:tokens].select(&:hiera?)
+  def lookup_calls
+    # Returns an array of all the tokens referencing calls to lookup
+    @resource[:tokens].select(&:lookup?)
+  end
+
+  def legacy_hiera_calls
+    # Returns an array of all the tokens referencing calls to hiera
+    @resource[:tokens].select(&:legacy_hiera?)
+  end
+
+  def legacy_validate_calls
+    # Returns an array of all the tokens referencing calls to a stdlib legacy validate function
+    @resource[:tokens].select(&:legacy_validate?)
   end
 
   def included_classes
+    # Returns an array of all the classes included (with require/include)
     @resource[:tokens].map(&:included_class).compact
   end
 
   def declared_classes
+    # Returns an array of all the declared classes
     @resource[:tokens].map(&:declared_class).compact
   end
 
   def declared_resources
+    # Returns an array of all the declared classes
     @resource[:tokens].select(&:declared_type?)
   end
 
   def resource?(name)
+    # Arguments:
+    #   name (string) Name of the resource we want to search
+    # Returns an array of all the defines of the specified resource
     @resource[:tokens].select { |t| t.declared_type? && t.value.gsub(/^::/, '') == name }
   end
 end
@@ -116,18 +146,32 @@ class PuppetLint
     class Token
       # Extend the basic token with utility functions
       def function?
-        @type == :NAME && @next_code_token.type == :LPAREN
+        # A function is something that has a name and is followed by a left parens
+        [:NAME, :FUNCTION_NAME].include?(@type) && @next_code_token.type == :LPAREN
       end
 
-      def hiera?
-        function? && @value == 'hiera'
+      def legacy_hiera?
+        # Using old hiera call
+        function? && ['hiera', 'hiera_array', 'hiera_hash'].include?(@value)
+      end
+
+      def lookup?
+        # A function call specifically calling lookup
+        function? && ['lookup'].include?(@value)
+      end
+
+      def legacy_validate?
+        # A function calling one of the legacy stdlib validate functions
+        function? && @value.start_with?('validate_')
       end
 
       def class_include?
-        @type == :NAME && ['include', 'require'].include?(@value) && @next_code_token.type != :FARROW
+        # Check for include-like objects
+        @type == :NAME && ['include', 'require', 'contain'].include?(@value) && @next_code_token.type != :FARROW
       end
 
       def included_class
+        # Fetch the token describing the included class
         return unless class_include?
         return @next_code_token.next_code_token if @next_code_token.type == :LPAREN
         @next_code_token
@@ -141,6 +185,7 @@ class PuppetLint
       end
 
       def declared_type?
+        # The token is a name and the next token is a {, while the previous one is not "class"
         @type == :NAME && @next_code_token.type == :LBRACE && @prev_code_token.type != :CLASS
       end
 
@@ -149,6 +194,7 @@ class PuppetLint
       end
 
       def role_keyword?
+        # This is a function with name "role"
         @type == :NAME && @value = 'role' && @next_code_token.type == :LPAREN
       end
     end
@@ -157,10 +203,10 @@ end
 
 # Checks and functions
 def check_profile(klass)
-  # All parameters of profiles should have a default value that is a hiera lookup
-  params_without_hiera_defaults klass
-  # All hiera lookups should be in parameters
-  hiera_not_in_params klass
+  # All parameters of profiles should have a default value that is a lookup
+  params_without_lookup_defaults klass
+  # All lookup lookups should be in parameters
+  lookup_not_in_params klass
   # Only a few selected classes should be included in a profile
   profile_illegal_include klass
   # System::role only goes in roles
@@ -169,7 +215,7 @@ end
 
 def check_role(klass)
   # Hiera lookups within a role are forbidden
-  hiera klass
+  lookup klass
   # A role should only include profiles
   include_not_profile klass
   # A call, and only one, to system::role will be done
@@ -179,8 +225,8 @@ def check_role(klass)
 end
 
 def check_class(klass)
-  # No hiera lookups allowed in a class.
-  hiera klass
+  # No lookup lookups allowed in a class.
+  lookup klass
   # Cannot include or declare classes from other modules
   class_illegal_include klass
   illegal_class_declaration klass
@@ -189,25 +235,26 @@ def check_class(klass)
 end
 
 def check_define(define)
-  # No hiera calls are admitted in defines. ever.
-  hiera define
+  # No lookup calls are admitted in defines. ever.
+  lookup define
   # No class can be included in defines, like in classes
   class_illegal_include define
   # Non-profile defines should respect the rules for classes
   illegal_class_declaration define unless define.module_name == 'profile'
 end
 
-def hiera(klass)
-  hiera_errors(klass.hiera_calls, klass)
+def lookup(klass)
+  # Searches for lookup calls inside classes and defines.
+  lookup_errors(klass.lookup_calls, klass)
 end
 
-def params_without_hiera_defaults(klass)
-  # Finds parameters that have no hiera-defined default value.
-  klass.params.each do |name, data|
-    next unless data[:value].select(&:hiera?).empty?
-    token = data[:param]
+def legacy_hiera(klass)
+  # No calls to legacy hiera
+  tokens = klass.legacy_hiera_calls
+  tokens.each do |token|
     msg = {
-      message: "wmf-style: Parameter '#{name}' of class '#{klass.name}' has no call to hiera",
+      message: "wmf-style: Found deprecated function (#{token.value}) " \
+               "in #{klass.type} '#{klass.name}', use lookup instead",
       line: token.line,
       column: token.column
     }
@@ -215,19 +262,52 @@ def params_without_hiera_defaults(klass)
   end
 end
 
-def hiera_not_in_params(klass)
-  tokens = klass.hiera_calls.reject do |token|
+def params_without_lookup_defaults(klass)
+  # Finds parameters that have no lookup-defined default value.
+  klass.params.each do |name, data|
+    next unless data[:value].select(&:lookup?).empty?
+    common = "wmf-style: Parameter '#{name}' of class '#{klass.name}'"
+    message = if data[:value].select(&:legacy_hiera?).empty?
+                "#{common} has no call to lookup"
+              else
+                "#{common} hiera is deprecated use lookup"
+              end
+    token = data[:param]
+    msg = { message: message, line: token.line, column: token.column }
+    notify :error, msg
+  end
+end
+
+def lookup_not_in_params(klass)
+  # Checks if a lookup call is not in a parameter declaration. Used to check profiles
+
+  # Any lookup call that is not inside a parameter declaration is a violation
+  tokens = klass.lookup_calls.reject do |token|
     maybe_param = token.prev_code_token.prev_code_token
     klass.params.keys.include?(maybe_param.value)
   end
-  hiera_errors(tokens, klass)
+  lookup_errors(tokens, klass)
 end
 
-def hiera_errors(tokens, klass)
+def lookup_errors(tokens, klass)
+  # Helper for printing lookup errors nicely
   tokens.each do |token|
+    # lookup ( 'some::label' )
     value = token.next_code_token.next_code_token.value
     msg = {
-      message: "wmf-style: Found hiera call in #{klass.type} '#{klass.name}' for '#{value}'",
+      message: "wmf-style: Found lookup call in #{klass.type} '#{klass.name}' for '#{value}'",
+      line: token.line,
+      column: token.column
+    }
+    notify :error, msg
+  end
+end
+
+def legacy_validate_errors(klass)
+  # Helper for printing errors nicely
+  klass.legacy_validate_calls.each do |token|
+    msg = {
+      message: "wmf-style: Found legacy function (#{token.value}) call in #{klass.type} '#{klass.name}'",
       line: token.line,
       column: token.column
     }
@@ -236,6 +316,9 @@ def hiera_errors(tokens, klass)
 end
 
 def profile_illegal_include(klass)
+  # Check if a profile includes any class that's not allowed there.
+  # Allowed are: any other profile, or a class from the passwords module,
+  # plus a couple parameter classes
   modules_include_ok = ['profile', 'passwords']
   classes_include_ok = ['lvs::configuration', 'network::constants']
   klass.included_classes.each do |token|
@@ -253,6 +336,7 @@ def profile_illegal_include(klass)
 end
 
 def class_illegal_include(klass)
+  # A class should only include classes from the same module.
   modules_include_ok = [klass.module_name]
   klass.included_classes.each do |token|
     class_name = token.value.gsub(/^::/, '')
@@ -268,7 +352,8 @@ def class_illegal_include(klass)
 end
 
 def include_not_profile(klass)
-  modules_include_ok = ['role', 'profile', 'standard']
+  # Checks that a role only includes other roles and profiles
+  modules_include_ok = ['role', 'profile']
   klass.included_classes.each do |token|
     class_name = token.value.gsub(/^::/, '')
     module_name = class_name.split('::')[0]
@@ -312,6 +397,7 @@ def check_no_system_role(klass)
 end
 
 def check_system_role(klass)
+  # Check that a role does indeed declare system::role
   return if klass.resource?('system::role').length == 1
   msg = {
     message: "wmf-style: role '#{klass.name}' should declare system::role once",
@@ -322,6 +408,7 @@ def check_system_role(klass)
 end
 
 def check_no_defines(klass)
+  # In a role, check if there is any define apart from one system::role call
   return if klass.declared_resources == klass.resource?('system::role')
   msg = {
     message: "wmf-style: role '#{klass.name}' should not include defines",
@@ -331,18 +418,40 @@ def check_no_defines(klass)
   notify :error, msg
 end
 
+def check_deprecations(resource)
+  # Check the resource for declarations of deprecated defines
+  legacy_validate_errors resource
+  legacy_hiera resource
+  deprecated_defines = ['base::service_unit']
+  deprecated_defines.each do |deprecated|
+    resource.resource?(deprecated).each do |token|
+      msg = {
+        message: "wmf-style: '#{resource.name}' should not include the deprecated define '#{token.value}'",
+        line: token.line,
+        column: token.column
+      }
+      notify :error, msg
+    end
+  end
+end
+
 # rubocop:disable Metrics/MethodLength, Metrics/PerceivedComplexity, Metrics/AbcSize, Metrics/CyclomaticComplexity
 def check_node(node)
   title = node[:title_tokens].map(&:value).join(', ')
   node[:tokens].each do |token|
     msg = nil
-    if token.hiera?
+    if token.lookup?
       msg = {
-        message: "wmf-style: Found hiera call in node '#{title}'",
+        message: "wmf-style: node '#{title}' calls lookup function",
+        line: token.line,
+        column: token.column
+      }
+    elsif token.legacy_hiera?
+      msg = {
+        message: "wmf-style: node '#{title}' calls legacy #{token.value} function",
         line: token.line,
         column: token.column
       }
-
     elsif token.class_include?
       msg = {
         message: "wmf-style: node '#{title}' includes class #{token.included_class.value}",
@@ -355,18 +464,12 @@ def check_node(node)
         line: token.line,
         column: token.column
       }
-    elsif token.declared_type?
+    elsif token.declared_type? && token.value != 'interface::add_ip6_mapped'
       msg = {
         message: "wmf-style: node '#{title}' declares #{token.value}",
         line: token.line,
         column: token.column
       }
-    elsif token.role_keyword? && token.next_code_token.next_code_token.next_code_token.type != :RPAREN
-      msg = {
-        message: "wmf-style: node '#{title}' includes multiple roles",
-        line: token.line,
-        column: token.column
-      }
     end
     notify :error, msg if msg
   end
@@ -420,6 +523,7 @@ PuppetLint.new_check(:wmf_styleguide) do
       else
         check_class klass
       end
+      check_deprecations klass
     end
   end
 
@@ -428,6 +532,7 @@ PuppetLint.new_check(:wmf_styleguide) do
     defined_type_indexes.each do |df|
       define = PuppetResource.new(df)
       check_define define
+      check_deprecations define
     end
     node_indexes.each do |node|
       check_node node

data/spec/puppet-lint/plugins/check_wmf_styleguide_check_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 class_ok = <<-EOF
@@ -12,16 +14,23 @@ EOF
 
 class_ko = <<-EOF
 class foo($t=hiera('foo::title')) {
-       $msg = hiera( "foo::bar")
+       $msg = lookup( "foo::bar")
        notice($msg)
        notice($t)
        include ::passwords::redis
        class { 'bar': }
+       validate_foobar($param)
+       validate_re($param, '^.*$')
+       hiera('foobar')
+       hiera_hash('foobar')
+       hiera_array('foobar')
 }
 EOF
 
 profile_ok = <<-EOF
-class profile::foobar ($test=hiera('profile::foobar::test')) {
+class profile::foobar (
+      $test=lookup('profile::foobar::test'),
+) {
       require ::profile::foo
       include ::passwords::redis
       class { '::bar': }
@@ -30,17 +39,19 @@ EOF
 
 profile_ko = <<-EOF
 class profile::fixme (
-      $test,
+      $test1,
+      $test2=hiera('profile::foobar::foo')
+      $test3=hiera_array('profile::foobar::foo')
+      $test4=hiera_hash('profile::foobar::foo')
 ) {
     include ::apache2::common
-    $role = hiera('role')
+    $role = lookup('role')
     system::role { $role: }
 }
 EOF
 
 role_ok = <<-EOF
 class role::fizzbuz {
-      include standard
       include ::profile::base
       include ::profile::bar
       system::role { 'fizzbuzz': }
@@ -68,6 +79,11 @@ define_ko = <<-EOF
 define foo::fixme ($a=hiera('something')) {
        include ::foo
        class { '::bar': }
+       validate_foobar($param)
+       validate_re($param, '^.*$')
+       hiera('foobar')
+       hiera_hash('foobar')
+       hiera_array('foobar')
 }
 EOF
 
@@ -79,12 +95,20 @@ EOF
 
 node_ko = <<-EOF
 node 'fixme' {
-     role(spare::system,
-          mediawiki::appserver)
      include base::firewall
      interface::mapped { 'eth0':
         foo => 'bar'
      }
+     lookup('foobar')
+     hiera('foobar')
+     hiera_array('foobar')
+     hiera_hash('foobar')
+}
+EOF
+
+deprecation_ko = <<-EOF
+define test() {
+   base::service_unit{ 'test2': }
 }
 EOF
 
@@ -112,28 +136,44 @@ describe 'wmf_styleguide' do
   context 'class with errors' do
     let(:code) { class_ko }
     it 'should create errors for hiera declarations' do
-      expect(problems).to contain_error("wmf-style: Found hiera call in class 'foo' for 'foo::title'").on_line(1).in_column(14)
-      expect(problems).to contain_error("wmf-style: Found hiera call in class 'foo' for 'foo::bar'").on_line(2).in_column(15)
+      expect(problems).to contain_error("wmf-style: Found deprecated function (hiera) in class 'foo', use lookup instead").on_line(1).in_column(14)
+      expect(problems).to contain_error("wmf-style: Found lookup call in class 'foo' for 'foo::bar'").on_line(2).in_column(15)
     end
     it 'should create errors for included classes' do
       expect(problems).to contain_error("wmf-style: class 'foo' includes passwords::redis from another module").on_line(5).in_column(16)
       expect(problems).to contain_error("wmf-style: class 'foo' declares class bar from another module").on_line(6).in_column(16)
     end
+    it 'should create errors for validate_function' do
+      expect(problems).to contain_error("wmf-style: Found legacy function (validate_foobar) call in class 'foo'").on_line(7).in_column(8)
+      expect(problems).to contain_error("wmf-style: Found legacy function (validate_re) call in class 'foo'").on_line(8).in_column(8)
+    end
+    it 'should create errors for hiera function' do
+      expect(problems).to contain_error("wmf-style: Found deprecated function (hiera) in class 'foo', use lookup instead").on_line(9).in_column(8)
+    end
+    it 'should create errors for hiera_hash function' do
+      expect(problems).to contain_error("wmf-style: Found deprecated function (hiera_hash) in class 'foo', use lookup instead").on_line(10).in_column(8)
+    end
+    it 'should create errors for hiera_array function' do
+      expect(problems).to contain_error("wmf-style: Found deprecated function (hiera_array) in class 'foo', use lookup instead").on_line(11).in_column(8)
+    end
   end
 
   context 'profile with errors' do
     let(:code) { profile_ko }
     it 'should create errors for parameters without hiera defaults' do
-      expect(problems).to contain_error("wmf-style: Parameter 'test' of class 'profile::fixme' has no call to hiera").on_line(2).in_column(7)
+      expect(problems).to contain_error("wmf-style: Parameter 'test1' of class 'profile::fixme' has no call to lookup").on_line(2).in_column(7)
+      expect(problems).to contain_error("wmf-style: Parameter 'test2' of class 'profile::fixme' hiera is deprecated use lookup").on_line(3).in_column(7)
+      expect(problems).to contain_error("wmf-style: Parameter 'test3' of class 'profile::fixme' hiera is deprecated use lookup").on_line(4).in_column(7)
+      expect(problems).to contain_error("wmf-style: Parameter 'test4' of class 'profile::fixme' hiera is deprecated use lookup").on_line(5).in_column(7)
     end
     it 'should create errors for hiera calls in body' do
-      expect(problems).to contain_error("wmf-style: Found hiera call in class 'profile::fixme' for 'role'").on_line(5).in_column(13)
+      expect(problems).to contain_error("wmf-style: Found lookup call in class 'profile::fixme' for 'role'").on_line(8).in_column(13)
     end
     it 'should create errors for use of system::role' do
-      expect(problems).to contain_error("wmf-style: class 'profile::fixme' declares system::role, which should only be used in roles").on_line(6).in_column(5)
+      expect(problems).to contain_error("wmf-style: class 'profile::fixme' declares system::role, which should only be used in roles").on_line(9).in_column(5)
     end
     it 'should create errors for non-explicit class inclusion' do
-      expect(problems).to contain_error("wmf-style: profile 'profile::fixme' includes non-profile class apache2::common").on_line(4).in_column(13)
+      expect(problems).to contain_error("wmf-style: profile 'profile::fixme' includes non-profile class apache2::common").on_line(7).in_column(13)
     end
   end
 
@@ -152,11 +192,24 @@ describe 'wmf_styleguide' do
   context 'defined type with violations' do
     let(:code) { define_ko }
     it 'should not contain hiera calls' do
-      expect(problems).to contain_error("wmf-style: Found hiera call in defined type 'foo::fixme' for 'something'").on_line(1)
+      expect(problems).to contain_error("wmf-style: Found deprecated function (hiera) in defined type 'foo::fixme', use lookup instead").on_line(1)
     end
     it 'should not include or define any class' do
       expect(problems).to contain_error("wmf-style: defined type 'foo::fixme' declares class bar from another module").on_line(3)
     end
+    it 'should create errors for validate_function' do
+      expect(problems).to contain_error("wmf-style: Found legacy function (validate_foobar) call in defined type 'foo::fixme'").on_line(4).in_column(8)
+      expect(problems).to contain_error("wmf-style: Found legacy function (validate_re) call in defined type 'foo::fixme'").on_line(5).in_column(8)
+    end
+    it 'should create errors for hiera function' do
+      expect(problems).to contain_error("wmf-style: Found deprecated function (hiera) in defined type 'foo::fixme', use lookup instead").on_line(6).in_column(8)
+    end
+    it 'should create errors for hiera_hash function' do
+      expect(problems).to contain_error("wmf-style: Found deprecated function (hiera_hash) in defined type 'foo::fixme', use lookup instead").on_line(7).in_column(8)
+    end
+    it 'should create errors for hiera_array function' do
+      expect(problems).to contain_error("wmf-style: Found deprecated function (hiera_array) in defined type 'foo::fixme', use lookup instead").on_line(8).in_column(8)
+    end
   end
 
   context 'node with no errors' do
@@ -167,14 +220,30 @@ describe 'wmf_styleguide' do
   end
   context 'node with violations' do
     let(:code) { node_ko }
-    it 'should not have multiple roles applied' do
-      expect(problems).to contain_error("wmf-style: node 'fixme' includes multiple roles").on_line(2)
-    end
     it 'should not include classes directly' do
       expect(problems).to contain_error("wmf-style: node 'fixme' includes class base::firewall")
     end
     it 'should not declare any defined type' do
       expect(problems).to contain_error("wmf-style: node 'fixme' declares interface::mapped")
     end
+    it 'should not call lookup' do
+      expect(problems).to contain_error("wmf-style: node 'fixme' calls lookup function")
+    end
+    it 'should not call hiera' do
+      expect(problems).to contain_error("wmf-style: node 'fixme' calls legacy hiera function")
+    end
+    it 'should not call hiera_array' do
+      expect(problems).to contain_error("wmf-style: node 'fixme' calls legacy hiera_array function")
+    end
+    it 'should not call hiera_hash' do
+      expect(problems).to contain_error("wmf-style: node 'fixme' calls legacy hiera_hash function")
+    end
+  end
+
+  context 'defined type with deprecations' do
+    let(:code) { deprecation_ko }
+    it 'should not' do
+      expect(problems).to contain_error("wmf-style: 'test' should not include the deprecated define 'base::service_unit'")
+    end
   end
 end

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'puppet-lint'
 
 PuppetLint::Plugins.load_spec_helper

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint-wmf_styleguide-check
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Giuseppe Lavagetto
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-24 00:00:00.000000000 Z
+date: 2021-02-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puppet-lint
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: 2.4.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: 2.4.0
 - !ruby/object:Gem::Dependency
   name: git
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.0
+        version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.0
+        version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -84,16 +84,16 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '12.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '12.0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -108,6 +108,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.49.1
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.17.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.17.1
 description: |2
       A puppet-lint plugin to check that the code adheres to the WMF coding guidelines:
 
@@ -118,6 +132,8 @@ description: |2
       * Check for system::role calls outside of roles
       * Check for cross-module class inclusion
       * Check for the use of the include keyword in profiles
+      * Check for wmf-deprecated resources usage
+      * Check for deprecated validate_* functions
 email: lavagetto@gmail.com
 executables: []
 extensions: []
@@ -128,7 +144,7 @@ files:
 - lib/puppet-lint/plugins/check_wmf_styleguide.rb
 - spec/puppet-lint/plugins/check_wmf_styleguide_check_spec.rb
 - spec/spec_helper.rb
-homepage: https://github.com/wikimedia/operations-puppet-lint-wmf_styleguide-check
+homepage: https://github.com/lavagetto/puppet-lint-wmf_styleguide-check
 licenses:
 - GPL-3.0
 metadata: {}
@@ -148,10 +164,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2.1
+rubygems_version: 2.7.6.2
 signing_key: 
 specification_version: 4
 summary: A puppet-lint plugin to check code adheres to the WMF coding guidelines
 test_files:
-- spec/spec_helper.rb
 - spec/puppet-lint/plugins/check_wmf_styleguide_check_spec.rb
+- spec/spec_helper.rb