puppet-lint-version_comparison-check 1.1.0 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8fb963a206341b0ca35ac2ae345a68d25ef28553fb6710cccecadce1e8fb417f
-  data.tar.gz: '058e28f92340c9c4714f6330ea34d0b57459be5a2c395e2f3ac20caf6059b86b'
+  metadata.gz: 3f0fb488a190f4b634f9913035b143587b4d04ab06067f43823c4d5a1362f9af
+  data.tar.gz: 660b7366183263734bb2202822568ab24d96552bb1513e710ad53f3786191e5c
 SHA512:
-  metadata.gz: 6b0ccc13db5fbbcbaa7b3907b8f7ac46b2ad0945cab46b67fec2de08bb5bfb08e319595c9ac9fa5cf1b8b3dbe9c72c651da7973ff4ad1c92d007853aa36b0a20
-  data.tar.gz: 422a9cfe4bfca63c9b2b71bb7c4ed1f183341eb1240cc8318c5a45f51b00af1adcabfe6cf0f77751119705f45eabe9f1283b4c48f448f775964a287ce1b9cbd0
+  metadata.gz: a0070ed982948400602f81bf5b8cacd8a42da6ce7ed2044aea8080eca6769aef3cf266c1aa0e45c7541b2fb91c2a3a87f38cc349d5a762f863810516a0ab5ddf
+  data.tar.gz: cd95872558df90c2c74196b517ed452c190f25467d0f1fd7833f09e761efcf9f9a0af0a564d583b539b06a1f231cb1281bcd8ef47c367c459cfd9fc0a5b0caac

data/CHANGELOG.md

@@ -2,6 +2,22 @@
 
 All notable changes to this project will be documented in this file.
 
+## [3.0.0](https://github.com/voxpupuli/puppet-lint-version_comparison-check/tree/3.0.0) (2025-09-25)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-lint-version_comparison-check/compare/2.0.0...3.0.0)
+
+**Breaking changes:**
+
+- Require Ruby 3.2+ & puppet-lint 5.1+ [\#26](https://github.com/voxpupuli/puppet-lint-version_comparison-check/pull/26) ([bastelfreak](https://github.com/bastelfreak))
+
+## [2.0.0](https://github.com/voxpupuli/puppet-lint-version_comparison-check/tree/2.0.0) (2023-04-21)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-lint-version_comparison-check/compare/1.1.0...2.0.0)
+
+**Breaking changes:**
+
+- Drop Ruby \< 2.7; Add RuboCop [\#15](https://github.com/voxpupuli/puppet-lint-version_comparison-check/pull/15) ([bastelfreak](https://github.com/bastelfreak))
+
 ## [1.1.0](https://github.com/voxpupuli/puppet-lint-version_comparison-check/tree/1.1.0) (2022-11-29)
 
 [Full Changelog](https://github.com/voxpupuli/puppet-lint-version_comparison-check/compare/1.0.0...1.1.0)

data/lib/puppet-lint/plugins/check_version_comparison.rb

@@ -1,25 +1,27 @@
 PuppetLint.new_check(:version_comparison) do
   def is_num_comparison?(token)
     return false unless token
-    return true if [:GREATEREQUAL, :GREATERTHAN, :LESSEQUAL, :LESSTHAN].include?(token.type)
-    return true if [:ISEQUAL, :NOTEQUAL].include?(token.type) && \
-                   token.next_code_token && \
-                   token.next_code_token.type == :NUMBER
+    return true if %i[GREATEREQUAL GREATERTHAN LESSEQUAL LESSTHAN].include?(token.type)
+
+    true if %i[ISEQUAL NOTEQUAL].include?(token.type) &&
+            token.next_code_token &&
+            token.next_code_token.type == :NUMBER
   end
 
   def check
-    tokens.each_with_index do |token, token_idx|
+    tokens.each_with_index do |token, _token_idx|
       next unless token.type == :VARIABLE
-      next unless token.value =~ /(?:version|release)$/
+      next unless /(?:version|release)$/.match?(token.value)
       next unless is_num_comparison?(token.next_code_token)
+
       notify :warning, {
-        :message => 'version compared as number',
-        :line    => token.line,
-        :column  => token.column,
-        :token   => token,
+        message: 'version compared as number',
+        line: token.line,
+        column: token.column,
+        token: token,
       }
     end
-  end 
+  end
 
   def compared_value(token)
     token.next_code_token.next_code_token.value
@@ -32,23 +34,23 @@ PuppetLint.new_check(:version_comparison) do
     )
     lparen = PuppetLint::Lexer::Token.new(
       :LPAREN, '(',
-      problem[:token].line, problem[:token].column+1
+      problem[:token].line, problem[:token].column + 1
     )
     rparen = PuppetLint::Lexer::Token.new(
       :RPAREN, ')',
-      problem[:token].line, problem[:token].column+2 # not +2
+      problem[:token].line, problem[:token].column + 2 # not +2
     )
     space = PuppetLint::Lexer::Token.new(
       :WHITESPACE, ' ',
-      problem[:token].line, problem[:token].column+3 # not +3
+      problem[:token].line, problem[:token].column + 3 # not +3
     )
     comma = PuppetLint::Lexer::Token.new(
       :COMMA, ',',
-      problem[:token].line, problem[:token].column+4 # not +4
+      problem[:token].line, problem[:token].column + 4 # not +4
     )
     value = PuppetLint::Lexer::Token.new(
       :SSTRING, compared_value(problem[:token]),
-      problem[:token].line, problem[:token].column+5 # not +5
+      problem[:token].line, problem[:token].column + 5 # not +5
     )
 
     idx = tokens.index(problem[:token])
@@ -57,12 +59,12 @@ PuppetLint.new_check(:version_comparison) do
     value_token.value = 0
     value_token.type = :NUMBER
     # Insert ')' after value
-    tokens.insert(idx+1, rparen)
+    tokens.insert(idx + 1, rparen)
     # Insert value as string after comma
-    tokens.insert(idx+1, value)
+    tokens.insert(idx + 1, value)
     # Insert comma after token
-    tokens.insert(idx+1, space)
-    tokens.insert(idx+1, comma)
+    tokens.insert(idx + 1, space)
+    tokens.insert(idx + 1, comma)
     # Insert 'versioncmp(' before token
     tokens.insert(idx, lparen)
     tokens.insert(idx, versioncmp)

data/spec/puppet-lint/plugins/check_version_comparison/version_comparison_spec.rb

@@ -14,7 +14,7 @@ describe 'version_comparison' do
         EOS
       end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -29,11 +29,11 @@ describe 'version_comparison' do
         EOS
       end
 
-      it 'should detect 4 problems' do
+      it 'detects 4 problems' do
         expect(problems).to have(4).problems
       end
 
-      it 'should create warnings' do
+      it 'creates warnings' do
         expect(problems).to contain_warning(msg).on_line(1).in_column(12)
         expect(problems).to contain_warning(msg).on_line(2).in_column(12)
         expect(problems).to contain_warning(msg).on_line(3).in_column(12)
@@ -61,7 +61,7 @@ describe 'version_comparison' do
         EOS
       end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -77,11 +77,11 @@ describe 'version_comparison' do
         EOS
       end
 
-      it 'should detect 5 problems' do
+      it 'detects 5 problems' do
         expect(problems).to have(5).problems
       end
 
-      it 'should create warnings' do
+      it 'creates warnings' do
         expect(problems).to contain_fixed(msg).on_line(1).in_column(12)
         expect(problems).to contain_fixed(msg).on_line(2).in_column(12)
         expect(problems).to contain_fixed(msg).on_line(3).in_column(12)
@@ -89,9 +89,9 @@ describe 'version_comparison' do
         expect(problems).to contain_fixed(msg).on_line(5).in_column(12)
       end
 
-      it 'should should use versioncmp' do
+      it 'shoulds use versioncmp' do
         expect(manifest).to eq(
-        <<-EOS
+          <<-EOS,
         if versioncmp($::lsbmajdistrelease, '4') >= 0 { }
         if versioncmp($version, '1') <= 0 { }
         if versioncmp($some_version, '3') < 0 { }

data/spec/spec_helper.rb

@@ -1,29 +1,6 @@
 # frozen_string_literal: true
 
-begin
-  require 'simplecov'
-  require 'simplecov-console'
-  require 'codecov'
-rescue LoadError
-else
-  SimpleCov.start do
-    track_files 'lib/**/*.rb'
-
-    add_filter '/spec'
-
-    enable_coverage :branch
-
-    # do not track vendored files
-    add_filter '/vendor'
-    add_filter '/.vendor'
-  end
-
-  SimpleCov.formatters = [
-    SimpleCov::Formatter::Console,
-    SimpleCov::Formatter::Codecov,
-  ]
-end
-
 require 'puppet-lint'
+require 'rspec/collection_matchers'
 
 PuppetLint::Plugins.load_spec_helper

metadata

@@ -1,105 +1,28 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint-version_comparison-check
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 3.0.0
 platform: ruby
 authors:
 - Vox Pupuli
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-11-29 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puppet-lint
   requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '1.0'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '4'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '1.0'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '4'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: rspec-its
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
-- !ruby/object:Gem::Dependency
-  name: rspec-collection_matchers
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-  type: :development
+        version: '5.1'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
-- !ruby/object:Gem::Dependency
-  name: simplecov
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
+        version: '5.1'
 description: "    A puppet-lint plugin to check for versions compared as numbers.\n"
 email: voxpupuli@groups.io
 executables: []
@@ -116,7 +39,6 @@ homepage: https://github.com/voxpupuli/puppet-lint-version_comparison-check
 licenses:
 - Apache-2.0
 metadata: {}
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -124,17 +46,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '3.2'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.33
-signing_key: 
+rubygems_version: 3.6.9
 specification_version: 4
 summary: A puppet-lint plugin to check for versions compared as numbers.
-test_files:
-- spec/puppet-lint/plugins/check_version_comparison/version_comparison_spec.rb
-- spec/spec_helper.rb
+test_files: []