puppet-lint-trailing_comma-check 0.4.2 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 88f6254b5b943d5d1db6f192ee09f985f9415d5633646fe8a5d078e608a6c12f
-  data.tar.gz: d44381bacafa7ffd15724c85d6e7000a96cad1c5d1e5e6f6638f9bad5a81dadd
+  metadata.gz: '018a77724925ca0bef3850617c749c009d3b83ae767eda4e87baf88de6f4cd80'
+  data.tar.gz: ddc25465f0676f38b5d3c16640f811431bbf2864fbb2d2cb8c5027b906fcf17c
 SHA512:
-  metadata.gz: 421c4cfe94c27a82569a88b4e9b709b259e32c9a4b772128d33744c2230704e9da975f4e130429eb3675075ed0b51ecf9b77e905122dc77c9e171c07f07a78f8
-  data.tar.gz: e5e0c305b05742384e0b2ff06976ef97b0bb5c1be079e9b69dc98da85e357e98ffb7e03a212dee2ec256b7e569c419116a1b5ad8158c626cca09eef50849542a
+  metadata.gz: 4fb19ce04aba821d695bf8590d31ae62f94511ec6caf2abe8c9f3937cc15974f40e90f3ab30f27cb8208eff7ea3ba3e149b8e15be7b6c635b2a03f03c385c510
+  data.tar.gz: 0a2d39ccf3301764ed941a043ca4656cb083e3675a3b21f33d64f6621764f3c6441c86a87a30f4226606b1c3ba3fa6b9d3e0fd1c3d808e81189cf234d9b0bc88

data/CHANGELOG.md

@@ -0,0 +1,99 @@
+# Changelog
+
+All notable changes to this project will be documented in this file.
+
+## [1.0.0](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/tree/1.0.0) (2022-11-29)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/compare/0.4.3...1.0.0)
+
+**Implemented enhancements:**
+
+- puppet-lint: Allow 3.x [\#29](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/pull/29) ([bastelfreak](https://github.com/bastelfreak))
+
+## [0.4.3](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/tree/0.4.3) (2022-10-13)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/compare/0.4.2...0.4.3)
+
+**Fixed bugs:**
+
+- Ignore data types where trailing commas are illegal [\#25](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/pull/25) ([chelnak](https://github.com/chelnak))
+
+**Merged pull requests:**
+
+- Set BUNDLE\_WITHOUT at the top level in GitHub Actions [\#26](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/pull/26) ([ekohl](https://github.com/ekohl))
+- Cleanup Gemfile/gemspec [\#22](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/pull/22) ([bastelfreak](https://github.com/bastelfreak))
+- Add badges to README.md / Publish gem to GitHub packages [\#20](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/pull/20) ([bastelfreak](https://github.com/bastelfreak))
+- Convert to Github Actions [\#19](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/pull/19) ([ekohl](https://github.com/ekohl))
+
+## [0.4.2](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/tree/0.4.2) (2018-12-06)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/compare/0.4.1...0.4.2)
+
+**Fixed bugs:**
+
+- Fix for type matching misdetection with !~ [\#17](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/pull/17) ([seanmil](https://github.com/seanmil))
+
+## [0.4.1](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/tree/0.4.1) (2018-10-24)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/compare/0.4.0...0.4.1)
+
+**Fixed bugs:**
+
+- Fix heredoc handling. Add support for interpolated heredocs. [\#15](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/pull/15) ([seanmil](https://github.com/seanmil))
+
+## [0.4.0](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/tree/0.4.0) (2018-10-20)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/compare/0.3.2...0.4.0)
+
+**Breaking changes:**
+
+- Drop support for ruby \< 2.0.0. Update badges for voxpupuli [\#7](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/pull/7) ([alexjfisher](https://github.com/alexjfisher))
+
+**Fixed bugs:**
+
+- Fix invalid handling of heredoc strings [\#10](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/pull/10) ([seanmil](https://github.com/seanmil))
+- Fix custom type misdetection [\#9](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/pull/9) ([seanmil](https://github.com/seanmil))
+
+## [0.3.2](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/tree/0.3.2) (2016-06-22)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/compare/0.3.1...0.3.2)
+
+**Implemented enhancements:**
+
+- With the release of puppet-lint 2.0.0, support ~\>2.0 versions. [\#3](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/pull/3) ([rnelson0](https://github.com/rnelson0))
+
+## [0.3.1](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/tree/0.3.1) (2015-02-18)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/compare/0.3.0...0.3.1)
+
+## [0.3.0](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/tree/0.3.0) (2015-02-10)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/compare/0.2.1...0.3.0)
+
+## [0.2.1](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/tree/0.2.1) (2015-02-10)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/compare/0.2.0...0.2.1)
+
+## [0.2.0](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/tree/0.2.0) (2015-02-10)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/compare/0.1.3...0.2.0)
+
+## [0.1.3](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/tree/0.1.3) (2015-02-10)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/compare/0.1.2...0.1.3)
+
+## [0.1.2](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/tree/0.1.2) (2015-02-10)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/compare/0.1.1...0.1.2)
+
+## [0.1.1](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/tree/0.1.1) (2015-02-10)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/compare/0.1.0...0.1.1)
+
+## [0.1.0](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/tree/0.1.0) (2015-02-10)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/compare/1737f56089f5b3797f797b1a158a3a32aa3631c8...0.1.0)
+
+
+
+\* *This Changelog was automatically generated by [github_changelog_generator](https://github.com/github-changelog-generator/github-changelog-generator)*

data/README.md

@@ -2,11 +2,11 @@ puppet-lint-trailing_comma-check
 =================================
 
 [![License](https://img.shields.io/github/license/voxpupuli/puppet-lint-trailing_comma-check.svg)](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/blob/master/LICENSE)
-[![Build Status](https://img.shields.io/travis/voxpupuli/puppet-lint-trailing_comma-check.svg)](https://travis-ci.org/voxpupuli/puppet-lint-trailing_comma-check)
-[![Gem Version](https://img.shields.io/gem/v/puppet-lint-trailing_comma-check.svg)](https://rubygems.org/gems/puppet-lint-trailing_comma-check)
-[![Gem Downloads](https://img.shields.io/gem/dt/puppet-lint-trailing_comma-check.svg)](https://rubygems.org/gems/puppet-lint-trailing_comma-check)
+[![Test](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/actions/workflows/test.yml/badge.svg)](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/actions/workflows/test.yml)
+[![Release](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/actions/workflows/release.yml/badge.svg)](https://github.com/voxpupuli/puppet-lint-trailing_comma-check/actions/workflows/release.yml)
+[![RubyGem Version](https://img.shields.io/gem/v/puppet-lint-trailing_comma-check.svg)](https://rubygems.org/gems/puppet-lint-trailing_comma-check)
+[![RubyGem Downloads](https://img.shields.io/gem/dt/puppet-lint-trailing_comma-check.svg)](https://rubygems.org/gems/puppet-lint-trailing_comma-check)
 [![Coverage Status](https://coveralls.io/repos/github/voxpupuli/puppet-lint-trailing_comma-check/badge.svg?branch=master)](https://coveralls.io/github/voxpupuli/puppet-lint-trailing_comma-check?branch=master)
-[![Dependency Status](https://gemnasium.com/badges/github.com/voxpupuli/puppet-lint-trailing_comma-check.svg)](https://gemnasium.com/github.com/voxpupuli/puppet-lint-trailing_comma-check)
 [![Donated by Camptocamp](https://img.shields.io/badge/donated%20by-camptocamp-fb7047.svg)](#transfer-notice)
 
 A puppet-lint plugin to check for missing trailing commas.
@@ -70,3 +70,17 @@ The maintainer preferred that Puppet Community take ownership of the module for
 Existing pull requests and issues were transferred over, please fork and continue to contribute here instead of Camptocamp.
 
 Previously: https://github.com/camptocamp/puppet-lint-trailing_comma-check
+
+## License
+
+This gem is licensed under the Apache-2 license.
+
+## Release information
+
+To make a new release, please do:
+* update the version in the gemspec file
+* Install gems with `bundle install --with release --path .vendor`
+* generate the changelog with `bundle exec rake changelog`
+* Check if the new version matches the closed issues/PRs in the changelog
+* Create a PR with it
+* After it got merged, push a tag. GitHub actions will do the actual release to rubygems and GitHub Packages

data/lib/puppet-lint/plugins/check_trailing_comma.rb

@@ -13,6 +13,11 @@ PuppetLint.new_check(:trailing_comma) do
           # Ignore resource references
           next if token.prev_code_token && \
             token.prev_code_token.type == :CLASSREF
+
+          # Ignore data types
+          next if token.prev_code_token && \
+            token.prev_code_token.type == :TYPE
+
           arrays << {
             :start  => token_idx,
             :end    => real_idx,

data/spec/puppet-lint/plugins/check_trailing_comma/check_trailing_comma_spec.rb

@@ -10,6 +10,11 @@ describe 'trailing_comma' do
         class { '::apache':
           timeout => '100',
           docroot => '/var/www',
+          Enum[
+            'a',
+            'b',
+            'c'
+          ] $test = 'c',
         }
 
         class{ '::nginx': }
@@ -70,6 +75,12 @@ describe 'trailing_comma' do
         if $var !~ Mymodule::MyType {
           fail("encountered error ${err}")
         }
+
+        $test = [
+          'a',
+          'b',
+          'c',
+        ],
         EOS
       }
 
@@ -83,7 +94,12 @@ describe 'trailing_comma' do
         <<-EOS
         class { '::apache':
           timeout => '100',
-          docroot => '/var/www'
+          docroot => '/var/www',
+          Enum[
+            'a',
+            'b',
+            'c'
+          ] $test = 'c'
         }
 
         class{ '::nginx': }
@@ -129,20 +145,27 @@ describe 'trailing_comma' do
             '/etc/baz.conf', '/etc/baz.conf.d'
              ],
         }
+
+        $test = [
+          'a',
+          'b',
+          'c'
+        ]
         EOS
       }
 
-      it 'should detect 6 problems' do
-        expect(problems).to have(6).problems
+      it 'should detect 7 problems' do
+        expect(problems).to have(7).problems
       end
 
       it 'should create warnings' do
-        expect(problems).to contain_warning(msg).on_line(3).in_column(32)
-        expect(problems).to contain_warning(msg).on_line(10).in_column(27)
-        expect(problems).to contain_warning(msg).on_line(24).in_column(18)
-        expect(problems).to contain_warning(msg).on_line(33).in_column(23)
-        expect(problems).to contain_warning(msg).on_line(39).in_column(26)
-        expect(problems).to contain_warning(msg).on_line(41).in_column(25)
+        expect(problems).to contain_warning(msg).on_line(8).in_column(24)
+        expect(problems).to contain_warning(msg).on_line(15).in_column(27)
+        expect(problems).to contain_warning(msg).on_line(29).in_column(18)
+        expect(problems).to contain_warning(msg).on_line(38).in_column(23)
+        expect(problems).to contain_warning(msg).on_line(44).in_column(26)
+        expect(problems).to contain_warning(msg).on_line(46).in_column(25)
+        expect(problems).to contain_warning(msg).on_line(58).in_column(14)
       end
     end
 
@@ -223,6 +246,11 @@ describe 'trailing_comma' do
         class { '::apache':
           timeout => '100',
           docroot => '/var/www',
+          Enum[
+            'a',
+            'b',
+            'c'
+          ] $test = 'c',
         }
 
         class{ '::nginx': }
@@ -268,6 +296,12 @@ describe 'trailing_comma' do
             '/etc/baz.conf', '/etc/baz.conf.d'
              ],
         }
+
+        $test = [
+          'a',
+          'b',
+          'c',
+        ],
         EOS
       }
 
@@ -285,7 +319,12 @@ describe 'trailing_comma' do
         <<-EOS
         class { '::apache':
           timeout => '100',
-          docroot => '/var/www'
+          docroot => '/var/www',
+          Enum[
+            'a',
+            'b',
+            'c'
+          ] $test = 'c'
         }
 
         class{ '::nginx': }
@@ -331,20 +370,27 @@ describe 'trailing_comma' do
             '/etc/baz.conf', '/etc/baz.conf.d'
              ],
         }
+
+        $test = [
+          'a',
+          'b',
+          'c'
+        ]
         EOS
       }
 
-      it 'should detect 6 problems' do
-        expect(problems).to have(6).problems
+      it 'should detect 7 problems' do
+        expect(problems).to have(7).problems
       end
 
       it 'should create a warning' do
-        expect(problems).to contain_fixed(msg).on_line(3).in_column(32)
-        expect(problems).to contain_fixed(msg).on_line(10).in_column(27)
-        expect(problems).to contain_fixed(msg).on_line(24).in_column(18)
-        expect(problems).to contain_fixed(msg).on_line(33).in_column(23)
-        expect(problems).to contain_fixed(msg).on_line(39).in_column(26)
-        expect(problems).to contain_fixed(msg).on_line(41).in_column(25)
+        expect(problems).to contain_fixed(msg).on_line(8).in_column(24)
+        expect(problems).to contain_fixed(msg).on_line(15).in_column(27)
+        expect(problems).to contain_fixed(msg).on_line(29).in_column(18)
+        expect(problems).to contain_fixed(msg).on_line(38).in_column(23)
+        expect(problems).to contain_fixed(msg).on_line(44).in_column(26)
+        expect(problems).to contain_fixed(msg).on_line(46).in_column(25)
+        expect(problems).to contain_fixed(msg).on_line(58).in_column(14)
       end
 
       it 'should add trailing commas' do
@@ -353,6 +399,11 @@ describe 'trailing_comma' do
         class { '::apache':
           timeout => '100',
           docroot => '/var/www',
+          Enum[
+            'a',
+            'b',
+            'c'
+          ] $test = 'c',
         }
 
         class{ '::nginx': }
@@ -398,7 +449,13 @@ describe 'trailing_comma' do
             '/etc/baz.conf', '/etc/baz.conf.d'
              ],
         }
-          EOS
+
+        $test = [
+          'a',
+          'b',
+          'c',
+        ]
+        EOS
         )
       end
     end

data/spec/spec_helper.rb

@@ -1,5 +1,28 @@
-require 'coveralls'
-Coveralls.wear!
+# frozen_string_literal: true
+
+begin
+  require 'simplecov'
+  require 'simplecov-console'
+  require 'codecov'
+rescue LoadError
+else
+  SimpleCov.start do
+    track_files 'lib/**/*.rb'
+
+    add_filter '/spec'
+
+    enable_coverage :branch
+
+    # do not track vendored files
+    add_filter '/vendor'
+    add_filter '/.vendor'
+  end
+
+  SimpleCov.formatters = [
+    SimpleCov::Formatter::Console,
+    SimpleCov::Formatter::Codecov,
+  ]
+end
 
 require 'puppet-lint'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint-trailing_comma-check
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 1.0.0
 platform: ruby
 authors:
-- Puppet Community
+- Vox Pupuli
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-06 00:00:00.000000000 Z
+date: 2022-11-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puppet-lint
@@ -19,7 +19,7 @@ dependencies:
         version: '1.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
         version: '1.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -73,21 +73,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: mime-types
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: coveralls
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -115,11 +101,12 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 description: "    A puppet-lint plugin to check for missing trailing commas.\n"
-email: raphael.pinson@camptocamp.com
+email: voxpupuli@groups.io
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- CHANGELOG.md
 - LICENSE
 - README.md
 - lib/puppet-lint/plugins/check_trailing_comma.rb
@@ -144,11 +131,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.8
+rubygems_version: 3.2.33
 signing_key: 
 specification_version: 4
 summary: A puppet-lint plugin to check for missing trailing commas.
 test_files:
-- spec/spec_helper.rb
 - spec/puppet-lint/plugins/check_trailing_comma/check_trailing_comma_spec.rb
+- spec/spec_helper.rb