puppet-lint-topscope-variable-check 1.2.0 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8168088835aca0348f181b125582456955c20cb0dee175dd62f72ba1df6607bc
-  data.tar.gz: 646719472eedfae47ad5ad0a3cd5d3f57bc5bf6ef3e7f8f0f6a845f27052ed95
+  metadata.gz: 1fc4c9fad102c69f34007e5ba9251dc01d21e026504fe8cd5d5758001260858e
+  data.tar.gz: afa1a825948a96aafc053c309d0c65bb7914c9cb4a72d3b0b9017897f30e8cca
 SHA512:
-  metadata.gz: e0585fb8efa9c97dade2f2a3ee3d725d1ccb0c59e220a105420b19100b33c73631b0de286e084b06c79d015ac3faa768044f243c54f4a5500821350a522d8d00
-  data.tar.gz: 23f37b88e4b10d51b8b05702e87081d554e048546193e9e633edc31a1a0350671ff3d01472702e8d7440c197cf2a9d0f63880440cb2b9c993a9827ac2d277392
+  metadata.gz: 7a545487b53ac6a268ef378e6adeae71b754085a3af3d29d07af5fa525bf9ec2169f37035c3fcf9ad81a8a9111858600f579346ac08706a63fa67081b67c8772
+  data.tar.gz: 1b40c7be69c3211843fe72821cd2a1fd90706bac4562ec25a6c987d343ee1b6e058f04e8ec2967beda4994c1579068acdfe2b07cc0be71d023e48b60806e46de

data/lib/puppet-lint/plugins/topscope_variable.rb

@@ -5,14 +5,15 @@ PuppetLint.new_check(:topscope_variable) do
     return if class_list.first.nil?
 
     tokens.select { |x| x.type == :VARIABLE }.each do |token|
-      next if token.value !~ /^::[a-z0-9_][a-zA-Z0-9_]+::/
+      next unless /^::[a-z0-9_][a-zA-Z0-9_]+::/.match?(token.value)
+
       fixed = token.value.sub(/^::/, '')
       notify(
         :warning,
         message: "use $#{fixed} instead of $#{token.value}",
         line: token.line,
         column: token.column,
-        token: token
+        token: token,
       )
     end
   end

data/spec/puppet-lint/plugins/topscope_variable_spec.rb

@@ -2,6 +2,7 @@ require 'spec_helper'
 
 describe 'topscope_variable' do
   let(:msg) { 'use $foo::bar instead of $::foo::bar' }
+
   context 'with fix disabled' do
     context 'with correct topscope' do
       let(:code) do
@@ -14,7 +15,7 @@ describe 'topscope_variable' do
         PUP
       end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problem
       end
     end
@@ -30,7 +31,7 @@ describe 'topscope_variable' do
         PUP
       end
 
-      it 'should detect one problem' do
+      it 'detects one problem' do
         expect(problems).to have(1).problem
       end
     end
@@ -46,7 +47,7 @@ describe 'topscope_variable' do
         PUP
       end
 
-      it 'should detect one problem' do
+      it 'detects one problem' do
         expect(problems).to have(1).problem
       end
     end
@@ -62,7 +63,7 @@ describe 'topscope_variable' do
         PUP
       end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problem
       end
     end
@@ -78,7 +79,7 @@ describe 'topscope_variable' do
         PUP
       end
 
-      it 'should detect one problem' do
+      it 'detects one problem' do
         expect(problems).to have(1).problem
       end
     end
@@ -94,7 +95,7 @@ describe 'topscope_variable' do
         PUP
       end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problem
       end
     end
@@ -110,7 +111,7 @@ describe 'topscope_variable' do
         PUP
       end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problem
       end
     end
@@ -136,7 +137,7 @@ describe 'topscope_variable' do
         PUP
       end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problem
       end
     end
@@ -152,16 +153,8 @@ describe 'topscope_variable' do
         PUP
       end
 
-      it 'should detect one problem' do
-        expect(problems).to have(1).problem
-      end
-
-      it 'should fix the problem' do
-        expect(problems).to contain_fixed(msg).on_line(3).in_column(16)
-      end
-
-      it 'should remove :: after the $' do
-        expect(manifest).to eq <<~PUP
+      let(:fixed) do
+        <<~PUP
           class foo::blub {
             notify { 'foo':
               message => $foo::bar
@@ -169,6 +162,18 @@ describe 'topscope_variable' do
           }
         PUP
       end
+
+      it 'detects one problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'fixes the problem' do
+        expect(problems).to contain_fixed(msg).on_line(3).in_column(16)
+      end
+
+      it 'removes :: after the $' do
+        expect(manifest).to eq fixed
+      end
     end
 
     context 'with incorrect topscope from external module' do
@@ -182,16 +187,8 @@ describe 'topscope_variable' do
         PUP
       end
 
-      it 'should detect one problem' do
-        expect(problems).to have(1).problem
-      end
-
-      it 'should fix the problem' do
-        expect(problems).to contain_fixed('use $some_component_module::bar instead of $::some_component_module::bar').on_line(3).in_column(16)
-      end
-
-      it 'should remove :: after the $' do
-        expect(manifest).to eq <<~PUP
+      let(:fixed) do
+        <<~PUP
           class profile::foo {
             notify { 'foo':
               message => $some_component_module::bar
@@ -199,6 +196,18 @@ describe 'topscope_variable' do
           }
         PUP
       end
+
+      it 'detects one problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'fixes the problem' do
+        expect(problems).to contain_fixed('use $some_component_module::bar instead of $::some_component_module::bar').on_line(3).in_column(16)
+      end
+
+      it 'removes :: after the $' do
+        expect(manifest).to eq fixed
+      end
     end
 
     context 'with incorrect topscope in quoted variable' do
@@ -212,16 +221,8 @@ describe 'topscope_variable' do
         PUP
       end
 
-      it 'should detect one problem' do
-        expect(problems).to have(1).problem
-      end
-
-      it 'should fix the problem' do
-        expect(problems).to contain_fixed(msg).on_line(3).in_column(20)
-      end
-
-      it 'should remove :: after the $' do
-        expect(manifest).to eq <<~PUP
+      let(:fixed) do
+        <<~PUP
           class foo::blub {
             notify { 'foo':
               message => ">${foo::bar}<"
@@ -229,6 +230,18 @@ describe 'topscope_variable' do
           }
         PUP
       end
+
+      it 'detects one problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'fixes the problem' do
+        expect(problems).to contain_fixed(msg).on_line(3).in_column(20)
+      end
+
+      it 'removes :: after the $' do
+        expect(manifest).to eq fixed
+      end
     end
   end
 
@@ -238,7 +251,8 @@ describe 'topscope_variable' do
         include ::foo
       PUP
     end
-    it 'should not detect any problems' do
+
+    it 'does not detect any problems' do
       expect(problems).to have(0).problem
     end
   end

data/spec/spec_helper.rb

@@ -1,29 +1,6 @@
 # frozen_string_literal: true
 
-begin
-  require 'simplecov'
-  require 'simplecov-console'
-  require 'codecov'
-rescue LoadError
-else
-  SimpleCov.start do
-    track_files 'lib/**/*.rb'
-
-    add_filter '/spec'
-
-    enable_coverage :branch
-
-    # do not track vendored files
-    add_filter '/vendor'
-    add_filter '/.vendor'
-  end
-
-  SimpleCov.formatters = [
-    SimpleCov::Formatter::Console,
-    SimpleCov::Formatter::Codecov,
-  ]
-end
-
 require 'puppet-lint'
+require 'rspec/collection_matchers'
 
 PuppetLint::Plugins.load_spec_helper

metadata

@@ -1,111 +1,28 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint-topscope-variable-check
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 3.0.0
 platform: ruby
 authors:
 - Vox Pupuli
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-02-24 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puppet-lint
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '2.0'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '4'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '2.0'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '4'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '12.0'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '14'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '12.0'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '14'
-- !ruby/object:Gem::Dependency
-  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: rspec-collection_matchers
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-- !ruby/object:Gem::Dependency
-  name: rspec-its
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-  type: :development
+        version: '5.1'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
-- !ruby/object:Gem::Dependency
-  name: simplecov
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
+        version: '5.1'
 description: "    A puppet-lint plugin to check that topscope variable names don't
   start with ::.\n"
 email: voxpupuli@groups.io
@@ -122,7 +39,6 @@ homepage: https://github.com/voxpupuli/puppet-lint-topscope-variable-check
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -130,17 +46,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '3.2'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.33
-signing_key: 
+rubygems_version: 3.6.9
 specification_version: 4
 summary: A puppet-lint plugin to check topscope variables.
-test_files:
-- spec/puppet-lint/plugins/topscope_variable_spec.rb
-- spec/spec_helper.rb
+test_files: []