puppet-lint-resource_reference_syntax 1.1.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a46a1903b6d2e1c4f769806edb8969fd1aecfaa0be25a0fe8be7831a94fb634f
-  data.tar.gz: 7bd63f489f10957be998878845fb88be834390fe6f9947a040e3fffe78189ab5
+  metadata.gz: f32aeb42bb00beab070d3869e8ecf12b611d96b0559761bbac30d4ee9449160d
+  data.tar.gz: d4e486abfbc11b73d37c929c62de10a046a214520f9d0c90752df32fc3a96607
 SHA512:
-  metadata.gz: a5a10f947b16541ee913f1ad16a4ba2ffaa978c01228269c42b7a166b172b85911fd1f30752f41e87d67fea4da44637c5210974cae00def70ccdd6512d532d8f
-  data.tar.gz: 4b555f5fe5fb76d656dbad267d1756d53a19ae8dc07861a094f36c33542c687d2dcfa602ff38bc1d21a12ed44519dbfd16634c2d81d99ef0b986c72743e89f59
+  metadata.gz: aa2ec06471afc6e00d7502bbc92faa9dee391ccc28dba85349cfe50eaf0bb2636f3e70babdc6a7ad97accde1a9b9484bd4094ee2e5da48cdc340713e30c99d1b
+  data.tar.gz: 85ab216100d441cadc7045672db21c9e07026241d1da8fad0430576757ae952e23a647c7f0826ac362b0ab59368414783022f887688d6a992bd8e6dbe3c6bb3e

data/CHANGELOG.md

@@ -0,0 +1,120 @@
+# Changelog
+
+All notable changes to this project will be documented in this file.
+
+## [2.0.0](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/tree/2.0.0) (2023-04-21)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/compare/1.2.0...2.0.0)
+
+**Breaking changes:**
+
+- Drop Ruby \< 2.7; Add RuboCop [\#26](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/pull/26) ([bastelfreak](https://github.com/bastelfreak))
+
+## [1.2.0](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/tree/1.2.0) (2022-11-29)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/compare/1.1.0...1.2.0)
+
+**Implemented enhancements:**
+
+- puppet-lint: Allow 3.x [\#24](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/pull/24) ([bastelfreak](https://github.com/bastelfreak))
+
+**Merged pull requests:**
+
+- cleanup README.md/gemspec [\#21](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/pull/21) ([bastelfreak](https://github.com/bastelfreak))
+
+## [1.1.0](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/tree/1.1.0) (2020-04-14)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/compare/1.0.14...1.1.0)
+
+**Implemented enhancements:**
+
+- Break out quoted refs check and add fix [\#16](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/pull/16) ([danzilio](https://github.com/danzilio))
+
+**Closed issues:**
+
+- Doesn't detect spaces when using chaining arrows syntax \("Class \['A'\] -\> Class \['B'\]"\) [\#14](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/issues/14)
+
+**Merged pull requests:**
+
+- Remove ruby 1.9 from testing, add ruby 2.5 [\#17](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/pull/17) ([tuxmea](https://github.com/tuxmea))
+
+## [1.0.14](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/tree/1.0.14) (2018-01-04)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/compare/1.0.13...1.0.14)
+
+## [1.0.13](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/tree/1.0.13) (2018-01-03)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/compare/1.0.12...1.0.13)
+
+## [1.0.12](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/tree/1.0.12) (2018-01-03)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/compare/1.0.11...1.0.12)
+
+**Closed issues:**
+
+- false resource\_reference\_without\_whitespace on resource collection [\#15](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/issues/15)
+- resource\_reference\_without\_whitespace error on resource collection [\#9](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/issues/9)
+
+## [1.0.11](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/tree/1.0.11) (2017-12-30)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/compare/1.0.10...1.0.11)
+
+**Merged pull requests:**
+
+- release 1.0.10 [\#13](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/pull/13) ([tuxmea](https://github.com/tuxmea))
+
+## [1.0.10](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/tree/1.0.10) (2016-11-17)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/compare/1.0.8...1.0.10)
+
+**Closed issues:**
+
+- False positive for require [\#10](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/issues/10)
+
+**Merged pull requests:**
+
+- Restrict checking to the matched parameter only [\#12](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/pull/12) ([cbowman0](https://github.com/cbowman0))
+- Improve message for resources missing quotes [\#11](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/pull/11) ([domcleal](https://github.com/domcleal))
+- add travis with voxpupili key [\#8](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/pull/8) ([tuxmea](https://github.com/tuxmea))
+- Release 1.0.9 [\#7](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/pull/7) ([bastelfreak](https://github.com/bastelfreak))
+
+## [1.0.8](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/tree/1.0.8) (2016-03-17)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/compare/1.0.7...1.0.8)
+
+**Closed issues:**
+
+- False warning: resource reference with title with capital letter [\#4](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/issues/4)
+- False warning: whitespce between reference type and title [\#3](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/issues/3)
+
+## [1.0.7](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/tree/1.0.7) (2016-03-16)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/compare/1.0.6...1.0.7)
+
+**Merged pull requests:**
+
+- iterate over resource reference arrays [\#5](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/pull/5) ([tuxmea](https://github.com/tuxmea))
+
+## [1.0.6](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/tree/1.0.6) (2016-01-25)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/compare/1.0.5...1.0.6)
+
+**Closed issues:**
+
+- Wrong match when a variable is in the title [\#1](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/issues/1)
+
+**Merged pull requests:**
+
+- Fix wrong match on titles with variables \(fixes \#1\) [\#2](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/pull/2) ([vStone](https://github.com/vStone))
+
+## [1.0.5](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/tree/1.0.5) (2015-11-26)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/compare/1.0.4...1.0.5)
+
+## [1.0.4](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/tree/1.0.4) (2015-10-18)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/compare/5ef5832a944246df5d3e7c781085e3a76357b641...1.0.4)
+
+
+
+\* *This Changelog was automatically generated by [github_changelog_generator](https://github.com/github-changelog-generator/github-changelog-generator)*

data/README.md

@@ -1,7 +1,13 @@
 # puppet-lint plugin resource reference check
 
-**Note, this plugin will check for Puppet resource reference syntax which will no 
-longer work with Puppet 4.x.**
+[![License](https://img.shields.io/github/license/voxpupuli/puppet-lint-resource_reference_syntax.svg)](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/blob/master/LICENSE)
+[![Test](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/actions/workflows/test.yml/badge.svg)](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/actions/workflows/test.yml)
+[![Release](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/actions/workflows/release.yml/badge.svg)](https://github.com/voxpupuli/puppet-lint-resource_reference_syntax/actions/workflows/release.yml)
+[![RubyGem Version](https://img.shields.io/gem/v/puppet-lint-resource_reference_syntax.svg)](https://rubygems.org/gems/puppet-lint-resource_reference_syntax)
+[![RubyGem Downloads](https://img.shields.io/gem/dt/puppet-lint-resource_reference_syntax.svg)](https://rubygems.org/gems/puppet-lint-resource_reference_syntax)
+[![Donated by example42](https://img.shields.io/badge/donated%20by-example42-fb7047.svg)](#transfer-notice)
+
+**Note, this plugin will check for Puppet resource reference syntax which will no longer work with Puppet 4.x.**
 
 ## Installation
 
@@ -55,7 +61,26 @@ The following references are good code for Puppet 4:
 
 ```
   require => Service['apache'],
-  require => Service['apache', 'mysql'], 
+  require => Service['apache', 'mysql'],
   require => [ Service['apache'], Service['mysql'] ],
 ```
 
+## Transfer Notice
+
+This plugin was originally authored by [example42](https://example42.de).
+The maintainer preferred that Puppet Community take ownership of the module for future improvement and maintenance.
+Existing pull requests and issues were transferred over, please fork and continue to contribute here instead of Camptocamp.
+
+## License
+
+This gem is licensed under the Apache-2 license.
+
+## Release information
+
+To make a new release, please do:
+* update the version in the gemspec file
+* Install gems with `bundle install --with release --path .vendor`
+* generate the changelog with `bundle exec rake changelog`
+* Check if the new version matches the closed issues/PRs in the changelog
+* Create a PR with it
+* After it got merged, push a tag. GitHub actions will do the actual release to rubygems and GitHub Packages

data/lib/puppet-lint/plugins/resource_reference_chain_without_whitespace.rb

@@ -1,21 +1,21 @@
 # Check for Class references
 PuppetLint.new_check(:resource_reference_chain_without_whitespace) do
   def check
-    tokens.select { |token|
+    tokens.select do |token|
       [:TYPE].include? token.type
-    }.each do |param_token|
+    end.each do |param_token|
       check = param_token
       case check.type
       when :TYPE
-        begin
-          if check.next_token.type == :WHITESPACE and check.next_code_token.type == :LBRACK
-            notify :error, {
-              :message => 'whitespce between reference type and title',
-              :line    => check.line,
-              :column  => check.column
-            }
-          end
+
+        if check.next_token.type == :WHITESPACE and check.next_code_token.type == :LBRACK
+          notify :error, {
+            message: 'whitespce between reference type and title',
+            line: check.line,
+            column: check.column,
+          }
         end
+
       end
     end
   end

data/lib/puppet-lint/plugins/resource_reference_with_unquoted_title.rb

@@ -1,12 +1,12 @@
 PuppetLint.new_check(:resource_reference_with_unquoted_title) do
   def check
     resource_indexes.each do |resource|
-      resource[:param_tokens].select { |param_token|
-        ['require', 'subscribe', 'notify', 'before', 'consume', 'export'].include? param_token.value
-      }.each do |param_token|
+      resource[:param_tokens].select do |param_token|
+        %w[require subscribe notify before consume export].include? param_token.value
+      end.each do |param_token|
         value_token = param_token.next_code_token
         check = value_token.next_token
-        until resource[:param_tokens].include? check or not resource[:tokens].include? check or check.nil?
+        until resource[:param_tokens].include? check or !resource[:tokens].include? check or check.nil?
           case value_token.next_token.type
           when :CLASSREF
             begin
@@ -14,10 +14,10 @@ PuppetLint.new_check(:resource_reference_with_unquoted_title) do
                 check_token = value_token.next_token.next_token.next_token
                 if check_token.type == :NAME
                   notify :error, {
-                    :message => 'unquoted title in resource reference',
-                    :line    => check_token.line,
-                    :column  => check_token.column,
-                    :token   => check_token,
+                    message: 'unquoted title in resource reference',
+                    line: check_token.line,
+                    column: check_token.column,
+                    token: check_token,
                   }
                 end
               end

data/lib/puppet-lint/plugins/resource_reference_without_title_capital.rb

@@ -1,12 +1,12 @@
 PuppetLint.new_check(:resource_reference_without_title_capital) do
   def check
     resource_indexes.each do |resource|
-      resource[:param_tokens].select { |param_token|
-        ['require', 'subscribe', 'notify', 'before', 'consume', 'export'].include? param_token.value
-      }.each do |param_token|
+      resource[:param_tokens].select do |param_token|
+        %w[require subscribe notify before consume export].include? param_token.value
+      end.each do |param_token|
         value_token = param_token.next_code_token
         check = value_token.next_token
-        until resource[:param_tokens].include? check or not resource[:tokens].include? check or check.nil?
+        until resource[:param_tokens].include? check or !resource[:tokens].include? check or check.nil?
           case value_token.next_token.type
           when :CLASSREF
             begin
@@ -14,9 +14,9 @@ PuppetLint.new_check(:resource_reference_without_title_capital) do
                 check_token = value_token.next_token.next_token.next_token
                 if check_token.type == :CLASSREF
                   notify :error, {
-                    :message => 'resource reference with title with capital letter',
-                    :line    => check_token.line,
-                    :column  => check_token.column
+                    message: 'resource reference with title with capital letter',
+                    line: check_token.line,
+                    column: check_token.column,
                   }
                 end
               end
@@ -32,4 +32,3 @@ PuppetLint.new_check(:resource_reference_without_title_capital) do
     end
   end
 end
-

data/lib/puppet-lint/plugins/resource_reference_without_whitespace.rb

@@ -1,22 +1,22 @@
 # Check for resource references
 PuppetLint.new_check(:resource_reference_without_whitespace) do
   def check
-    resource_indexes.each do |resource|
-      tokens.select { |token|
+    resource_indexes.each do |_resource|
+      tokens.select do |token|
         [:CLASSREF].include? token.type
-      }.each do |param_token|
+      end.each do |param_token|
         check = param_token
         case check.type
         when :CLASSREF
-          begin
-            if check.next_token.type == :WHITESPACE and check.next_code_token.type == :LBRACK
-              notify :error, {
-                :message => 'whitespce between reference type and title',
-                :line    => check.line,
-                :column  => check.column
-              }
-            end
+
+          if check.next_token.type == :WHITESPACE and check.next_code_token.type == :LBRACK
+            notify :error, {
+              message: 'whitespce between reference type and title',
+              line: check.line,
+              column: check.column,
+            }
           end
+
         end
       end
     end

data/spec/puppet-lint/plugins/resource_reference_chain_without_whitespace_spec.rb

@@ -1,18 +1,18 @@
 require 'spec_helper'
 
 describe 'resource_reference_chain_without_whitespace' do
-
   context 'a whitespace between reference and bracket on chains' do
     let(:msg) { 'whitespce between reference type and title' }
-    let(:code) { "class foo { include foo::install include foo::config include foo::service Class ['foo::install'] -> Class ['foo::config'] ~> Class ['foo::service'] } " }
+    let(:code) do
+      "class foo { include foo::install include foo::config include foo::service Class ['foo::install'] -> Class ['foo::config'] ~> Class ['foo::service'] } "
+    end
 
-    it 'should detect two problems' do
+    it 'detects two problems' do
       expect(problems).to have(3).problem
     end
 
-    it 'should create an error' do
+    it 'creates an error' do
       expect(problems).to contain_error(msg).on_line(1)
     end
   end
-
 end

data/spec/puppet-lint/plugins/resource_reference_with_unquoted_title_spec.rb

@@ -7,7 +7,7 @@ describe 'resource_reference_with_unquoted_title' do
     context 'quoted resource ref on single line resource' do
       let(:code) { "file { 'foo': require => File['bar'] }" }
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -15,16 +15,15 @@ describe 'resource_reference_with_unquoted_title' do
     context 'unquoted resource ref on single line resource' do
       let(:code) { "file { 'foo': require => File[bar] }" }
 
-      it 'should only detect a single problem' do
+      it 'onlies detect a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should raise an error' do
+      it 'raises an error' do
         expect(problems).to contain_error(msg).on_line(1).in_column(31)
       end
     end
 
-
     context 'quoted resource ref on multi line resource' do
       let(:code) do
         <<-END
@@ -34,7 +33,7 @@ describe 'resource_reference_with_unquoted_title' do
         END
       end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -48,11 +47,11 @@ describe 'resource_reference_with_unquoted_title' do
         END
       end
 
-      it 'should only detect a single problem' do
+      it 'onlies detect a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should raise an error' do
+      it 'raises an error' do
         expect(problems).to contain_error(msg).on_line(2).in_column(29)
       end
     end
@@ -69,7 +68,7 @@ describe 'resource_reference_with_unquoted_title' do
         END
       end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -86,11 +85,11 @@ describe 'resource_reference_with_unquoted_title' do
         END
       end
 
-      it 'should only detect a single problem' do
+      it 'onlies detect a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should raise an error' do
+      it 'raises an error' do
         expect(problems).to contain_error(msg).on_line(3).in_column(31)
       end
     end
@@ -106,11 +105,10 @@ describe 'resource_reference_with_unquoted_title' do
         END
       end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
-
   end
 
   context 'with fix enabled' do
@@ -125,15 +123,15 @@ describe 'resource_reference_with_unquoted_title' do
     context 'unquoted resource ref on single line resource' do
       let(:code) { "file { 'foo': require => File[bar] }" }
 
-      it 'should only detect a single problem' do
+      it 'onlies detect a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the manifest' do
+      it 'fixes the manifest' do
         expect(problems).to contain_fixed(msg).on_line(1).in_column(31)
       end
 
-      it 'should single quote the resource title' do
+      it 'singles quote the resource title' do
         expect(manifest).to eq("file { 'foo': require => File['bar'] }")
       end
     end
@@ -155,15 +153,15 @@ describe 'resource_reference_with_unquoted_title' do
         END
       end
 
-      it 'should only detect a single problem' do
+      it 'onlies detect a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the manifest' do
+      it 'fixes the manifest' do
         expect(problems).to contain_fixed(msg).on_line(2).in_column(29)
       end
 
-      it 'should single quote the resource ref' do
+      it 'singles quote the resource ref' do
         expect(manifest).to eq(fixed)
       end
     end
@@ -191,15 +189,15 @@ describe 'resource_reference_with_unquoted_title' do
         END
       end
 
-      it 'should only detect a single problem' do
+      it 'onlies detect a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the manifest' do
+      it 'fixes the manifest' do
         expect(problems).to contain_fixed(msg).on_line(3).in_column(31)
       end
 
-      it 'should single quote the resource title' do
+      it 'singles quote the resource title' do
         expect(manifest).to eq(fixed)
       end
     end

data/spec/puppet-lint/plugins/resource_reference_without_title_capital_spec.rb

@@ -1,12 +1,11 @@
 require 'spec_helper'
 
 describe 'resource_reference_without_title_capital' do
-
   context 'a proper reference' do
     let(:msg) { 'whitespce between reference type and title' }
     let(:code) { "file { 'foo': ensure => file, notify => Title['one'],}" }
 
-    it 'should detect no problem' do
+    it 'detects no problem' do
       expect(problems).to have(0).problem
     end
   end
@@ -14,7 +13,7 @@ describe 'resource_reference_without_title_capital' do
   context 'a proper reference in quotes' do
     let(:code) { "file { 'foo': ensure => file, notify => Title['One'],}" }
 
-    it 'should detect no problem' do
+    it 'detects no problem' do
       expect(problems).to have(0).problem
     end
   end
@@ -22,7 +21,7 @@ describe 'resource_reference_without_title_capital' do
   context 'a proper reference as array in quotes' do
     let(:code) { "file { 'foo': ensure => file, notify => Title['one', 'two'],}" }
 
-    it 'should detect no problem' do
+    it 'detects no problem' do
       expect(problems).to have(0).problem
     end
   end
@@ -30,7 +29,7 @@ describe 'resource_reference_without_title_capital' do
   context 'multiple proper references as array in quotes' do
     let(:code) { "file { 'foo': ensure => file, notify => [ Title['one'], Title['two'] ],}" }
 
-    it 'should detect no problem' do
+    it 'detects no problem' do
       expect(problems).to have(0).problem
     end
   end
@@ -38,7 +37,7 @@ describe 'resource_reference_without_title_capital' do
   context 'multiple proper references as array one in quotes, one as variable' do
     let(:code) { "file { 'foo': ensure => file, notify => [ Title['one'], Title[$foo_var] ],}" }
 
-    it 'should detect no problem' do
+    it 'detects no problem' do
       expect(problems).to have(0).problem
     end
   end
@@ -46,16 +45,17 @@ describe 'resource_reference_without_title_capital' do
   context 'a proper reference as variable' do
     let(:code) { "file { 'foo': ensure => file, notify => Title[$foo_var],}" }
 
-    it 'should detect no problem' do
+    it 'detects no problem' do
       expect(problems).to have(0).problem
     end
   end
 
   context 'a proper reference with a variable enclosed' do
-    let(:code) {
+    let(:code) do
       %(file {'foo': ensure => file, notify => Title["with ${param}"],} )
-    }
-    it 'should detect no problem' do
+    end
+
+    it 'detects no problem' do
       expect(problems).to have(0).problem
     end
   end
@@ -64,11 +64,11 @@ describe 'resource_reference_without_title_capital' do
     let(:msg) { 'resource reference with title with capital letter' }
     let(:code) { "file { 'foo': ensure => file, notify => Title[One],}" }
 
-    it 'should only detect a single problem' do
+    it 'onlies detect a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create an error' do
+    it 'creates an error' do
       expect(problems).to contain_error(msg).on_line(1)
     end
   end
@@ -77,11 +77,11 @@ describe 'resource_reference_without_title_capital' do
     let(:msg) { 'resource reference with title with capital letter' }
     let(:code) { "file { 'foo': ensure => file, notify => Title[One, Two],}" }
 
-    it 'should only detect a single problem' do
+    it 'onlies detect a single problem' do
       expect(problems)
     end
 
-    it 'should create an error' do
+    it 'creates an error' do
       expect(problems).to contain_error(msg).on_line(1)
     end
   end
@@ -90,11 +90,11 @@ describe 'resource_reference_without_title_capital' do
     let(:msg) { 'resource reference with title with capital letter' }
     let(:code) { "file { 'foo': ensure => file, notify => [Title[One], Title[Two],]}" }
 
-    it 'should only detect a single problem' do
+    it 'onlies detect a single problem' do
       expect(problems)
     end
 
-    it 'should create an error' do
+    it 'creates an error' do
       expect(problems).to contain_error(msg).on_line(1)
     end
   end
@@ -102,9 +102,8 @@ describe 'resource_reference_without_title_capital' do
   context 'stay within the parameter context' do
     let(:code) { "file { 'foo': ensure => file, notify => Title['One'],} $var = [ Exec[runsomething] ]" }
 
-    it 'should detect no problem' do
+    it 'detects no problem' do
       expect(problems).to have(0).problem
     end
   end
-
 end

data/spec/puppet-lint/plugins/resource_reference_without_whitespace_spec.rb

@@ -1,12 +1,11 @@
 require 'spec_helper'
 
 describe 'resource_reference_without_whitespace' do
-
   context 'a proper reference as array' do
     let(:msg) { 'whitespce between reference type and title' }
     let(:code) { "file { 'foo': ensure => file, notify => [ Title['one'], Title['two'] ]}" }
 
-    it 'should detect no problem' do
+    it 'detects no problem' do
       expect(problems).to have(0).problem
     end
   end
@@ -15,7 +14,7 @@ describe 'resource_reference_without_whitespace' do
     let(:msg) { 'whitespce between reference type and title' }
     let(:code) { "file { 'foo': ensure => file, notify => [ Title['one'], Title[$two] ]}" }
 
-    it 'should detect no problem' do
+    it 'detects no problem' do
       expect(problems).to have(0).problem
     end
   end
@@ -24,7 +23,7 @@ describe 'resource_reference_without_whitespace' do
     let(:msg) { 'whitespce between reference type and title' }
     let(:code) { "file { 'foo': ensure => file, notify => Title['one'],}" }
 
-    it 'should detect no problem' do
+    it 'detects no problem' do
       expect(problems).to have(0).problem
     end
   end
@@ -33,11 +32,11 @@ describe 'resource_reference_without_whitespace' do
     let(:msg) { 'whitespce between reference type and title' }
     let(:code) { "file { 'foo': ensure => file, consume => Title ['one'],}" }
 
-    it 'should only detect a single problem' do
+    it 'onlies detect a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create an error' do
+    it 'creates an error' do
       expect(problems).to contain_error(msg).on_line(1)
     end
   end
@@ -46,19 +45,21 @@ describe 'resource_reference_without_whitespace' do
     let(:msg) { 'whitespce between reference type and title' }
     let(:code) { "file { 'foo': ensure => file, consume => [ Title ['one'], Title['two']],}" }
 
-    it 'should only detect a single problem' do
+    it 'onlies detect a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create an error' do
+    it 'creates an error' do
       expect(problems).to contain_error(msg).on_line(1)
     end
   end
 
   context 'stay within the parameter context' do
-    let(:code) { "package { 'bar': ensure => installed,}  exec { 'baz': require => Package['bar'],} file { 'foo': ensure => file,}" }
+    let(:code) do
+      "package { 'bar': ensure => installed,}  exec { 'baz': require => Package['bar'],} file { 'foo': ensure => file,}"
+    end
 
-    it 'should detect no problem' do
+    it 'detects no problem' do
       expect(problems).to have(0).problem
     end
   end
@@ -67,24 +68,26 @@ describe 'resource_reference_without_whitespace' do
     let(:msg) { 'whitespce between reference type and title' }
     let(:code) { "package { 'one': ensure => present, } Package ['one'] ~> Service ['two']" }
 
-    it 'should detect two problems' do
+    it 'detects two problems' do
       expect(problems).to have(2).problem
     end
 
-    it 'should create an error' do
+    it 'creates an error' do
       expect(problems).to contain_error(msg).on_line(1)
     end
   end
 
   context 'more resources and a whitespace between reference and bracket on chains' do
     let(:msg) { 'whitespce between reference type and title' }
-    let(:code) { "package { 'one': ensure => present, } package { 'two': ensure => present, } Package ['one'] ~> Service['two']" }
+    let(:code) do
+      "package { 'one': ensure => present, } package { 'two': ensure => present, } Package ['one'] ~> Service['two']"
+    end
 
-    it 'should detect one problem' do
+    it 'detects one problem' do
       expect(problems).to have(2).problem
     end
 
-    it 'should create an error' do
+    it 'creates an error' do
       expect(problems).to contain_error(msg).on_line(1)
     end
   end
@@ -92,9 +95,8 @@ describe 'resource_reference_without_whitespace' do
   context 'collectors should not cause an error' do
     let(:code) { "@package { 'bar': ensure => installed,}  Package <| |>" }
 
-    it 'should detect no problem' do
+    it 'detects no problem' do
       expect(problems).to have(0).problem
     end
   end
-
 end

data/spec/spec_helper.rb

@@ -1,3 +1,29 @@
+# frozen_string_literal: true
+
+begin
+  require 'simplecov'
+  require 'simplecov-console'
+  require 'codecov'
+rescue LoadError
+else
+  SimpleCov.start do
+    track_files 'lib/**/*.rb'
+
+    add_filter '/spec'
+
+    enable_coverage :branch
+
+    # do not track vendored files
+    add_filter '/vendor'
+    add_filter '/.vendor'
+  end
+
+  SimpleCov.formatters = [
+    SimpleCov::Formatter::Console,
+    SimpleCov::Formatter::Codecov,
+  ]
+end
+
 require 'puppet-lint'
 
 PuppetLint::Plugins.load_spec_helper

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint-resource_reference_syntax
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 2.0.0
 platform: ruby
 authors:
-- Martin Alfke
+- Vox Pupuli
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-04-14 00:00:00.000000000 Z
+date: 2023-04-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puppet-lint
@@ -16,98 +16,29 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '3'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '3'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: rspec-its
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-- !ruby/object:Gem::Dependency
-  name: rspec-collection_matchers
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: simplecov
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
+        version: '5'
 description: "    Extends puppet-lint to ensure that the reference syntax follows
   Puppet 4 style\n"
-email: ma@example42.com
+email: voxpupuli@groups.io
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
 - ".rspec"
+- CHANGELOG.md
 - LICENSE
 - README.md
 - lib/puppet-lint/plugins/resource_reference_chain_without_whitespace.rb
@@ -121,7 +52,7 @@ files:
 - spec/spec_helper.rb
 homepage: https://github.com/voxpupuli/puppet-lint-resource_reference_syntax
 licenses:
-- APL2
+- Apache-2.0
 metadata: {}
 post_install_message: 
 rdoc_options: []
@@ -131,21 +62,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.7.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.7
+rubygems_version: 3.2.33
 signing_key: 
 specification_version: 4
 summary: puppet-lint reference_syntax check
-test_files:
-- spec/spec_helper.rb
-- spec/puppet-lint/plugins/resource_reference_without_whitespace_spec.rb
-- spec/puppet-lint/plugins/resource_reference_without_title_capital_spec.rb
-- spec/puppet-lint/plugins/resource_reference_chain_without_whitespace_spec.rb
-- spec/puppet-lint/plugins/resource_reference_with_unquoted_title_spec.rb
+test_files: []