puppet-lint-resource_reference_syntax 1.0.9 → 1.0.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: de33a133447a8396c8c0304efe1ced66d1c3f0a1
-  data.tar.gz: 7008588276b55a2428ff5d477c3bb4ccdab52b68
+  metadata.gz: cf65ebeb1562c96b729170887f3f0858aa334167
+  data.tar.gz: f958ba6c54fad7dfc3d0729159156b2721c752d0
 SHA512:
-  metadata.gz: dd1d8fd591bb1fca61f419b6af10036f7f120e8b4bfb6f875dfec8c59ec82e895d165a6e9c3f20ae06b3125c4f945b0432599ad4bea193037dd7fc43d61e7ca1
-  data.tar.gz: 23c7cc7e27c274829a2835c33f358c9db0960dcefab9048a26aadf705c62bba348add32fb071e0ab59a78be97972a353e207985cee41f30594caded3809b65ba
+  metadata.gz: 61d6d864fdabfdc16324549676577a45a83a9e34956f629d9eb6d1f347c1f0ac1a96e4ee84604131c05536ab87948ff0ddfaeed90aa13a4cc3aace9bd71d97e8
+  data.tar.gz: 1a649de579bedca54c45dbaa496e482c2ca4fa37d128879d45dced05f0eeff7f79f7307fb371cf11d550c87c269046068c01e93affe318730be4d4caa3240039

data/lib/puppet-lint/plugins/resource_reference_without_title_capital.rb

@@ -6,18 +6,24 @@ PuppetLint.new_check(:resource_reference_without_title_capital) do
       }.each do |param_token|
         value_token = param_token.next_code_token
         check = value_token.next_token
-        until check.nil?
+        until resource[:param_tokens].include? check or not resource[:tokens].include? check or check.nil?
           case value_token.next_token.type
           when :CLASSREF
             begin
               if value_token.next_token.next_token.type == :LBRACK
                 check_token = value_token.next_token.next_token.next_token
-                if check_token.type == :CLASSREF or check_token.type == :NAME
+                if check_token.type == :CLASSREF
                   notify :error, {
                     :message => 'resource reference with title with capital letter',
                     :line    => check_token.line,
                     :column  => check_token.column
                   }
+                elsif check_token.type == :NAME
+                  notify :error, {
+                    :message => 'resource reference with title with missing quotes',
+                    :line    => check_token.line,
+                    :column  => check_token.column
+                  }
                 end
               end
               value_token = value_token.next_token

data/lib/puppet-lint/plugins/resource_reference_without_whitespace.rb

@@ -6,7 +6,7 @@ PuppetLint.new_check(:resource_reference_without_whitespace) do
       }.each do |param_token|
         value_token = param_token.next_code_token
         check = value_token.next_token
-        until check.nil?
+        until resource[:param_tokens].include? check or not resource[:tokens].include? check or check.nil?
           case value_token.next_token.type
           when :CLASSREF
             begin

data/spec/puppet-lint/plugins/resource_reference_without_title_capital_spec.rb

@@ -100,7 +100,7 @@ describe 'resource_reference_without_title_capital' do
   end
 
   context 'resource reference with title without quotes' do
-    let(:msg) { 'resource reference with title with capital letter' }
+    let(:msg) { 'resource reference with title with missing quotes' }
     let(:code) { "file { 'foo': ensure => file, notify => Title[one],}" }
 
     it 'should only detect a single problem' do
@@ -112,4 +112,12 @@ describe 'resource_reference_without_title_capital' do
     end
   end
 
+  context 'stay within the parameter context' do
+    let(:code) { "file { 'foo': ensure => file, notify => Title['One'],} $var = [ Exec[runsomething] ]" }
+
+    it 'should detect no problem' do
+      expect(problems).to have(0).problem
+    end
+  end
+
 end

data/spec/puppet-lint/plugins/resource_reference_without_whitespace_spec.rb

@@ -55,4 +55,12 @@ describe 'resource_reference_without_whitespace' do
     end
   end
 
+  context 'stay within the parameter context' do
+    let(:code) { "package { 'bar': ensure => installed,}  exec { 'baz': require => Package['bar'],} File { 'foo': ensure => file,}" }
+
+    it 'should detect no problem' do
+      expect(problems).to have(0).problem
+    end
+  end
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint-resource_reference_syntax
 version: !ruby/object:Gem::Version
-  version: 1.0.9
+  version: 1.0.10
 platform: ruby
 authors:
 - Martin Alfke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-23 00:00:00.000000000 Z
+date: 2016-11-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puppet-lint