puppet-lint-resource_reference_syntax 1.0.3 → 1.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d237aec2bf27b27da3e1ba61f593a4359128224f
-  data.tar.gz: 6852215c95538df3aa99ee5d8f24608a8694bd18
+  metadata.gz: 968682a225e6084c2004bde43dfb6c9ea5c738fb
+  data.tar.gz: c996f8d7c54b06799e5c24b2b8518f035098e1d5
 SHA512:
-  metadata.gz: 2fc6e4c9c1f31998d34d6f1a5b062b3ab19fe9d629e4507a8ace17622ace54610d9e2baf5c4c44c81736e0d7cf63f55965a9a6f575af67a9ea61cee1a539206e
-  data.tar.gz: 3f4eb2990f6012b640a4717ff44786c2c8bba2f5a5ee329cb82b1f9e8a6db3f3d72dcf7d88d2d2244957b749562ed31208ff4144ffc57df13dca099de33f16f3
+  metadata.gz: 2a165376ff9f202412f4a163f0b094e8c3dee55637cfded25abc8f140f83dfa5e01ca1c13eea651df41efb5f06420ba45796152897508c3c5a66918691004d84
+  data.tar.gz: 1fdcc56b72dfd1e71462c6422e950032412a50eb14bb7348f042f3b6d23653895c7da2882e59bd91f14875d2dd2e3abfdea61396001853a0c9c69a0a03c7625f

data/lib/puppet-lint/plugins/resource_reference_without_title_capital.rb

@@ -2,17 +2,15 @@ PuppetLint.new_check(:resource_reference_without_title_capital) do
   def check
     resource_indexes.each do |resource|
       resource[:param_tokens].select { |param_token|
-        ['require', 'subscribe', 'notify', 'before'].include? param_token.value
+        ['require', 'subscribe', 'notify', 'before', 'consume', 'export'].include? param_token.value
       }.each do |param_token|
         value_token = param_token.next_code_token.next_code_token.next_code_token.next_token
-        unless value_token.type == :SSTRING
-          unless value_token.value =~ (/^[a-z_]*$/)
-            notify :error, {
-              :message => 'resource reference with title with capital letter',
-              :line    => value_token.line,
-              :column  => value_token.column
-            }
-          end
+        unless value_token.type == :SSTRING or value_token.type == :VARIABLE
+          notify :error, {
+            :message => 'resource reference with title with capital letter',
+            :line    => value_token.line,
+            :column  => value_token.column
+          }
         end
       end
     end

data/lib/puppet-lint/plugins/resource_reference_without_whitespace.rb

@@ -2,7 +2,7 @@ PuppetLint.new_check(:resource_reference_without_whitespace) do
   def check
     resource_indexes.each do |resource|
       resource[:param_tokens].select { |param_token|
-        ['require', 'subscribe', 'notify', 'before'].include? param_token.value
+        ['require', 'subscribe', 'notify', 'before', 'consume', 'export'].include? param_token.value
       }.each do |param_token|
         value_token = param_token.next_code_token.next_code_token.next_token
         if value_token.type != :LBRACK

data/spec/puppet-lint/plugins/resource_reference_without_title_capital_spec.rb

@@ -40,4 +40,17 @@ describe 'resource_reference_without_title_capital' do
     end
   end
 
+  context 'resource reference with title without quotes' do
+    let(:msg) { 'resource reference with title with capital letter' }
+    let(:code) { "file { 'foo': ensure => file, notify => Title[one],}" }
+
+    it 'should only detect a single problem' do
+      expect(problems).to have(1).problem
+    end
+
+    it 'should create an error' do
+      expect(problems).to contain_error(msg).on_line(1)
+    end
+  end
+
 end

data/spec/puppet-lint/plugins/resource_reference_without_whitespace_spec.rb

@@ -13,7 +13,7 @@ describe 'resource_reference_without_whitespace' do
 
   context 'a whitespace between reference and bracket' do
     let(:msg) { 'whitespce between reference type and title' }
-    let(:code) { "file { 'foo': ensure => file, notify => Title ['one'],}" }
+    let(:code) { "file { 'foo': ensure => file, consume => Title ['one'],}" }
 
     it 'should only detect a single problem' do
       expect(problems).to have(1).problem

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint-resource_reference_syntax
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.0.4
 platform: ruby
 authors:
 - Martin Alfke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-13 00:00:00.000000000 Z
+date: 2015-10-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puppet-lint