puppet-lint-resource_reference_syntax 1.0.10 → 1.0.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cf65ebeb1562c96b729170887f3f0858aa334167
-  data.tar.gz: f958ba6c54fad7dfc3d0729159156b2721c752d0
+  metadata.gz: 6bec0b0cda5b6e0baaf5be0d7384eeebb8bd54f3
+  data.tar.gz: a1b14449a5dd89ea9519482f7b58601f008d2a83
 SHA512:
-  metadata.gz: 61d6d864fdabfdc16324549676577a45a83a9e34956f629d9eb6d1f347c1f0ac1a96e4ee84604131c05536ab87948ff0ddfaeed90aa13a4cc3aace9bd71d97e8
-  data.tar.gz: 1a649de579bedca54c45dbaa496e482c2ca4fa37d128879d45dced05f0eeff7f79f7307fb371cf11d550c87c269046068c01e93affe318730be4d4caa3240039
+  metadata.gz: cc948517e4a2e414e73243d6da93e427a6dbfc0fe24c74847d6a79bc4596b86d3ba8607b399b9aa64d0b9858b8a6b613230b3eca65edfec326c522ec8eac7707
+  data.tar.gz: ca4d94b023baa8b20a2124fcb78b604141d827bd562074ae0b572d2ad92135f8a42e9959a20d71b85fb9df43c6f3c847779fd0eef79b8ae2ad3988f7bda2626e

data/lib/puppet-lint/plugins/resource_reference_without_whitespace.rb

@@ -1,28 +1,20 @@
 PuppetLint.new_check(:resource_reference_without_whitespace) do
   def check
     resource_indexes.each do |resource|
-      resource[:param_tokens].select { |param_token|
-        ['require', 'subscribe', 'notify', 'before', 'consume', 'export'].include? param_token.value
+      tokens.select { |token|
+        [:CLASSREF].include? token.type
       }.each do |param_token|
-        value_token = param_token.next_code_token
-        check = value_token.next_token
-        until resource[:param_tokens].include? check or not resource[:tokens].include? check or check.nil?
-          case value_token.next_token.type
-          when :CLASSREF
-            begin
-              if value_token.next_token.next_token.type == :WHITESPACE
-                notify :error, {
-                  :message => 'whitespce between reference type and title',
-                  :line    => value_token.next_token.next_token.line,
-                  :column  => value_token.next_token.next_token.column
-                }
-              end
-              value_token = value_token.next_token
-              check = value_token.next_token
+        check = param_token
+        case check.type
+        when :CLASSREF
+          begin
+            if check.next_token.type == :WHITESPACE
+              notify :error, {
+                :message => 'whitespce between reference type and title',
+                :line    => check.line,
+                :column  => check.column
+              }
             end
-          else
-            value_token = value_token.next_token
-            check = value_token.next_token
           end
         end
       end

data/spec/puppet-lint/plugins/resource_reference_without_whitespace_spec.rb

@@ -56,11 +56,24 @@ describe 'resource_reference_without_whitespace' do
   end
 
   context 'stay within the parameter context' do
-    let(:code) { "package { 'bar': ensure => installed,}  exec { 'baz': require => Package['bar'],} File { 'foo': ensure => file,}" }
+    let(:code) { "package { 'bar': ensure => installed,}  exec { 'baz': require => Package['bar'],} file { 'foo': ensure => file,}" }
 
     it 'should detect no problem' do
       expect(problems).to have(0).problem
     end
   end
 
+  context 'a whitespace between reference and bracket on chains' do
+    let(:msg) { 'whitespce between reference type and title' }
+    let(:code) { "package { 'one': ensure => present, } Package ['one'] ~> Service ['two']" }
+
+    it 'should detect three problems' do
+      expect(problems).to have(2).problem
+    end
+
+    it 'should create an error' do
+      expect(problems).to contain_error(msg).on_line(1)
+    end
+  end
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint-resource_reference_syntax
 version: !ruby/object:Gem::Version
-  version: 1.0.10
+  version: 1.0.11
 platform: ruby
 authors:
 - Martin Alfke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-18 00:00:00.000000000 Z
+date: 2017-12-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puppet-lint
@@ -86,6 +86,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0'
 description: |2
       Extends puppet-lint to ensure that the reference syntax follows Puppet 4 style
 email: ma@example42.com