puppet-lint-resource_outside_class-check 0.0.1

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 33a1b5dacd70bd9c800c13d1b527bd8405a22e51
+  data.tar.gz: 35fccecdbf4433347f56b7d081dfea63473845d0
+SHA512:
+  metadata.gz: f2fdd9c13adbdd8145e9bc1053def3d6c33f88c2ef86a1c236e23cee3ef4a0d5a5bc1454a5fa822902cc3faf92f040714104a2e367bbceac7efef5852aa64b0e
+  data.tar.gz: 3e939686068f78ebed002e073c97140ddb4d34ba58f376941e10aeb31e2a7d25ebe8a8e4c9ae526dc829697f5174f40b2a35c0cf8c3892b266da280a4297dee7

data/LICENSE

@@ -0,0 +1,22 @@
+The MIT License (MIT)
+
+Copyright (c) 2015 Lee Lowder
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.
+

data/README.md

@@ -0,0 +1,17 @@
+# puppet-lint-resource_outside_class-check
+Adds a new puppet-lint check to see if resources exist outside of a class or defined type.
+
+##Installation
+`gem install puppet-lint-resource_outside_class-check`
+
+##Usage
+
+This check will detect if resources exist outside of a class or defined types.
+
+Conditions caught:
+ - resource before start of a class or defined type definiton
+ - resources after the close of a class or defined type definition
+ - resources in a manifest that do not ahve a class or defiend type definition
+
+
+

data/lib/puppet-lint/plugins/check_resource_outside_class.rb

@@ -0,0 +1,51 @@
+PuppetLint.new_check(:resource_outside_class) do
+  def check
+
+    first_token = tokens.first
+    last_token = tokens.last
+    resource_list = resource_indexes
+
+    if class_indexes.length > 0
+      # The file has at least a class in it it
+      class_list = class_indexes
+      
+      class_list.each do |cl|
+        resource_list.each do |res|
+          unless ( res[:start] > cl[:start] ) && ( res[:end] < cl[:end] )
+            notify :warning,  {
+              :message => 'resource found outside a class definition',
+              :line    => res[:type].line,
+              :column  => res[:type].column,
+            }
+          end
+        end
+      end
+
+    elsif defined_type_indexes.length > 0
+      #the file has at least a defined type in it
+      define_list = defined_type_indexes
+      
+      define_list.each do |dl|
+        resource_list.each do |res|
+          unless ( res[:start] > dl[:start] ) && ( res[:end] < dl[:end] )
+            notify :warning,  {
+              :message => 'resource found outside a defined type defintion',
+              :line    => res[:type].line,
+              :column  => res[:type].column,
+            }
+          end
+        end
+      end
+    else
+      #no class and no defined type
+      unless resource_list.length == 0
+        notify :warning, {
+          :message => 'resourcss exist but no class or defined type definition found in manifest',
+          :line    => resource_list.first[:line],
+          :column  => resource_list.first[:column],
+        }
+      end
+    end
+  end
+end
+

data/spec/puppet-lint/plugins/check_resource_outside_class_spec.rb

@@ -0,0 +1,68 @@
+require 'spec_helper'
+
+describe 'resource_outside_class' do
+
+  let(:class_msg) { 'resource found outside a class definition' }
+  let(:define_msg) { 'resource found outside a defined type defintion' }
+  let(no_class_or_define_msg) { 'resourcss exist but no class or defined type definition found in manifest')
+
+  context 'with fix disabled' do
+
+    context 'resource inside class definition' do
+      let(:code) { "class foo{\nnotify{ 'resource in class': }\n}" }
+
+      it 'should not detect any problems' do
+        expect(problems).to have(0).problems
+      end
+    end
+
+    context 'resource inside defined type definition' do
+      let(:code) { "define bar{\nnotify{ 'resource in defined type': }\n}" }
+
+      it 'should not detect any problems' do
+        expect(problems).to have(0).problems
+      end
+    end
+
+    context 'resource outside, after of a class definition' do
+      let(:code) { "class foo{ }\nnotify{'badfoo': }" }
+
+      it 'should create a warning' do
+        expect(problems).to contain_warning(class_msg).on_line(2)
+      end
+    end
+
+    context 'resource outside of, after, a defined type' do
+      let(:code) { "define bar{}\nnotify{'resource after define':}\n}" }
+
+      it 'should create a warning' do
+        expect(problems).to contain_warning(define_msg).on_line(2)
+      end
+    end
+
+    context 'resource outside of, before, a class definition' do
+      let(:code) { "notify{'badfoo': }\nclass foo{ }\n" }
+
+      it 'should create a warning' do
+        expect(problems).to contain_warning(class_msg).on_line(1)
+      end
+    end
+
+    context 'resource outside, before, of a defined type' do
+      let(:code) { "notify{'resource before define':}\ndefine bar{}" }
+
+      it 'should create a warning' do
+        expect(problems).to contain_warning(define_msg).on_line(1)
+      end
+    end
+
+    context 'resource with no class or define present' do
+      let(:code) { "notify{'no classes!': }" }
+
+      it 'should create a warning' do
+        expect(problems).to contain_warning(no_class_or_define_msg).on_line(1)
+      end
+    end
+
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,3 @@
+require 'puppet-lint'
+
+PuppetLint::Plugins.load_spec_helper

metadata

@@ -0,0 +1,122 @@
+--- !ruby/object:Gem::Specification
+name: puppet-lint-resource_outside_class-check
+version: !ruby/object:Gem::Version
+  version: 0.0.1
+platform: ruby
+authors:
+- Lee Lowder
+autorequire: 
+bindir: bin
+cert_chain: []
+date: 2015-04-05 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: puppet-lint
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rspec-its
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: rspec-collection_matchers
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+description: |2
+       A puppet-lint plugin to check that manifest files do not contain resources outside of a class or defined type definition.
+email: friedbob@keepingyouhonest.net
+executables: []
+extensions: []
+extra_rdoc_files: []
+files:
+- README.md
+- LICENSE
+- lib/puppet-lint/plugins/check_resource_outside_class.rb
+- spec/puppet-lint/plugins/check_resource_outside_class_spec.rb
+- spec/spec_helper.rb
+homepage: https://github.com/llowder/puppet-lint-resource_outside_class-check
+licenses:
+- MIT
+metadata: {}
+post_install_message: 
+rdoc_options: []
+require_paths:
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements: []
+rubyforge_project: 
+rubygems_version: 2.0.14
+signing_key: 
+specification_version: 4
+summary: A puppet-lint plugin to check for resources outside of a class or defiend
+  type definition.
+test_files:
+- spec/puppet-lint/plugins/check_resource_outside_class_spec.rb
+- spec/spec_helper.rb