puppet-lint-reference_on_declaration_outside_of_class-check 1.0.8 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7f58019a41dba9734b248d9948d161ca1a6667c8
-  data.tar.gz: 853ced4f419b00481ae4053c59a668c5d71492ee
+  metadata.gz: cb3a2a8ca764f6d767353e40a00c1c6754431ae2
+  data.tar.gz: 1ddc9e80ece4791e5a9f19feafd58d8e77305e18
 SHA512:
-  metadata.gz: c0f3b11ba2c770c908d8693257ea61841c9f28625b464dd7e5ea9acb0088a9edce1b32143dfd7f5f1fd5971649b0a86a7e19431751068124b7ec62fd4cc57267
-  data.tar.gz: b92dcb7d4858f70d16530c275aed5f42ccbe11956005747ba13da0cd81a0fc8d9aee776a9e7ff33f3a2cf45e017bebc3efed790a46888dca8e1d904e415552c1
+  metadata.gz: 3d125b5df110b98527c28f335031f65c64e5f8d4ce971129853f756719f7305d4a573b68a3a2acb3c2544ac5c167f0bcea63ce6acb80de2e0eba2c1c57f8c8dc
+  data.tar.gz: 41b8d014246d4156a9486c1b6b3e160dd0ad36b937d7cb1f73ea8fe5524802989f9742d9dfccfc47d12adf41bc710100e4ba30ffcad9af2898739b03f312fc69

data/spec/puppet-lint/plugins/reference_on_foreign_class_spec.rb

@@ -16,6 +16,20 @@ describe 'reference_on_foreign_class' do
     end
   end
 
+  context 'a proper reference on a local class include using a variable' do
+    let(:code) { "
+      class demo {
+        include $install
+        include $config
+        Class[$config] -> Class[$install]
+      }
+            " }
+
+    it 'should detect no problem' do
+      expect(problems).to have(0).problem
+    end
+  end
+
   context 'a proper reference on a local class type declaration' do
     let(:code) { "
       class demo2 {
@@ -30,6 +44,20 @@ describe 'reference_on_foreign_class' do
     end
   end
 
+  context 'a proper reference on a local class type declaration using a variable' do
+    let(:code) { "
+      class demo2 {
+        class { $install: }
+        class { $config: }
+        Class[$config] -> Class[$install]
+      }
+            " }
+
+    it 'should detect no problem' do
+      expect(problems).to have(0).problem
+    end
+  end
+
 
   context 'a reference on a foreign class declaration' do
     let(:msg) { 'reference on a foreign class' }
@@ -38,7 +66,39 @@ describe 'reference_on_foreign_class' do
       Class['demo'] -> Class['foo']
             " }
 
-    it 'should only detect a single problem' do
+    it 'should detect two problems' do
+      expect(problems).to have(2).problem
+    end
+
+    it 'should create a warning' do
+      expect(problems).to contain_warning(msg)
+    end
+  end
+
+  context 'a reference on a foreign class declaration using a variable' do
+    let(:msg) { 'reference on a foreign class' }
+    let(:code) { "
+      include $base::demo
+      Class[$demo] -> Class[$foo]
+            " }
+
+    it 'should detect two problems' do
+      expect(problems).to have(2).problem
+    end
+
+    it 'should create a warning' do
+      expect(problems).to contain_warning(msg)
+    end
+  end
+
+  context 'a reference on a foreign class type declaration' do
+    let(:msg) { 'reference on a foreign class' }
+    let(:code) { "
+      class{ base::demo: }
+      Class['demo'] -> Class['foo']
+            " }
+
+    it 'should detect two problems' do
       expect(problems).to have(2).problem
     end
 

metadata

@@ -1,29 +1,35 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint-reference_on_declaration_outside_of_class-check
 version: !ruby/object:Gem::Version
-  version: 1.0.8
+  version: 1.1.1
 platform: ruby
 authors:
 - Martin Alfke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-01 00:00:00.000000000 Z
+date: 2016-06-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puppet-lint
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement