puppet-lint-racism_terminology-check 1.0.0 → 1.0.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (6) hide show
  1. checksums.yaml +5 -5
  2. data/README.md +6 -2
  3. data/lib/puppet-lint/plugins/check_racism_terminology.rb +2 -2
  4. data/spec/puppet-lint/plugins/check_racism_terminology_spec.rb +18 -0
  5. metadata +54 -27
  6. data/lib/puppet-lint/plugins/racism_terminology.rb +0 -22
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
- SHA256:
3
- metadata.gz: 700b7652d5e6806ae24fa6de70ab45977e6300056c1268a288a77bbf327e79dc
4
- data.tar.gz: 7bfc0068fb8b443d5a70455148c0133cdbec61edbb054b419d6938e1b832e0cd
2
+ SHA1:
3
+ metadata.gz: 4528e23b9efcaa3ba1a21367a4e54c14c2a2aca8
4
+ data.tar.gz: 4eb78af7211badb530710c2e936d4c2a7c6b45ff
5
5
  SHA512:
6
- metadata.gz: 95045d0365c5449dd2354372db2f7fe69615df901cf22948eb948bd2c17bda7641be1e90f3f1fc5b9a98ee75ed98e55e02a0246d60638b4e2934ae9227e62344
7
- data.tar.gz: 0ae443f6daada72bba37642441c54db1a0758117786f7d98dc273ff444d840233e80309fbbff6d7831e0aa1a04da88898b579d47ed20a406035e4b68271a09a4
6
+ metadata.gz: ade22d5d2d64138ab9902b2e7901f96a6c042c14ce140bb3ae67efa97a36ea4868052a0d0c689732734c8ae1d72a9dc3c9fe137ec7db1ddd5259668261d97af5
7
+ data.tar.gz: 9a84d4f719a0fc8ade947606be1cbb607c4bb9742ce359795791f8c08684d7d224656fcc26d7987c2bec41d8a8766a360b43ac98e7acfcd5503022f4ca94fd66
data/README.md CHANGED
@@ -2,11 +2,15 @@
2
2
 
3
3
  A puppet-lint extension that offers warnings when you include words that
4
4
  have a racist history: 'master/slave', 'whitelist/blacklist', for
5
- starters. See: <https://tools.ietf.org/id/draft-knodel-terminology-01.html>
5
+ starters. See: <https://datatracker.ietf.org/doc/draft-knodel-terminology/13/>
6
+
7
+ This check will not match against URL's. This is by design to not flag
8
+ for every comment that may contain a github link to a repo using
9
+ 'master' as the main branch.
6
10
 
7
11
  ## Installation
8
12
 
9
- `gem install puppet-lint-racism_terminology-check`
13
+ `gem install puppet-lint-racism_terminology-check`
10
14
 
11
15
  ### Author
12
16
 
data/lib/puppet-lint/plugins/check_racism_terminology.rb CHANGED
@@ -2,7 +2,7 @@ PuppetLint.new_check(:racism_terminology) do
2
2
  # rubocop:disable Style/Next
3
3
  def check
4
4
  manifest_lines.each_with_index do |line, idx|
5
- if line =~ /\b(master|slave)\b/
5
+ if line =~ /\b(master|slave)\b/ && line !~ URI::DEFAULT_PARSER.make_regexp
6
6
  notify(
7
7
  :warning,
8
8
  message: 'master/slave terminology, perhaps leader/follower?',
@@ -11,7 +11,7 @@ PuppetLint.new_check(:racism_terminology) do
11
11
  )
12
12
  end
13
13
 
14
- if line =~ /\b(blacklist|whitelist)\b/
14
+ if line =~ /\b(blacklist|whitelist)\b/ && line !~ URI::DEFAULT_PARSER.make_regexp
15
15
  notify(
16
16
  :warning,
17
17
  message: 'blacklist/whitelist terminology, perhaps blocklist/approvelist?',
data/spec/puppet-lint/plugins/check_racism_terminology_spec.rb CHANGED
@@ -18,6 +18,15 @@ describe 'racism_terminology' do
18
18
  end
19
19
  end
20
20
 
21
+ context 'master in a URL' do
22
+ let(:code) { "file { '/foo/bar': source => 'http://example.com/master' }" }
23
+ let(:msg) { 'master/slave terminology, perhaps leader/follower?' }
24
+
25
+ it 'should not create a warning' do
26
+ expect(problems).not_to contain_warning(msg).on_line(1)
27
+ end
28
+ end
29
+
21
30
  context 'slave' do
22
31
  let(:code) { "file { '/tmp/slave': }" }
23
32
  let(:msg) { 'master/slave terminology, perhaps leader/follower?' }
@@ -44,4 +53,13 @@ describe 'racism_terminology' do
44
53
  expect(problems).to contain_warning(msg).on_line(1)
45
54
  end
46
55
  end
56
+
57
+ context 'master in a URL' do
58
+ let(:code) { '# Some URL example.com/master/' }
59
+ let(:msg) { 'url testing' }
60
+
61
+ it 'should not create a warning' do
62
+ expect(problems).not_to contain_warning
63
+ end
64
+ end
47
65
  end
metadata CHANGED
@@ -1,133 +1,161 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: puppet-lint-racism_terminology-check
3
3
  version: !ruby/object:Gem::Version
4
- version: 1.0.0
4
+ version: 1.0.2
5
5
  platform: ruby
6
6
  authors:
7
7
  - Tim Skirvin
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2020-06-12 00:00:00.000000000 Z
11
+ date: 2023-06-09 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: puppet-lint
15
15
  requirement: !ruby/object:Gem::Requirement
16
16
  requirements:
17
- - - ">="
17
+ - - '>='
18
18
  - !ruby/object:Gem::Version
19
19
  version: '1.1'
20
- - - "<"
20
+ - - <
21
21
  - !ruby/object:Gem::Version
22
- version: '3.0'
22
+ version: '5.0'
23
23
  type: :runtime
24
24
  prerelease: false
25
25
  version_requirements: !ruby/object:Gem::Requirement
26
26
  requirements:
27
- - - ">="
27
+ - - '>='
28
28
  - !ruby/object:Gem::Version
29
29
  version: '1.1'
30
- - - "<"
30
+ - - <
31
31
  - !ruby/object:Gem::Version
32
- version: '3.0'
32
+ version: '5.0'
33
+ - !ruby/object:Gem::Dependency
34
+ name: uri
35
+ requirement: !ruby/object:Gem::Requirement
36
+ requirements:
37
+ - - ~>
38
+ - !ruby/object:Gem::Version
39
+ version: 0.10.0
40
+ type: :runtime
41
+ prerelease: false
42
+ version_requirements: !ruby/object:Gem::Requirement
43
+ requirements:
44
+ - - ~>
45
+ - !ruby/object:Gem::Version
46
+ version: 0.10.0
33
47
  - !ruby/object:Gem::Dependency
34
48
  name: rake
35
49
  requirement: !ruby/object:Gem::Requirement
36
50
  requirements:
37
- - - ">="
51
+ - - '>='
38
52
  - !ruby/object:Gem::Version
39
53
  version: '0'
40
54
  type: :development
41
55
  prerelease: false
42
56
  version_requirements: !ruby/object:Gem::Requirement
43
57
  requirements:
44
- - - ">="
58
+ - - '>='
45
59
  - !ruby/object:Gem::Version
46
60
  version: '0'
47
61
  - !ruby/object:Gem::Dependency
48
62
  name: rspec
49
63
  requirement: !ruby/object:Gem::Requirement
50
64
  requirements:
51
- - - "~>"
65
+ - - ~>
52
66
  - !ruby/object:Gem::Version
53
67
  version: '3.0'
54
68
  type: :development
55
69
  prerelease: false
56
70
  version_requirements: !ruby/object:Gem::Requirement
57
71
  requirements:
58
- - - "~>"
72
+ - - ~>
59
73
  - !ruby/object:Gem::Version
60
74
  version: '3.0'
61
75
  - !ruby/object:Gem::Dependency
62
76
  name: rspec-collection_matchers
63
77
  requirement: !ruby/object:Gem::Requirement
64
78
  requirements:
65
- - - "~>"
79
+ - - ~>
66
80
  - !ruby/object:Gem::Version
67
81
  version: '1.0'
68
82
  type: :development
69
83
  prerelease: false
70
84
  version_requirements: !ruby/object:Gem::Requirement
71
85
  requirements:
72
- - - "~>"
86
+ - - ~>
73
87
  - !ruby/object:Gem::Version
74
88
  version: '1.0'
75
89
  - !ruby/object:Gem::Dependency
76
90
  name: rspec-its
77
91
  requirement: !ruby/object:Gem::Requirement
78
92
  requirements:
79
- - - "~>"
93
+ - - ~>
80
94
  - !ruby/object:Gem::Version
81
95
  version: '1.0'
82
96
  type: :development
83
97
  prerelease: false
84
98
  version_requirements: !ruby/object:Gem::Requirement
85
99
  requirements:
86
- - - "~>"
100
+ - - ~>
87
101
  - !ruby/object:Gem::Version
88
102
  version: '1.0'
89
103
  - !ruby/object:Gem::Dependency
90
104
  name: rspec-json_expectations
91
105
  requirement: !ruby/object:Gem::Requirement
92
106
  requirements:
93
- - - "~>"
107
+ - - ~>
94
108
  - !ruby/object:Gem::Version
95
109
  version: '2.2'
96
110
  type: :development
97
111
  prerelease: false
98
112
  version_requirements: !ruby/object:Gem::Requirement
99
113
  requirements:
100
- - - "~>"
114
+ - - ~>
101
115
  - !ruby/object:Gem::Version
102
116
  version: '2.2'
103
117
  - !ruby/object:Gem::Dependency
104
118
  name: rubocop
105
119
  requirement: !ruby/object:Gem::Requirement
106
120
  requirements:
107
- - - "~>"
121
+ - - ~>
108
122
  - !ruby/object:Gem::Version
109
123
  version: 0.85.0
110
124
  type: :development
111
125
  prerelease: false
112
126
  version_requirements: !ruby/object:Gem::Requirement
113
127
  requirements:
114
- - - "~>"
128
+ - - ~>
115
129
  - !ruby/object:Gem::Version
116
130
  version: 0.85.0
117
131
  - !ruby/object:Gem::Dependency
118
132
  name: simplecov
119
133
  requirement: !ruby/object:Gem::Requirement
120
134
  requirements:
121
- - - "~>"
135
+ - - ~>
122
136
  - !ruby/object:Gem::Version
123
137
  version: 0.18.0
124
138
  type: :development
125
139
  prerelease: false
126
140
  version_requirements: !ruby/object:Gem::Requirement
127
141
  requirements:
128
- - - "~>"
142
+ - - ~>
129
143
  - !ruby/object:Gem::Version
130
144
  version: 0.18.0
145
+ - !ruby/object:Gem::Dependency
146
+ name: uri
147
+ requirement: !ruby/object:Gem::Requirement
148
+ requirements:
149
+ - - '>='
150
+ - !ruby/object:Gem::Version
151
+ version: '0'
152
+ type: :development
153
+ prerelease: false
154
+ version_requirements: !ruby/object:Gem::Requirement
155
+ requirements:
156
+ - - '>='
157
+ - !ruby/object:Gem::Version
158
+ version: '0'
131
159
  description: |2
132
160
  A puppet-lint extension that warns when you use racist terminology
133
161
  in your code. Starting terms: whitelist, blacklist, master, slave
@@ -136,10 +164,9 @@ executables: []
136
164
  extensions: []
137
165
  extra_rdoc_files: []
138
166
  files:
139
- - LICENSE
140
167
  - README.md
168
+ - LICENSE
141
169
  - lib/puppet-lint/plugins/check_racism_terminology.rb
142
- - lib/puppet-lint/plugins/racism_terminology.rb
143
170
  - spec/puppet-lint/plugins/check_racism_terminology_spec.rb
144
171
  - spec/spec_helper.rb
145
172
  homepage: https://github.com/tskirvin/puppet-lint-racism_terminology-check
@@ -152,17 +179,17 @@ require_paths:
152
179
  - lib
153
180
  required_ruby_version: !ruby/object:Gem::Requirement
154
181
  requirements:
155
- - - ">="
182
+ - - '>='
156
183
  - !ruby/object:Gem::Version
157
184
  version: '0'
158
185
  required_rubygems_version: !ruby/object:Gem::Requirement
159
186
  requirements:
160
- - - ">="
187
+ - - '>='
161
188
  - !ruby/object:Gem::Version
162
189
  version: '0'
163
190
  requirements: []
164
191
  rubyforge_project:
165
- rubygems_version: 2.7.6.2
192
+ rubygems_version: 2.0.14.1
166
193
  signing_key:
167
194
  specification_version: 4
168
195
  summary: puppet-lint racism terminology check
data/lib/puppet-lint/plugins/racism_terminology.rb DELETED
@@ -1,22 +0,0 @@
1
- PuppetLint.new_check(:racism_terminology) do
2
- def check
3
- manifest_lines.each_with_index do |line, idx|
4
- if line =~ %r{/(master|slave)/w}
5
- notify(
6
- warning,
7
- message: 'master/slave terminology, perhaps leader/follower?',
8
- line: idx + 1,
9
- column: 1
10
- )
11
- end
12
- if line =~ %r{/(blacklist|whitelist)/w}
13
- notify(
14
- warning,
15
- message: 'blacklist/whitelist terminology, perhaps blocklist/approvelist?',
16
- line: idx + 1,
17
- column: 1
18
- )
19
- end
20
- end
21
- end
22
- end