puppet-lint-nine-check 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c4708a12e4b0252d046a69e52f62ca9296daab1e6f0d356a16f712df5d56df5b
-  data.tar.gz: a903c154bc715a5dfd8c21a77eccff6ceb2baaeeaf4412a794d4b6bcea83bf44
+  metadata.gz: 6b17f0f00ef8f387090bb661db7760091cd2d0c2f59ac1d4b99f2c76e59f86f3
+  data.tar.gz: 8067c71c2f9e97e19f16dd3ed0baa7e58216148a5ad6ef131d218f965b0b2f4c
 SHA512:
-  metadata.gz: b56ffb029e88553a11a87a9c4f819cb54e985dc19e62e50032f4c5b8c2ab5efce592073405a809ed53d153aa26087fb67bb3e0553789256b16facf196cf33fee
-  data.tar.gz: 677c848e83b23cbc1b2488e922b75a6471e31145a9ac6c7961be63442369cfba9bc3308d8a8b387df76048f5dac936b380fa3305ad885ab719903d947ec87d57
+  metadata.gz: b7fac1f845f03de996108428233bc2e349daeba55e2e1450923013da4c23620e391ba953116a96fcf06025d168d8ab3ba706b781f2737684ab6500ba89b5901e
+  data.tar.gz: 2ecefee96e6c970a9d9328bc5565179f4ed3a4fa757ab4103d373fd96b66219b51a20bb9d224129056894b0d009ae12136dfb7fb9429d96a8ecd11d9d1a22507

data/lib/puppet-lint/plugins/absolute_template_path.rb

@@ -0,0 +1,53 @@
+# https://github.com/deanwilson/puppet-lint-absolute_template_path-check/blob/fa2d1e9a75e566c483b62ea7ff5df0bb9756ad8a/lib/puppet-lint/plugins/absolute_template_path.rb
+#
+# The MIT License (MIT)
+#
+# Copyright (c) 2014 Dean Wilson
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"), to deal
+# in the Software without restriction, including without limitation the rights
+# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+# copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included in all
+# copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+# SOFTWARE.
+
+PuppetLint.new_check(:absolute_template_path) do
+  def check
+    resource_indexes.each do |resource|
+      next unless resource[:type].value == "file"
+
+      content_tokens = resource[:param_tokens].select { |pt| pt.value == "content" }
+
+      content_tokens.each do |content_token|
+        value_token = content_token.next_code_token.next_code_token
+
+        next unless value_token.value.start_with? "template"
+
+        template_path = value_token.next_code_token.next_code_token.value
+
+        next unless template_path.start_with? "/" # skip relative paths
+
+        # if we made it here it's a file resource with a template parameter
+        # that begins with an absolute path, so raise a lint issue for it.
+        notify :warning, {
+          message: "template module paths should be relative, not absolute",
+          line: value_token.line,
+          column: value_token.column,
+          param_token: content_token,
+          value_token: value_token
+        }
+      end
+    end
+  end
+end

data/spec/puppet-lint/plugins/absolute_template_path_spec.rb

@@ -0,0 +1,77 @@
+require "spec_helper"
+
+describe "absolute_template_path" do
+  let(:msg) { "template module paths should be relative, not absolute" }
+
+  context "when the manifest has no file resources" do
+    let(:code) do
+      <<-TEST_CLASS
+        class no_file_resource {
+          host { "syslog":
+            ip => "10.10.10.10",
+          }
+        }
+      TEST_CLASS
+    end
+
+    it "does not detect any problems" do
+      expect(problems.size).to eq(0)
+    end
+  end
+
+  context "with file resource but no template call" do
+    context "when the template has a relative module path" do
+      let(:code) do
+        <<-TEST_CLASS
+          class template_tester {
+            file { "/tmp/template":
+              content => "A static string",
+            }
+          }
+        TEST_CLASS
+      end
+
+      it "detects no problems" do
+        expect(problems.size).to eq(0)
+      end
+    end
+  end
+
+  context "with fix disabled" do
+    context "when the template has a relative module path" do
+      let(:code) do
+        <<-TEST_CLASS
+          class template_tester {
+            file { "/tmp/template":
+              content => template("example/template.erb"),
+            }
+          }
+        TEST_CLASS
+      end
+
+      it "detects no problems" do
+        expect(problems.size).to eq(0)
+      end
+    end
+
+    context "when the template has an absolute module path" do
+      let(:code) do
+        <<-TEST_CLASS
+          class template_tester {
+            file { "/tmp/template":
+              content => template("/etc/puppet/modules/example/template.erb"),
+            }
+          }
+        TEST_CLASS
+      end
+
+      it "detects a single problem" do
+        expect(problems.size).to eq(1)
+      end
+
+      it "creates a warning" do
+        expect(problems).to contain_warning(msg).on_line(3).in_column(26)
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint-nine-check
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Nine Internet Solutions AG
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-07-25 00:00:00.000000000 Z
+date: 2026-10-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puppet-lint
@@ -131,6 +131,7 @@ extra_rdoc_files: []
 files:
 - LICENSE
 - README.md
+- lib/puppet-lint/plugins/absolute_template_path.rb
 - lib/puppet-lint/plugins/class_alignment.rb
 - lib/puppet-lint/plugins/class_alignment/helper.rb
 - lib/puppet-lint/plugins/class_alignment_params_newline.rb
@@ -141,6 +142,7 @@ files:
 - lib/puppet-lint/plugins/template_file_extension.rb
 - lib/puppet-lint/plugins/trailing_newline.rb
 - lib/puppet-lint/plugins/world_writable_files.rb
+- spec/puppet-lint/plugins/absolute_template_path_spec.rb
 - spec/puppet-lint/plugins/class_alignment_equals_spec.rb
 - spec/puppet-lint/plugins/class_alignment_params_newline_spec.rb
 - spec/puppet-lint/plugins/class_alignment_params_spec.rb