puppet-lint-nine-check 0.3.0 → 0.5.0

data/spec/puppet-lint/plugins/template_file_extension_spec.rb

@@ -0,0 +1,188 @@
+require "spec_helper"
+
+describe "template_file_extension" do
+  context "when the manifest has no file resources" do
+    let(:code) do
+      <<-TEST_CLASS
+        class no_file_resource {
+          host { 'syslog':
+            ip => '10.10.10.10',
+          }
+        }
+      TEST_CLASS
+    end
+
+    it "does not detect any problems" do
+      expect(problems.size).to eq(0)
+    end
+  end
+
+  context "when a non-template function is called" do
+    let(:code) do
+      <<-TEST_CLASS
+        class random_function {
+          file { '/tmp/templated':
+            content => random_name('mymodule/single_file.erb'),
+          }
+        }
+      TEST_CLASS
+    end
+
+    it "does not detect any problems" do
+      expect(problems.size).to eq(0)
+    end
+  end
+
+  context "when the template function is called with one valid file name" do
+    let(:code) do
+      <<-TEST_CLASS
+        class valid_template_filename {
+          file { '/tmp/templated':
+            content => template('mymodule/single_file.erb'),
+          }
+        }
+      TEST_CLASS
+    end
+
+    it "does not detect any problems" do
+      expect(problems.size).to eq(0)
+    end
+  end
+
+  context "when the epp function is called with one valid file name" do
+    let(:code) do
+      <<-TEST_CLASS
+        class valid_epp_template_filename {
+          file { '/tmp/templated':
+            content => epp('mymodule/single_file.epp'),
+          }
+        }
+      TEST_CLASS
+    end
+
+    it "does not detect any problems" do
+      expect(problems.size).to eq(0)
+    end
+  end
+
+  context "when the epp function is called with one valid file name and parameters" do
+    let(:code) do
+      <<-TEST_CLASS
+        class valid_epp_template_filename {
+          file { '/tmp/templated':
+            content => epp('mymodule/single_file.epp', {'key' => 'val'}),
+          }
+        }
+      TEST_CLASS
+    end
+
+    it "does not detect any problems" do
+      expect(problems.size).to eq(0)
+    end
+  end
+
+  context "when a space it present between the template function and opening paren" do
+    let(:code) do
+      <<-TEST_CLASS
+        class space_between_template_and_opening_paren {
+          file { '/tmp/templated':
+            content => template ('mymodule/a_file.erb'),
+          }
+        }
+      TEST_CLASS
+    end
+
+    it "does not detect any problems" do
+      expect(problems.size).to eq(0)
+    end
+  end
+
+  context "when the template function is called with a single invalid file name" do
+    let(:template_msg) { "all template file names should end with .erb" }
+    let(:code) do
+      <<-TEST_CLASS
+        class multi_templated_file {
+          file { '/tmp/templated':
+            content => template('mymodule/first_file.erb', 'mymodule/second_file.conf'),
+          }
+        }
+      TEST_CLASS
+    end
+
+    it "detects a single problem" do
+      expect(problems.size).to eq(1)
+    end
+
+    it "creates a warning" do
+      expect(problems).to contain_warning(template_msg).on_line(3).in_column(24)
+    end
+  end
+
+  context "when the epp function is called with a single invalid file name" do
+    let(:epp_msg) { "all epp file names should end with .epp" }
+
+    let(:code) do
+      <<-TEST_CLASS
+        class epp_multi_templated_file {
+          file { '/tmp/templated':
+            content => epp('mymodule/first_file', {'key' => 'val'}),
+          }
+        }
+      TEST_CLASS
+    end
+
+    it "detects a single problem" do
+      expect(problems.size).to eq(1)
+    end
+
+    it "creates a warning" do
+      expect(problems).to contain_warning(epp_msg).on_line(3).in_column(24)
+    end
+  end
+
+  context "when there is a space between the template function and opening paren, and no extension is provided" do
+    let(:template_msg) { "all template file names should end with .erb" }
+
+    let(:code) do
+      <<-TEST_CLASS
+        class space_between_template_and_opening_paren {
+          file { '/tmp/templated':
+            content => template ('mymodule/a_file'),
+          }
+        }
+      TEST_CLASS
+    end
+
+    it "detects a single problem" do
+      expect(problems.size).to eq(1)
+    end
+
+    it "creates a warning" do
+      expect(problems).to contain_warning(template_msg).on_line(3).in_column(24)
+    end
+  end
+
+  ## https://github.com/deanwilson/puppet-lint-template_file_extension-check/issues/48
+  context "when the paramater type is DQPOST not SSTRING and no extension is provided (issue #48)" do
+    let(:template_msg) { "all template file names should end with .erb" }
+
+    let(:code) do
+      <<-TEST_CLASS
+        class space_between_template_and_opening_paren {
+          file { "/etc/${package_name}.conf":
+            ensure  => file,
+            content => template("allknowingdns/${package_name}.conf"),
+          }
+        }
+      TEST_CLASS
+    end
+
+    it "detects a single problem" do
+      expect(problems.size).to eq(1)
+    end
+
+    it "creates a warning" do
+      expect(problems).to contain_warning(template_msg).on_line(4).in_column(24)
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require "rspec/collection_matchers"
 require "puppet-lint"
 
 PuppetLint::Plugins.load_spec_helper

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint-nine-check
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Nine Internet Solutions AG
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-10-26 00:00:00.000000000 Z
+date: 2024-07-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puppet-lint
@@ -108,10 +108,21 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: |2
-    A pupet-lint to check you are not using Nine legacy facts like `$::nine_location`
-    or `$facts['nine_location']`. You should use the new structured facts like
-    `$facts['nine_metadata']['location']` instead.
+- !ruby/object:Gem::Dependency
+  name: standardrb
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+description: "  A collection of pupet-lint checks used at Nine.\n"
 email:
 - support@nine.ch
 executables: []
@@ -120,14 +131,24 @@ extra_rdoc_files: []
 files:
 - LICENSE
 - README.md
+- lib/puppet-lint/plugins/class_alignment.rb
+- lib/puppet-lint/plugins/class_alignment/helper.rb
+- lib/puppet-lint/plugins/class_alignment_params_newline.rb
 - lib/puppet-lint/plugins/concatenated_template_files.rb
 - lib/puppet-lint/plugins/explicit_hiera_class_param_lookup.rb
 - lib/puppet-lint/plugins/nine_legacy_facts.rb
+- lib/puppet-lint/plugins/no_symbolic_file_modes.rb
+- lib/puppet-lint/plugins/template_file_extension.rb
 - lib/puppet-lint/plugins/trailing_newline.rb
 - lib/puppet-lint/plugins/world_writable_files.rb
+- spec/puppet-lint/plugins/class_alignment_equals_spec.rb
+- spec/puppet-lint/plugins/class_alignment_params_newline_spec.rb
+- spec/puppet-lint/plugins/class_alignment_params_spec.rb
 - spec/puppet-lint/plugins/concatenated_template_files_spec.rb
 - spec/puppet-lint/plugins/explicit_hiera_class_param_lookup_spec.rb
 - spec/puppet-lint/plugins/nine_legacy_facts_spec.rb
+- spec/puppet-lint/plugins/no_symbolic_file_modes_spec.rb
+- spec/puppet-lint/plugins/template_file_extension_spec.rb
 - spec/puppet-lint/plugins/trailing_newline_spec.rb
 - spec/puppet-lint/plugins/world_writable_files_spec.rb
 - spec/spec_helper.rb
@@ -150,7 +171,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.10
+rubygems_version: 3.4.19
 signing_key:
 specification_version: 4
 summary: A puppet-lint plugin for different checks used at Nine.