puppet-lint-manifest_whitespace-check 0.2.7 → 0.2.9

data/spec/puppet-lint/plugins/manifest_whitespace_opening_bracket_spec.rb

@@ -5,24 +5,40 @@ require 'spec_helper'
 describe 'manifest_whitespace_opening_bracket_before' do
   let(:opening_bracket_msg) { 'there should be a single space before an opening bracket' }
 
-  context 'with comment' do
+  context 'inside heredoc' do
     let(:code) do
-      <<~EOF
-        {
-          # some generic comment
-          ['some', 'values']
+      <<~CODE
+        class test::heredoc {
+          $unsupported = @("MESSAGE"/L)
+            This does not support ${facts['os']['name']} ${$facts['os']['release']['major']}; \
+            see ${support_urls['supported_platforms']} for more information\
+            | MESSAGE
+
+          fail($unsupported)
         }
-      EOF
+      CODE
     end
 
-    it 'should detect no problems' do
+    it 'detects no problems' do
+      expect(problems).to be_empty
+    end
+  end
+
+  context 'as value in an lambda' do
+    let(:code) do
+      <<~CODE
+        $result = assert_type(Array, $some_value) |$expected, $actual| { [] }
+      CODE
+    end
+
+    it 'detects no problems' do
       expect(problems).to be_empty
     end
   end
 
   context 'with iterator' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         {
           if condition {
           }
@@ -30,46 +46,46 @@ describe 'manifest_whitespace_opening_bracket_before' do
           ['ib0', 'ib1', 'ib2', 'ib3', 'pub', 'oob', '0', '184'].each |String $name| {
           }
         }
-      EOF
+      CODE
     end
 
-    it 'should detect no problems' do
+    it 'detects no problems' do
       expect(problems).to be_empty
     end
   end
 
   context 'with array key in interpolation' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         "${my_array['keyname']}"
-      EOF
+      CODE
     end
 
-    it 'should detect no problems' do
+    it 'detects no problems' do
       expect(problems).to be_empty
     end
   end
 
   context 'with multiline iterator' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         include my::class
 
         [
           'a',
           'b',
         ].each |$i| { }
-      EOF
+      CODE
     end
 
-    it 'should detect no problems' do
+    it 'detects no problems' do
       expect(problems).to be_empty
     end
   end
 
   context 'with no spaces' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         # example
         #
         # Main class, includes all other classes.
@@ -87,6 +103,7 @@ describe 'manifest_whitespace_opening_bracket_before' do
           if fact["${var}"] != $var2.keys[0] {
             # noop
           }
+          $variable_customfact = $facts['customfact_name'][$variable]
 
           $value = [{ 'key' => 'value' }]
           $value2 = [
@@ -118,11 +135,11 @@ describe 'manifest_whitespace_opening_bracket_before' do
             }
           }
         }
-      EOF
+      CODE
     end
 
     context 'with fix disabled' do
-      it 'should detect 0 problems' do
+      it 'detects 0 problems' do
         expect(problems).to be_empty
       end
     end
@@ -130,15 +147,15 @@ describe 'manifest_whitespace_opening_bracket_before' do
 
   context 'with resource inline' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         package { ['pack1', 'pack2']:
           ensure => present,
         }
-      EOF
+      CODE
     end
 
     context 'with fix disabled' do
-      it 'should detect 0 problems' do
+      it 'detects 0 problems' do
         expect(problems).to be_empty
       end
     end
@@ -146,18 +163,18 @@ describe 'manifest_whitespace_opening_bracket_before' do
 
   context 'with resource next line' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         package {
           ['pack3', 'pack4']:
             ensure => present;
           ['pack5', 'pack6']:
             ensure => present;
         }
-      EOF
+      CODE
     end
 
     context 'with fix disabled' do
-      it 'should detect 0 problems' do
+      it 'detects 0 problems' do
         expect(problems).to be_empty
       end
     end
@@ -165,7 +182,7 @@ describe 'manifest_whitespace_opening_bracket_before' do
 
   context 'with two spaces' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         # example
         #
         # Main class, includes all other classes.
@@ -192,15 +209,15 @@ describe 'manifest_whitespace_opening_bracket_before' do
             }
           }
         }
-      EOF
+      CODE
     end
 
     context 'with fix disabled' do
-      it 'should detect a 2 problems' do
+      it 'detects a 2 problems' do
         expect(problems).to have(2).problems
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_error(opening_bracket_msg).on_line(9).in_column(13)
       end
     end
@@ -214,17 +231,17 @@ describe 'manifest_whitespace_opening_bracket_before' do
         PuppetLint.configuration.fix = false
       end
 
-      it 'should detect a 2 problems' do
+      it 'detects a 2 problems' do
         expect(problems).to have(2).problems
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_fixed(opening_bracket_msg)
       end
 
-      it 'should remove a space' do
+      it 'removes a space' do
         expect(manifest).to eq(
-          <<~EOF,
+          <<~CODE,
             # example
             #
             # Main class, includes all other classes.
@@ -251,7 +268,7 @@ describe 'manifest_whitespace_opening_bracket_before' do
                 }
               }
             }
-          EOF
+          CODE
         )
       end
     end
@@ -259,7 +276,7 @@ describe 'manifest_whitespace_opening_bracket_before' do
 
   context 'with newline' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         # example
         #
         # Main class, includes all other classes.
@@ -289,19 +306,19 @@ describe 'manifest_whitespace_opening_bracket_before' do
             }
           }
         }
-      EOF
+      CODE
     end
 
     context 'with fix disabled' do
-      it 'should detect a no problems' do
+      it 'detects a no problems' do
         expect(problems).to be_empty
       end
     end
   end
 
-  context 'with comment' do
+  context 'with comment 1' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         # example
         #
         # Main class, includes all other classes.
@@ -330,15 +347,30 @@ describe 'manifest_whitespace_opening_bracket_before' do
             }
           }
         }
-      EOF
+      CODE
     end
 
     context 'with fix disabled' do
-      it 'should detect a no problems' do
+      it 'detects a no problems' do
         expect(problems).to be_empty
       end
     end
   end
+
+  context 'with comment 2' do
+    let(:code) do
+      <<~CODE
+        {
+          # some generic comment
+          ['some', 'values']
+        }
+      CODE
+    end
+
+    it 'detects no problems' do
+      expect(problems).to be_empty
+    end
+  end
 end
 
 describe 'manifest_whitespace_opening_bracket_after' do
@@ -346,23 +378,23 @@ describe 'manifest_whitespace_opening_bracket_after' do
 
   context 'with iterator' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         ['ib0', 'ib1', 'ib2', 'ib3', 'pub', 'oob', '0', '184'].each |String $name| {
         }
 
         ['ib0', 'ib1', 'ib2', 'ib3', 'pub', 'oob', '0', '184'].each |String $name| {
         }
-      EOF
+      CODE
     end
 
-    it 'should detect no problems' do
+    it 'detects no problems' do
       expect(problems).to be_empty
     end
   end
 
   context 'with a single space' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         # example
         #
         # Main class, includes all other classes.
@@ -392,15 +424,15 @@ describe 'manifest_whitespace_opening_bracket_after' do
             }
           }
         }
-      EOF
+      CODE
     end
 
     context 'with fix disabled' do
-      it 'should detect 4 problems' do
+      it 'detects 4 problems' do
         expect(problems).to have(4).problem
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_error(opening_bracket_msg).on_line(9).in_column(13)
       end
     end
@@ -414,13 +446,13 @@ describe 'manifest_whitespace_opening_bracket_after' do
         PuppetLint.configuration.fix = false
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_fixed(opening_bracket_msg)
       end
 
-      it 'should add spaces' do
+      it 'adds spaces' do
         expect(manifest).to eq(
-          <<~EOF,
+          <<~CODE,
             # example
             #
             # Main class, includes all other classes.
@@ -450,7 +482,7 @@ describe 'manifest_whitespace_opening_bracket_after' do
                 }
               }
             }
-          EOF
+          CODE
         )
       end
     end
@@ -458,7 +490,7 @@ describe 'manifest_whitespace_opening_bracket_after' do
 
   context 'with no spaces' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         # example
         #
         # Main class, includes all other classes.
@@ -485,11 +517,11 @@ describe 'manifest_whitespace_opening_bracket_after' do
             }
           }
         }
-      EOF
+      CODE
     end
 
     context 'with fix disabled' do
-      it 'should detect 0 problems' do
+      it 'detects 0 problems' do
         expect(problems).to be_empty
       end
     end
@@ -497,7 +529,7 @@ describe 'manifest_whitespace_opening_bracket_after' do
 
   context 'with two newlines' do
     let(:code) do
-      <<~EOF
+      <<~CODE
         # example
         #
         # Main class, includes all other classes.
@@ -530,15 +562,15 @@ describe 'manifest_whitespace_opening_bracket_after' do
             }
           }
         }
-      EOF
+      CODE
     end
 
     context 'with fix disabled' do
-      it 'should detect 1 problems' do
+      it 'detects 1 problems' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_error(opening_bracket_msg).on_line(12).in_column(1)
       end
     end
@@ -552,17 +584,17 @@ describe 'manifest_whitespace_opening_bracket_after' do
         PuppetLint.configuration.fix = false
       end
 
-      it 'should detect 1 problems' do
+      it 'detects 1 problems' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a error' do
+      it 'creates a error' do
         expect(problems).to contain_fixed(opening_bracket_msg)
       end
 
-      it 'should add spaces' do
+      it 'adds spaces' do
         expect(manifest).to eq(
-          <<~EOF,
+          <<~CODE,
             # example
             #
             # Main class, includes all other classes.
@@ -594,7 +626,7 @@ describe 'manifest_whitespace_opening_bracket_after' do
                 }
               }
             }
-          EOF
+          CODE
         )
       end
     end

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'coveralls'
 Coveralls.wear!
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint-manifest_whitespace-check
 version: !ruby/object:Gem::Version
-  version: 0.2.7
+  version: 0.2.9
 platform: ruby
 authors:
 - Jo Vandeginste
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-11-30 00:00:00.000000000 Z
+date: 2023-01-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puppet-lint
@@ -114,8 +114,8 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
-description: "    A new check for puppet-lint that validates generic whitespace issues
-  in manifests.\n"
+description: A new check for puppet-lint that validates generic whitespace issues
+  in manifests.
 email: jo.vandeginste@kuleuven.be
 executables: []
 extensions: []
@@ -151,7 +151,7 @@ licenses:
 - MIT
 metadata:
   rubygems_mfa_required: 'true'
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -159,15 +159,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.0'
+      version: '2.4'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
-signing_key:
+rubygems_version: 3.3.5
+signing_key: 
 specification_version: 4
 summary: A puppet-lint check to validate whitespace in manifests
 test_files: []