puppet-lint-legacy_facts-check 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cd3cb8032b34bedd7b911d90349ee7e0b921e09c72759da6333830975d060f6f
-  data.tar.gz: 6ab5ba872068cb338625ea655bb696d5f9d3d46599dfc7260f35aa745a2c0e40
+  metadata.gz: 5dd36569f910c1f7a9907a666afb2d6cdd2e516881027e2d84d9ee260e670d10
+  data.tar.gz: d67750794d8a7900a03423a9c745e54318e1e102a83cefe34033c2ed77ff821f
 SHA512:
-  metadata.gz: 357229fe8dd7417ebc38053ec7eeb174cefac881651dff55d47be03af62f04c6f936059f98499cf33cc9eb7e314c31d842b61b308b263322b3c89ae8dd04cbe8
-  data.tar.gz: 459f5115df04d1f6c682076a82ad8e3377d7786fb85b301f57d72baee2052ced015dfbf704b24477da6e6e875577124650137bfea40a14ed125d68843843266a
+  metadata.gz: 74733b16e7a684abd387334abe0bed9a4ba7f93dda808d32ff3a1f52b86c20e015b67538b2ee5873fbbd550ea71feb2c8179d6079ba4ddf1d72a65c1c7e364b0
+  data.tar.gz: df5f3ab48fafb0904ffaa033db415430abecc8aecb3e7027311a6389186930d19fabc05272458a91aa8e16a2f13e290540c73b0793b1e30ea5016180e9f2b715

data/README.md

@@ -1,7 +1,7 @@
 [![Build Status](https://travis-ci.org/mmckinst/puppet-lint-legacy_facts-check.svg?branch=master)](https://travis-ci.org/mmckinst/puppet-lint-legacy_facts-check)
-[![Gem](https://img.shields.io/gem/v/puppet-lint-legacy_facts-check.svg?maxAge=2592000)](https://rubygems.org/gems/puppet-lint-legacy_facts-check)
-![](https://img.shields.io/gem/dtv/puppet-lint-legacy_facts-check.svg?style=flat)
-![](https://img.shields.io/gem/dt/puppet-lint-legacy_facts-check.svg?style=flat)
+[![Gem](https://img.shields.io/gem/v/puppet-lint-legacy_facts-check.svg)](https://rubygems.org/gems/puppet-lint-legacy_facts-check)
+[![Total Downloads](https://img.shields.io/gem/dt/puppet-lint-legacy_facts-check.svg)](https://rubygems.org/gems/puppet-lint-legacy_facts-check)
+[![Latest Downloads](https://img.shields.io/gem/dtv/puppet-lint-legacy_facts-check.svg)](https://rubygems.org/gems/puppet-lint-legacy_facts-check)
 
 ## Overview
 

data/lib/puppet-lint/plugins/legacy_facts.rb

@@ -40,20 +40,20 @@ PuppetLint.new_check(:legacy_facts) do
     'chassistype'                 => "facts['dmi']['chassis']['type']",
     'domain'                      => "facts['networking']['domain']",
     'fqdn'                        => "facts['networking']['fqdn']",
-    'gid'                         => "facts['identity']['gid']",
+    'gid'                         => "facts['identity']['group']",
     'hardwareisa'                 => "facts['processors']['isa']",
     'hardwaremodel'               => "facts['os']['hardware']",
     'hostname'                    => "facts['networking']['hostname']",
-    'id'                          => "facts['identity']['uid']",
+    'id'                          => "facts['identity']['user']",
     'ipaddress'                   => "facts['networking']['ip']",
     'ipaddress6'                  => "facts['networking']['ip6']",
-    'lsbdistcodename'             => "facts['distro']['codename']",
-    'lsbdistdescription'          => "facts['distro']['description']",
-    'lsbdistid'                   => "facts['distro']['id']",
-    'lsbdistrelease'              => "facts['distro']['release']['full']",
-    'lsbmajdistrelease'           => "facts['distro']['release']['major']",
-    'lsbminordistrelease'         => "facts['distro']['release']['minor']",
-    'lsbrelease'                  => "facts['distro']['release']['specification']",
+    'lsbdistcodename'             => "facts['os']['distro']['codename']",
+    'lsbdistdescription'          => "facts['os']['distro']['description']",
+    'lsbdistid'                   => "facts['os']['distro']['id']",
+    'lsbdistrelease'              => "facts['os']['distro']['release']['full']",
+    'lsbmajdistrelease'           => "facts['os']['distro']['release']['major']",
+    'lsbminordistrelease'         => "facts['os']['distro']['release']['minor']",
+    'lsbrelease'                  => "facts['os']['distro']['release']['specification']",
     'macaddress'                  => "facts['networking']['mac']",
     'macosx_buildversion'         => "facts['os']['build']",
     'macosx_productname'          => "facts['os']['product']",

data/spec/puppet-lint/plugins/legacy_facts_spec.rb

@@ -292,5 +292,104 @@ describe 'legacy_facts' do
         expect(manifest).to eq("\"$facts['os']['family']\"")
       end
     end
+    context "fact variable using legacy variable in double quotes \"$::gid\"" do
+      let(:code) { "\"$::gid\"" }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should use the facts hash' do
+        expect(manifest).to eq("\"$facts['identity']['group']\"")
+      end
+    end
+    context "fact variable using legacy variable in double quotes \"$::id\"" do
+      let(:code) { "\"$::id\"" }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should use the facts hash' do
+        expect(manifest).to eq("\"$facts['identity']['user']\"")
+      end
+    end
+    context "fact variable using legacy variable in double quotes \"$::lsbdistcodename\"" do
+      let(:code) { "\"$::lsbdistcodename\"" }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should use the facts hash' do
+        expect(manifest).to eq("\"$facts['os']['distro']['codename']\"")
+      end
+    end
+    context "fact variable using legacy variable in double quotes \"$::lsbdistdescription\"" do
+      let(:code) { "\"$::lsbdistdescription\"" }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should use the facts hash' do
+        expect(manifest).to eq("\"$facts['os']['distro']['description']\"")
+      end
+    end
+    context "fact variable using legacy variable in double quotes \"$::lsbdistid\"" do
+      let(:code) { "\"$::lsbdistid\"" }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should use the facts hash' do
+        expect(manifest).to eq("\"$facts['os']['distro']['id']\"")
+      end
+    end
+    context "fact variable using legacy variable in double quotes \"$::lsbdistrelease\"" do
+      let(:code) { "\"$::lsbdistrelease\"" }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should use the facts hash' do
+        expect(manifest).to eq("\"$facts['os']['distro']['release']['full']\"")
+      end
+    end
+    context "fact variable using legacy variable in double quotes \"$::lsbmajdistrelease\"" do
+      let(:code) { "\"$::lsbmajdistrelease\"" }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should use the facts hash' do
+        expect(manifest).to eq("\"$facts['os']['distro']['release']['major']\"")
+      end
+    end
+    context "fact variable using legacy variable in double quotes \"$::lsbminordistrelease\"" do
+      let(:code) { "\"$::lsbminordistrelease\"" }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should use the facts hash' do
+        expect(manifest).to eq("\"$facts['os']['distro']['release']['minor']\"")
+      end
+    end
+    context "fact variable using legacy variable in double quotes \"$::lsbrelease\"" do
+      let(:code) { "\"$::lsbrelease\"" }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should use the facts hash' do
+        expect(manifest).to eq("\"$facts['os']['distro']['release']['specification']\"")
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint-legacy_facts-check
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Mark McKinstry
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-13 00:00:00.000000000 Z
+date: 2019-05-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puppet-lint