puppet-lint-legacy_facts-check 0.0.6 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9a7f2391ddc2702af498700ea0b6d0b8ba497c4a2e4ec5fe1c4435ccbf8bace9
-  data.tar.gz: f8d7e0285d707ff2573c5ab3c192d2ef0091471a00c889a0fa767acd22e4299a
+  metadata.gz: cd3cb8032b34bedd7b911d90349ee7e0b921e09c72759da6333830975d060f6f
+  data.tar.gz: 6ab5ba872068cb338625ea655bb696d5f9d3d46599dfc7260f35aa745a2c0e40
 SHA512:
-  metadata.gz: 20e2f8fe27fb5040a4de485946553c0c40571a3852f0f7b47ca88c7ee0e336a1c1aecf60b13abec13d79cf69d235e21168c0d85f3516a4aee6efa82f77ebd8e7
-  data.tar.gz: e52f2ab36c8181c51abc12adba813e364a13798291226b3c1750d6e4ca2dbd1388848feab44c8d9e96a5ded608b43fe472b43760f8a8f853e5caf5f914e50bfd
+  metadata.gz: 357229fe8dd7417ebc38053ec7eeb174cefac881651dff55d47be03af62f04c6f936059f98499cf33cc9eb7e314c31d842b61b308b263322b3c89ae8dd04cbe8
+  data.tar.gz: 459f5115df04d1f6c682076a82ad8e3377d7786fb85b301f57d72baee2052ced015dfbf704b24477da6e6e875577124650137bfea40a14ed125d68843843266a

data/README.md

@@ -1,5 +1,7 @@
 [![Build Status](https://travis-ci.org/mmckinst/puppet-lint-legacy_facts-check.svg?branch=master)](https://travis-ci.org/mmckinst/puppet-lint-legacy_facts-check)
 [![Gem](https://img.shields.io/gem/v/puppet-lint-legacy_facts-check.svg?maxAge=2592000)](https://rubygems.org/gems/puppet-lint-legacy_facts-check)
+![](https://img.shields.io/gem/dtv/puppet-lint-legacy_facts-check.svg?style=flat)
+![](https://img.shields.io/gem/dt/puppet-lint-legacy_facts-check.svg?style=flat)
 
 ## Overview
 

data/lib/puppet-lint/plugins/legacy_facts.rb

@@ -1,4 +1,5 @@
 PuppetLint.new_check(:legacy_facts) do
+  VAR_TYPES = Set[:VARIABLE, :UNENC_VARIABLE]
 
   # These facts that can't be converted to new facts for reasons documented at
   # https://github.com/mmckinst/puppet-lint-legacy_facts-check#limitations
@@ -96,7 +97,7 @@ PuppetLint.new_check(:legacy_facts) do
     'zonename'                    => "facts['solaris_zones']['current']",
   }
   def check
-    tokens.select { |x| x.type == :VARIABLE}.each do |token|
+    tokens.select { |x| VAR_TYPES.include?(x.type) }.each do |token|
       fact_name = ''
 
       # Get rid of the top scope before we do our work. We don't need to

data/spec/puppet-lint/plugins/legacy_facts_spec.rb

@@ -22,7 +22,7 @@ describe 'legacy_facts' do
     context "fact variable using legacy $osfamily" do
       let(:code) { "$osfamily" }
 
-      it 'should only detect a single problem' do
+      it 'should not detect any problems' do
         expect(problems).to have(0).problem
       end
     end
@@ -98,6 +98,14 @@ describe 'legacy_facts' do
         expect(problems).to have(1).problem
       end
     end
+
+    context "fact variable using legacy variable in double quotes \"$::osfamily\"" do
+      let(:code) { "\"$::osfamily\"" }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+    end
   end
 
 
@@ -129,9 +137,10 @@ describe 'legacy_facts' do
     context "fact variable using legacy $osfamily" do
       let(:code) { "$osfamily" }
 
-      it 'should only detect a single problem' do
+      it 'should not detect any problems' do
         expect(problems).to have(0).problem
       end
+
     end
 
     context "fact variable using legacy $facts['osfamily']" do
@@ -271,5 +280,17 @@ describe 'legacy_facts' do
         expect(manifest).to eq('"start '"${facts['os']['family']}"' end"')
       end
     end
+
+    context "fact variable using legacy variable in double quotes \"$::osfamily\"" do
+      let(:code) { "\"$::osfamily\"" }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should use the facts hash' do
+        expect(manifest).to eq("\"$facts['os']['family']\"")
+      end
+    end
   end
 end

data/spec/spec_helper.rb

@@ -1,3 +1,7 @@
 require 'puppet-lint'
 
 PuppetLint::Plugins.load_spec_helper
+
+RSpec.configure do |config|
+  config.formatter = :documentation
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint-legacy_facts-check
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 1.0.0
 platform: ruby
 authors:
 - Mark McKinstry
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-10 00:00:00.000000000 Z
+date: 2019-04-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puppet-lint
@@ -141,7 +141,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.2
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: A puppet-lint plugin to check you are not using legacy facts like $::operatingsystem