puppet-lint-legacy_facts-check 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 5df51a154367eb04ff197dfcf45c3398442b9470
-  data.tar.gz: ec60551e8b1ed914526d1b6b615acade910db4c3
+SHA256:
+  metadata.gz: 2b882589a54a6bf4e353d926c036211ccd1a354eba43902cef5fa9596978e6be
+  data.tar.gz: 6fd9ce9d4330c000b0e68261522a78770678c544db6c5f35c83547cf5524247b
 SHA512:
-  metadata.gz: f98d366343aec0e5df666dd92727e9f001fe18a2b3f7571d757a6bd64e414c8d0e92e4c6c18955955f881ce15371e8d7b7d81c85e111bc0043e634a8125abc15
-  data.tar.gz: ce089ee8a469d627ff36f245399e8cb6a5aee48bd1f5d41efd23d836e81aefd0d5de499d66f646cff7ad78717f86439ed517ad8c8235dc86c51d59ed8411faf0
+  metadata.gz: 1bac5d13a682d9ba27723624d547a9452df2c6f64fd0b71b3b9ea0250bd31f2e02dcd5cf4766ba99591d0eaa6c9c5d2fc1c8676d53062a0c946c697ea39c2522
+  data.tar.gz: 37782343cfba21ca9105ce72617c2c0ee0ad6513dce8336f1f6b45cb9dda9ae96d5a9cb148bd8a0d5dd4b7923521451a0219f1635c11a531364d11395d022625

data/lib/puppet-lint/plugins/legacy_facts.rb

@@ -8,7 +8,7 @@ PuppetLint.new_check(:legacy_facts) do
                  /^(?<attribute>ipaddress|ipaddress6|macaddress|mtu|netmask|netmask6|network|network6)_(?<interface>.*)$/,
                  /^processor(?<id>[0-9]+)$/,
                  /^sp_(?<name>.*)$/,
-                 /^ssh(?<algorithm>.*)key$/,
+                 /^ssh(?<algorithm>dsa|ecdsa|ed25519|rsa)key$/,
                  /^ldom_(?<name>.*)$/,
                  /^zone_(?<name>.*)_(?<attribute>brand|iptype|name|uuid|id|path|status)$/]
 
@@ -118,7 +118,7 @@ PuppetLint.new_check(:legacy_facts) do
         problem[:token].value = "facts['processors']['models'][" << m['id'] << "]"
       elsif m = fact_name.match(/^sp_(?<name>.*)$/)
         problem[:token].value = "facts['system_profiler']['" << m['name'] << "']"
-      elsif m = fact_name.match(/^ssh(?<algorithm>.*)key$/)
+      elsif m = fact_name.match(/^ssh(?<algorithm>dsa|ecdsa|ed25519|rsa)key$/)
         problem[:token].value = "facts['ssh']['" << m['algorithm'] << "']['key']"
       elsif m = fact_name.match(/^ldom_(?<name>.*)$/)
         problem[:token].value = "facts['ldom']['" << m['name'] << "']"

data/spec/puppet-lint/plugins/legacy_facts_spec.rb

@@ -11,6 +11,14 @@ describe 'legacy_facts' do
       end
     end
 
+    context "fact variable using modern $facts['ssh']['rsa']['key'] hash" do
+      let(:code) { "$facts['ssh']['rsa']['key']" }
+
+      it 'should not detect any problems' do
+        expect(problems).to have(0).problem
+      end
+    end
+
     context "fact variable using legacy $osfamily" do
       let(:code) { "$osfamily" }
 
@@ -102,6 +110,14 @@ describe 'legacy_facts' do
       end
     end
 
+    context "fact variable using modern $facts['ssh']['rsa']['key'] hash" do
+      let(:code) { "$facts['ssh']['rsa']['key']" }
+
+      it 'should not detect any problems' do
+        expect(problems).to have(0).problem
+      end
+    end
+
     context "fact variable using legacy $osfamily" do
       let(:code) { "$osfamily" }
 
@@ -142,6 +158,22 @@ describe 'legacy_facts' do
       end
     end
 
+    context "fact variable using legacy $::sshrsakey" do
+      let(:code) { "$::sshrsakey" }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should fix the problem' do
+        expect(problems).to contain_fixed(msg).on_line(1).in_column(1)
+      end
+
+      it 'should use the facts hash' do
+        expect(manifest).to eq("$facts['ssh']['rsa']['key']")
+      end
+    end
+
     context "fact variable using legacy $::memoryfree_mb" do
       let(:code) { "$::memoryfree_mb" }
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint-legacy_facts-check
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Mark McKinstry
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-07 00:00:00.000000000 Z
+date: 2018-11-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puppet-lint
@@ -94,6 +94,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: |2
     A pupet-lint to check you are not using legacy facts like `$::operatingsystem`
     or `$facts['operatingsystem']`. You should use the new structured facts like
@@ -128,10 +142,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.7.8
 signing_key: 
 specification_version: 4
 summary: A puppet-lint plugin to check you are not using legacy facts like $::operatingsystem
 test_files:
-- spec/puppet-lint/plugins/legacy_facts_spec.rb
 - spec/spec_helper.rb
+- spec/puppet-lint/plugins/legacy_facts_spec.rb