puppet-lint-global_resource-check 0.1.0

data/README.md

@@ -0,0 +1,25 @@
+# puppet-lint global resource check
+
+## Installation
+
+To use this plugin, add the following like to the Gemfile in your Puppet code
+base and run `bundle install`.
+
+```ruby
+gem 'puppet-lint-global_resource-check'
+```
+
+## Usage
+
+This plugin provides a new check to `puppet-lint`.
+
+### global_resource
+
+**--fix support: No**
+
+This check will raise a error for any global defines resource.
+
+```
+ERROR: Resource file in global space on line 19
+```
+

data/lib/puppet-lint/plugins/check_global_resource.rb

@@ -0,0 +1,33 @@
+PuppetLint.new_check(:global_resource) do
+  def check
+
+    secure = []
+
+    class_indexes.each { |c| secure << [c[:start], c[:end]] }
+    defined_type_indexes.each { |d| secure << [d[:start], d[:end]] }
+
+    # node_indexes will be in the next puppet-lint version
+    unless defined? node_indexes
+      node_indexes = PuppetLint::Data.definition_indexes(:NODE)
+    end
+    node_indexes.each { |n| secure << [n[:start], n[:end]] }
+
+    resource_indexes.each do |r|
+      encap = 0
+      secure.each do |s|
+        if s[0] < r[:start] and s[1] > r[:end]
+          encap = 1
+        end
+      end
+      next if encap == 1
+
+      notify(:error, {
+        :message => "Resource #{r[:type].value} in global space",
+        :line => r[:type].line,
+        :column => r[:type].column,
+      })
+    end
+
+  end
+
+end

data/spec/puppet-lint/plugins/check_global_resource_spec.rb

@@ -0,0 +1,37 @@
+require 'spec_helper'
+
+describe 'global_resource' do
+  
+  context 'just a class' do
+    let(:code) { "class test { file { 'file': } }" }
+    
+    it 'should not detect any problems' do
+      expect(problems).to have(0).problems
+    end
+  end
+
+  context 'just a define' do
+    let(:code) { "define test ($param = undef) { file { 'file': } }" }
+
+    it 'should not detect any problems' do
+      expect(problems).to have(0).problems
+    end
+  end
+
+  context 'allow node resources' do
+    let(:code) { "node 'test' { file { 'file': } }" }
+
+    it 'should not detect any problems' do
+      expect(problems).to have(0).problems
+    end
+  end
+
+  context 'global file' do
+    let(:code) { "file { 'file': } define test ($param = undef) { file { 'file': } }" }
+
+    it 'should detect a problem' do
+      expect(problems).to have(1).problems
+    end
+  end
+
+end

data/spec/spec_helper.rb

@@ -0,0 +1,3 @@
+require 'puppet-lint'
+
+PuppetLint::Plugins.load_spec_helper

metadata

@@ -0,0 +1,134 @@
+--- !ruby/object:Gem::Specification
+name: puppet-lint-global_resource-check
+version: !ruby/object:Gem::Version
+  version: 0.1.0
+  prerelease: 
+platform: ruby
+authors:
+- Marius Rieder
+autorequire: 
+bindir: bin
+cert_chain: []
+date: 2015-03-03 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: puppet-lint
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rspec-its
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: rspec-collection_matchers
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+description: ! '    Extends puppet-lint to ensure that your manifests have no global
+  resources.
+
+'
+email: marius.rieder@nine.ch
+executables: []
+extensions: []
+extra_rdoc_files: []
+files:
+- README.md
+- lib/puppet-lint/plugins/check_global_resource.rb
+- spec/puppet-lint/plugins/check_global_resource_spec.rb
+- spec/spec_helper.rb
+homepage: https://github.com/ninech/puppet-lint-global_resource-check
+licenses:
+- MIT
+post_install_message: 
+rdoc_options: []
+require_paths:
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements: []
+rubyforge_project: 
+rubygems_version: 1.8.23
+signing_key: 
+specification_version: 3
+summary: puppet-lint global_resource check
+test_files:
+- spec/puppet-lint/plugins/check_global_resource_spec.rb
+- spec/spec_helper.rb