puppet-lint-file_line_match-check 1.0.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: d0da08b397ff2bdee2ad4166ef3ab35aef98f4dd
+  data.tar.gz: 8dd4b743d771e576584ae72c99d2f7deb3ab5806
+SHA512:
+  metadata.gz: 27c49f6836c6c79254e354dfdc56337e1e10f3d76cba005f7859dc838350568f3945836ea4a2fbe2d91768b63d74320b44a3202dbf94c08085f017a0ff2b6c7b
+  data.tar.gz: f8a2f17efa13db1a00436bd2c66598b558b2f4b7a28486da1c3c183be6e95a170c14f1df19d324343ea8cd5ae1db83236f6f40da2c7540c8ff1240ce4389b688

data/LICENSE

@@ -0,0 +1,21 @@
+The MIT License (MIT)
+
+Copyright (c) 2014 Chris Spence
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

data/README.md

@@ -0,0 +1,7 @@
+# Puppet lint check for file_line resources
+
+[![Build Status](https://travis-ci.org/tolleiv/puppet-lint-file_line_match-check.png?branch=master)](https://travis-ci.org/tolleiv/puppet-lint-file_line_match-check)
+
+We found that using file\_line without a match attrbite is dangerous in our setup.
+Therefore this check implements a warning in case the match is missing.
+

data/lib/puppet-lint/plugins/check_file_line_match.rb

@@ -0,0 +1,20 @@
+PuppetLint.new_check(:file_line_match) do
+  def check
+
+    resource_indexes.each do |resource|
+      if resource[:type].value == "file_line"
+        matches = resource[:param_tokens].select { |param_token|
+          param_token.value == 'match'
+        }
+        unless matches.length == 1
+          tkn = resource[:tokens].first
+          notify :warning, {
+              :message => 'expected one match attribute for file_line resource',
+              :line    => tkn.line,
+              :column  => tkn.column,
+          }
+        end
+      end
+    end
+  end
+end

data/spec/puppet-lint/plugins/check_file_line_match_spec.rb

@@ -0,0 +1,60 @@
+require 'spec_helper'
+
+describe 'file_line_match' do
+  let(:msg) { 'expected one match attribute for file_line resource' }
+
+  context 'with fix disabled' do
+    context 'code with missing match attribute' do
+      let(:code) { "
+      file { '/tmp/foo':
+        ensure => present,
+        foo => bar,
+        baz => gronk,
+        foo => meh,
+      }
+      file_line { 'sudo_rule':
+        path => '/etc/sudoers',
+        line => '%sudo ALL=(ALL) ALL',
+      }" }
+
+      it 'should detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should create a warning' do
+        expect(problems).to contain_warning(msg).on_line(8).in_column(31)
+      end
+    end
+    context 'code with duplicate match attribute' do
+      let(:code) { "
+      file_line { 'sudo_rule':
+        path => '/etc/sudoers',
+        match  => '^export\\ HTTP_PROXY\\=',
+        line => '%sudo ALL=(ALL) ALL',
+        match  => '^export\\ HTTP_PROXY\\=',
+      }" }
+
+      it 'should detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should create a warning' do
+        expect(problems).to contain_warning(msg).on_line(2).in_column(31)
+      end
+    end
+
+    context 'code with a match attribute' do
+      let(:code) { "
+      file_line { 'bashrc_proxy':
+        ensure => present,
+        path   => '/etc/bashrc',
+        line   => 'export HTTP_PROXY=http://squid.puppetlabs.vm:3128',
+        match  => '^export\\ HTTP_PROXY\\=',
+      }" }
+
+      it 'should not detect any problems' do
+        expect(problems).to have(0).problems
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,4 @@
+require 'puppet-lint'
+
+PuppetLint::Plugins.load_spec_helper
+

metadata

@@ -0,0 +1,123 @@
+--- !ruby/object:Gem::Specification
+name: puppet-lint-file_line_match-check
+version: !ruby/object:Gem::Version
+  version: 1.0.0
+platform: ruby
+authors:
+- Tolleiv Nietsch
+autorequire: 
+bindir: bin
+cert_chain: []
+date: 2016-03-22 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: puppet-lint
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rspec-its
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: rspec-collection_matchers
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0'
+description: |2
+      A puppet-lint plugin to check whether all file_line resources have a match condition.
+      That's important to avoid that file_line screws up the file-content.
+email: tolleiv.nietsch@aoe.com
+executables: []
+extensions: []
+extra_rdoc_files: []
+files:
+- LICENSE
+- README.md
+- lib/puppet-lint/plugins/check_file_line_match.rb
+- spec/puppet-lint/plugins/check_file_line_match_spec.rb
+- spec/spec_helper.rb
+homepage: https://github.com/tolleiv/puppet-lint-file_line_match-check
+licenses:
+- MIT
+metadata: {}
+post_install_message: 
+rdoc_options: []
+require_paths:
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements: []
+rubyforge_project: 
+rubygems_version: 2.4.6
+signing_key: 
+specification_version: 4
+summary: A puppet-lint plugin to check whether all file_line resources have a match
+  condition.
+test_files:
+- spec/puppet-lint/plugins/check_file_line_match_spec.rb
+- spec/spec_helper.rb