puppet-lint-duplicate_class_parameters-check 1.0.4 → 1.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: ad8bf84346ce09b36f6268ffea85e13b34696e28
-  data.tar.gz: c8fa8c9006fd3714de3703cc8d592ccad9003f65
+SHA256:
+  metadata.gz: d3b64e4aadbcf743b16ed650778e90c64362c3c2fa87586a3db25a3c5588e1fe
+  data.tar.gz: 7b20846a265a8d9643668df2c692e5d53c3441e25914e46f66c6e1cbcd34a5b9
 SHA512:
-  metadata.gz: 6ce98b5eda889442bd9e61784a6d2023962353e1890fa2288a478fc267113604742e89a5654a59f1ec9479c3320c5f6d66fcfc0b19bb5b0b09421c22c5a45c35
-  data.tar.gz: 28d2c4abfc70af9604093b7ee0752d26360a4da08752898ba49bab5b839eb24fd75b1159d77eb1dd7056f2bb33a612c35da6a2e58e4e151f011537f7f0d9a1f8
+  metadata.gz: 62f18dd0efb26da270255bdef226551df53e4d5645cee3d9adb81a7dab04fbcc1bce1119f54c12de50c45e177e1234581f99c7280456073e4e8e84309614c9a4
+  data.tar.gz: c0bbe56fb14bb4910c9f52dc24ce0b184a80ee13cc7fa14e868518ae615ff0903a620a4ee08238f31925584f1f5a587233fe43c4382009c98af7bddaebb102a0

data/lib/puppet-lint/plugins/duplicate_class_parameters.rb

@@ -3,6 +3,7 @@ PuppetLint.new_check(:duplicate_class_parameters) do
     class_indexes.each do |class_idx|
       seen = Hash.new(0)
       inside = nil
+      level = 0
 
       # if there are no params there is nothing to do, return early.
       return if class_idx[:param_tokens].nil?
@@ -10,6 +11,15 @@ PuppetLint.new_check(:duplicate_class_parameters) do
       class_idx[:param_tokens].each do |token|
         class_name = class_idx[:name_token].value
 
+        case token.type
+        when :LBRACK, :LBRACE
+          level += 1
+        when :RBRACK, :RBRACE
+          level -= 1
+        end
+
+        next unless level.zero?
+
         if token.type == :VARIABLE
           next_type = token.next_code_token.type
 

data/spec/puppet-lint/plugins/puppet-lint_duplicate_class_parameters_spec.rb

@@ -162,4 +162,22 @@ describe 'duplicate_class_parameters' do
     end
   end
 
+  context 'class with a structure using a variable and assigned in another variable' do
+    let(:code) do
+      <<-EOS
+        class complex_structure_assignation (
+          Optional[String] $hostname = undef,
+          Array[String] $aliases = ["www.${hostname}"],
+        ) {
+          if $hostname {
+            # ...
+          }
+        }
+      EOS
+    end
+
+    it 'should not detect any problems' do
+      expect(problems).to have(0).problems
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint-duplicate_class_parameters-check
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.0.5
 platform: ruby
 authors:
 - Dean Wilson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-18 00:00:00.000000000 Z
+date: 2019-08-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puppet-lint
@@ -161,10 +161,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: puppet-lint duplicate class parameters check
 test_files:
-- spec/spec_helper.rb
 - spec/puppet-lint/plugins/puppet-lint_duplicate_class_parameters_spec.rb
+- spec/spec_helper.rb