puppet-lint-cuddled_else-check 0.1.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA256:
+  metadata.gz: 1b48ad06c4aadea657c41baaf5aa09d5b393024b04400efd3ebf83785a753957
+  data.tar.gz: 1d54d0b7273fb8715dd16b198476cb13e63d3f0d8ffeda11192bf6d2eb933a6a
+SHA512:
+  metadata.gz: 79006155a35ed05cce79fde709db20fa58ad0a404fc4638b76f4e243da4d1b7adc32471fdf415177a9364dac372099d3cdb0e2912b7adb073af2952975f1b238
+  data.tar.gz: 0de7254bdd7b0377d7e47cf5efaae6c545f7a4ef666143ea35b9812e7a8e2284c15828119986e6c9348919b095d5dbc4287526b08624acb5c4183f1669747570

data/LICENSE

@@ -0,0 +1,21 @@
+MIT License
+
+Copyright (c) [2019] [Christian Bartolomäus]
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

data/README.md

@@ -0,0 +1,61 @@
+puppet-lint-cuddled_else-check
+==============================
+
+A puppet-lint plugin to check for [cuddled else blocks](http://wiki.c2.com/?CuddledElseBlocks).
+
+## Installation
+
+### From the command line
+
+```shell
+$ gem install puppet-lint-cuddled_else-check
+```
+
+## Checks
+
+### Cuddled else/elsif
+
+There are two different styles regarding the placement of `else` and `elsif` keywords. It can be placed on the same line as the closing curly of the preceding if block (`cuddled`) or on a separate line below that closing curly (`uncuddled`). There are pros and cons for both styles -- cmp. http://wiki.c2.com/?CuddledElseBlocks.
+
+This check helps to enforce a consistent style by warning about `cuddled` else/elsif keywords.
+
+#### What you have done
+
+The `else` (or `elsif`) keyword is on the same line as the closing curly brace of the preceding if block.
+
+```puppet
+if $foo == 'bar' {
+  ## some stuff
+} else {
+  ## other stuff
+}
+```
+
+#### What you should have done
+
+The `else` (or `elsif`) keyword is on a new line below the closing curly brace of the preceding if block.
+
+```puppet
+if $foo == 'bar' {
+  ## some stuff
+}
+else {
+  ## other stuff
+}
+```
+
+#### Disabling the check
+
+To disable this check, you can add `--no-cuddled_else-check' to your puppet-lint command line.
+
+```
+$ puppet-lint --no-cuddled_else-check /path/to/file.pp
+```
+
+## See also
+
+There is a corresponding plugin `puppet-lint-uncuddled_else-check` that warns for uncuddled else blocks. Most probably you only want one of both checks. ;)
+
+## Acknowledgments
+
+This plugin for `puppet-lint` has been written owing to the very nice [tutorial for writing puppet-lint checks](http://puppet-lint.com/developer/tutorial/).

data/lib/puppet-lint/plugins/check_cuddled_else.rb

@@ -0,0 +1,18 @@
+PuppetLint.new_check(:cuddled_else) do
+  def check
+    tokens.each do |token|
+      next unless token.type == :ELSE || token.type == :ELSIF
+
+      ## 'else/elsif' should be first thing on line (but could be indented)
+      prev1 = token.prev_token
+      next if prev1.type == :NEWLINE || prev1.type == :INDENT
+
+      ## otherwise it's not an uncuddled else/elsif
+      notify :warning, {
+        :message => "found cuddled #{token.type.to_s.downcase}, should be on separate line",
+        :line    => token.line,
+        :column  => token.column,
+      }
+    end
+  end
+end

data/spec/puppet-lint/plugins/check_cuddled_else_spec.rb

@@ -0,0 +1,99 @@
+require 'spec_helper'
+
+# rubocop:disable Metrics/BlockLength, Metrics/LineLength
+describe 'cuddled_else' do
+  ## cuddled else
+  context 'with fix disabled' do
+    let(:msg) { 'found cuddled else, should be on separate line' }
+
+    ## no indentation
+    context 'else on next line after closing curly of preceding if block' do
+      let(:code) { "if $foo == 'bar' {\n  ## some stuff\n}\nelse {\n  ## other stuff\n}\n" }
+
+      it 'should not detect any problems' do
+        expect(problems).to have(0).problems
+      end
+    end
+
+    context 'else on same line as closing curly of preceding if block' do
+      let(:code) { "if $foo == 'bar' {\n  ## some stuff\n} else {\n  ## other stuff\n}\n" }
+
+      it 'should detect a single problems' do
+        expect(problems).to have(1).problems
+      end
+
+      it 'should create a warning' do
+        expect(problems).to contain_warning(msg).on_line(3).in_column(3)
+      end
+    end
+
+    ## with indentation
+    context 'indented else on next line after closing curly of preceding if block' do
+      let(:code) { "  if $foo == 'bar' {\n    ## some stuff\n  }\n  else {\n    ## other stuff\n  }\n" }
+
+      it 'should not detect any problems' do
+        expect(problems).to have(0).problems
+      end
+    end
+
+    context 'else on same line as indented closing curly of preceding if block' do
+      let(:code) { "  if $foo == 'bar' {\n    ## some stuff\n  } else {\n    ## other stuff\n  }\n" }
+
+      it 'should detect a single problems' do
+        expect(problems).to have(1).problems
+      end
+
+      it 'should create a warning' do
+        expect(problems).to contain_warning(msg).on_line(3).in_column(5)
+      end
+    end
+  end
+
+  ## cuddled elsif
+  context 'with fix disabled' do
+    let(:msg) { 'found cuddled elsif, should be on separate line' }
+
+    ## no indentation
+    context 'elsif on next line after closing curly of preceding if block' do
+      let(:code) { "if $foo == 'bar' {\n  ## some stuff\n}\nelsif $foo == 'baz' {\n  ## other stuff\n}\n" }
+
+      it 'should not detect any problems' do
+        expect(problems).to have(0).problems
+      end
+    end
+
+    context 'elsif on same line as closing curly of preceding if block' do
+      let(:code) { "if $foo == 'bar' {\n  ## some stuff\n} elsif $foo == 'baz' {\n  ## other stuff\n}\n" }
+
+      it 'should detect a single problems' do
+        expect(problems).to have(1).problems
+      end
+
+      it 'should create a warning' do
+        expect(problems).to contain_warning(msg).on_line(3).in_column(3)
+      end
+    end
+
+    ## with indentation
+    context 'indented elsif on next line after closing curly of preceding if block' do
+      let(:code) { "  if $foo == 'bar' {\n    ## some stuff\n  }\n  elsif $foo == 'baz' {\n    ## other stuff\n  }\n" }
+
+      it 'should not detect any problems' do
+        expect(problems).to have(0).problems
+      end
+    end
+
+    context 'elsif on same line as indented closing curly of preceding if block' do
+      let(:code) { "  if $foo == 'bar' {\n    ## some stuff\n  } elsif $foo == 'baz' {  \n  ## other stuff\n  }\n" }
+
+      it 'should detect a single problems' do
+        expect(problems).to have(1).problems
+      end
+
+      it 'should create a warning' do
+        expect(problems).to contain_warning(msg).on_line(3).in_column(5)
+      end
+    end
+  end
+end
+# rubocop:enable Metrics/BlockLength, Metrics/LineLength

data/spec/spec_helper.rb

@@ -0,0 +1,3 @@
+require 'puppet-lint'
+
+PuppetLint::Plugins.load_spec_helper

metadata

@@ -0,0 +1,148 @@
+--- !ruby/object:Gem::Specification
+name: puppet-lint-cuddled_else-check
+version: !ruby/object:Gem::Version
+  version: 0.1.0
+platform: ruby
+authors:
+- Christian Bartolomäus
+autorequire: 
+bindir: bin
+cert_chain: []
+date: 2019-03-06 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: puppet-lint
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rspec-its
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: rspec-collection_matchers
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: rspec-json_expectations
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+description: "    A puppet-lint plugin to check that manifest files do not have cuddled
+  else blocks.\n"
+email: use_v6@aglaz.de
+executables: []
+extensions: []
+extra_rdoc_files: []
+files:
+- LICENSE
+- README.md
+- lib/puppet-lint/plugins/check_cuddled_else.rb
+- spec/puppet-lint/plugins/check_cuddled_else_spec.rb
+- spec/spec_helper.rb
+homepage: https://github.com/optivo-org/puppet-lint-cuddled_else-check
+licenses:
+- MIT
+metadata: {}
+post_install_message: 
+rdoc_options: []
+require_paths:
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements: []
+rubygems_version: 3.0.1
+signing_key: 
+specification_version: 4
+summary: A puppet-lint plugin to check for cuddled else blocks.
+test_files:
+- spec/spec_helper.rb
+- spec/puppet-lint/plugins/check_cuddled_else_spec.rb