puppet-lint-absolute_classname-check 3.1.0 → 5.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 86140cad9c7e991e50d45bb4bc896788b16a64776749c5cbbb80f29032bc1692
-  data.tar.gz: 716c53d528e10c3bcda030e1c19cc54c017346556fb98ff580a698fc32542680
+  metadata.gz: bab4eb9b4aef059a9c8504154fae11e0255f60d5189917cca60e2cfb34b3303b
+  data.tar.gz: cb99d84abdd3643e7716cfbcd8acaa305e01044cacde4ef357a2356027598207
 SHA512:
-  metadata.gz: 51b2d31cff4c997644a034a97c909c950ac67e59c3ddec2135b21bcc1a096e0357d48e61fd15d89ddbdfb0643bdac37e3e1f32c956f748c89c79ba348a6e3b52
-  data.tar.gz: 0ce3da50d95b4643d37b99e526b887c0ae7fa876abbb2c60917420a8c10b69efaa5c59714c09f57f4a42ef18d0cd5df7bc48aaa6620ab6322ca92d0067e90ea8
+  metadata.gz: 04e32d38a39f8971047041bef61928e17a4bbf10b2094dd87179ff7596714bf36abefcaa15723effb7f031943024b21868fc84446a0bd002579620f2ae9f0265
+  data.tar.gz: 7dd31a3d2d1554008030ae3dba22257573be9a7c9f06e96bcdd251c01728f5e7c1e36e84da23b63ff53b71b8c161408283b7977089dda495f6c544fe217a78f4

data/lib/puppet-lint/plugins/check_absolute_classname.rb

@@ -2,8 +2,8 @@ PuppetLint.new_check(:relative_classname_inclusion) do
   def check
     message = 'class included by absolute name (::$class)'
 
-    tokens.each_with_index do |token, token_idx|
-      if [:NAME,:FUNCTION_NAME].include?(token.type) && ['include','contain','require'].include?(token.value)
+    tokens.each_with_index do |token, _token_idx|
+      if %i[NAME FUNCTION_NAME].include?(token.type) && %w[include contain require].include?(token.value)
         s = token.next_code_token
         next if s.nil?
         next if s.type == :FARROW
@@ -11,7 +11,7 @@ PuppetLint.new_check(:relative_classname_inclusion) do
         in_function = 0
         while s.type != :NEWLINE
           n = s.next_code_token
-          if [:NAME, :FUNCTION_NAME, :SSTRING,].include?(s.type)
+          if %i[NAME FUNCTION_NAME SSTRING].include?(s.type)
             if n && n.type == :LPAREN
               in_function += 1
             elsif in_function > 0 && n && n.type == :RPAREN
@@ -21,7 +21,7 @@ PuppetLint.new_check(:relative_classname_inclusion) do
                 message: message,
                 line: s.line,
                 column: s.column,
-                token: s
+                token: s,
               }
             end
           end
@@ -30,12 +30,12 @@ PuppetLint.new_check(:relative_classname_inclusion) do
       elsif token.type == :CLASS and token.next_code_token.type == :LBRACE
         s = token.next_code_token
         while s.type != :COLON
-          if (s.type == :NAME || s.type == :SSTRING) && s.value.start_with?('::')
+          if %i[NAME SSTRING].include?(s.type) && s.value.start_with?('::')
             notify :warning, {
               message: message,
               line: s.line,
               column: s.column,
-              token: s
+              token: s,
             }
           end
           s = s.next_token
@@ -47,7 +47,7 @@ PuppetLint.new_check(:relative_classname_inclusion) do
             message: message,
             line: s.line,
             column: s.column,
-            token: s
+            token: s,
           }
         end
       end

data/lib/puppet-lint/plugins/check_classname_reference.rb

@@ -2,20 +2,20 @@ PuppetLint.new_check(:relative_classname_reference) do
   def check
     message = 'absolute class name reference'
 
-    tokens.each_with_index do |token, token_idx|
-      if token.type == :TYPE and token.value == 'Class' and token.next_code_token.type == :LBRACK
-        s = token.next_code_token
-        while s.type != :RBRACK
-          if (s.type == :NAME || s.type == :SSTRING) && s.value.start_with?('::')
-            notify :warning, {
-              message: message,
-              line: s.line,
-              column: s.column,
-              token: s
-            }
-          end
-          s = s.next_token
+    tokens.each_with_index do |token, _token_idx|
+      next unless token.type == :TYPE and token.value == 'Class' and token.next_code_token.type == :LBRACK
+
+      s = token.next_code_token
+      while s.type != :RBRACK
+        if %i[NAME SSTRING].include?(s.type) && s.value.start_with?('::')
+          notify :warning, {
+            message: message,
+            line: s.line,
+            column: s.column,
+            token: s,
+          }
         end
+        s = s.next_token
       end
     end
   end

data/spec/puppet-lint/plugins/check_absolute_classname/relative_classname_inclusion_spec.rb

@@ -35,11 +35,11 @@ describe 'relative_classname_inclusion' do
         EOS
       end
 
-      it 'should detect 12 problems' do
+      it 'detects 12 problems' do
         expect(problems).to have(12).problems
       end
 
-      it 'should create warnings' do
+      it 'creates warnings' do
         expect(problems).to contain_warning(msg).on_line(1).in_column(17)
         expect(problems).to contain_warning(msg).on_line(2).in_column(17)
         expect(problems).to contain_warning(msg).on_line(6).in_column(17)
@@ -70,7 +70,7 @@ describe 'relative_classname_inclusion' do
         EOS
       end
 
-      it 'should not detect a problem' do
+      it 'does not detect a problem' do
         expect(problems).to have(0).problems
       end
     end
@@ -85,7 +85,7 @@ describe 'relative_classname_inclusion' do
         EOS
       end
 
-      it 'should detect no problems' do
+      it 'detects no problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -102,7 +102,7 @@ describe 'relative_classname_inclusion' do
         EOS
       end
 
-      it 'should detect no problems' do
+      it 'detects no problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -148,11 +148,11 @@ describe 'relative_classname_inclusion' do
         EOS
       end
 
-      it 'should detect 12 problems' do
+      it 'detects 12 problems' do
         expect(problems).to have(12).problems
       end
 
-      it 'should fix the problems' do
+      it 'fixes the problems' do
         expect(problems).to contain_fixed(msg).on_line(1).in_column(17)
         expect(problems).to contain_fixed(msg).on_line(2).in_column(17)
         expect(problems).to contain_fixed(msg).on_line(6).in_column(17)
@@ -167,9 +167,9 @@ describe 'relative_classname_inclusion' do
         expect(problems).to contain_fixed(msg).on_line(24).in_column(31)
       end
 
-      it 'should should remove colons' do
+      it 'shoulds remove colons' do
         expect(manifest).to eq(
-        <<-EOS
+          <<-EOS,
         include foobar
         include('foobar')
         include(foobar(baz))
@@ -215,7 +215,7 @@ describe 'relative_classname_inclusion' do
         EOS
       end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -230,7 +230,7 @@ describe 'relative_classname_inclusion' do
       EOS
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end

data/spec/puppet-lint/plugins/check_classname_reference/relative_classname_reference_spec.rb

@@ -21,11 +21,11 @@ describe 'relative_classname_reference' do
         EOS
       end
 
-      it 'should detect 6 problems' do
+      it 'detects 6 problems' do
         expect(problems).to have(6).problems
       end
 
-      it 'should create warnings' do
+      it 'creates warnings' do
         expect(problems).to contain_warning(msg).on_line(1).in_column(15)
         expect(problems).to contain_warning(msg).on_line(1).in_column(31)
         expect(problems).to contain_warning(msg).on_line(5).in_column(28)
@@ -50,7 +50,7 @@ describe 'relative_classname_reference' do
         EOS
       end
 
-      it 'should not detect a problem' do
+      it 'does not detect a problem' do
         expect(problems).to have(0).problems
       end
     end
@@ -82,11 +82,11 @@ describe 'relative_classname_reference' do
         EOS
       end
 
-      it 'should detect 6 problems' do
+      it 'detects 6 problems' do
         expect(problems).to have(6).problems
       end
 
-      it 'should fix the problems' do
+      it 'fixes the problems' do
         expect(problems).to contain_fixed(msg).on_line(1).in_column(15)
         expect(problems).to contain_fixed(msg).on_line(1).in_column(31)
         expect(problems).to contain_fixed(msg).on_line(5).in_column(28)
@@ -95,9 +95,9 @@ describe 'relative_classname_reference' do
         expect(problems).to contain_fixed(msg).on_line(10).in_column(43)
       end
 
-      it 'should should remove colons' do
+      it 'shoulds remove colons' do
         expect(manifest).to eq(
-        <<-EOS
+          <<-EOS,
         Class[foo] -> Class['bar']
 
         file { '/path':
@@ -129,7 +129,7 @@ describe 'relative_classname_reference' do
         EOS
       end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end

data/spec/spec_helper.rb

@@ -1,29 +1,6 @@
 # frozen_string_literal: true
 
-begin
-  require 'simplecov'
-  require 'simplecov-console'
-  require 'codecov'
-rescue LoadError
-else
-  SimpleCov.start do
-    track_files 'lib/**/*.rb'
-
-    add_filter '/spec'
-
-    enable_coverage :branch
-
-    # do not track vendored files
-    add_filter '/vendor'
-    add_filter '/.vendor'
-  end
-
-  SimpleCov.formatters = [
-    SimpleCov::Formatter::Console,
-    SimpleCov::Formatter::Codecov,
-  ]
-end
-
 require 'puppet-lint'
+require 'rspec/collection_matchers'
 
 PuppetLint::Plugins.load_spec_helper

metadata

@@ -1,91 +1,28 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint-absolute_classname-check
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 5.0.0
 platform: ruby
 authors:
 - Vox Pupuli
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-11-29 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puppet-lint
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '4'
+        version: '5.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '1.0'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '4'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec-collection_matchers
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec-its
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
+        version: '5.1'
 description: "    A puppet-lint plugin to check that classes are not included or referenced
   by their absolute name.\n"
 email: voxpupuli@groups.io
@@ -104,7 +41,6 @@ homepage: https://github.com/voxpupuli/puppet-lint-absolute_classname-check
 licenses:
 - Apache-2.0
 metadata: {}
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -112,19 +48,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.1.0
+      version: '3.2'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.33
-signing_key: 
+rubygems_version: 3.6.9
 specification_version: 4
 summary: A puppet-lint plugin to check that classes are not included or referenced
   by their absolute name.
-test_files:
-- spec/puppet-lint/plugins/check_absolute_classname/relative_classname_inclusion_spec.rb
-- spec/puppet-lint/plugins/check_classname_reference/relative_classname_reference_spec.rb
-- spec/spec_helper.rb
+test_files: []