puppet-lint-absolute_classname-check 3.0.1 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0242bd18a491a4b01bfddbc2c16a09bdd988dfb2629c0e09297504f2e679cbfb
-  data.tar.gz: 15079e58e64171b9147a451c6bd937c70aa493c0a0c4cb28cd653e4c8adddaf4
+  metadata.gz: 44d9484de2d04ad14e0eb4ed9c17424b72c319a94b49fb823622a98fa85771d5
+  data.tar.gz: 589a21445dbf0baade77d8bc94c0217573b0767c838e86dd71d365d6dc43f8f4
 SHA512:
-  metadata.gz: ee1bf3d638248a5d8af48107cc7eb4f00c6ac5dcfa388b909f1a49fd00a08966c43d1963abbc21252a876b3488445609409cb55af377faaa40ba2b2584378b78
-  data.tar.gz: 356f61d658b2b154fae41285f5bcd192b3eaa44fc268443c842052683d64837faf3a9835be8c06b492d094c0dd476a419b02f5ff97c5fd887e0a4d9ab8d5c0db
+  metadata.gz: 57dc43ecd8829bc7baff9186b430a47050c51513f59326db2b4e28c8e99cf50340d21776ea7d0f09578e4a9772a621a195f21d2ab0d739932ccb0c4ec951e513
+  data.tar.gz: 4c37050af7045255fba3f396ff56fcaae3e8160f22e2ce2786ab68ba230756f5ac7d87d42ad1bc3a22134d117d6febfe028195886366815276a5658b538ec14a

data/lib/puppet-lint/plugins/check_absolute_classname.rb

@@ -2,8 +2,8 @@ PuppetLint.new_check(:relative_classname_inclusion) do
   def check
     message = 'class included by absolute name (::$class)'
 
-    tokens.each_with_index do |token, token_idx|
-      if [:NAME,:FUNCTION_NAME].include?(token.type) && ['include','contain','require'].include?(token.value)
+    tokens.each_with_index do |token, _token_idx|
+      if %i[NAME FUNCTION_NAME].include?(token.type) && %w[include contain require].include?(token.value)
         s = token.next_code_token
         next if s.nil?
         next if s.type == :FARROW
@@ -11,7 +11,7 @@ PuppetLint.new_check(:relative_classname_inclusion) do
         in_function = 0
         while s.type != :NEWLINE
           n = s.next_code_token
-          if [:NAME, :FUNCTION_NAME, :SSTRING,].include?(s.type)
+          if %i[NAME FUNCTION_NAME SSTRING].include?(s.type)
             if n && n.type == :LPAREN
               in_function += 1
             elsif in_function > 0 && n && n.type == :RPAREN
@@ -21,7 +21,7 @@ PuppetLint.new_check(:relative_classname_inclusion) do
                 message: message,
                 line: s.line,
                 column: s.column,
-                token: s
+                token: s,
               }
             end
           end
@@ -35,7 +35,7 @@ PuppetLint.new_check(:relative_classname_inclusion) do
               message: message,
               line: s.line,
               column: s.column,
-              token: s
+              token: s,
             }
           end
           s = s.next_token
@@ -47,7 +47,7 @@ PuppetLint.new_check(:relative_classname_inclusion) do
             message: message,
             line: s.line,
             column: s.column,
-            token: s
+            token: s,
           }
         end
       end

data/lib/puppet-lint/plugins/check_classname_reference.rb

@@ -2,20 +2,20 @@ PuppetLint.new_check(:relative_classname_reference) do
   def check
     message = 'absolute class name reference'
 
-    tokens.each_with_index do |token, token_idx|
-      if token.type == :TYPE and token.value == 'Class' and token.next_code_token.type == :LBRACK
-        s = token.next_code_token
-        while s.type != :RBRACK
-          if (s.type == :NAME || s.type == :SSTRING) && s.value.start_with?('::')
-            notify :warning, {
-              message: message,
-              line: s.line,
-              column: s.column,
-              token: s
-            }
-          end
-          s = s.next_token
+    tokens.each_with_index do |token, _token_idx|
+      next unless token.type == :TYPE and token.value == 'Class' and token.next_code_token.type == :LBRACK
+
+      s = token.next_code_token
+      while s.type != :RBRACK
+        if (s.type == :NAME || s.type == :SSTRING) && s.value.start_with?('::')
+          notify :warning, {
+            message: message,
+            line: s.line,
+            column: s.column,
+            token: s,
+          }
         end
+        s = s.next_token
       end
     end
   end

data/spec/puppet-lint/plugins/check_absolute_classname/relative_classname_inclusion_spec.rb

@@ -35,11 +35,11 @@ describe 'relative_classname_inclusion' do
         EOS
       end
 
-      it 'should detect 12 problems' do
+      it 'detects 12 problems' do
         expect(problems).to have(12).problems
       end
 
-      it 'should create warnings' do
+      it 'creates warnings' do
         expect(problems).to contain_warning(msg).on_line(1).in_column(17)
         expect(problems).to contain_warning(msg).on_line(2).in_column(17)
         expect(problems).to contain_warning(msg).on_line(6).in_column(17)
@@ -70,7 +70,7 @@ describe 'relative_classname_inclusion' do
         EOS
       end
 
-      it 'should not detect a problem' do
+      it 'does not detect a problem' do
         expect(problems).to have(0).problems
       end
     end
@@ -85,7 +85,7 @@ describe 'relative_classname_inclusion' do
         EOS
       end
 
-      it 'should detect no problems' do
+      it 'detects no problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -102,7 +102,7 @@ describe 'relative_classname_inclusion' do
         EOS
       end
 
-      it 'should detect no problems' do
+      it 'detects no problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -148,11 +148,11 @@ describe 'relative_classname_inclusion' do
         EOS
       end
 
-      it 'should detect 12 problems' do
+      it 'detects 12 problems' do
         expect(problems).to have(12).problems
       end
 
-      it 'should fix the problems' do
+      it 'fixes the problems' do
         expect(problems).to contain_fixed(msg).on_line(1).in_column(17)
         expect(problems).to contain_fixed(msg).on_line(2).in_column(17)
         expect(problems).to contain_fixed(msg).on_line(6).in_column(17)
@@ -167,9 +167,9 @@ describe 'relative_classname_inclusion' do
         expect(problems).to contain_fixed(msg).on_line(24).in_column(31)
       end
 
-      it 'should should remove colons' do
+      it 'shoulds remove colons' do
         expect(manifest).to eq(
-        <<-EOS
+          <<-EOS,
         include foobar
         include('foobar')
         include(foobar(baz))
@@ -215,7 +215,7 @@ describe 'relative_classname_inclusion' do
         EOS
       end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
@@ -230,7 +230,7 @@ describe 'relative_classname_inclusion' do
       EOS
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end

data/spec/puppet-lint/plugins/check_classname_reference/relative_classname_reference_spec.rb

@@ -21,11 +21,11 @@ describe 'relative_classname_reference' do
         EOS
       end
 
-      it 'should detect 6 problems' do
+      it 'detects 6 problems' do
         expect(problems).to have(6).problems
       end
 
-      it 'should create warnings' do
+      it 'creates warnings' do
         expect(problems).to contain_warning(msg).on_line(1).in_column(15)
         expect(problems).to contain_warning(msg).on_line(1).in_column(31)
         expect(problems).to contain_warning(msg).on_line(5).in_column(28)
@@ -50,7 +50,7 @@ describe 'relative_classname_reference' do
         EOS
       end
 
-      it 'should not detect a problem' do
+      it 'does not detect a problem' do
         expect(problems).to have(0).problems
       end
     end
@@ -82,11 +82,11 @@ describe 'relative_classname_reference' do
         EOS
       end
 
-      it 'should detect 6 problems' do
+      it 'detects 6 problems' do
         expect(problems).to have(6).problems
       end
 
-      it 'should fix the problems' do
+      it 'fixes the problems' do
         expect(problems).to contain_fixed(msg).on_line(1).in_column(15)
         expect(problems).to contain_fixed(msg).on_line(1).in_column(31)
         expect(problems).to contain_fixed(msg).on_line(5).in_column(28)
@@ -95,9 +95,9 @@ describe 'relative_classname_reference' do
         expect(problems).to contain_fixed(msg).on_line(10).in_column(43)
       end
 
-      it 'should should remove colons' do
+      it 'shoulds remove colons' do
         expect(manifest).to eq(
-        <<-EOS
+          <<-EOS,
         Class[foo] -> Class['bar']
 
         file { '/path':
@@ -129,7 +129,7 @@ describe 'relative_classname_reference' do
         EOS
       end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end

data/spec/spec_helper.rb

@@ -1,5 +1,29 @@
-require 'coveralls'
-Coveralls.wear!
+# frozen_string_literal: true
+
+begin
+  require 'simplecov'
+  require 'simplecov-console'
+  require 'codecov'
+rescue LoadError
+else
+  SimpleCov.start do
+    track_files 'lib/**/*.rb'
+
+    add_filter '/spec'
+
+    enable_coverage :branch
+
+    # do not track vendored files
+    add_filter '/vendor'
+    add_filter '/.vendor'
+  end
+
+  SimpleCov.formatters = [
+    SimpleCov::Formatter::Console,
+    SimpleCov::Formatter::Codecov,
+  ]
+end
 
 require 'puppet-lint'
+
 PuppetLint::Plugins.load_spec_helper

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint-absolute_classname-check
 version: !ruby/object:Gem::Version
-  version: 3.0.1
+  version: 4.0.0
 platform: ruby
 authors:
 - Vox Pupuli
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-06-19 00:00:00.000000000 Z
+date: 2023-04-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puppet-lint
@@ -16,90 +16,20 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '3.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
-      - !ruby/object:Gem::Version
-        version: '1.0'
-    - - "<"
       - !ruby/object:Gem::Version
         version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: coveralls
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec-collection_matchers
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec-its
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '5'
 description: "    A puppet-lint plugin to check that classes are not included or referenced
   by their absolute name.\n"
 email: voxpupuli@groups.io
@@ -126,19 +56,16 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.1.0
+      version: 2.7.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.15
+rubygems_version: 3.2.33
 signing_key: 
 specification_version: 4
 summary: A puppet-lint plugin to check that classes are not included or referenced
   by their absolute name.
-test_files:
-- spec/puppet-lint/plugins/check_absolute_classname/relative_classname_inclusion_spec.rb
-- spec/puppet-lint/plugins/check_classname_reference/relative_classname_reference_spec.rb
-- spec/spec_helper.rb
+test_files: []