puppet-ghostbuster 2.1.0 → 2.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 825f0bad6bda91f1b0c1ac0c423d436fb2593a4b77b2354815b4c2520bd74425
-  data.tar.gz: 2b04bcddbb57796ebff9136ddab64626a48ecde7f20e273209e8cefc23e429c5
+  metadata.gz: 3ded6aa277f38f2383a92a014237dfcf53e4c5d08b9a31ddca68c04a1ba9d5a0
+  data.tar.gz: 9bc03b84ae579a7d1c0c8087d19dcf1f9a096882e261126941b333f43bfc49df
 SHA512:
-  metadata.gz: 7f0a8c6c0327eb6bb8873d24da61d266134d9ec7ea533d6dde5eff717ca720c8b917cb3c6a92557ab0c5d71d29a8e7134bd897778142481bbe53c22702e000ff
-  data.tar.gz: e83248042353d7419766749fb28e0a45f768e64c924dd7386acda9b05ba7ed2838afe092dbb93a95ea6b1f09572aceba4e34ab54dfe31e1b8e482719c02e2886
+  metadata.gz: 9626a929c8fa55a70ab0600dc807f83db204bcc23d4f9db39c9cd5eda4fe55fd93c6dc03e8eae680dba8ad678cfc1a2e8e031cdb2eb49e70d0815dc89b6831ef
+  data.tar.gz: 8c664c1ecd7d405319f6567646104d7f7d9c96f47a17dd4049d7d1a1285999e5682c432e4fccfb121fa495e56147e3ae158079c4b479ece41f8831a301c3198e

data/.github/labeler.yml

@@ -0,0 +1,3 @@
+---
+skip-changelog:
+ - head-branch: ['^release-*']

data/.github/release.yml

@@ -0,0 +1,40 @@
+---
+# https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes
+
+changelog:
+  exclude:
+    labels:
+      - duplicate
+      - invalid
+      - modulesync
+      - question
+      - skip-changelog
+      - wont-fix
+      - wontfix
+      - github_actions
+
+  categories:
+    - title: Breaking Changes 🛠
+      labels:
+        - backwards-incompatible
+
+    - title: New Features 🎉
+      labels:
+        - enhancement
+
+    - title: Bug Fixes 🐛
+      labels:
+        - bug
+
+    - title: Documentation Updates 📚
+      labels:
+        - documentation
+        - docs
+
+    - title: Dependency Updates ⬆️
+      labels:
+        - dependencies
+
+    - title: Other Changes
+      labels:
+        - "*"

data/.github/workflows/labeler.yml

@@ -0,0 +1,18 @@
+---
+name: 🏷️ Pull Request Labeler
+
+on:
+  - pull_request_target
+
+permissions:
+  contents: read
+
+jobs:
+  labeler:
+    name: Labeler
+    runs-on: ubuntu-latest
+    if: github.repository_owner == 'voxpupuli' || github.repository_owner == 'OpenVoxProject'
+    permissions:
+      pull-requests: write
+    steps:
+      - uses: actions/labeler@bf12e9b00b37c5c0ca2b87b79b2daf7891dbda13 # v7.0.0

data/.github/workflows/release.yml

@@ -15,7 +15,7 @@ jobs:
     name: Build the gem
     runs-on: ubuntu-24.04
     steps:
-      - uses: actions/checkout@v6
+      - uses: actions/checkout@v7
       - name: Install Ruby
         uses: ruby/setup-ruby@v1
         with:
@@ -76,7 +76,7 @@ jobs:
         uses: actions/download-artifact@v8
         with:
           name: gem-artifact
-      - uses: rubygems/configure-rubygems-credentials@v1.0.0
+      - uses: rubygems/configure-rubygems-credentials@v2.1.0
       - name: Publish gem to rubygems.org
         shell: bash
         run: gem push *.gem

data/.github/workflows/test.yml

@@ -10,11 +10,16 @@ on:
 env:
   BUNDLE_WITHOUT: release
 
+permissions:
+  contents: read
+
 jobs:
-  rubocop:
+  rubocop_and_matrix:
     runs-on: ubuntu-latest
+    outputs:
+      ruby: ${{ steps.ruby.outputs.versions }}
     steps:
-      - uses: actions/checkout@v6
+      - uses: actions/checkout@v7
       - name: Setup ruby
         uses: ruby/setup-ruby@v1
         with:
@@ -22,21 +27,21 @@ jobs:
           bundler-cache: true
       - name: Run rake rubocop
         run: bundle exec rake rubocop
+      - id: ruby
+        uses: voxpupuli/ruby-version@be0467ce7366d206b2e87f5b7a032a030120b7cb # 2.0.0
   test:
     runs-on: ubuntu-latest
+    needs: rubocop_and_matrix
     strategy:
       fail-fast: false
       matrix:
-        include:
-          - ruby: "3.2"
-            coverage: "yes"
-          - ruby: "3.3"
-          - ruby: "3.4"
-    env:
-      COVERAGE: ${{ matrix.coverage }}
+        ruby: ${{ fromJSON(needs.rubocop_and_matrix.outputs.ruby) }}
+
     name: Ruby ${{ matrix.ruby }}
+    env:
+      COVERAGE: ${{ (matrix.ruby == '3.2' || matrix.ruby == '4.0') && 'yes' || 'no' }}
     steps:
-      - uses: actions/checkout@v6
+      - uses: actions/checkout@v7
       - name: Install Ruby ${{ matrix.ruby }}
         uses: ruby/setup-ruby@v1
         with:
@@ -47,10 +52,14 @@ jobs:
       - name: Verify gem builds
         run: gem build --strict --verbose *.gemspec
   tests:
+    if: always()
     needs:
-      - rubocop
+      - rubocop_and_matrix
       - test
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-26.04
     name: Test suite
     steps:
-      - run: echo Test suite completed
+      - name: Decide whether the needed jobs succeeded or failed
+        uses: re-actors/alls-green@release/v1
+        with:
+          jobs: ${{ toJSON(needs) }}

data/CHANGELOG.md

@@ -2,9 +2,24 @@
 
 All notable changes to this project will be documented in this file.
 
-## [2.1.0](https://github.com/voxpupuli/puppet-ghostbuster/tree/2.1.0) (2026-02-27)
+## [2.2.0](https://github.com/voxpupuli/puppet-ghostbuster/tree/2.2.0) (2026-10-08)
 
-[Full Changelog](https://github.com/voxpupuli/puppet-ghostbuster/compare/v2.0.0...2.1.0)
+[Full Changelog](https://github.com/voxpupuli/puppet-ghostbuster/compare/v2.1.0...2.2.0)
+
+**Implemented enhancements:**
+
+- feat: make it work with openvox9 [\#129](https://github.com/voxpupuli/puppet-ghostbuster/pull/129) ([rwaffen](https://github.com/rwaffen))
+
+**Merged pull requests:**
+
+- Update voxpupuli-rubocop requirement from ~\> 5.2.0 to ~\> 5.3.0 [\#126](https://github.com/voxpupuli/puppet-ghostbuster/pull/126) ([dependabot[bot]](https://github.com/apps/dependabot))
+- Update json requirement from \>= 2.0, \< 3.0 to \>= 2.0, \< 4.0 [\#124](https://github.com/voxpupuli/puppet-ghostbuster/pull/124) ([dependabot[bot]](https://github.com/apps/dependabot))
+- Update github\_changelog\_generator requirement from ~\> 1.16.4 to ~\> 1.18 [\#120](https://github.com/voxpupuli/puppet-ghostbuster/pull/120) ([dependabot[bot]](https://github.com/apps/dependabot))
+- Update voxpupuli-rubocop requirement from ~\> 5.1.0 to ~\> 5.2.0 [\#119](https://github.com/voxpupuli/puppet-ghostbuster/pull/119) ([dependabot[bot]](https://github.com/apps/dependabot))
+
+## [v2.1.0](https://github.com/voxpupuli/puppet-ghostbuster/tree/v2.1.0) (2026-02-27)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-ghostbuster/compare/v2.0.0...v2.1.0)
 
 **Merged pull requests:**
 

data/Gemfile

@@ -4,9 +4,11 @@ source ENV['GEM_SOURCE'] || 'https://rubygems.org'
 
 gemspec
 
-group :release do
+gem 'openvox', ENV['OPENVOX_VERSION'] if ENV['OPENVOX_VERSION']
+
+group :release, optional: true do
   gem 'faraday-retry', '~> 2.1', require: false
-  gem 'github_changelog_generator', '~> 1.16.4', require: false
+  gem 'github_changelog_generator', '~> 1.18', require: false
 end
 
 group :coverage, optional: ENV['COVERAGE'] != 'yes' do

data/README.md

@@ -16,6 +16,8 @@ This gems helps puppet users to find dead code by displaying unused classes, def
 
 This gems only support PuppetDB APi v4 (PuppetDB 3+)
 
+Supports OpenVox 8 and 9 with Ruby 3.2 or newer.
+
 Usage
 -----
 
@@ -34,7 +36,10 @@ The location of the `hiera.yaml` file. Defaults to `./hiera.yaml` or `/etc/puppe
 
 ### PUPPETDB_URL
 
-The url or the PuppetDB. Defaults to `http://puppetdb:8080`
+The URL of PuppetDB.
+If unset, uses the first server URL from `puppetdb.conf` when the PuppetDB integration is available,
+otherwise `https://<server>:8081` using the `server` setting in `puppet.conf`.
+OpenVox 9 has no default `server`, so configure it or set `PUPPETDB_URL` explicitly.
 
 ### PUPPETDB_CACERT_FILE
 

data/lib/puppet-ghostbuster/puppetdb.rb

@@ -5,17 +5,22 @@ class PuppetGhostbuster
   class PuppetDB
     Puppet.initialize_settings
 
-    begin
+    def self.server_url
+      return ENV['PUPPETDB_URL'] if ENV['PUPPETDB_URL'] && !ENV['PUPPETDB_URL'].empty?
+
       require 'puppet/util/puppetdb'
-      @@puppetdb = Puppet::Util::Puppetdb.config.server_urls[0]
+      Puppet::Util::Puppetdb.config.server_urls[0]
     rescue LoadError
-      @@puppetdb = "https://#{Puppet[:server]}:8081"
+      server = Puppet[:server]
+      raise ArgumentError, 'Set PUPPETDB_URL or configure server in puppet.conf to connect to PuppetDB' if server.nil? || server.empty?
+
+      "https://#{server}:8081"
     end
 
     def self.client
       @@client ||= begin
         options = {
-          server: ENV['PUPPETDB_URL'] || @@puppetdb,
+          server: server_url,
         }
 
         if ENV['PE_TOKEN']

data/lib/puppet-ghostbuster/version.rb

@@ -1,3 +1,3 @@
 class PuppetGhostbuster
-  VERSION = '2.1.0'.freeze
+  VERSION = '2.2.0'.freeze
 end

data/puppet-ghostbuster.gemspec

@@ -25,10 +25,10 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'rspec', '~> 3.0'
   s.add_development_dependency 'rspec-collection_matchers', '~> 1.0'
   s.add_development_dependency 'rspec-its', '~> 2.0'
-  s.add_development_dependency 'voxpupuli-rubocop', '~> 5.1.0'
+  s.add_development_dependency 'voxpupuli-rubocop', '~> 5.3.0'
 
-  s.add_dependency 'json', '>= 2.0', '< 3.0'
-  s.add_dependency 'openvox', '>= 8.0', '< 9.0'
+  s.add_dependency 'json', '>= 2.0', '< 4.0'
+  s.add_dependency 'openvox', '>= 8.0', '< 10.0'
   s.add_dependency 'puppetdb-ruby', '~> 1.1', '>= 1.1.1'
   s.add_dependency 'syslog', '>= 0.3', '< 0.5'
 end

data/spec/puppet_ghostbuster/puppet_db_spec.rb

@@ -0,0 +1,56 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe PuppetGhostbuster::PuppetDB do
+  describe '.server_url' do
+    around do |example|
+      original_url = ENV.fetch('PUPPETDB_URL', nil)
+      ENV.delete('PUPPETDB_URL')
+      example.run
+    ensure
+      if original_url
+        ENV['PUPPETDB_URL'] = original_url
+      else
+        ENV.delete('PUPPETDB_URL')
+      end
+    end
+
+    it 'uses the explicit URL without loading the PuppetDB integration' do
+      ENV['PUPPETDB_URL'] = 'https://database.example.com:8081'
+      allow(described_class).to receive(:require)
+      expect(described_class.server_url).to eq('https://database.example.com:8081')
+      expect(described_class).not_to have_received(:require)
+    end
+
+    it 'uses the first URL from the PuppetDB integration' do
+      config = Struct.new(:server_urls).new(['https://database.example.com:8081'])
+      integration = Struct.new(:config).new(config)
+      stub_const('Puppet::Util::Puppetdb', integration)
+      allow(described_class).to receive(:require).with('puppet/util/puppetdb')
+      expect(described_class.server_url).to eq('https://database.example.com:8081')
+    end
+
+    context 'without the PuppetDB integration' do
+      before do
+        allow(described_class).to receive(:require).with('puppet/util/puppetdb').and_raise(LoadError)
+      end
+
+      it 'uses the configured Puppet server' do
+        allow(Puppet).to receive(:[]).with(:server).and_return('compiler.example.com')
+        expect(described_class.server_url).to eq('https://compiler.example.com:8081')
+      end
+
+      it 'reports a missing server instead of constructing an invalid URL' do
+        allow(Puppet).to receive(:[]).with(:server).and_return('')
+        expect { described_class.server_url }.to raise_error(ArgumentError, /Set PUPPETDB_URL/)
+      end
+
+      it 'treats an empty explicit URL as unset' do
+        ENV['PUPPETDB_URL'] = ''
+        allow(Puppet).to receive(:[]).with(:server).and_return('compiler.example.com')
+        expect(described_class.server_url).to eq('https://compiler.example.com:8081')
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,6 +1,8 @@
 require 'puppet-lint'
 require 'jgrep'
 
+ENV['PUPPETDB_URL'] ||= 'https://puppetdb.example.com:8081'
+
 PuppetLint::Plugins.load_spec_helper
 
 class PuppetDB::Client

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: puppet-ghostbuster
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.2.0
 platform: ruby
 authors:
 - Camptocamp
@@ -138,14 +138,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.1.0
+        version: 5.3.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.1.0
+        version: 5.3.0
 - !ruby/object:Gem::Dependency
   name: json
   requirement: !ruby/object:Gem::Requirement
@@ -155,7 +155,7 @@ dependencies:
         version: '2.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -165,7 +165,7 @@ dependencies:
         version: '2.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: openvox
   requirement: !ruby/object:Gem::Requirement
@@ -175,7 +175,7 @@ dependencies:
         version: '8.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '9.0'
+        version: '10.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -185,7 +185,7 @@ dependencies:
         version: '8.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '9.0'
+        version: '10.0'
 - !ruby/object:Gem::Dependency
   name: puppetdb-ruby
   requirement: !ruby/object:Gem::Requirement
@@ -232,6 +232,9 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".github/dependabot.yml"
+- ".github/labeler.yml"
+- ".github/release.yml"
+- ".github/workflows/labeler.yml"
 - ".github/workflows/release.yml"
 - ".github/workflows/test.yml"
 - ".gitignore"
@@ -279,6 +282,7 @@ files:
 - spec/puppet-lint/plugins/ghostbuster_hiera_files_spec.rb
 - spec/puppet-lint/plugins/ghostbuster_templates_spec.rb
 - spec/puppet-lint/plugins/ghostbuster_types_spec.rb
+- spec/puppet_ghostbuster/puppet_db_spec.rb
 - spec/spec_helper.rb
 homepage: http://github.com/voxpupuli/puppet-ghostbuster
 licenses:
@@ -298,7 +302,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.3
+rubygems_version: 4.0.20
 specification_version: 4
 summary: Dead code detector for Puppet
 test_files: []