puppet-ghostbuster 1.2.1 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 833a968929238772dc7ddd1f8fe1df5f7f6619ac35ebd8728dc80a84a81f9797
-  data.tar.gz: 66ae42129a1dc62b2db60f26a2579d67317f4c23c20dc2035bcf6b495efb2b14
+  metadata.gz: 825f0bad6bda91f1b0c1ac0c423d436fb2593a4b77b2354815b4c2520bd74425
+  data.tar.gz: 2b04bcddbb57796ebff9136ddab64626a48ecde7f20e273209e8cefc23e429c5
 SHA512:
-  metadata.gz: 65462ffe20fb495d3db8c3742f73dd82e5b6514720d7c821c6b4294d4afeeee3763074bfa401eb6f6d8b1ac7eb81904210a4075b192299f80f94c911bfb424af
-  data.tar.gz: 7dc4843877ceee379a1a4e58d046cb21bac6fbf168aad0f036c93d9d1a97b87e4c117c104bf04929e755c3763cdcbbdb882edfae3bbc1f75f65d77a11f47b2b1
+  metadata.gz: 7f0a8c6c0327eb6bb8873d24da61d266134d9ec7ea533d6dde5eff717ca720c8b917cb3c6a92557ab0c5d71d29a8e7134bd897778142481bbe53c22702e000ff
+  data.tar.gz: e83248042353d7419766749fb28e0a45f768e64c924dd7386acda9b05ba7ed2838afe092dbb93a95ea6b1f09572aceba4e34ab54dfe31e1b8e482719c02e2886

data/.github/workflows/release.yml

@@ -1,33 +1,106 @@
-name: Release
+---
+name: Gem Release
 
 on:
   push:
     tags:
       - '*'
 
+permissions: {}
+
 jobs:
-  release:
-    runs-on: ubuntu-latest
+  build-release:
+    # Prevent releases from forked repositories
     if: github.repository_owner == 'voxpupuli'
+    name: Build the gem
+    runs-on: ubuntu-24.04
     steps:
-      - uses: actions/checkout@v4
-      - name: Install Ruby 3.0
+      - uses: actions/checkout@v6
+      - name: Install Ruby
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: '3.0'
-          bundler: 'none'
-        env:
-          BUNDLE_WITHOUT: release:development:rubocop
+          ruby-version: 'ruby'
       - name: Build gem
-        run: gem build --strict --verbose *.gemspec
+        shell: bash
+        run: gem build --verbose *.gemspec
+      - name: Upload gem to GitHub cache
+        uses: actions/upload-artifact@v7
+        with:
+          name: gem-artifact
+          path: '*.gem'
+          retention-days: 1
+          compression-level: 0
+
+  create-github-release:
+    needs: build-release
+    name: Create GitHub release
+    runs-on: ubuntu-24.04
+    permissions:
+      contents: write # clone repo and create release
+    steps:
+      - name: Download gem from GitHub cache
+        uses: actions/download-artifact@v8
+        with:
+          name: gem-artifact
+      - name: Create Release
+        shell: bash
+        env:
+          GH_TOKEN: ${{ github.token }}
+        run: gh release create --repo ${{ github.repository }} ${{ github.ref_name }} --generate-notes *.gem
+
+  release-to-github:
+    needs: build-release
+    name: Release to GitHub
+    runs-on: ubuntu-24.04
+    permissions:
+      packages: write # publish to rubygems.pkg.github.com
+    steps:
+      - name: Download gem from GitHub cache
+        uses: actions/download-artifact@v8
+        with:
+          name: gem-artifact
+      - name: Publish gem to GitHub packages
+        run: gem push --host https://rubygems.pkg.github.com/${{ github.repository_owner }} *.gem
+        env:
+          GEM_HOST_API_KEY: ${{ secrets.GITHUB_TOKEN }}
+
+  release-to-rubygems:
+    needs: build-release
+    name: Release gem to rubygems.org
+    runs-on: ubuntu-24.04
+    environment: release # recommended by rubygems.org
+    permissions:
+      id-token: write # rubygems.org authentication
+    steps:
+      - name: Download gem from GitHub cache
+        uses: actions/download-artifact@v8
+        with:
+          name: gem-artifact
+      - uses: rubygems/configure-rubygems-credentials@v1.0.0
       - name: Publish gem to rubygems.org
+        shell: bash
         run: gem push *.gem
-        env:
-          GEM_HOST_API_KEY: '${{ secrets.RUBYGEMS_AUTH_TOKEN }}'
-      - name: Setup GitHub packages access
+
+  release-verification:
+    name: Check that all releases are done
+    runs-on: ubuntu-24.04
+    permissions:
+      contents: read # minimal permissions that we have to grant
+    needs:
+      - create-github-release
+      - release-to-github
+      - release-to-rubygems
+    steps:
+      - name: Download gem from GitHub cache
+        uses: actions/download-artifact@v8
+        with:
+          name: gem-artifact
+      - name: Install Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 'ruby'
+      - name: Wait for release to propagate
+        shell: bash
         run: |
-          mkdir -p ~/.gem
-          echo ":github: Bearer ${{ secrets.GITHUB_TOKEN }}" >> ~/.gem/credentials
-          chmod 0600 ~/.gem/credentials
-      - name: Publish gem to GitHub packages
-        run: gem push --key github --host https://rubygems.pkg.github.com/${{ github.repository_owner }} *.gem
+          gem install rubygems-await
+          gem await *.gem

data/.github/workflows/test.yml

@@ -14,11 +14,11 @@ jobs:
   rubocop:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
       - name: Setup ruby
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: '3.0'
+          ruby-version: '3.2'
           bundler-cache: true
       - name: Run rake rubocop
         run: bundle exec rake rubocop
@@ -28,16 +28,15 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - ruby: "2.7"
-          - ruby: "3.0"
-          - ruby: "3.1"
-            coverage: "yes"
           - ruby: "3.2"
+            coverage: "yes"
+          - ruby: "3.3"
+          - ruby: "3.4"
     env:
       COVERAGE: ${{ matrix.coverage }}
     name: Ruby ${{ matrix.ruby }}
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
       - name: Install Ruby ${{ matrix.ruby }}
         uses: ruby/setup-ruby@v1
         with:

data/CHANGELOG.md

@@ -2,7 +2,37 @@
 
 All notable changes to this project will be documented in this file.
 
-## [1.2.1](https://github.com/voxpupuli/puppet-ghostbuster/tree/1.2.1) (2024-02-09)
+## [2.1.0](https://github.com/voxpupuli/puppet-ghostbuster/tree/2.1.0) (2026-02-27)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-ghostbuster/compare/v2.0.0...2.1.0)
+
+**Merged pull requests:**
+
+- Update syslog requirement from ~\> 0.3.0 to \>= 0.3, \< 0.5 [\#113](https://github.com/voxpupuli/puppet-ghostbuster/pull/113) ([dependabot[bot]](https://github.com/apps/dependabot))
+- Update voxpupuli-rubocop requirement from ~\> 5.0.0 to ~\> 5.1.0 [\#110](https://github.com/voxpupuli/puppet-ghostbuster/pull/110) ([dependabot[bot]](https://github.com/apps/dependabot))
+- README.md: Add note about execution directory [\#108](https://github.com/voxpupuli/puppet-ghostbuster/pull/108) ([bastelfreak](https://github.com/bastelfreak))
+- Update rspec-its requirement from ~\> 1.0 to ~\> 2.0 [\#105](https://github.com/voxpupuli/puppet-ghostbuster/pull/105) ([dependabot[bot]](https://github.com/apps/dependabot))
+
+## [v2.0.0](https://github.com/voxpupuli/puppet-ghostbuster/tree/v2.0.0) (2025-10-16)
+
+[Full Changelog](https://github.com/voxpupuli/puppet-ghostbuster/compare/1.2.1...v2.0.0)
+
+**Breaking changes:**
+
+- feat: switch to openvox, adapt new release ci, switch to ruby 3.2 [\#99](https://github.com/voxpupuli/puppet-ghostbuster/pull/99) ([rwaffen](https://github.com/rwaffen))
+
+**Implemented enhancements:**
+
+- Use vcr for unit tests [\#58](https://github.com/voxpupuli/puppet-ghostbuster/issues/58)
+- Plugin to detect unused top scope variables [\#55](https://github.com/voxpupuli/puppet-ghostbuster/issues/55)
+- Plugin to detect unused entries in hiera files [\#47](https://github.com/voxpupuli/puppet-ghostbuster/issues/47)
+
+**Merged pull requests:**
+
+- Update voxpupuli-rubocop requirement from ~\> 2.6.0 to ~\> 2.8.0 [\#96](https://github.com/voxpupuli/puppet-ghostbuster/pull/96) ([dependabot[bot]](https://github.com/apps/dependabot))
+- Update voxpupuli-rubocop requirement from ~\> 2.4.0 to ~\> 2.6.0 [\#93](https://github.com/voxpupuli/puppet-ghostbuster/pull/93) ([dependabot[bot]](https://github.com/apps/dependabot))
+
+## [1.2.1](https://github.com/voxpupuli/puppet-ghostbuster/tree/1.2.1) (2024-03-26)
 
 [Full Changelog](https://github.com/voxpupuli/puppet-ghostbuster/compare/1.2.0...1.2.1)
 
@@ -56,7 +86,6 @@ Due to problems during the migration from the camptocamp GitHub org to Vox Pupul
 
 **Merged pull requests:**
 
-- Bump actions/checkout from 3 to 4 [\#72](https://github.com/voxpupuli/puppet-ghostbuster/pull/72) ([dependabot[bot]](https://github.com/apps/dependabot))
 - added some unsafe rubocop fixes [\#71](https://github.com/voxpupuli/puppet-ghostbuster/pull/71) ([zilchms](https://github.com/zilchms))
 - Update puppet-lint requirement from \>= 1.0, \< 3.0 to \>= 1.0, \< 5.0 [\#70](https://github.com/voxpupuli/puppet-ghostbuster/pull/70) ([dependabot[bot]](https://github.com/apps/dependabot))
 - modulesync 2023-8-23 [\#69](https://github.com/voxpupuli/puppet-ghostbuster/pull/69) ([zilchms](https://github.com/zilchms))

data/README.md

@@ -23,6 +23,8 @@ Usage
 $ find . -type f -exec puppet-lint --only-checks ghostbuster_classes,ghostbuster_defines,ghostbuster_facts,ghostbuster_files,ghostbuster_functions,ghostbuster_hiera_files,ghostbuster_templates,ghostbuster_types {} \+
 ```
 
+**the command has to be executed in your environment root, e.g. /etc/puppetlabs/code/environments/production/**
+
 Environment variables
 ---------------------
 

data/Rakefile

@@ -14,7 +14,7 @@ rescue LoadError
 else
   GitHubChangelogGenerator::RakeTask.new :changelog do |config|
     config.header = "# Changelog\n\nAll notable changes to this project will be documented in this file."
-    config.exclude_labels = %w[duplicate question invalid wontfix wont-fix skip-changelog modulesync]
+    config.exclude_labels = %w[duplicate question invalid wontfix wont-fix skip-changelog modulesync github_actions]
     config.user = 'voxpupuli'
     config.project = 'puppet-ghostbuster'
     config.future_release = Gem::Specification.load("#{config.project}.gemspec").version

data/lib/puppet-ghostbuster/version.rb

@@ -1,3 +1,3 @@
 class PuppetGhostbuster
-  VERSION = '1.2.1'
+  VERSION = '2.1.0'.freeze
 end

data/lib/puppet-lint/plugins/check_ghostbuster_facts.rb

@@ -28,7 +28,7 @@ PuppetLint.new_check(:ghostbuster_facts) do
     return if m.nil?
 
     File.foreach(path) do |line|
-      if line =~ /Facter.add\(["':](?<fact>[^"'\)]+)["']?\)/
+      if line =~ /Facter.add\(["':](?<fact>[^"')]+)["']?\)/
         fact_name = Regexp.last_match(:fact)
 
         found = false

data/lib/puppet-lint/plugins/check_ghostbuster_hiera_files.rb

@@ -41,7 +41,7 @@ PuppetLint.new_check(:ghostbuster_hiera_files) do
       path_datadir = Regexp.escape((hierarchy['datadir'] || default_datadir).chomp('/'))
       ([*hierarchy['path']] + [*hierarchy['paths']]).each do |level|
         level = File.join(path_datadir, level)
-        regex = Regexp.new(level.gsub(/%\{(::)?(trusted|server_facts|facts)\.[^\}]+\}/, '(.+)').gsub(/%\{[^\}]+\}/, '.+'))
+        regex = Regexp.new(level.gsub(/%\{(::)?(trusted|server_facts|facts)\.[^}]+\}/, '(.+)').gsub(/%\{[^}]+\}/, '.+'))
         facts = level.match(regex).captures.map { |f| f[/%{(::)?(trusted|server_facts|facts)\.(.+)}/, 3] }
         regs[regex] = facts
       end

data/puppet-ghostbuster.gemspec

@@ -12,20 +12,23 @@ Gem::Specification.new do |s|
   s.description = 'Try and find dead code in Puppet receipts'
   s.licenses    = 'Apache-2.0'
 
-  s.required_ruby_version = '>= 2.7'
+  s.required_ruby_version = '>= 3.2'
 
   s.files       = `git ls-files`.split("\n")
   s.executables = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
 
+  s.add_dependency 'puppet-lint', '>= 5.0', '< 6.0'
+
   s.add_development_dependency 'coveralls', '>= 0.8', '< 0.9'
   s.add_development_dependency 'jgrep', '>= 1.0.0', '< 2.0.0'
   s.add_development_dependency 'rake', '>= 13.0.0', '< 14.0.0'
   s.add_development_dependency 'rspec', '~> 3.0'
   s.add_development_dependency 'rspec-collection_matchers', '~> 1.0'
-  s.add_development_dependency 'rspec-its', '~> 1.0'
-  s.add_development_dependency 'voxpupuli-rubocop', '~> 2.4.0'
-  s.add_runtime_dependency 'json', '>= 2.0', '< 3.0'
-  s.add_runtime_dependency 'puppet', '>= 6.0', '< 9.0'
-  s.add_dependency         'puppet-lint', '>= 1.0', '< 5.0'
-  s.add_runtime_dependency 'puppetdb-ruby', '~> 1.1', '>= 1.1.1'
+  s.add_development_dependency 'rspec-its', '~> 2.0'
+  s.add_development_dependency 'voxpupuli-rubocop', '~> 5.1.0'
+
+  s.add_dependency 'json', '>= 2.0', '< 3.0'
+  s.add_dependency 'openvox', '>= 8.0', '< 9.0'
+  s.add_dependency 'puppetdb-ruby', '~> 1.1', '>= 1.1.1'
+  s.add_dependency 'syslog', '>= 0.3', '< 0.5'
 end

data/spec/spec_helper.rb

@@ -5,7 +5,7 @@ PuppetLint::Plugins.load_spec_helper
 
 class PuppetDB::Client
   def puppetdb_to_jgrep(query)
-    if query[0] == :and || query[0] == :or
+    if %i[and or].include?(query[0])
       "(#{puppetdb_to_jgrep(query[1])} #{query[0]} #{puppetdb_to_jgrep(query[2])})"
     else
       "#{[query[1]].flatten.join('.')}#{query[0]}#{query[2]}"

metadata

@@ -1,16 +1,35 @@
 --- !ruby/object:Gem::Specification
 name: puppet-ghostbuster
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 2.1.0
 platform: ruby
 authors:
 - Camptocamp
 - Vox Pupuli
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-03-26 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: puppet-lint
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '5.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '5.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
@@ -105,28 +124,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: voxpupuli-rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: 5.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: 5.1.0
 - !ruby/object:Gem::Dependency
   name: json
   requirement: !ruby/object:Gem::Requirement
@@ -148,12 +167,12 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: puppet
+  name: openvox
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '8.0'
     - - "<"
       - !ruby/object:Gem::Version
         version: '9.0'
@@ -163,52 +182,51 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '8.0'
     - - "<"
       - !ruby/object:Gem::Version
         version: '9.0'
 - !ruby/object:Gem::Dependency
-  name: puppet-lint
+  name: puppetdb-ruby
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
-    - - "<"
+        version: '1.1'
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: 1.1.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
-    - - "<"
+        version: '1.1'
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: 1.1.1
 - !ruby/object:Gem::Dependency
-  name: puppetdb-ruby
+  name: syslog
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.1'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.1.1
+        version: '0.3'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '0.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.1'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.1.1
+        version: '0.3'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '0.5'
 description: Try and find dead code in Puppet receipts
-email: 
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -266,7 +284,6 @@ homepage: http://github.com/voxpupuli/puppet-ghostbuster
 licenses:
 - Apache-2.0
 metadata: {}
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -274,15 +291,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.7'
+      version: '3.2'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.33
-signing_key: 
+rubygems_version: 4.0.3
 specification_version: 4
 summary: Dead code detector for Puppet
 test_files: []