puppet-ghostbuster 0.6.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ff46382cda3c0d72b04acb1e62d037820262dfe0
-  data.tar.gz: 5673735d436e8a3749df668a0a65edf2acf70eb0
+  metadata.gz: 0f4d56b90b0f6e22a0f28b01e5ca1bdccc3c3bcc
+  data.tar.gz: 75c739ec623682f6eb850ad7559126b67ef7a676
 SHA512:
-  metadata.gz: 4c4205f32f8a76054b8a0f5f634f58d4a3510493387defcb9104e9d8b729e0e9e056931e197d66b05ce208b2cba7ae77035b3966b30d13c0b7c386948e9eb63b
-  data.tar.gz: 0023f1fd6afc36b7fe6ce75752e0d9308e884a35a4fc9b25fc58e186c0d580039f4978e492a47cdde62b1bb1905b493dfe15eaf6bbf5661582104e24384516cb
+  metadata.gz: 1a49b28f9dfe55668e828d06f05f0c564718c13ffa913c28318445c17f701d861e5da4a3d2daecd94320c2702fbea8bd5affac28d9cd189e877af8ae83ebd50d
+  data.tar.gz: d040b8d124939e48574cabd486f625bda849216e6fd9e6bc461080fde2cfd02abb16dba06f519f9c2ed4a55d258637013f28267842b26aa9cf7e14c86c09d24b

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Change Log
 
+## [0.7.0](https://rubygems.org/gems/puppet-ghostbuster/versions/0.7.0) (2016-05-16)
+[Full Changelog](https://github.com/camptocamp/puppet-ghostbuster/compare/0.6.0...0.7.0)
+
+**Implemented enhancements:**
+
+- Detect unused facts.
+- Detect unused functions.
+- Detect unused types.
+
 ## [0.6.0](https://rubygems.org/gems/puppet-ghostbuster/versions/0.6.0) (2016-05-12)
 [Full Changelog](https://github.com/camptocamp/puppet-ghostbuster/compare/0.5.1...0.6.0)
 

data/lib/puppet-ghostbuster/version.rb

@@ -1,3 +1,3 @@
 class PuppetGhostbuster
-  VERSION = '0.6.0'
+  VERSION = '0.7.0'
 end

data/lib/puppet-lint/plugins/check_ghostbuster_facts.rb

@@ -0,0 +1,39 @@
+PuppetLint.new_check(:ghostbuster_facts) do
+  def manifests
+    Dir.glob('./**/manifests/**/*.pp')
+  end
+
+  def templates
+    Dir.glob('./**/templates/**/*').select{ |f| File.file? f }
+  end
+
+  def check
+    m = path.match(%r{.*/([^/]+)/lib/facter/(.+)$})
+    return if m.nil?
+
+    File.readlines(path).grep(%r{Facter.add\(["']([^"']+)["']\)}).each do |line|
+      fact_name = line.match(%r{Facter.add\(["']([^"']+)["']\)}).captures[0]
+
+      found = false
+
+      manifests.each do |manifest|
+        found = true if File.readlines(manifest).grep(%r{\$\{?::#{fact_name}\}?}).size > 0
+        break if found
+      end
+
+      templates.each do |template|
+        found = true if File.readlines(template).grep(%r{@#{fact_name}}).size > 0
+        break if found
+      end
+
+      unless found
+        notify :warning, {
+          :message => "Fact #{fact_name} seems unused",
+          :line    => 1,
+          :column  => 1,
+        }
+      end
+    end
+
+  end
+end

data/lib/puppet-lint/plugins/check_ghostbuster_functions.rb

@@ -0,0 +1,31 @@
+PuppetLint.new_check(:ghostbuster_functions) do
+  def manifests
+    Dir.glob('./**/manifests/**/*.pp')
+  end
+
+  def templates
+    Dir.glob('./**/templates/**/*').select{ |f| File.file? f }
+  end
+
+  def check
+    m = path.match(%r{.*/[^/]+/lib/puppet/parser/functions/(.+)\.rb$})
+    return if m.nil?
+
+    function_name = m.captures[0]
+
+    manifests.each do |manifest|
+      return if File.readlines(manifest).grep(%r{#{function_name}\(}).size > 0
+    end
+
+    templates.each do |template|
+      return if File.readlines(template).grep(%r{scope.function_#{function_name}\(}).size > 0
+      return if File.readlines(template).grep(%r{Puppet::Parser::Functions.function\(:#{function_name}}).size > 0
+    end
+
+    notify :warning, {
+      :message => "Function #{function_name} seems unused",
+      :line    => 1,
+      :column  => 1,
+    }
+  end
+end

data/lib/puppet-lint/plugins/check_ghostbuster_types.rb

@@ -0,0 +1,22 @@
+PuppetLint.new_check(:ghostbuster_types) do
+  def manifests
+    Dir.glob('./**/manifests/**/*.pp')
+  end
+
+  def check
+    m = path.match(%r{.*/[^/]+/lib/puppet/type/(.+)\.rb$})
+    return if m.nil?
+
+    type_name = m.captures[0]
+
+    manifests.each do |manifest|
+      return if File.readlines(manifest).grep(%r{^\s*#{type_name}\s*\{}).size > 0
+    end
+
+    notify :warning, {
+      :message => "Type #{type_name.capitalize} seems unused",
+      :line    => 1,
+      :column  => 1,
+    }
+  end
+end

data/puppet-ghostbuster.gemspec

@@ -21,6 +21,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'rspec-its', '~> 1.0'
   s.add_development_dependency 'rspec-collection_matchers', '~> 1.0'
   s.add_development_dependency 'github_changelog_generator'
+  s.add_development_dependency 'jgrep'
   s.add_runtime_dependency 'json'
   s.add_runtime_dependency 'puppet'
   s.add_dependency         'puppet-lint', '~> 1.0'

data/spec/fixtures/modules/foo/lib/facter/bar.rb

@@ -0,0 +1,6 @@
+# Fact used in manifest
+Facter.add('bar') do
+  setcode do
+    'bar'
+  end
+end

data/spec/fixtures/modules/foo/lib/facter/baz.rb

@@ -0,0 +1,6 @@
+# Fact used in template
+Facter.add('baz') do
+  setcode do
+    'baz'
+  end
+end

data/spec/fixtures/modules/foo/lib/facter/foo.rb

@@ -0,0 +1,6 @@
+# Fact used in a string
+Facter.add('foo') do
+  setcode do
+    'foo'
+  end
+end

data/spec/fixtures/modules/foo/lib/facter/multi.rb

@@ -0,0 +1,12 @@
+# Unused facts
+Facter.add('multi1') do
+  setcode do
+    'multi1'
+  end
+end
+
+Facter.add('multi2') do
+  setcode do
+    'multi2'
+  end
+end

data/spec/fixtures/modules/foo/lib/puppet/parser/functions/bar.rb

@@ -0,0 +1,4 @@
+module Puppet::Parser::Functions
+  newfunction(:bar, :type => :rvalue) do |arguments|
+  end
+end

data/spec/fixtures/modules/foo/lib/puppet/parser/functions/baz.rb

@@ -0,0 +1,4 @@
+module Puppet::Parser::Functions
+  newfunction(:baz, :type => :rvalue) do |arguments|
+  end
+end

data/spec/fixtures/modules/foo/lib/puppet/parser/functions/foo.rb

@@ -0,0 +1,4 @@
+module Puppet::Parser::Functions
+  newfunction(:foo, :type => :rvalue) do |arguments|
+  end
+end

data/spec/fixtures/modules/foo/lib/puppet/parser/functions/quux.rb

@@ -0,0 +1,4 @@
+module Puppet::Parser::Functions
+  newfunction(:quux, :type => :rvalue) do |arguments|
+  end
+end

data/spec/fixtures/modules/foo/lib/puppet/type/bar.rb

@@ -0,0 +1,2 @@
+Puppet::Type.newtype(:bar) do
+end

data/spec/fixtures/modules/foo/lib/puppet/type/foo.rb

@@ -0,0 +1,2 @@
+Puppet::Type.newtype(:foo) do
+end

data/spec/fixtures/modules/foo/manifests/bar.pp

@@ -11,4 +11,9 @@ class foo::bar {
   file { 'used_with_template_and_module_name':
     content => template("${module_name}/used_with_template_and_module_name"),
   }
+  if $::bar {
+    $foo = "Hello ${::foo}"
+  }
+  $foo = bar('baz')
+  bar { 'bar': }
 }

data/spec/fixtures/modules/foo/templates/foo.erb

@@ -1 +1,4 @@
 <%= scope.function_template(['foo/used_in_template.erb']) -%>
+<%= @baz -%>
+<%= scope.function_baz() -%>
+<%= Puppet::Parser::Functions.function(:quux) -%>

data/spec/fixtures/nodes.json

@@ -0,0 +1,17 @@
+[
+  {
+    "certname": "bar.example.com"
+  },
+  {
+    "certname": "virtual.example.com",
+    "fact": {
+      "is_virtual": "true"
+    }
+  },
+  {
+    "certname": "prod.example.com",
+    "fact": {
+      "environment": "production"
+    }
+  }
+]

data/spec/fixtures/resources.json

@@ -0,0 +1,25 @@
+[
+  {
+    "type": "Foo"
+  },
+  {
+    "type": "Foo::Foo"
+  },
+  {
+    "type": "Class",
+    "title": "Foo"
+  },
+  {
+    "type": "File",
+    "parameter": {
+      "source": "puppet:///modules/foo/bar"
+    }
+  },
+  {
+    "type": "File",
+    "parameter": {
+      "source": "puppet:///modules/foo/baz",
+      "recurse": "true"
+    }
+  }
+]

data/spec/puppet-lint/plugins/ghostbuster_classes_spec.rb

@@ -1,16 +1,10 @@
 require 'spec_helper'
 
 describe 'ghostbuster_classes' do
-  #let(:path) { "./manifests/site.pp" }
   let(:path) { "./modules/foo/manifests/init.pp" }
 
   context 'with fix disabled' do
 
-    before :each do
-      expect(PuppetGhostbuster::PuppetDB).to \
-        receive(:classes).and_return(['Foo'])
-    end
-
     context 'when class is used' do
       let(:code) { "class foo {}" }
 

data/spec/puppet-lint/plugins/ghostbuster_defines_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe 'ghostbuster_defines' do
-  include PuppetGhostbusterSpec
 
   context 'with fix disabled' do
 
@@ -10,7 +9,6 @@ describe 'ghostbuster_defines' do
       let(:path) { "./modules/foo/manifests/init.pp" }
 
       it 'should not detect any problem' do
-        expect_puppetdb_resources([:'=', 'type', 'Foo'], [{}])
         expect(problems).to have(0).problems
       end
     end
@@ -19,10 +17,6 @@ describe 'ghostbuster_defines' do
       let(:code) { "define bar {}" }
       let(:path) { "./modules/bar/manifests/init.pp" }
 
-      before :each do
-        expect_puppetdb_resources([:'=', 'type', 'Bar'], [])
-      end
-
       it 'should detect one problem' do
         expect(problems).to have(1).problems
       end

data/spec/puppet-lint/plugins/ghostbuster_facts_spec.rb

@@ -0,0 +1,48 @@
+require 'spec_helper'
+
+describe 'ghostbuster_facts' do
+  let(:code) { "Facter.add('foo')" }
+
+  context 'with fix disabled' do
+
+    context 'when fact is not used' do
+      let(:path) { "./spec/fixtures/modules/foo/lib/facter/multi.rb" }
+
+      it 'should detect one problem' do
+        expect(problems).to have(2).problems
+      end
+
+      it 'should create a warning' do
+        expect(problems).to contain_warning("Fact multi1 seems unused")
+      end
+
+      it 'should create a warning' do
+        expect(problems).to contain_warning("Fact multi2 seems unused")
+      end
+    end
+
+    context 'when fact is used in a string' do
+      let(:path) { "./spec/fixtures/modules/foo/lib/facter/foo.rb" }
+
+      it 'should not detect any problem' do
+        expect(problems).to have(0).problems
+      end
+    end
+
+    context 'when fact is used in manifest' do
+      let(:path) { "./spec/fixtures/modules/foo/lib/facter/bar.rb" }
+
+      it 'should not detect any problem' do
+        expect(problems).to have(0).problems
+      end
+    end
+
+    context 'when fact is used in a template' do
+      let(:path) { "./spec/fixtures/modules/foo/lib/facter/baz.rb" }
+
+      it 'should not detect any problem' do
+        expect(problems).to have(0).problems
+      end
+    end
+  end
+end

data/spec/puppet-lint/plugins/ghostbuster_files_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe 'ghostbuster_files' do
-  include PuppetGhostbusterSpec
 
   let(:code) { "" }
 
@@ -11,30 +10,14 @@ describe 'ghostbuster_files' do
       let(:path) { "./modules/foo/files/bar" }
 
       it 'should not detect any problem' do
-        expect_puppetdb_resources(
-          [:'=', ['parameter', 'source'], "puppet:///modules/foo/bar"],
-          [{}]
-        )
         expect(problems).to have(0).problems
       end
     end
 
     context 'when parent directory with recurse => true usage is found in puppetdb' do
-      let(:path) { "./modules/foo/files/bar/baz" }
+      let(:path) { "./modules/foo/files/baz/baz" }
 
       it 'should not detect any problem' do
-        expect_puppetdb_resources(
-          [:'=', ['parameter', 'source'], "puppet:///modules/foo/bar/baz"],
-          [])
-        expect_puppetdb_resources(
-          [:'and',
-             [:'or',
-              [:'=', ['parameter', 'source'], "puppet:///modules/foo/bar"],
-              [:'=', ['parameter', 'source'], "puppet:///modules/foo/bar/"],
-        ],
-        [:'=', ['parameter', 'recurse'], true],
-        ],
-          [{}])
         expect(problems).to have(0).problems
       end
     end
@@ -43,9 +26,6 @@ describe 'ghostbuster_files' do
       let(:path) { "./modules/foo/files/used_with_file" }
 
       it 'should not detect any problem' do
-        expect_puppetdb_resources(
-          [:'=', ['parameter', 'source'], "puppet:///modules/foo/used_with_file"],
-          [])
         expect(problems).to have(0).problems
       end
     end
@@ -54,9 +34,6 @@ describe 'ghostbuster_files' do
       let(:path) { "./modules/foo/files/used_with_file_and_module_name" }
 
       it 'should not detect any problem' do
-        expect_puppetdb_resources(
-          [:'=', ['parameter', 'source'], "puppet:///modules/foo/used_with_file_and_module_name"],
-          [])
         expect(problems).to have(0).problems
       end
     end
@@ -64,12 +41,6 @@ describe 'ghostbuster_files' do
     context 'when file in ROOT is not used' do
       let(:path) { "./modules/bar/files/foo" }
 
-      before :each do
-        expect_puppetdb_resources(
-          [:'=', ['parameter', 'source'], "puppet:///modules/bar/foo"],
-          [])
-      end
-
       it 'should detect one problem' do
         expect(problems).to have(1).problems
       end
@@ -82,21 +53,6 @@ describe 'ghostbuster_files' do
     context 'when file in subdir is not used' do
       let(:path) { "./modules/bar/files/foo/bar" }
 
-      before :each do
-        expect_puppetdb_resources(
-          [:'=', ['parameter', 'source'], "puppet:///modules/bar/foo/bar"],
-          [])
-        expect_puppetdb_resources(
-          [:'and',
-           [:'or',
-            [:'=', ['parameter', 'source'], "puppet:///modules/bar/foo"],
-            [:'=', ['parameter', 'source'], "puppet:///modules/bar/foo/"],
-        ],
-        [:'=', ['parameter', 'recurse'], true],
-        ],
-          [])
-      end
-
       it 'should detect one problem' do
         expect(problems).to have(1).problems
       end

data/spec/puppet-lint/plugins/ghostbuster_functions_spec.rb

@@ -0,0 +1,44 @@
+require 'spec_helper'
+
+describe 'ghostbuster_functions' do
+  let(:code) { '' }
+
+  context 'with fix disabled' do
+
+    context 'when function is not used' do
+      let(:path) { "./spec/fixtures/modules/foo/lib/puppet/parser/functions/foo.rb" }
+
+      it 'should detect one problem' do
+        expect(problems).to have(1).problems
+      end
+
+      it 'should create a warning' do
+        expect(problems).to contain_warning("Function foo seems unused")
+      end
+    end
+
+    context 'when function is used in a manifest' do
+      let(:path) { "./spec/fixtures/modules/foo/lib/puppet/parser/functions/bar.rb" }
+
+      it 'should not detect any problem' do
+        expect(problems).to have(0).problems
+      end
+    end
+
+    context 'when function is used in a template using scope.function_baz()' do
+      let(:path) { "./spec/fixtures/modules/foo/lib/puppet/parser/functions/baz.rb" }
+
+      it 'should not detect any problem' do
+        expect(problems).to have(0).problems
+      end
+    end
+
+    context 'when function is used in a template using Puppet::Parser::Functions.function(:quux)' do
+      let(:path) { "./spec/fixtures/modules/foo/lib/puppet/parser/functions/quux.rb" }
+
+      it 'should not detect any problem' do
+        expect(problems).to have(0).problems
+      end
+    end
+  end
+end

data/spec/puppet-lint/plugins/ghostbuster_hiera_files_spec.rb

@@ -3,7 +3,6 @@ require 'spec_helper'
 ENV['HIERA_YAML_PATH'] = './spec/fixtures/hiera.yaml'
 
 describe 'ghostbuster_hiera_files' do
-  include PuppetGhostbusterSpec
 
   let(:code) { "" }
 
@@ -12,13 +11,6 @@ describe 'ghostbuster_hiera_files' do
     context 'when a certname file is NOT used' do
       let(:path) { "./hieradata/nodes/foo.example.com.yaml" }
 
-      before :each do
-        expect_puppetdb_nodes(
-          [:'=', 'certname', 'foo.example.com'],
-          []
-        )
-      end
-
       it 'should detect one problem' do
         expect(problems).to have(1).problems
       end
@@ -32,10 +24,6 @@ describe 'ghostbuster_hiera_files' do
       let(:path) { "./hieradata/nodes/bar.example.com.yaml" }
 
       it 'should not detect any problem' do
-        expect_puppetdb_nodes(
-          [:'=', 'certname', 'bar.example.com'],
-          [{}]
-        )
         expect(problems).to have(0).problems
       end
     end
@@ -43,13 +31,6 @@ describe 'ghostbuster_hiera_files' do
     context 'when an environment file is NOT used' do
       let(:path) { "./hieradata/environment/foo.yaml" }
 
-      before :each do
-        expect_puppetdb_nodes(
-          [:'=', ['fact', 'environment'], 'foo'],
-          []
-        )
-      end
-
       it 'should detect one problem' do
         expect(problems).to have(1).problems
       end
@@ -63,10 +44,6 @@ describe 'ghostbuster_hiera_files' do
       let(:path) { "./hieradata/environment/production.yaml" }
 
       it 'should not detect any problem' do
-        expect_puppetdb_nodes(
-          [:'=', ['fact', 'environment'], 'production'],
-          [{}]
-        )
         expect(problems).to have(0).problems
       end
     end
@@ -74,13 +51,6 @@ describe 'ghostbuster_hiera_files' do
     context 'when an fact is NOT used' do
       let(:path) { "./hieradata/virtual/false.yaml" }
 
-      before :each do
-        expect_puppetdb_nodes(
-          [:'=', ['fact', 'is_virtual'], 'false'],
-          []
-        )
-      end
-
       it 'should detect one problem' do
         expect(problems).to have(1).problems
       end
@@ -94,10 +64,6 @@ describe 'ghostbuster_hiera_files' do
       let(:path) { "./hieradata/virtual/true.yaml" }
 
       it 'should not detect any problem' do
-        expect_puppetdb_nodes(
-          [:'=', ['fact', 'is_virtual'], 'true'],
-          [{}]
-        )
         expect(problems).to have(0).problems
       end
     end

data/spec/puppet-lint/plugins/ghostbuster_types_spec.rb

@@ -0,0 +1,28 @@
+require 'spec_helper'
+
+describe 'ghostbuster_types' do
+  let(:code) { '' }
+
+  context 'with fix disabled' do
+
+    context 'when type is not used' do
+      let(:path) { "./spec/fixtures/modules/foo/lib/puppet/type/foo.rb" }
+
+      it 'should detect one problem' do
+        expect(problems).to have(1).problems
+      end
+
+      it 'should create a warning' do
+        expect(problems).to contain_warning("Type Foo seems unused")
+      end
+    end
+
+    context 'when type is used in a manifest' do
+      let(:path) { "./spec/fixtures/modules/foo/lib/puppet/type/bar.rb" }
+
+      it 'should not detect any problem' do
+        expect(problems).to have(0).problems
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,9 +1,20 @@
 require 'puppet-lint'
+require 'jgrep'
 
-require 'pathname'
-dir = Pathname.new(__FILE__).parent
-$LOAD_PATH.unshift(dir, File.join(dir, 'lib'), File.join(dir, '..', 'lib'))
+PuppetLint::Plugins.load_spec_helper
 
-require 'puppet-ghostbuster_spec'
+class PuppetDB::Client
+  def puppetdb_to_jgrep(query)
+    if query[0] == :'and' || query[0] == :'or'
+      "(#{puppetdb_to_jgrep(query[1])} #{query[0]} #{puppetdb_to_jgrep(query[2])})"
+    else
+      "#{[query[1]].flatten.join('.')}#{query[0]}#{query[2]}"
+    end
+  end
+
+  def request(endpoint, query, opts={})
+    ret = JGrep.jgrep(File.read("spec/fixtures/#{endpoint}.json"), puppetdb_to_jgrep(query))
+    PuppetDB::Response.new(ret, ret.size)
+  end
+end
 
-PuppetLint::Plugins.load_spec_helper

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-ghostbuster
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.0
 platform: ruby
 authors:
 - Camptocamp
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-12 00:00:00.000000000 Z
+date: 2016-05-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: coveralls
@@ -94,6 +94,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: jgrep
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: json
   requirement: !ruby/object:Gem::Requirement
@@ -167,19 +181,36 @@ files:
 - lib/puppet-ghostbuster/version.rb
 - lib/puppet-lint/plugins/check_ghostbuster_classes.rb
 - lib/puppet-lint/plugins/check_ghostbuster_defines.rb
+- lib/puppet-lint/plugins/check_ghostbuster_facts.rb
 - lib/puppet-lint/plugins/check_ghostbuster_files.rb
+- lib/puppet-lint/plugins/check_ghostbuster_functions.rb
 - lib/puppet-lint/plugins/check_ghostbuster_hiera_files.rb
 - lib/puppet-lint/plugins/check_ghostbuster_templates.rb
+- lib/puppet-lint/plugins/check_ghostbuster_types.rb
 - puppet-ghostbuster.gemspec
 - spec/fixtures/hiera.yaml
+- spec/fixtures/modules/foo/lib/facter/bar.rb
+- spec/fixtures/modules/foo/lib/facter/baz.rb
+- spec/fixtures/modules/foo/lib/facter/foo.rb
+- spec/fixtures/modules/foo/lib/facter/multi.rb
+- spec/fixtures/modules/foo/lib/puppet/parser/functions/bar.rb
+- spec/fixtures/modules/foo/lib/puppet/parser/functions/baz.rb
+- spec/fixtures/modules/foo/lib/puppet/parser/functions/foo.rb
+- spec/fixtures/modules/foo/lib/puppet/parser/functions/quux.rb
+- spec/fixtures/modules/foo/lib/puppet/type/bar.rb
+- spec/fixtures/modules/foo/lib/puppet/type/foo.rb
 - spec/fixtures/modules/foo/manifests/bar.pp
 - spec/fixtures/modules/foo/templates/foo.erb
-- spec/lib/puppet-ghostbuster_spec.rb
+- spec/fixtures/nodes.json
+- spec/fixtures/resources.json
 - spec/puppet-lint/plugins/ghostbuster_classes_spec.rb
 - spec/puppet-lint/plugins/ghostbuster_defines_spec.rb
+- spec/puppet-lint/plugins/ghostbuster_facts_spec.rb
 - spec/puppet-lint/plugins/ghostbuster_files_spec.rb
+- spec/puppet-lint/plugins/ghostbuster_functions_spec.rb
 - spec/puppet-lint/plugins/ghostbuster_hiera_files_spec.rb
 - spec/puppet-lint/plugins/ghostbuster_templates_spec.rb
+- spec/puppet-lint/plugins/ghostbuster_types_spec.rb
 - spec/spec_helper.rb
 homepage: http://github.com/camptocamp/puppet-ghostbuster
 licenses:

data/spec/lib/puppet-ghostbuster_spec.rb

@@ -1,23 +0,0 @@
-module PuppetGhostbusterSpec
-  class PuppetDBRequest
-    def initialize(data)
-      @data = data
-    end
-
-    def data
-      @data
-    end
-  end
-
-  def expect_puppetdb_nodes(request, data)
-    expect_any_instance_of(PuppetDB::Client).to \
-      receive(:request).with('nodes', request)
-    .and_return(PuppetDBRequest.new(data))
-  end
-
-  def expect_puppetdb_resources(request, data)
-    expect_any_instance_of(PuppetDB::Client).to \
-      receive(:request).with('resources', request)
-    .and_return(PuppetDBRequest.new(data))
-  end
-end