puppet-function-updater 0.0.5

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA256:
+  metadata.gz: '094bf95a8bf88b5e9448ae673d41dc8f00302a82c8aab047f6910786c51b28e0'
+  data.tar.gz: f4b3e071ff53aa311f44b5918e2820fa52290f8c1f49126aed68ad4d1dcb64d2
+SHA512:
+  metadata.gz: ee2c6b1f06b074eabfdc11c659673e37c71013e5c7a0557d9991ac124ada0031847df5bb239db2a6773d0da51a2cd05d697c968bfe7bb9097c45e2e8e61bf874
+  data.tar.gz: 415fc16222ad2f3796b71a99e97a471868af5e5605c2e7eea81ab5e936acdc15df15bb2cc846d34c4f9b5d4f003637ba3423795ac2dfee046447030dc41985a4

data/CHANGELOG.md

@@ -0,0 +1,18 @@
+v0.0.5
+  * Catch a lot of weird little edge cases
+
+v0.0.4
+  * Generate a simple spec test for the new function
+  * Properly report the `require` warning as a warning
+  * Write a little more docs
+
+v0.0.3
+  * Cleans up by deleting the legacy function files if requested with `--clean`
+
+v0.0.2
+  * Now parses almost all of stdlib
+  * handles heredocs
+  * handles require statements outside the function block
+
+v0.0.1
+  * Initial release

data/LICENSE

@@ -0,0 +1,201 @@
+                                 Apache License
+                           Version 2.0, January 2004
+                        http://www.apache.org/licenses/
+
+   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+   1. Definitions.
+
+      "License" shall mean the terms and conditions for use, reproduction,
+      and distribution as defined by Sections 1 through 9 of this document.
+
+      "Licensor" shall mean the copyright owner or entity authorized by
+      the copyright owner that is granting the License.
+
+      "Legal Entity" shall mean the union of the acting entity and all
+      other entities that control, are controlled by, or are under common
+      control with that entity. For the purposes of this definition,
+      "control" means (i) the power, direct or indirect, to cause the
+      direction or management of such entity, whether by contract or
+      otherwise, or (ii) ownership of fifty percent (50%) or more of the
+      outstanding shares, or (iii) beneficial ownership of such entity.
+
+      "You" (or "Your") shall mean an individual or Legal Entity
+      exercising permissions granted by this License.
+
+      "Source" form shall mean the preferred form for making modifications,
+      including but not limited to software source code, documentation
+      source, and configuration files.
+
+      "Object" form shall mean any form resulting from mechanical
+      transformation or translation of a Source form, including but
+      not limited to compiled object code, generated documentation,
+      and conversions to other media types.
+
+      "Work" shall mean the work of authorship, whether in Source or
+      Object form, made available under the License, as indicated by a
+      copyright notice that is included in or attached to the work
+      (an example is provided in the Appendix below).
+
+      "Derivative Works" shall mean any work, whether in Source or Object
+      form, that is based on (or derived from) the Work and for which the
+      editorial revisions, annotations, elaborations, or other modifications
+      represent, as a whole, an original work of authorship. For the purposes
+      of this License, Derivative Works shall not include works that remain
+      separable from, or merely link (or bind by name) to the interfaces of,
+      the Work and Derivative Works thereof.
+
+      "Contribution" shall mean any work of authorship, including
+      the original version of the Work and any modifications or additions
+      to that Work or Derivative Works thereof, that is intentionally
+      submitted to Licensor for inclusion in the Work by the copyright owner
+      or by an individual or Legal Entity authorized to submit on behalf of
+      the copyright owner. For the purposes of this definition, "submitted"
+      means any form of electronic, verbal, or written communication sent
+      to the Licensor or its representatives, including but not limited to
+      communication on electronic mailing lists, source code control systems,
+      and issue tracking systems that are managed by, or on behalf of, the
+      Licensor for the purpose of discussing and improving the Work, but
+      excluding communication that is conspicuously marked or otherwise
+      designated in writing by the copyright owner as "Not a Contribution."
+
+      "Contributor" shall mean Licensor and any individual or Legal Entity
+      on behalf of whom a Contribution has been received by Licensor and
+      subsequently incorporated within the Work.
+
+   2. Grant of Copyright License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      copyright license to reproduce, prepare Derivative Works of,
+      publicly display, publicly perform, sublicense, and distribute the
+      Work and such Derivative Works in Source or Object form.
+
+   3. Grant of Patent License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      (except as stated in this section) patent license to make, have made,
+      use, offer to sell, sell, import, and otherwise transfer the Work,
+      where such license applies only to those patent claims licensable
+      by such Contributor that are necessarily infringed by their
+      Contribution(s) alone or by combination of their Contribution(s)
+      with the Work to which such Contribution(s) was submitted. If You
+      institute patent litigation against any entity (including a
+      cross-claim or counterclaim in a lawsuit) alleging that the Work
+      or a Contribution incorporated within the Work constitutes direct
+      or contributory patent infringement, then any patent licenses
+      granted to You under this License for that Work shall terminate
+      as of the date such litigation is filed.
+
+   4. Redistribution. You may reproduce and distribute copies of the
+      Work or Derivative Works thereof in any medium, with or without
+      modifications, and in Source or Object form, provided that You
+      meet the following conditions:
+
+      (a) You must give any other recipients of the Work or
+          Derivative Works a copy of this License; and
+
+      (b) You must cause any modified files to carry prominent notices
+          stating that You changed the files; and
+
+      (c) You must retain, in the Source form of any Derivative Works
+          that You distribute, all copyright, patent, trademark, and
+          attribution notices from the Source form of the Work,
+          excluding those notices that do not pertain to any part of
+          the Derivative Works; and
+
+      (d) If the Work includes a "NOTICE" text file as part of its
+          distribution, then any Derivative Works that You distribute must
+          include a readable copy of the attribution notices contained
+          within such NOTICE file, excluding those notices that do not
+          pertain to any part of the Derivative Works, in at least one
+          of the following places: within a NOTICE text file distributed
+          as part of the Derivative Works; within the Source form or
+          documentation, if provided along with the Derivative Works; or,
+          within a display generated by the Derivative Works, if and
+          wherever such third-party notices normally appear. The contents
+          of the NOTICE file are for informational purposes only and
+          do not modify the License. You may add Your own attribution
+          notices within Derivative Works that You distribute, alongside
+          or as an addendum to the NOTICE text from the Work, provided
+          that such additional attribution notices cannot be construed
+          as modifying the License.
+
+      You may add Your own copyright statement to Your modifications and
+      may provide additional or different license terms and conditions
+      for use, reproduction, or distribution of Your modifications, or
+      for any such Derivative Works as a whole, provided Your use,
+      reproduction, and distribution of the Work otherwise complies with
+      the conditions stated in this License.
+
+   5. Submission of Contributions. Unless You explicitly state otherwise,
+      any Contribution intentionally submitted for inclusion in the Work
+      by You to the Licensor shall be under the terms and conditions of
+      this License, without any additional terms or conditions.
+      Notwithstanding the above, nothing herein shall supersede or modify
+      the terms of any separate license agreement you may have executed
+      with Licensor regarding such Contributions.
+
+   6. Trademarks. This License does not grant permission to use the trade
+      names, trademarks, service marks, or product names of the Licensor,
+      except as required for reasonable and customary use in describing the
+      origin of the Work and reproducing the content of the NOTICE file.
+
+   7. Disclaimer of Warranty. Unless required by applicable law or
+      agreed to in writing, Licensor provides the Work (and each
+      Contributor provides its Contributions) on an "AS IS" BASIS,
+      WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+      implied, including, without limitation, any warranties or conditions
+      of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
+      PARTICULAR PURPOSE. You are solely responsible for determining the
+      appropriateness of using or redistributing the Work and assume any
+      risks associated with Your exercise of permissions under this License.
+
+   8. Limitation of Liability. In no event and under no legal theory,
+      whether in tort (including negligence), contract, or otherwise,
+      unless required by applicable law (such as deliberate and grossly
+      negligent acts) or agreed to in writing, shall any Contributor be
+      liable to You for damages, including any direct, indirect, special,
+      incidental, or consequential damages of any character arising as a
+      result of this License or out of the use or inability to use the
+      Work (including but not limited to damages for loss of goodwill,
+      work stoppage, computer failure or malfunction, or any and all
+      other commercial damages or losses), even if such Contributor
+      has been advised of the possibility of such damages.
+
+   9. Accepting Warranty or Additional Liability. While redistributing
+      the Work or Derivative Works thereof, You may choose to offer,
+      and charge a fee for, acceptance of support, warranty, indemnity,
+      or other liability obligations and/or rights consistent with this
+      License. However, in accepting such obligations, You may act only
+      on Your own behalf and on Your sole responsibility, not on behalf
+      of any other Contributor, and only if You agree to indemnify,
+      defend, and hold each Contributor harmless for any liability
+      incurred by, or claims asserted against, such Contributor by reason
+      of your accepting any such warranty or additional liability.
+
+   END OF TERMS AND CONDITIONS
+
+   APPENDIX: How to apply the Apache License to your work.
+
+      To apply the Apache License to your work, attach the following
+      boilerplate notice, with the fields enclosed by brackets "{}"
+      replaced with your own identifying information. (Don't include
+      the brackets!)  The text should be enclosed in the appropriate
+      comment syntax for the file format. We also recommend that a
+      file or class name and description of purpose be included on the
+      same "printed page" as the copyright notice for easier
+      identification within third-party archives.
+
+   Copyright {yyyy} {name of copyright owner}
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.

data/README.md

@@ -0,0 +1,242 @@
+# Puppet Function Updater
+
+Port legacy Puppet 3.x functions to the new function API automatically.
+
+Run this command with a space separated list of either function file paths, or
+directories containing functions. If omitted, it will default to porting all the
+legacy functions, so you can just run this in the root of a Puppet module and it
+will do the right thing.
+
+
+## Installation
+
+```
+$ gem install puppet-function-updater
+```
+
+
+## Usage
+
+Run the command puppet_function_updater in the root of a Puppet module, then
+inspect all the generated functions for suitability when it’s done. If you pass
+the --clean argument it will **delete the legacy function file from disk** after
+validating that the new function works.
+
+You might see some warnings. Many can be ignored. For example, the following
+warning just means that the function attempted to require a library file outside
+of the the function block. You might evaluate whether you could remove the call
+or move it inside the function declaration so it's lazily loaded.
+
+```
+INFO: Creating lib/puppet/functions/stdlib/deep_merge.rb
+WARN: The function attempted to load libraries outside the function block.
+WARN: cannot load such file -- puppet/parser/functions (ignored)
+```
+
+On the other hand, errors like below indicate that the function code doesn't parse
+properly after porting. It's generally an issue with the original source code.
+
+```
+INFO: Creating lib/puppet/functions/stdlib/validate_x509_rsa_key_pair.rb
+ERROR: Oh crap; the generated function isn't valid Ruby code!
+ERROR: <compiled>:47: dynamic constant assignment
+    NUM_ARGS = 2 unless defined? NUM_ARGS
+             ^
+```
+
+### After porting
+
+Two files will be generated, the function file and the spec test for that function.
+
+* `lib/puppet/functions/<namespace>/<function>.rb`
+* `spec/functions/<namespace>_<function>_spec.rb`
+
+After porting, you should inspect the generated files. At a minimum, you'll want
+to clean up the documentation comments, but I'd also suggest reading a bit on the
+new function API and writing better dispatches to provide proper type checking
+and reduce the amount of manual argument validation your function must do.
+
+The test simply validates that the function compiles and defines a function
+properly, so you'll also want to write more test cases. If your legacy function
+has unit tests, you might consider porting them to the new function, following
+the examples provided as comments.
+
+See a [tutorial](https://binford2k.com/2019/11/27/automagic-function-port/) on its usage on my blog.
+
+
+### Example:
+
+```
+[~/Projects/puppetlabs-stdlib]$ puppet_function_updater --verbose
+INFO: Creating lib/puppet/functions/stdlib/abs.rb
+INFO: Creating lib/puppet/functions/stdlib/any2array.rb
+INFO: Creating lib/puppet/functions/stdlib/any2bool.rb
+INFO: Creating lib/puppet/functions/stdlib/assert_private.rb
+INFO: Creating lib/puppet/functions/stdlib/base64.rb
+INFO: Creating lib/puppet/functions/stdlib/basename.rb
+INFO: Creating lib/puppet/functions/stdlib/bool2num.rb
+INFO: Creating lib/puppet/functions/stdlib/bool2str.rb
+INFO: Creating lib/puppet/functions/stdlib/camelcase.rb
+INFO: Creating lib/puppet/functions/stdlib/capitalize.rb
+INFO: Creating lib/puppet/functions/stdlib/ceiling.rb
+INFO: Creating lib/puppet/functions/stdlib/chomp.rb
+INFO: Creating lib/puppet/functions/stdlib/chop.rb
+INFO: Creating lib/puppet/functions/stdlib/clamp.rb
+INFO: Creating lib/puppet/functions/stdlib/concat.rb
+INFO: Creating lib/puppet/functions/stdlib/convert_base.rb
+INFO: Creating lib/puppet/functions/stdlib/count.rb
+INFO: Creating lib/puppet/functions/stdlib/deep_merge.rb
+WARN: The function attempted to load libraries outside the function block.
+WARN: cannot load such file -- puppet/parser/functions (ignored)
+INFO: Creating lib/puppet/functions/stdlib/defined_with_params.rb
+INFO: Creating lib/puppet/functions/stdlib/delete.rb
+INFO: Creating lib/puppet/functions/stdlib/delete_at.rb
+INFO: Creating lib/puppet/functions/stdlib/delete_regex.rb
+INFO: Creating lib/puppet/functions/stdlib/delete_undef_values.rb
+INFO: Creating lib/puppet/functions/stdlib/delete_values.rb
+INFO: Creating lib/puppet/functions/stdlib/deprecation.rb
+INFO: Creating lib/puppet/functions/stdlib/difference.rb
+INFO: Creating lib/puppet/functions/stdlib/dig.rb
+INFO: Creating lib/puppet/functions/stdlib/dig44.rb
+INFO: Creating lib/puppet/functions/stdlib/dirname.rb
+INFO: Creating lib/puppet/functions/stdlib/dos2unix.rb
+INFO: Creating lib/puppet/functions/stdlib/downcase.rb
+INFO: Creating lib/puppet/functions/stdlib/empty.rb
+INFO: Creating lib/puppet/functions/stdlib/enclose_ipv6.rb
+INFO: Creating lib/puppet/functions/stdlib/ensure_packages.rb
+WARN: The function attempted to load libraries outside the function block.
+WARN: cannot load such file -- puppet/parser/functions (ignored)
+INFO: Creating lib/puppet/functions/stdlib/ensure_resource.rb
+WARN: The function attempted to load libraries outside the function block.
+WARN: cannot load such file -- puppet/parser/functions (ignored)
+INFO: Creating lib/puppet/functions/stdlib/ensure_resources.rb
+INFO: Creating lib/puppet/functions/stdlib/flatten.rb
+INFO: Creating lib/puppet/functions/stdlib/floor.rb
+INFO: Creating lib/puppet/functions/stdlib/fqdn_rand_string.rb
+INFO: Creating lib/puppet/functions/stdlib/fqdn_rotate.rb
+INFO: Creating lib/puppet/functions/stdlib/fqdn_uuid.rb
+INFO: Creating lib/puppet/functions/stdlib/get_module_path.rb
+WARN: The function attempted to load libraries outside the function block.
+WARN: cannot load such file -- puppet/parser/functions (ignored)
+INFO: Creating lib/puppet/functions/stdlib/getparam.rb
+INFO: Creating lib/puppet/functions/stdlib/getvar.rb
+INFO: Creating lib/puppet/functions/stdlib/glob.rb
+INFO: Creating lib/puppet/functions/stdlib/grep.rb
+INFO: Creating lib/puppet/functions/stdlib/has_interface_with.rb
+INFO: Creating lib/puppet/functions/stdlib/has_ip_address.rb
+INFO: Creating lib/puppet/functions/stdlib/has_ip_network.rb
+INFO: Creating lib/puppet/functions/stdlib/has_key.rb
+INFO: Creating lib/puppet/functions/stdlib/hash.rb
+INFO: Creating lib/puppet/functions/stdlib/intersection.rb
+INFO: Creating lib/puppet/functions/stdlib/is_absolute_path.rb
+INFO: Creating lib/puppet/functions/stdlib/is_array.rb
+INFO: Creating lib/puppet/functions/stdlib/is_bool.rb
+INFO: Creating lib/puppet/functions/stdlib/is_domain_name.rb
+INFO: Creating lib/puppet/functions/stdlib/is_email_address.rb
+INFO: Creating lib/puppet/functions/stdlib/is_float.rb
+INFO: Creating lib/puppet/functions/stdlib/is_function_available.rb
+INFO: Creating lib/puppet/functions/stdlib/is_hash.rb
+INFO: Creating lib/puppet/functions/stdlib/is_integer.rb
+INFO: Creating lib/puppet/functions/stdlib/is_ip_address.rb
+INFO: Creating lib/puppet/functions/stdlib/is_ipv4_address.rb
+INFO: Creating lib/puppet/functions/stdlib/is_ipv6_address.rb
+INFO: Creating lib/puppet/functions/stdlib/is_mac_address.rb
+INFO: Creating lib/puppet/functions/stdlib/is_numeric.rb
+INFO: Creating lib/puppet/functions/stdlib/is_string.rb
+INFO: Creating lib/puppet/functions/stdlib/join.rb
+INFO: Creating lib/puppet/functions/stdlib/join_keys_to_values.rb
+INFO: Creating lib/puppet/functions/stdlib/keys.rb
+INFO: Creating lib/puppet/functions/stdlib/load_module_metadata.rb
+INFO: Creating lib/puppet/functions/stdlib/loadjson.rb
+INFO: Creating lib/puppet/functions/stdlib/loadyaml.rb
+INFO: Creating lib/puppet/functions/stdlib/lstrip.rb
+INFO: Creating lib/puppet/functions/stdlib/max.rb
+INFO: Creating lib/puppet/functions/stdlib/member.rb
+INFO: Creating lib/puppet/functions/stdlib/merge.rb
+INFO: Creating lib/puppet/functions/stdlib/min.rb
+INFO: Creating lib/puppet/functions/stdlib/num2bool.rb
+INFO: Creating lib/puppet/functions/stdlib/parsejson.rb
+INFO: Creating lib/puppet/functions/stdlib/parseyaml.rb
+INFO: Creating lib/puppet/functions/stdlib/pick.rb
+INFO: Creating lib/puppet/functions/stdlib/pick_default.rb
+INFO: Creating lib/puppet/functions/stdlib/prefix.rb
+INFO: Creating lib/puppet/functions/stdlib/private.rb
+INFO: Creating lib/puppet/functions/stdlib/pry.rb
+INFO: Creating lib/puppet/functions/stdlib/pw_hash.rb
+INFO: Creating lib/puppet/functions/stdlib/range.rb
+INFO: Creating lib/puppet/functions/stdlib/regexpescape.rb
+INFO: Creating lib/puppet/functions/stdlib/reject.rb
+INFO: Creating lib/puppet/functions/stdlib/reverse.rb
+INFO: Creating lib/puppet/functions/stdlib/round.rb
+INFO: Creating lib/puppet/functions/stdlib/rstrip.rb
+INFO: Creating lib/puppet/functions/stdlib/seeded_rand.rb
+INFO: Creating lib/puppet/functions/stdlib/shell_escape.rb
+INFO: Creating lib/puppet/functions/stdlib/shell_join.rb
+INFO: Creating lib/puppet/functions/stdlib/shell_split.rb
+INFO: Creating lib/puppet/functions/stdlib/shuffle.rb
+INFO: Creating lib/puppet/functions/stdlib/size.rb
+INFO: Creating lib/puppet/functions/stdlib/sort.rb
+INFO: Creating lib/puppet/functions/stdlib/squeeze.rb
+INFO: Creating lib/puppet/functions/stdlib/str2bool.rb
+INFO: Creating lib/puppet/functions/stdlib/str2saltedsha512.rb
+INFO: Creating lib/puppet/functions/stdlib/strftime.rb
+INFO: Creating lib/puppet/functions/stdlib/strip.rb
+INFO: Creating lib/puppet/functions/stdlib/suffix.rb
+INFO: Creating lib/puppet/functions/stdlib/swapcase.rb
+INFO: Creating lib/puppet/functions/stdlib/time.rb
+INFO: Creating lib/puppet/functions/stdlib/to_bytes.rb
+INFO: Creating lib/puppet/functions/stdlib/try_get_value.rb
+INFO: Creating lib/puppet/functions/stdlib/type.rb
+INFO: Creating lib/puppet/functions/stdlib/type3x.rb
+INFO: Creating lib/puppet/functions/stdlib/union.rb
+INFO: Creating lib/puppet/functions/stdlib/unique.rb
+INFO: Creating lib/puppet/functions/stdlib/unix2dos.rb
+INFO: Creating lib/puppet/functions/stdlib/upcase.rb
+INFO: Creating lib/puppet/functions/stdlib/uriescape.rb
+INFO: Creating lib/puppet/functions/stdlib/validate_absolute_path.rb
+INFO: Creating lib/puppet/functions/stdlib/validate_array.rb
+INFO: Creating lib/puppet/functions/stdlib/validate_augeas.rb
+INFO: Creating lib/puppet/functions/stdlib/validate_bool.rb
+WARN: The function attempted to load libraries outside the function block.
+WARN: cannot load such file -- puppet/util/execution (ignored)
+INFO: Creating lib/puppet/functions/stdlib/validate_cmd.rb
+INFO: Creating lib/puppet/functions/stdlib/validate_domain_name.rb
+INFO: Creating lib/puppet/functions/stdlib/validate_email_address.rb
+INFO: Creating lib/puppet/functions/stdlib/validate_hash.rb
+INFO: Creating lib/puppet/functions/stdlib/validate_integer.rb
+INFO: Creating lib/puppet/functions/stdlib/validate_ip_address.rb
+INFO: Creating lib/puppet/functions/stdlib/validate_ipv4_address.rb
+INFO: Creating lib/puppet/functions/stdlib/validate_ipv6_address.rb
+INFO: Creating lib/puppet/functions/stdlib/validate_numeric.rb
+INFO: Creating lib/puppet/functions/stdlib/validate_re.rb
+INFO: Creating lib/puppet/functions/stdlib/validate_slength.rb
+INFO: Creating lib/puppet/functions/stdlib/validate_string.rb
+INFO: Creating lib/puppet/functions/stdlib/validate_x509_rsa_key_pair.rb
+ERROR: Oh crap; the generated function isn't valid Ruby code!
+ERROR: <compiled>:47: dynamic constant assignment
+    NUM_ARGS = 2 unless defined? NUM_ARGS
+             ^
+INFO: Creating lib/puppet/functions/stdlib/values.rb
+INFO: Creating lib/puppet/functions/stdlib/values_at.rb
+INFO: Creating lib/puppet/functions/stdlib/zip.rb
+INFO: Functions generated. Please inspect for suitability and then
+INFO: update any Puppet code with the new function names.
+INFO: See https://puppet.com/docs/puppet/latest/custom_functions_ruby.html
+INFO: for more information about Puppet's modern Ruby function API.
+```
+
+
+## Limitations
+
+This is super early in development and has not yet been battle tested.
+
+
+## Disclaimer
+
+I take no liability for the use of this tool.
+
+
+Contact
+-------
+
+binford2k@gmail.com

data/bin/puppet_function_updater

@@ -0,0 +1,83 @@
+#!/usr/bin/env ruby
+$:.unshift File.join(File.dirname(__FILE__), '..', 'lib')
+
+require 'logger'
+require 'optparse'
+require 'json'
+require 'pfu'
+
+loglevel = Logger::WARN
+options = {}
+OptionParser.new do |opts|
+  opts.banner = "Usage: puppet_function_updater [paths]
+
+Run this command with a space separated list of legacy function file paths and it
+will attempt to automatically port them to the modern function API for you.
+
+If you run it from the root of a module directory, it will infer the namespace of
+the module and use it automatically in the generated function names.
+
+If you pass no paths and run it from the root of a module, it will assume that you
+mean to port all the legacy functions.
+
+"
+
+  opts.on('-v', '--verbose', 'Show verbose output') do
+    loglevel = Logger::INFO
+  end
+
+  opts.on('-d', '--debug', 'Show debugging messages') do
+    loglevel = Logger::DEBUG
+  end
+
+  opts.on('-c', '--clean', 'Delete legacy function files from disk') do
+    options[:clean] = true
+  end
+
+  opts.on('-n', '--namespace NAMESPACE', 'The namespace for the generated functions to live in') do |arg|
+    options[:namespace] = arg
+  end
+
+  opts.on('--shell', 'Open a pry shell for debugging (must have Pry installed)') do
+    options[:shell] = true
+  end
+
+  opts.on('--version', 'Show version number') do
+    puts Pfu::VERSION
+    exit
+  end
+
+end.parse!
+
+$logger           = Logger.new($stderr)
+$logger.level     = loglevel
+$logger.formatter = proc { |severity,datetime,progname,msg| "#{severity}: #{msg}\n" }
+
+options[:filenames]   = ARGV.map {|f| File.expand_path f} unless ARGV.empty?
+options[:filenames] ||= ['lib/puppet/parser/functions']
+
+options[:filenames].map! do |path|
+  next path unless File.directory? path
+
+  Dir.glob("#{path}/*")
+end
+options[:filenames].flatten!
+
+if options[:namespace].nil?
+  if File.exist? 'metadata.json'
+    metadata = JSON.parse(File.read('metadata.json')) rescue {'name' => ''}
+    options[:namespace] = metadata['name'].split('-')[1] rescue nil
+  else
+    $logger.warn "*********** Namespace is highly suggested! *********** "
+    $logger.warn "      Either run this command from within a module"
+    $logger.warn " or provide a namespace with the --namespace argument!"
+  end
+end
+
+if options[:shell]
+  require 'pry'
+  binding.pry
+  exit 0
+end
+
+Pfu.new(options).refactor!

data/lib/pfu.rb

@@ -0,0 +1,26 @@
+class Pfu
+  require 'pfu/parser'
+  require 'pfu/generator'
+  require 'pfu/version'
+
+  def initialize(options)
+    @filenames = options[:filenames]
+    @namespace = options[:namespace]
+    @clean     = options[:clean]
+  end
+
+  def refactor!
+    @filenames.each do |path|
+      next unless data = Pfu::Parser.parse(path)
+      data[:namespace] = @namespace
+      if Pfu::Generator.write(data)
+        FileUtils.rm(path) if @clean
+      end
+    end
+
+    $logger.info "Functions generated. Please inspect for suitability and then"
+    $logger.info "update any Puppet code with the new function names."
+    $logger.info "See https://puppet.com/docs/puppet/latest/custom_functions_ruby.html"
+    $logger.info "for more information about Puppet's modern Ruby function API."
+  end
+end

data/lib/pfu/generator.rb

@@ -0,0 +1,51 @@
+require 'erb'
+require 'fileutils'
+
+class Pfu::Generator
+  def self.write(opts)
+    newpath  = "lib/puppet/functions/#{opts[:namespace]}/#{opts[:name]}.rb"
+    specpath = "spec/functions/#{opts[:namespace]}_#{opts[:name]}_spec.rb"
+
+    [newpath, specpath].each do |path|
+      next unless File.exist?(path)
+      $logger.error "Cowardly refusing to overwrite #{path}"
+      return
+    end
+
+    opts[:fullname] = case opts[:namespace]
+    when '', nil
+      opts[:name]
+    else
+      "#{opts[:namespace]}::#{opts[:name]}"
+    end
+
+    template = File.join(File.dirname(__FILE__), '..', '..', 'templates', 'function.erb')
+    contents = ERB.new(File.read(template), nil, '-').result(binding)
+
+    template = File.join(File.dirname(__FILE__), '..', '..', 'templates', 'function_spec.erb')
+    specfile = ERB.new(File.read(template), nil, '-').result(binding)
+
+    $logger.info "Creating #{newpath}"
+    $logger.debug "Function contents:\n#{contents}"
+
+    begin
+      # syntax check the code before writing it
+      # TODO: validate that it actually creates a puppet function
+      RubyVM::InstructionSequence.compile(contents)
+
+      FileUtils.mkdir_p("lib/puppet/functions/#{opts[:namespace]}")
+      File.write(newpath, contents)
+
+      FileUtils.mkdir_p("spec/functions")
+      File.write(specpath, specfile)
+
+      return true
+    rescue Exception => e
+      $logger.error "Oh crap; the generated function isn't valid Ruby code!"
+      $logger.error e.message
+      $logger.debug e.backtrace.join("\n")
+      return false
+    end
+
+  end
+end

data/lib/pfu/parser.rb

@@ -0,0 +1,81 @@
+# We don't actually use this, but a surprising number of functions assume it
+require 'yaml'
+
+module Puppet
+  module Parser
+    module Functions
+
+      def self.newfunction(funcname, opts = {}, &block)
+        return [funcname, opts, block.source_location.last]
+      end
+
+    end
+  end
+end
+
+# shudder
+module Kernel
+  alias original_require require
+  alias original_require_relative require_relative
+
+  def require(*a, &b)
+    original_require(*a, &b)
+  rescue LoadError => e
+    $logger.warn "The function attempted to load libraries outside the function block."
+    $logger.warn "#{e.message} (ignored)"
+  end
+
+  def require_relative(*a, &b)
+    original_require_relative(*a, &b)
+  rescue LoadError => e
+    $logger.warn "The function attempted to relatively load libraries outside the function block."
+    $logger.warn "#{e.message} (ignored)"
+  end
+end
+
+
+class Pfu::Parser
+  def self.parse(path)
+    return unless File.extname(path) == '.rb'
+    source = File.read(path)
+    lines  = source.split("\n")
+
+    begin
+      funcname, opts, lineno = eval(source)
+      
+      raise 'Invalid function definition' unless (funcname and opts and lineno)
+    rescue => e
+      $logger.error "The function in #{path} doesn't load properly!"
+      $logger.error e.message
+      return nil
+    end
+
+    stripcount = case source
+    when /module\s+Puppet::Parser::Functions/
+      2
+    when /Puppet::Parser::Functions(.|::)newfunction/
+      1
+    end
+
+    block = lines[(lineno-1)..-1].join("\n")
+    block.gsub!(/\A.*\|\*?\w+\|/, '')                            # remove block arg string ("|args|")
+    block.gsub!(/((end|})\s*){#{stripcount}}(^#.*|\s*)*\z/, '')  # remove closing block keywords and trailing comments
+
+    heredoc = source.match(/<<-['"]?(\w+)['"]?/)
+    if heredoc
+      block.gsub!(/\A.*#{heredoc[1]}/m, '')
+    end
+
+    header = lines[0...(lines.index { |l| l =~ /Puppet::Parser::Functions/ })].join("\n")
+    args   = lines[lineno-1].match(/\|\s*\*?(\w+)\s*\|/)[1]
+
+    opts[:doc]            = opts[:doc].gsub("\n", "\n#") unless opts[:doc].nil?
+    opts[:name]           = funcname.to_sym
+    opts[:header]         = header
+    opts[:args]           = args
+    opts[:implementation] = block
+
+    opts
+  end
+
+end

data/lib/pfu/version.rb

@@ -0,0 +1,3 @@
+class Pfu
+  VERSION = '0.0.5'
+end

data/lib/puppet/functions/testing/direct.rb

@@ -0,0 +1,39 @@
+# This is an autogenerated function, ported from the original legacy version.
+# It /should work/ as is, but will not have all the benefits of the modern
+# function API. You should see the function docs to learn how to add function
+# signatures for type safety and to document this function using puppet-strings.
+#
+# https://puppet.com/docs/puppet/latest/custom_functions_ruby.html
+#
+# ---- original file header ----
+# A comment! Theoretically it would tell you what the function does.
+# ---- original file header ----
+#
+# @summary
+#   Just a naive strlen example
+#
+Puppet::Functions.create_function(:'testing::direct') do
+  # @param args
+  #   The original array of arguments. Port this to individually managed params
+  #   to get the full benefit of the modern function API.
+  #
+  # @return [Data type]
+  #   Describe what the function returns here
+  #
+  dispatch :default_impl do
+    # Call the method named 'default_impl' when this is matched
+    # Port this to match individual params for better type safety
+    repeated_param 'Any', :args
+  end
+
+
+  def default_impl(*args)
+    
+    raise "Wrong number of args" unless args.size == 1         # arg validation
+    raise "Wrong type of args" unless args.first.is_a String   # arg validation
+    value = args.first                                         # arg handling
+
+    value.length                                               # implementation
+
+  end
+end

data/lib/puppet/functions/testing/module.rb

@@ -0,0 +1,39 @@
+# This is an autogenerated function, ported from the original legacy version.
+# It /should work/ as is, but will not have all the benefits of the modern
+# function API. You should see the function docs to learn how to add function
+# signatures for type safety and to document this function using puppet-strings.
+#
+# https://puppet.com/docs/puppet/latest/custom_functions_ruby.html
+#
+# ---- original file header ----
+
+# ---- original file header ----
+#
+# @summary
+#   Just a naive strlen example
+#
+Puppet::Functions.create_function(:'testing::module') do
+  # @param args
+  #   The original array of arguments. Port this to individually managed params
+  #   to get the full benefit of the modern function API.
+  #
+  # @return [Data type]
+  #   Describe what the function returns here
+  #
+  dispatch :default_impl do
+    # Call the method named 'default_impl' when this is matched
+    # Port this to match individual params for better type safety
+    repeated_param 'Any', :args
+  end
+
+
+  def default_impl(*args)
+    
+    raise "Wrong number of args" unless args.size == 1         # arg validation
+    raise "Wrong type of args" unless args.first.is_a String   # arg validation
+    value = args.first                                         # arg handling
+
+    value.length                                               # implementation
+  
+  end
+end

data/lib/puppet/functions/testing/noopts.rb

@@ -0,0 +1,41 @@
+# This is an autogenerated function, ported from the original legacy version.
+# It /should work/ as is, but will not have all the benefits of the modern
+# function API. You should see the function docs to learn how to add function
+# signatures for type safety and to document this function using puppet-strings.
+#
+# https://puppet.com/docs/puppet/latest/custom_functions_ruby.html
+#
+# ---- original file header ----
+#! /usr/bin/env ruby
+# This is a leading comment
+# it might have docs or something
+# ---- original file header ----
+#
+# @summary
+#   
+#
+Puppet::Functions.create_function(:'testing::noopts') do
+  # @param args
+  #   The original array of arguments. Port this to individually managed params
+  #   to get the full benefit of the modern function API.
+  #
+  # @return [Data type]
+  #   Describe what the function returns here
+  #
+  dispatch :default_impl do
+    # Call the method named 'default_impl' when this is matched
+    # Port this to match individual params for better type safety
+    repeated_param 'Any', :args
+  end
+
+
+  def default_impl(*args)
+    
+    raise "Wrong number of args" unless args.size == 1         # arg validation
+    raise "Wrong type of args" unless args.first.is_a String   # arg validation
+    value = args.first                                         # arg handling
+
+    value.length                                               # implementation
+
+  end
+end

data/templates/function.erb

@@ -0,0 +1,33 @@
+# This is an autogenerated function, ported from the original legacy version.
+# It /should work/ as is, but will not have all the benefits of the modern
+# function API. You should see the function docs to learn how to add function
+# signatures for type safety and to document this function using puppet-strings.
+#
+# https://puppet.com/docs/puppet/latest/custom_functions_ruby.html
+#
+# ---- original file header ----
+<%= opts[:header] %>
+# ---- original file header ----
+#
+# @summary
+#   <%= opts[:doc] || 'Summarise what the function does here' %>
+#
+Puppet::Functions.create_function(:'<%= opts[:fullname] %>') do
+  # @param <%= opts[:args] %>
+  #   The original array of arguments. Port this to individually managed params
+  #   to get the full benefit of the modern function API.
+  #
+  # @return [Data type]
+  #   Describe what the function returns here
+  #
+  dispatch :default_impl do
+    # Call the method named 'default_impl' when this is matched
+    # Port this to match individual params for better type safety
+    repeated_param 'Any', :<%= opts[:args] %>
+  end
+
+
+  def default_impl(*<%= opts[:args] %>)
+    <%= opts[:implementation] %>
+  end
+end

data/templates/function_spec.erb

@@ -0,0 +1,41 @@
+require 'spec_helper'
+
+describe '<%= opts[:fullname] %>' do
+  # without knowing details about the implementation, this is the only test
+  # case that we can autogenerate. You should add more examples below!
+  it { is_expected.not_to eq(nil) }
+
+#################################
+# Below are some example test cases. You may uncomment and modify them to match
+# your needs. Notice that they all expect the base error class of `StandardError`.
+# This is because the autogenerated function uses an untyped array for parameters
+# and relies on your implementation to do the validation. As you convert your
+# function to proper dispatches and typed signatures, you should change the
+# expected error of the argument validation examples to `ArgumentError`.
+#
+# Other error types you might encounter include
+#
+# * StandardError
+# * ArgumentError
+# * Puppet::ParseError
+#
+# Read more about writing function unit tests at https://rspec-puppet.com/documentation/functions/
+#
+#   it 'raises an error if called with no argument' do
+#     is_expected.to run.with_params.and_raise_error(StandardError)
+#   end
+#
+#   it 'raises an error if there is more than 1 arguments' do
+#     is_expected.to run.with_params({ 'foo' => 1 }, 'bar' => 2).and_raise_error(StandardError)
+#   end
+#
+#   it 'raises an error if argument is not the proper type' do
+#     is_expected.to run.with_params('foo').and_raise_error(StandardError)
+#   end
+#
+#   it 'returns the proper output' do
+#     is_expected.to run.with_params(123).and_return('the expected output')
+#   end
+#################################
+
+end

metadata

@@ -0,0 +1,60 @@
+--- !ruby/object:Gem::Specification
+name: puppet-function-updater
+version: !ruby/object:Gem::Version
+  version: 0.0.5
+platform: ruby
+authors:
+- Ben Ford
+autorequire: 
+bindir: bin
+cert_chain: []
+date: 2020-01-03 00:00:00.000000000 Z
+dependencies: []
+description: |
+  Run this command with a space separated list of either function file paths, or
+  directories containing functions. If omitted, it will default to porting all the
+  legacy functions, so you can just run this in the root of a Puppet module and it
+  will do the right thing.
+email: ben.ford@puppet.com
+executables:
+- puppet_function_updater
+extensions: []
+extra_rdoc_files: []
+files:
+- CHANGELOG.md
+- LICENSE
+- README.md
+- bin/puppet_function_updater
+- lib/pfu.rb
+- lib/pfu/generator.rb
+- lib/pfu/parser.rb
+- lib/pfu/version.rb
+- lib/puppet/functions/testing/direct.rb
+- lib/puppet/functions/testing/module.rb
+- lib/puppet/functions/testing/noopts.rb
+- templates/function.erb
+- templates/function_spec.erb
+homepage: https://binford2k.com/2019/11/27/automagic-function-port/
+licenses:
+- Apache-2.0
+metadata: {}
+post_install_message: 
+rdoc_options: []
+require_paths:
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements: []
+rubygems_version: 3.0.3
+signing_key: 
+specification_version: 4
+summary: Automagically ports legacy Puppet functions to the modern API.
+test_files: []