puppet-debugger 0.17.0 → 1.2.0

data/spec/input_responders/environment_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'puppet-debugger'
 require 'puppet-debugger/plugin_test_helper'

data/spec/input_responders/exit_spec.rb

@@ -1,13 +1,11 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'puppet-debugger'
 
 describe :exit do
   let(:args) { [] }
 
-  xit 'exits' do
-    expect{plugin.run(args)}.to eq('')
-  end
-
   let(:plugin) do
     instance = PuppetDebugger::InputResponders::Commands.plugin_from_command(subject.to_s).instance
     instance.debugger = debugger
@@ -26,21 +24,21 @@ describe :exit do
     {}
   end
 
-  it "commands contant is an array" do
+  it 'commands contant is an array' do
     expect(plugin.class::COMMAND_WORDS).to be_a(Array)
   end
 
-  it "commands must contain at least one word" do
-    expect(plugin.class::COMMAND_WORDS.count).to  be > 0
+  it 'commands must contain at least one word' do
+    expect(plugin.class::COMMAND_WORDS.count).to be > 0
   end
 
-  it "summary must be a string" do
+  it 'summary must be a string' do
     expect(plugin.class::SUMMARY).to be_a(String)
   end
 
-  it 'implements run' do
-    expect{plugin.run([])}.not_to raise_error(NotImplementedError)
-  end
+  # it 'implements run' do
+  #   expect { plugin.run([]) }.not_to raise(SystemExit)
+  # end
 
   it 'be looked up via any command words' do
     plugin.class::COMMAND_WORDS.each do |word|

data/spec/input_responders/facterdb_filter_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'puppet-debugger'
 require 'puppet-debugger/plugin_test_helper'

data/spec/input_responders/facts_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'puppet-debugger'
 require 'puppet-debugger/plugin_test_helper'

data/spec/input_responders/functions_spec.rb

@@ -1,73 +1,75 @@
-require "spec_helper"
-require "puppet-debugger"
-require "puppet-debugger/plugin_test_helper"
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'puppet-debugger'
+require 'puppet-debugger/plugin_test_helper'
 
 describe :functions do
-  include_examples "plugin_tests"
+  include_examples 'plugin_tests'
 
   let(:input) do
     "md5('hello')"
   end
 
   let(:mod_dir) do
-    File.join(fixtures_dir, "modules", "extlib")
+    File.join(fixtures_dir, 'modules', 'extlib')
   end
 
-  it "runs" do
+  it 'runs' do
     expect(plugin.run).to be_a String
   end
 
-  it "returns functions" do
+  it 'returns functions' do
     expect(plugin.function_map).to be_a Hash
   end
 
-  it "sorted_list" do
+  it 'sorted_list' do
     expect(plugin.sorted_list).to be_a Array
     expect(plugin.sorted_list.first).to be_a Hash
   end
 
-  it "returns function names" do
+  it 'returns function names' do
     expect(plugin.func_list).to be_a Array
-    expect(plugin.func_list.find { |m| m =~ /md5/ }).to eq("md5()")
+    expect(plugin.func_list.find { |m| m =~ /md5/ }).to eq('md5()')
   end
 
-  it "execute md5" do
+  it 'execute md5' do
     debugger_output = /5d41402abc4b2a76b9719d911017c592/
     debugger.handle_input("md5('hello')")
     expect(output.string).to match(debugger_output)
   end
 
-  it "execute swapcase" do
+  it 'execute swapcase' do
     debugger_output = /HELLO/
     debugger.handle_input("swapcase('hello')")
     expect(output.string).to match(debugger_output)
   end
 
-  it "#function_obj with native function" do
-    expect(plugin.function_obj(File.join(mod_dir, "functions", "dir_split.pp"))).to eq(
-      { :file => File.join(mod_dir, "functions", "dir_split.pp"), :mod_name => "extlib",
-        :full_name => "extlib::dir_split", :name => "extlib::dir_split", :namespace => "extlib",
-        :summary => "Splits the given directory or directories into individual paths." }
+  it '#function_obj with native function' do
+    expect(plugin.function_obj(File.join(mod_dir, 'functions', 'dir_split.pp'))).to eq(
+      file: File.join(mod_dir, 'functions', 'dir_split.pp'), mod_name: 'extlib',
+      full_name: 'extlib::dir_split', name: 'extlib::dir_split', namespace: 'extlib',
+      summary: 'Splits the given directory or directories into individual paths.'
     )
   end
 
-  it "#function_obj ruby v4 without namespace" do
-    expect(plugin.function_obj(File.join(mod_dir, "lib", "puppet", "functions", "echo.rb"))).to eq({ :file => File.join(mod_dir, "lib", "puppet", "functions", "echo.rb"), :mod_name => "extlib",
-                                                                                                     :full_name => "echo", :name => "echo", :namespace => "", :summary => "DEPRECATED.  Use the namespaced function [`extlib::echo`](#extlibecho) instead." })
+  it '#function_obj ruby v4 without namespace' do
+    expect(plugin.function_obj(File.join(mod_dir, 'lib', 'puppet', 'functions', 'echo.rb'))).to eq(file: File.join(mod_dir, 'lib', 'puppet', 'functions', 'echo.rb'), mod_name: 'extlib',
+                                                                                                   full_name: 'echo', name: 'echo', namespace: '', summary: 'DEPRECATED.  Use the namespaced function [`extlib::echo`](#extlibecho) instead.')
   end
 
-  it "#function_obj ruby v4 and namespace" do
-    expect(plugin.function_obj(File.join(mod_dir, "lib", "puppet", "functions", "extlib", "echo.rb"))).to eq({ :file => File.join(mod_dir, "lib", "puppet", "functions", "extlib", "echo.rb"), :mod_name => "extlib",
-                                                                                                               :full_name => "extlib::echo", :name => "extlib::echo", :namespace => "extlib", :summary => nil })
+  it '#function_obj ruby v4 and namespace' do
+    expect(plugin.function_obj(File.join(mod_dir, 'lib', 'puppet', 'functions', 'extlib', 'echo.rb'))).to eq(file: File.join(mod_dir, 'lib', 'puppet', 'functions', 'extlib', 'echo.rb'), mod_name: 'extlib',
+                                                                                                             full_name: 'extlib::echo', name: 'extlib::echo', namespace: 'extlib', summary: nil)
   end
 
-  it "#function_obj has puppet namespace" do
-    file, _ = Puppet::Functions.method(:create_function).source_location
+  it '#function_obj has puppet namespace' do
+    file, = Puppet::Functions.method(:create_function).source_location
     dir = File.dirname(file)
-    f_obj = plugin.function_obj(File.join(dir, "functions", "include.rb"))
+    f_obj = plugin.function_obj(File.join(dir, 'functions', 'include.rb'))
     expect(f_obj[:mod_name]).to match(/puppet-.*/)
-    expect(f_obj[:name]).to eq("include")
-    expect(f_obj[:full_name]).to eq("include")
+    expect(f_obj[:name]).to eq('include')
+    expect(f_obj[:full_name]).to eq('include')
     expect(f_obj[:summary]).to be_nil
   end
 end

data/spec/input_responders/help_spec.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'puppet-debugger/plugin_test_helper'
 
 describe :help do
-  include_examples "plugin_tests"
+  include_examples 'plugin_tests'
   let(:args) { [] }
 
   let(:help_output) do
@@ -23,10 +25,10 @@ describe :help do
   end
 
   it 'show debugger version' do
-    expect(help_output).to match(/Puppet Debugger Version: \d.\d\d?.\d+\n/)
+    expect(help_output).to match(/Puppet Debugger Version: \d.\d\d?.\d.*+\n/)
   end
 
   it 'show created by' do
     expect(help_output).to match(/Created by: NWOps <corey@nwops.io>\n/)
   end
-end
+end

data/spec/input_responders/krt_spec.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'puppet-debugger/plugin_test_helper'
 
 describe :krt do
-  include_examples "plugin_tests"
+  include_examples 'plugin_tests'
   let(:args) { [] }
 
   it 'works' do

data/spec/input_responders/play_spec.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'puppet-debugger/plugin_test_helper'
 describe :play do
-  include_examples "plugin_tests"
+  include_examples 'plugin_tests'
 
   describe 'convert  url' do
     describe 'unsupported' do
@@ -96,7 +98,6 @@ describe :play do
 
   describe 'multiple lines of input' do
     before(:each) do
-
     end
     describe '3 lines' do
       let(:input) do
@@ -133,16 +134,12 @@ describe :play do
     end
     describe 'multiple lines puppet code' do
       let(:input) do
-        <<-EOF
-if $osfamily {
-  $var = '3'
-}
-$var
-        EOF
-      end
-      xit do
-        plugin.play_back_string(input)
-        expect(output.string).to include('"3"')
+        <<~OUT
+          if $osfamily {
+            $var = '3'
+          }
+          $var
+        OUT
       end
     end
   end
@@ -158,17 +155,10 @@ $var
     let(:input) do
       "play #{file_url}"
     end
-    # requires internet and stops testing
-    xit 'url' do
-      allow(debugger).to receive(:fetch_url_data).with(file_url + '.txt').and_return(File.read(fixtures_file))
-      debugger.handle_input(input)
-      expect(output.string).to match(/test/)
-      expect(output.string).to match(/Puppet::Type::File/)
-    end
 
     it 'file' do
       debugger.handle_input("play #{fixtures_file}")
       expect(output.string).to match(/Puppet::Type::File/)
     end
   end
-end
+end

data/spec/input_responders/reset_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'puppet-debugger'
 require 'puppet-debugger/plugin_test_helper'

data/spec/input_responders/resources_spec.rb

@@ -1,13 +1,19 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'puppet-debugger'
 require 'puppet-debugger/plugin_test_helper'
 
 describe :resources do
   include_examples 'plugin_tests'
-  let(:args) { ["resources"] }
+  let(:args) {}
 
   it 'should be able to print resources' do
     debugger_output = /main/
     expect(plugin.run(args)).to match(debugger_output)
   end
+
+  it 'filter resources' do
+    expect(plugin.run(['settings'])).to match(/Settings/)
+  end
 end

data/spec/input_responders/set_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'puppet-debugger'
 require 'puppet-debugger/plugin_test_helper'
@@ -7,7 +9,7 @@ describe 'set' do
   let(:input) do
     ':set loglevel debug'
   end
-  
+
   it 'should set the loglevel' do
     debugger_output = /loglevel debug is set/
     debugger.handle_input(input)

data/spec/input_responders/stacktrace_spec.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'puppet-debugger'
+require 'puppet-debugger/plugin_test_helper'
+
+describe :stacktrace do
+  include_examples 'plugin_tests'
+  let(:args) {}
+
+  it 'should be able to print stacktrace' do
+    debugger_output = /stacktrace\snot\savailable/
+    expect(plugin.run(args)).to match(debugger_output)
+  end
+end

data/spec/input_responders/types_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'puppet-debugger'
 require 'puppet-debugger/plugin_test_helper'

data/spec/input_responders/vars_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'puppet-debugger'
 require 'puppet-debugger/plugin_test_helper'
@@ -38,10 +40,10 @@ describe :vars do
 
   describe 'list variables' do
     let(:input) do
-      <<-EOF
+      <<-OUT
       class test( $param1 = "files", $param2 = $param1 ) {}
       include test
-      EOF
+      OUT
     end
     it 'ls test' do
       debugger.handle_input(input)
@@ -49,7 +51,5 @@ describe :vars do
       expect(out).to include('"param1"')
       expect(out).to include('"param2"')
     end
-   
-
   end
 end

data/spec/input_responders/whereami_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'puppet-debugger'
 require 'puppet-debugger/plugin_test_helper'

data/spec/pdb_spec.rb

@@ -28,11 +28,6 @@ describe 'pdb' do
     expect(`bundle exec bin/pdb --play #{fixtures_file} --run-once`)
       .to match(/Puppet::Type::File/)
   end
-  # xit do
-  #   # this test does not work without internet, and I am at 30K feet right now
-  #   expect(`bundle exec bin/pdb --play #{file_url} --run-once`)
-  #     .to match(/Puppet::Type::File/)
-  # end
 
   describe 'remote_node' do
     let(:node_obj) do
@@ -44,9 +39,5 @@ describe 'pdb' do
     before :each do
       allow(PuppetDebugger).to receive(:get_remote_node).with(node_name).and_return(node_obj)
     end
-    # xit do
-    #   expect(`echo 'vars'| bundle exec bin/pdb -n #{node_name}`)
-    #     .to match(/server_facts/)
-    # end
   end
 end

data/spec/puppet/application/debugger_spec.rb

@@ -8,12 +8,15 @@ describe Puppet::Application::Debugger do
     Puppet::Application::Debugger.new(command_line)
   end
 
+  # ideally, we should only be providing args in stead of mocking the options
+  # however during a text, the options in the puppet application are not merged from
+  # the command line opts so the args never get passed through to options
   let(:args) do
     []
   end
 
   let(:command_line) do
-    Puppet::Util::CommandLine.new('debugger', args)
+    Puppet::Util::CommandLine.new('puppet', ['debugger', args].flatten)
   end
 
   let(:environment) do
@@ -53,6 +56,7 @@ describe Puppet::Application::Debugger do
   it 'shows describtion' do
     expect(debugger.help).to match(/^puppet-debugger\([^\)]+\) -- (.*)$/)
   end
+
   describe 'with facterdb' do
     before(:each) do
     end
@@ -68,13 +72,13 @@ describe Puppet::Application::Debugger do
 
     describe 'can reset correctly' do
       let(:input) do
-        <<-EOF
-$var1 = 'dsfasd'
-$var1
-reset
-$var1 = '111111'
-$var1
-        EOF
+        <<~OUT
+          $var1 = 'dsfasd'
+          $var1
+          reset
+          $var1 = '111111'
+          $var1
+        OUT
       end
 
       it 'assign variable' do
@@ -85,26 +89,40 @@ $var1
   end
 
   describe 'without facterdb' do
-    before(:each) do
-    end
     it 'run md5 function' do
       allow(debugger).to receive(:options).and_return(code: "md5('sdafsd')", quiet: true, run_once: true, use_facterdb: false)
       expect { debugger.run_command }.to output(/569ebc3d91672e7d3dce25de1684d0c9/).to_stdout
     end
+
     it 'assign variable' do
       allow(debugger).to receive(:options).and_return(code: "$var1 = 'blah'", quiet: true, run_once: true, use_facterdb: false)
       expect { debugger.run_command }.to output(/"blah"/).to_stdout
     end
 
+    describe 'import a catalog' do
+      let(:args) do
+        [
+          '--quiet', '--run_once', "--code='resources'",
+          "--catalog=#{File.expand_path(File.join(fixtures_dir, 'pe-xl-core-0.puppet.vm.json'))}"
+        ]
+      end
+      it 'list resources in catalog' do
+        allow(debugger).to receive(:options).and_return(code: 'resources',
+                                                        quiet: true, run_once: true, use_facterdb: true,
+                                                        catalog: File.expand_path(File.join(fixtures_dir, 'pe-xl-core-0.puppet.vm.json')))
+        expect { debugger.run_command }.to output(/Puppet_enterprise/).to_stdout
+      end
+    end
+
     describe 'can reset correctly' do
       let(:input) do
-        <<-EOF
-$var1 = 'dsfasd'
-$var1
-reset
-$var1 = '111111'
-$var1
-        EOF
+        <<~OUT
+          $var1 = 'dsfasd'
+          $var1
+          reset
+          $var1 = '111111'
+          $var1
+        OUT
       end
 
       it 'assign variable' do