puppet-community-rangefinder 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7986044b95869bd79c6a178eaca3144fd1e51ee9a3b03ade69f6d35defea98c1
-  data.tar.gz: 9dd7301b92a27c9e10ac645e07bbbfc4729c46389338072511ea9f2ded204ecf
+  metadata.gz: 1ca220be6aa4a132ea5446370c2be2e02fa5d4d391026eea586e24636f6010c8
+  data.tar.gz: 3aa913744e8abc0a9425ebe22e3dea4a32c957e1382df8eedda2c4241d055bbb
 SHA512:
-  metadata.gz: 693ebb9f951938e2da629f8d6cf85e5843bcdea5d2a11a69de0f93a23641fed57cd92dfe7c31e1ccbd11ec745898bdf840639ef4e77dffa617067ef607bccdf4
-  data.tar.gz: a74f95290fe024d045548783d8293cae30d2e25e7dd73d7f428ef3752f00a17635e53a57082e4f78090313347035ea676b1d7f3c3ae46e80c36d96a333208374
+  metadata.gz: 865fc5f2c07268fb2dcb18e23b1ac56eb9b700008fde3cdadf663470c9410a4fc85faa61242adb9c46b1c19c6c2977390216b18140636694070b8158f6d07ed2
+  data.tar.gz: d65542c4505d25adee4058818240870cdce74a0dd1a2ef04bb5178cf673a476a6f2870a07c68cd3afc834ce4b051cb3ec3f0de00976b4d8166b7fd5a4b5ea61c

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+# v0.0.2
+
+* better identification of WILL impact and MAY impact lists
+* eliminate edge cases which might lead to minor duplicate results
+
+
 # v0.0.1
 
 * Initial release.

data/README.md

@@ -5,12 +5,17 @@ Predicts downstream impact of breaking file changes
 
 Rangefinder provides a command that can infer what a file defines and then tell
 you what Forge modules use it. In other words, if you change the interface
-provided by that file -- this will tell you what Forge modules must adapt to it.
+provided by that file -- this will tell you what Forge modules must adapt to
+that change.
+
+If the file being evaluated is part of a Puppet module, then Rangefinder will
+use that module's `metadata.json` to identify the name, and then use it to
+fine-tune the way the results are presented.
 
 It will separate output by the modules that we *know* will be impacted and those
 which we can only *guess* that will be impacted. We can tell the difference based
-on whether the impacted module has properly described dependencies in their
-`metadata.json`.
+on whether the impacted module has properly described dependencies in their own
+`metadata.json` and whether `rangefinder` can figure out a dependency match.
 
 This currently knows how to interpret and look up:
 
@@ -41,9 +46,9 @@ Contact [me](mailto:ben.ford@puppet.com) for credentials.
 
 ## Running
 
-Just run the `rangefinder` command with a list of files in a Puppet module. If
-it knows what the file is, then it will print out a list of Forge modules that
-use the thing defined by that file.
+Just run the `rangefinder` command with a list of files. If it knows what the
+file defines, then it will print out a list of Forge modules that use the thing
+defined by that file.
 
 You can also `--render-as` either `json` or `yaml`.
 

data/lib/rangefinder/bigquery.rb

@@ -17,7 +17,7 @@ class Rangefinder::Bigquery
   end
 
   def find(namespace, kind, name)
-    sql = "SELECT module, i.source, m.source AS repo
+    sql = "SELECT DISTINCT module, i.source, m.source AS repo
            FROM `bto-dataops-datalake-prod.community.forge_itemized` AS i
            JOIN `bto-dataops-datalake-prod.community.forge_modules` AS m
              ON m.slug = i.module
@@ -25,11 +25,13 @@ class Rangefinder::Bigquery
 
     data = @dataset.query(sql, params: {kind: kind.to_s, name: name})
 
+    exact, near = data.partition {|row| row[:source] == namespace and not namespace.nil?}
+
     {
-      :kind => kind,
-      :name => name,
-      :exact => data.select {|row| row[:source] == namespace},
-      :near  => data.reject {|row| row[:source]},
+      :kind  => kind,
+      :name  => name,
+      :exact => exact,
+      :near  => near,
     }
   end
 end

data/lib/rangefinder/version.rb

@@ -1,3 +1,3 @@
 class Rangefinder
-  VERSION = '0.0.1'
+  VERSION = '0.0.2'
 end

metadata

@@ -1,41 +1,47 @@
 --- !ruby/object:Gem::Specification
 name: puppet-community-rangefinder
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Ben Ford
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-30 00:00:00.000000000 Z
+date: 2018-11-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puppet
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '7.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '7.0'
 - !ruby/object:Gem::Dependency
   name: google-cloud-bigquery
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">"
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">"
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
 description: |2