puppet-check 1.6.1 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4351237d9dbb4f8790fb4b3aa77dce9a3274b9146b566261ca089c4759c634ee
-  data.tar.gz: 4a6c8d9e48b456bea5a130e3984613f7cb923891c9fe6779ac481ffdc043a3c1
+  metadata.gz: 7f43468b01f25dba9ea6e997c982c632fb884d6cb8ec8faa31a670ac523a8ee8
+  data.tar.gz: 5baeb571e293b32c6120448d45c036523b96ffc0a325ba02c6f47e70323c1f3f
 SHA512:
-  metadata.gz: dcf4c5c9ec7906f130f8ae74f61b1efaab297d33276f1587c88ac68bea8f25a09aa1deeac0ede9cee835e0b2bed95b404e1a208649df29e76693d56a37ab867c
-  data.tar.gz: 1b4a1c372216d42d5e0e547e98a606866d0576da2e494d56340eb7a025e0f3763a9139ca18c24165a473c03429c1cf271ca0606017889e29dfbead14a0e5e7da
+  metadata.gz: f0ff327a57b78229800e56dae894b863ff0217d9ae8f368d7ff9db048160b29c0b1365144fb4db596c3951fafa4b5569d0c5ad741e7d0b3fa1a3491ed64fed50
+  data.tar.gz: 7b15f95dc0876eb1d8a6b9fa5295c45858fc7eef02ba6a2924c68ad29dadf6fa179c62ed32eae167923f39172eb9b1464910f48e7072dfaf8e9d98328dd6739e

data/CHANGELOG.md

@@ -1,4 +1,24 @@
-### 1.6.1 (Next)
+### 2.1.0 (Roadmap)
+- Minimum supported version of Puppet bumped to 5.0.
+- Minimum Ruby version bumped to 2.4.
+- Official support for Puppet 7, Rubocop 1, and Reek 6.
+- Fix Puppet message string transform conditionals.
+
+### 2.0.1
+- Check for existence of executables for dependency module retrieval.
+- Beta support for Puppet 7, Rubocop 1, and Reek 6.
+
+### 2.0.0
+- Bump minimum version of Puppet to 4.0.0 and remove < 4 support code.
+- Official support for Puppet 6.
+- Minimum Ruby version bumped to 2.2.0.
+- Bumped Rubocop and Reek minimum versions and fully migrated SPDX to Rubygems.
+- Add rubocop-performance extension to Rubocop.
+- Update manifest validation for breaking change in 6.5 API.
+- Fix check on specified dependencies in metadata.
+- Enable parallel module dependency retrieval.
+
+### 1.6.1
 - Removed check for hieradata nil/undef value for Hiera >= 5.
 - Add rudimentary checks for task metadata.
 - Preliminary support for Puppet 6.

data/README.md

@@ -1,5 +1,6 @@
 # Puppet Check
-[![Build Status](https://travis-ci.org/mschuchard/puppet-check.svg?branch=master)](https://travis-ci.org/mschuchard/puppet-check)
+[![Build Status](https://travis-ci.com/mschuchard/puppet-check.svg?branch=master)](https://travis-ci.com/mschuchard/puppet-check)
+[![CircleCI](https://circleci.com/gh/mschuchard/puppet-check.svg?style=svg)](https://circleci.com/gh/mschuchard/puppet-check)
 
 - [Description](#description)
 - [Usage](#usage)
@@ -124,14 +125,16 @@ The following files have unrecognized formats and therefore were not processed:
 ### What About Puppet Development Kit?
 The fairly recent release of the Puppet Development Kit (PDK) will hopefully eventually bring about the capability to test and validate your Puppet code and data in a streamlined, efficient, comprehensive, and accurate fashion comparable to Puppet Check. Unfortunately, the PDK has not yet achieved feature or efficiency parity with Puppet Check. The goal is for the PDK to one day replace Puppet Check and for Puppet Check to enter maintenance mode, but for now Puppet Check is still needed to lead Puppet testing.
 
+### What About PDK now?
+As of version 2.4.0 of the PDK, the PDK has essentially more or less achieved feature parity with Puppet Check. Although the PDK is not as efficient (including especially that Puppet Check executes significantly faster), it is still supported by Puppetlabs. Therefore, if you need an efficient and comprehensive Puppet validation solution, then you can still utilize Puppet Check, but the PDK is a recommended alternative for the future.
+
 ## Usage
-Please see the [Gemspec](puppet-check.gemspec) for dependency information.  All other dependencies should be fine with various versions. Puppet Check can be used with a CLI, Rake tasks, or API, from your system, rbenv, rvm, Docker, or Vagrant. Please note all interfaces (API by default, but can be modified) will ignore any directories named `fixtures` or specified paths with that directory during file checks and spec tests.
+Please see the [Gemspec](puppet-check.gemspec) for dependency information.  All other dependencies should be fine with various versions. Puppet Check can be used with a CLI, Rake tasks, or API, from your system, rbenv, rvm, Docker, or Vagrant. Please note all interfaces (API by default, but can be modified) will ignore any directories named `fixtures`, or specified paths with that directory during file checks and spec tests.
 
 ### CLI
 ```
 usage: puppet-check [options] paths
         --version                    Display the current version.
-    -f, --future                     Enable future parser
         --fail-on-warnings           Fail on warnings
     -s, --style                      Enable style checks
         --smoke                      Enable smoke testing
@@ -148,7 +151,7 @@ usage: puppet-check [options] paths
         --rubocop arg_one,arg_two    Arguments for Rubocop disabled cops
 ```
 
-The command line interface enables the ability to select the Puppet future parser, additional style checks besides the syntax checks, and to specify PuppetLint and Rubocop checks to ignore. If you require a more robust interface to PuppetLint, Rubocop, and Reek, then please use `.puppet-lint.rc`, `.rubocop.yml` and `*.reek` config files. The `.puppet-lint.rc` can be specified with the `-c` argument. If it is not specified, then PuppetLint will automatically load one from `.puppet-lint.rc`, `~/.puppet-lint.rc`, or `/etc/puppet-lint.rc`, in that order of preference. The nearest `.rubocop.yml` and `*.reek` will be automatically respected.
+The command line interface enables the ability to select additional style checks besides the syntax checks, and to specify PuppetLint and Rubocop checks to ignore. If you require a more robust interface to PuppetLint, Rubocop, and Reek, then please use `.puppet-lint.rc`, `.rubocop.yml` and `*.reek` config files. The `.puppet-lint.rc` can be specified with the `-c` argument. If it is not specified, then PuppetLint will automatically load one from `.puppet-lint.rc`, `~/.puppet-lint.rc`, or `/etc/puppet-lint.rc`, in that order of preference. The nearest `.rubocop.yml` and `*.reek` will be automatically respected.
 
 Example:
 ```
@@ -167,15 +170,14 @@ rake puppetcheck:kitchen:* # Execute Test Kitchen acceptance tests
 ```
 
 #### puppetcheck:file
-You can add style, smoke, and regression checks to and select the future parser for the `rake puppetcheck:file`, or change the output format, by adding the following after the require:
+You can add style, smoke, and regression checks to the `rake puppetcheck:file`, or change the output format, by adding the following after the require:
 
 ```ruby
 # example of modifying Puppet Check behavior
-PuppetCheck.settings[:style_check] = true
+PuppetCheck.settings[:style] = true
 PuppetCheck.settings[:fail_on_warnings] = true
-PuppetCheck.settings[:future_parser] = true
-PuppetCheck.settings[:smoke_check] = true
-PuppetCheck.settings[:regression_check] = true # in progress, do not use
+PuppetCheck.settings[:smoke] = true
+PuppetCheck.settings[:regression] = true # in progress, do not use
 PuppetCheck.settings[:public] = 'public.pem'
 PuppetCheck.settings[:private] = 'private.pem'
 PuppetCheck.settings[:output_format] = 'yaml'
@@ -256,11 +258,10 @@ If you are performing your Puppet testing from within a Ruby script or your own
 require 'puppet-check'
 
 settings = {}
-settings[:future_parser] = true # default false
 settings[:fail_on_warnings] = true # default false
-settings[:style_check] = true # default false
-settings[:smoke_check] = true # default false
-settings[:regression_check] = true # in progress, do not use; default false
+settings[:style] = true # default false
+settings[:smoke] = true # default false
+settings[:regression] = true # in progress, do not use; default false
 settings[:public] = 'public.pem' # default nil
 settings[:private] = 'private.pem' # default nil
 settings[:output_format] = 'yaml' # also 'json'; default 'text'
@@ -280,15 +281,15 @@ task.pattern = Dir.glob('**/{classes,defines,facter,functions,hosts,puppet,unit,
 
 ### Docker
 
-You can also use Puppet Check inside of Docker for quick, portable, and disposable testing. Below is an example Dockerfile for this purpose:
+You can also use Puppet Check inside of Docker for quick, portable, and disposable testing. Below is an example `Dockerfile` for this purpose:
 
 ```dockerfile
-# a reliable and small container at the moment
-FROM ubuntu:18.04
+# a reliable and small container; today should maybe use ruby:slim instead
+FROM ubuntu:20.04
 # you need ruby and any other extra dependencies that come from packages; in this example we install git to use it for downloading external module dependencies
 RUN apt-get update && apt-get install ruby git -y
-# you need puppet-check and any other extra dependencies that come from gems; in this example we install reek because the ruby ABI is 2.3 and then rspec-puppet and rake for extra testing
-RUN gem install --no-document puppet-check reek rspec-puppet rake
+# you need puppet-check and any other extra dependencies that come from gems; in this example we install rspec-puppet and rake for extra testing
+RUN gem install --no-document puppet-check rspec-puppet rake
 # this is needed for the ruby json parser to not flip out on fresh os installs for some reason (change encoding value as necessary)
 ENV LANG en_US.UTF-8
 # create the directory for your module, directory environment, etc. and change directory into it
@@ -299,24 +300,26 @@ COPY / .
 ENTRYPOINT ["rake", "puppetcheck"]
 ```
 
-You can also build your own general container for testing various Puppet situations by removing the last three lines. You can then test each module, directory environment, etc. on top of that container by merely adding and modifying the final three lines to a Dockerfile that uses the container you built from the first four lines. This is recommended usage due to being very efficient and stable.
+You can also build your own general container image for testing various Puppet situations by removing the last three lines. You can then test each module, directory environment, etc. on top of that container by merely adding and modifying the final three lines to a `Dockerfile` that uses the container you built from the first four lines. This is recommended usage due to being very efficient and stable.
+
+As an alternative to copying Puppet code and data into the image for testing, it is also recommended to bind volume mount the container to the directory with your Puppet code and data.
 
 ### Vagrant
 
-As an alternative to Docker, you can also use Vagrant for quick and disposable testing, but it is not as portable as Docker for these testing purposes. Below is an example Vagrantfile for this purpose.
+As an alternative to Docker, you can also use Vagrant for quick and disposable testing, but it is not as portable as Docker for these testing purposes. Below is an example `Vagrantfile` for this purpose.
 
 ```ruby
 Vagrant.configure(2) do |config|
   # a reliable and small box at the moment
-  config.vm.box = 'fedora/26-cloud-base'
+  config.vm.box = 'fedora/35-cloud-base'
 
   config.vm.provision 'shell', inline: <<-SHELL
     # cd to '/vagrant'
     cd /vagrant
     # you need ruby and any other extra dependencies that come from packages; in this example we install git to use it for downloading external module dependencies
     sudo dnf install ruby rubygems git -y
-    # you need puppet-check and any other extra dependencies that come from gems; in this example we install reek because the ruby ABI is 2.2 and then rspec-puppet and rake for extra testing
-    sudo gem install --no-document puppet-check reek rspec-puppet rake
+    # you need puppet-check and any other extra dependencies that come from gems; in this example we install rspec-puppet and rake for extra testing
+    sudo gem install --no-document puppet-check rspec-puppet rake
     # this is needed for the ruby json parser to not flip out on fresh os installs for some reason (change encoding value as necessary)
     export LANG='en_US.UTF-8'
     # execute your tests; in this example we are executing the full suite of tests
@@ -330,7 +333,7 @@ To overcome the lack of convenient portability, you could try spinning up the Va
 ### Exit Codes
 - 0: PuppetCheck exited with no internal exceptions or errors in your code and data.
 - 1: PuppetCheck exited with an internal exception (takes preference over other non-zero exit codes) or failed spec test(s).
-- 2: PuppetCheck exited with one or more errors in your code and data. Alternatively, PuppetCheck exited with one or more warnings in your code and data and you specified to fail on warnings.
+- 2: PuppetCheck exited with one or more errors in your code and data. Alternatively, PuppetCheck exited with one or more warnings in your code and data, and you specified to fail on warnings.
 
 ### Optional Dependencies
 - **rake** (gem): install this if you want to use Puppet Check with `rake` tasks in addition to the CLI.

data/lib/puppet-check/cli.rb

@@ -1,5 +1,5 @@
 require 'optparse'
-require_relative '../puppet-check'
+require_relative '../puppet_check'
 
 # the command line interface for PuppetCheck
 class PuppetCheck::CLI
@@ -27,16 +27,15 @@ class PuppetCheck::CLI
 
       # base options
       opts.on('--version', 'Display the current version.') do
-        puts 'puppet-check 1.6.1'
+        puts 'puppet-check 2.1.0'
         exit 0
       end
 
       # bool options
-      opts.on('-f', '--future', 'Enable future parser') { settings[:future_parser] = true }
       opts.on('--fail-on-warnings', 'Fail on warnings') { settings[:fail_on_warnings] = true }
-      opts.on('-s', '--style', 'Enable style checks') { settings[:style_check] = true }
-      opts.on('--smoke', 'Enable smoke testing') { settings[:smoke_check] = true }
-      opts.on('-r', '--regression', 'Enable regression testing (in progress, do not use)') { settings[:regression_check] = true }
+      opts.on('-s', '--style', 'Enable style checks') { settings[:style] = true }
+      opts.on('--smoke', 'Enable smoke testing') { settings[:smoke] = true }
+      opts.on('-r', '--regression', 'Enable regression testing (in progress, do not use)') { settings[:regression] = true }
 
       # ssl key options for eyaml checks
       opts.on('--public cert.pem', String, 'Public key for EYAML checks') { |arg| settings[:public] = arg }

data/lib/puppet-check/data_parser.rb

@@ -1,4 +1,4 @@
-require_relative '../puppet-check'
+require_relative '../puppet_check'
 
 # executes diagnostics on data files
 class DataParser
@@ -85,7 +85,7 @@ class DataParser
         # check metadata.json
         if File.basename(file) == 'metadata.json'
           # metadata-json-lint has issues and is essentially no longer maintained, so here is an improved and leaner version of it
-          require 'spdx-licenses'
+          require 'rubygems/util/licenses'
 
           # check for errors
           errors = []
@@ -97,7 +97,7 @@ class DataParser
 
           # check requirements and dependencies keys
           %w[requirements dependencies].each do |key|
-            # skip if key is missing or or value is an empty string, array, or hash
+            # skip if key is missing or value is an empty string, array, or hash
             next if !parsed.key?(key) || parsed[key].empty?
 
             # check that dependencies and requirements are an array of hashes
@@ -118,8 +118,8 @@ class DataParser
               next warnings.push("'#{req_dep['name']}' is missing an upper bound.") unless req_dep['version_requirement'].include?('<')
 
               # check for semantic versioning
-              if key == 'dependencies'
-                warnings.push("'#{req_dep['name']}' has non-semantic versioning in its 'version_requirement' key.") unless req_dep['version_requirement'] =~ /\d+\.\d+\.\d+.*\d+\.\d+\.\d+/
+              if key == 'dependencies' && req_dep['version_requirement'] !~ /\d+\.\d+\.\d+.*\d+\.\d+\.\d+/
+                warnings.push("'#{req_dep['name']}' has non-semantic versioning in its 'version_requirement' key.")
               end
             end
           end
@@ -161,16 +161,8 @@ class DataParser
           end
 
           # check for spdx license
-          begin
-            require 'rubygems/util/licenses'
-
-            if parsed.key?('license') && !Gem::Licenses.match?(parsed['license']) && parsed['license'] !~ /[pP]roprietary/
-              warnings.push("License identifier '#{parsed['license']}' is not in the SPDX list: http://spdx.org/licenses/")
-            end
-          rescue LoadError
-            if parsed.key?('license') && !SpdxLicenses.exist?(parsed['license']) && parsed['license'] !~ /[pP]roprietary/
-              warnings.push("License identifier '#{parsed['license']}' is not in the SPDX list: http://spdx.org/licenses/")
-            end
+          if parsed.key?('license') && !Gem::Licenses.match?(parsed['license']) && parsed['license'] !~ /[pP]roprietary/
+            warnings.push("License identifier '#{parsed['license']}' is not in the SPDX list: http://spdx.org/licenses/")
           end
         # assume this is task metadata if it has this key
         elsif parsed.key?('description')
@@ -185,16 +177,16 @@ class DataParser
             end
           end
           # check that parameters is a hash
-          if parsed.key?('parameters')
-            warnings.push('parameters value is not a Hash') unless parsed['parameters'].is_a?(Hash)
+          if parsed.key?('parameters') && !parsed['parameters'].is_a?(Hash)
+            warnings.push('parameters value is not a Hash')
           end
           # check that puppet_task_version is an integer
-          if parsed.key?('puppet_task_version')
-            warnings.push('puppet_task_version value is not an Integer') unless parsed['puppet_task_version'].is_a?(Integer)
+          if parsed.key?('puppet_task_version') && !parsed['puppet_task_version'].is_a?(Integer)
+            warnings.push('puppet_task_version value is not an Integer')
           end
           # check that supports_noop is a boolean
-          if parsed.key?('supports_noop')
-            warnings.push('supports_noop value is not a Boolean') unless parsed['supports_noop'].is_a?(TrueClass) || parsed['supports_noop'].is_a?(FalseClass)
+          if parsed.key?('supports_noop') && !(parsed['supports_noop'].is_a?(TrueClass) || parsed['supports_noop'].is_a?(FalseClass))
+            warnings.push('supports_noop value is not a Boolean')
           end
         # assume this is hieradata and ensure it is non-empty
         elsif parsed
@@ -213,7 +205,7 @@ class DataParser
     warnings = []
 
     # disregard nil/undef value data check if default values (common)
-    unless file =~ /^common/
+    unless /^common/.match?(file)
       data.each do |key, value|
         # check for nil values in the data (nil keys are fine)
         if (value.is_a?(Hash) && value.values.any?(&:nil?)) || value.nil?

data/lib/puppet-check/output_results.rb

@@ -1,4 +1,4 @@
-require_relative '../puppet-check'
+require_relative '../puppet_check'
 
 # class to handle outputting diagnostic results in desired format
 class OutputResults
@@ -22,7 +22,7 @@ class OutputResults
   end
 
   # output the results as yaml or json
-  def self.markup
+  def self.markup(format)
     # generate output hash
     hash = {}
     hash['errors'] = PuppetCheck.settings[:error_files] unless PuppetCheck.settings[:error_files].empty?
@@ -31,14 +31,15 @@ class OutputResults
     hash['ignored'] = PuppetCheck.settings[:ignored_files] unless PuppetCheck.settings[:ignored_files].empty?
 
     # convert hash to markup language
-    if PuppetCheck.settings[:output_format] == 'yaml'
+    case format
+    when 'yaml'
       require 'yaml'
       puts Psych.dump(hash, indentation: 2)
-    elsif PuppetCheck.settings[:output_format] == 'json'
+    when 'json'
       require 'json'
       puts JSON.pretty_generate(hash)
     else
-      raise "puppet-check: Unsupported output format '#{PuppetCheck.settings[:output_format]}' was specified."
+      raise "puppet-check: Unsupported output format '#{format}' was specified."
     end
   end
 end

data/lib/puppet-check/puppet_parser.rb

@@ -1,42 +1,51 @@
 require 'puppet'
-require_relative '../puppet-check'
+require_relative '../puppet_check'
 
 # executes diagnostics on puppet files
 class PuppetParser
   # checks puppet (.pp)
-  def self.manifest(files, future, style, pl_args)
+  def self.manifest(files, style, pl_args)
     require 'puppet/face'
 
     # prepare the Puppet settings for the error checking
     Puppet.initialize_settings unless Puppet.settings.app_defaults_initialized?
-    Puppet[:parser] = 'future' if future && (Puppet::PUPPETVERSION.to_i < 4)
 
     files.each do |file|
-      # setup error logging and collection
+      # setup error logging and collection; warnings logged for all versions, but errors for only puppet < 6.5
       errors = []
       Puppet::Util::Log.newdestination(Puppet::Test::LogCollector.new(errors))
 
       # check puppet syntax
       begin
-        Puppet::Face[:parser, :current].validate(file)
+        # initialize message
+        message = ''
+        # in puppet >= 6.5 the return of this method is a hash with the error
+        new_error = Puppet::Face[:parser, :current].validate(file)
+        # puppet 6.5 output format is now a hash from the face api
+        if Gem::Version.new(Puppet::PUPPETVERSION) >= Gem::Version.new('6.5.0') && new_error != {}
+          message = new_error.values.map(&:to_s).join("\n").gsub(/ \(file: #{File.absolute_path(file)}(, |\))/, '').gsub(/Could not parse.*: /, '')
+        end
       # this is the actual error that we need to rescue Puppet::Face from
       rescue SystemExit
-        # puppet 5.4-5.x has a new validator output format and eof errors have fake dir env info
-        if Puppet::PUPPETVERSION.to_f >= 5.4
-          next PuppetCheck.settings[:error_files].push("#{file}:\n#{errors.map(&:to_s).join("\n").gsub(/file: #{File.absolute_path(file)}(, |\))/, '').gsub(/Could not parse.*: /, '')}")
-        # puppet 5.0-5.2 can only do one error per line and outputs fake dir env info
-        elsif Puppet::PUPPETVERSION.to_f >= 5.0 && Puppet::PUPPETVERSION.to_f < 5.3
-          next PuppetCheck.settings[:error_files].push("#{file}:\n#{errors.map(&:to_s).join("\n").gsub("#{File.absolute_path(file)}:", '').gsub(/Could not parse.*: /, '')}")
-        end
-        # puppet < 5 and 5.3 parser output style
-        next PuppetCheck.settings[:error_files].push("#{file}:\n#{errors.map(&:to_s).join("\n").gsub("#{File.absolute_path(file)}:", '')}")
+        # puppet 5.4-6.4 has a new validator output format and eof errors have fake dir env info
+        message = if Gem::Version.new(Puppet::PUPPETVERSION) >= Gem::Version.new('5.4') && Gem::Version.new(Puppet::PUPPETVERSION) < Gem::Version.new('6.5')
+                    errors.map(&:to_s).join("\n").gsub(/file: #{File.absolute_path(file)}(, |\))/, '').gsub(/Could not parse.*: /, '')
+                  # puppet 5.0-5.2 can only do one error per line and outputs fake dir env info
+                  elsif Gem::Version.new(Puppet::PUPPETVERSION) >= Gem::Version.new('5.0') && Gem::Version.new(Puppet::PUPPETVERSION) < Gem::Version.new('5.3')
+                    errors.map(&:to_s).join("\n").gsub("#{File.absolute_path(file)}:", '').gsub(/Could not parse.*: /, '')
+                  # puppet < 5 and 5.3 parser output style
+                  else
+                    errors.map(&:to_s).join("\n").gsub("#{File.absolute_path(file)}:", '')
+                  end
       end
+      # output message
+      next PuppetCheck.settings[:error_files].push("#{file}:\n#{message}") unless message.empty?
 
       # initialize warnings with output from the parser if it exists, since the output is warnings if Puppet::Face did not trigger a SystemExit
       warnings = "#{file}:"
       unless errors.empty?
         # puppet 5.4-5.x has a new validator output format
-        warnings << if Puppet::PUPPETVERSION.to_f >= 5.4
+        warnings << if Gem::Version.new(Puppet::PUPPETVERSION) >= Gem::Version.new('5.4')
                       "\n#{errors.map(&:to_s).join("\n").gsub("file: #{File.absolute_path(file)}, ", '')}"
                     # puppet <= 5.3 validator output format
                     else
@@ -77,9 +86,6 @@ class PuppetParser
     require 'puppet/pops'
 
     files.each do |file|
-      # puppet before version 4 cannot check template syntax
-      next PuppetCheck.settings[:ignored_files].push("#{file}: ignored due to Puppet < 4") if Puppet::PUPPETVERSION.to_i < 4
-
       # check puppet template syntax
       begin
         # credits to gds-operations/puppet-syntax for the parser function call

data/lib/puppet-check/rspec_puppet_support.rb

@@ -3,7 +3,7 @@ class RSpecPuppetSupport
   # code diagram:
   # 'puppetcheck:spec' task invokes 'run'
   # 'run' invokes 'file_setup' always and 'dependency_setup' if metadata.json exists
-  # 'dependency_setup' invokes 'git/forge/hg' if dependencies exist and git/forge/hg is download option
+  # 'dependency_setup' invokes 'git/forge/svn/hg' if dependencies exist and git/forge/svn/hg is download option
   # 'git/forge/svn/hg' downloads module fixture appropriately
 
   # prepare the spec fixtures directory for rspec-puppet testing
@@ -15,10 +15,10 @@ class RSpecPuppetSupport
     # setup fixtures for rspec-puppet testing
     specdirs.each do |specdir|
       # skip to next specdir if it does not seem like a puppet module
-      next unless File.directory?(specdir + '/../manifests')
+      next unless File.directory?("#{specdir}/../manifests")
 
       # change to module directory
-      Dir.chdir(specdir + '/..')
+      Dir.chdir("#{specdir}/..")
 
       # grab the module name from the directory name of the module to pass to file_setup
       file_setup(File.basename(Dir.pwd))
@@ -66,7 +66,7 @@ class RSpecPuppetSupport
     parsed = JSON.parse(File.read('metadata.json'))
 
     # grab dependencies if they exist
-    return if parsed['dependencies'].empty?
+    return unless parsed.key?('dependencies')
     parsed['dependencies'].each do |dependency_hash|
       # determine how the user wants to download the module dependency
       if dependency_hash.key?('git')
@@ -81,6 +81,7 @@ class RSpecPuppetSupport
         warn "#{dependency_hash['name']} has an unspecified, or specified but unsupported, download method."
       end
     end
+    Process.waitall
   end
 
   # download external module dependency with git
@@ -89,7 +90,11 @@ class RSpecPuppetSupport
     # establish path to clone module to
     path = "spec/fixtures/modules/#{File.basename(git_url, '.git')}"
     # is the module present and already cloned with git? do a pull; otherwise, do a clone
-    File.directory?("#{path}/.git") ? system("git -C #{path} pull") : system("git clone #{args} #{git_url} #{path}")
+    begin
+      File.directory?("#{path}/.git") ? spawn("git -C #{path} pull") : spawn("git clone #{args} #{git_url} #{path}")
+    rescue Errno::ENOENT
+      warn 'git is not installed and cannot be used to retrieve dependency modules'
+    end
   end
 
   # download external module dependency with forge
@@ -97,7 +102,7 @@ class RSpecPuppetSupport
     private_class_method :method
     # is the module present? do an upgrade; otherwise, do an install
     subcommand = File.directory?("spec/fixtures/modules/#{forge_name}") ? 'upgrade' : 'install'
-    system("puppet module #{subcommand} --modulepath spec/fixtures/modules/ #{args} #{forge_name}")
+    spawn("puppet module #{subcommand} --modulepath spec/fixtures/modules/ #{args} #{forge_name}")
   end
 
   # download external module dependency with svn
@@ -106,7 +111,11 @@ class RSpecPuppetSupport
     # establish path to checkout module to
     path = "spec/fixtures/modules/#{File.basename(svn_url)}"
     # is the module present and already checked out with svn? do an update; otherwise, do a checkout
-    File.directory?("#{path}/.svn") ? system("svn update #{path}") : system("svn co #{args} #{svn_url} #{path}")
+    begin
+      File.directory?("#{path}/.svn") ? spawn("svn update #{path}") : spawn("svn co #{args} #{svn_url} #{path}")
+    rescue Errno::ENOENT
+      warn 'subversion is not installed and cannot be used to retrieve dependency modules'
+    end
   end
 
   # download external module dependency with hg
@@ -115,6 +124,10 @@ class RSpecPuppetSupport
     # establish path to clone module to
     path = "spec/fixtures/modules/#{File.basename(hg_url)}"
     # is the module present and already cloned with hg? do a pull and update; otherwise do a clone
-    File.directory?("#{path}/.hg") ? system("hg --cwd #{path} pull; hg --cwd #{path} update") : system("hg clone #{args} #{hg_url} #{path}")
+    begin
+      File.directory?("#{path}/.hg") ? spawn("hg --cwd #{path} pull; hg --cwd #{path} update") : spawn("hg clone #{args} #{hg_url} #{path}")
+    rescue Errno::ENOENT
+      warn 'mercurial is not installed and cannot be used to retrieve dependency modules'
+    end
   end
 end

data/lib/puppet-check/ruby_parser.rb

@@ -1,4 +1,4 @@
-require_relative '../puppet-check'
+require_relative '../puppet_check'
 require_relative 'utils'
 
 # executes diagnostics on ruby files
@@ -18,7 +18,7 @@ class RubyParser
           require 'rubocop'
 
           # check RuboCop and collect warnings
-          rubocop_warnings = Utils.capture_stdout { RuboCop::CLI.new.run(rc_args + ['--format', 'emacs', file]) }
+          rubocop_warnings = Utils.capture_stdout { RuboCop::CLI.new.run(rc_args + ['--require', 'rubocop-performance', '--format', 'emacs', file]) }
           warnings = rubocop_warnings == '' ? '' : rubocop_warnings.split("#{File.absolute_path(file)}:").join('')
 
           # check Reek and collect warnings
@@ -43,8 +43,14 @@ class RubyParser
       # check ruby template syntax
       begin
         # need to eventually have this associated with a different binding during each iteration
-        warnings = Utils.capture_stderr { ERB.new(File.read(file), nil, '-').result }
-        # ERB.new(File.read(file), nil, '-').result(RubyParser.new.bind)
+        # older usage throws extra warning and mixes with valid warnings confusingly
+        warnings = if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.6')
+                     Utils.capture_stderr { ERB.new(File.read(file), trim_mode: '-').result }
+                     # ERB.new(File.read(file), trim_mode: '-').result(RubyParser.new.bind)
+                   # and for extra fun it is incompatible with non-new ruby
+                   else
+                     Utils.capture_stderr { ERB.new(File.read(file), nil, '-').result }
+                   end
       rescue NameError, TypeError
         # empty out warnings since it would contain an error if this pass triggers
         warnings = ''
@@ -62,10 +68,9 @@ class RubyParser
     # efficient var assignment prior to iterator
     if style
       require 'rubocop'
-      # cop named differently depending upon version
-      filename_cop = RuboCop::Version::STRING.to_f >= 0.5 ? 'Naming/FileName' : 'Style/FileName'
+
       # RuboCop is grumpy about non-snake_case filenames so disable the FileName check
-      rc_args.include?('--except') ? rc_args[rc_args.index('--except') + 1] = "#{rc_args[rc_args.index('--except') + 1]},#{filename_cop}" : rc_args.concat(['--except', filename_cop])
+      rc_args.include?('--except') ? rc_args[rc_args.index('--except') + 1] = "#{rc_args[rc_args.index('--except') + 1]},Naming/FileName" : rc_args.concat(['--except', 'Naming/FileName'])
     end
 
     files.each do |file|
@@ -79,7 +84,7 @@ class RubyParser
       else
         if style
           # check Rubocop
-          warnings = Utils.capture_stdout { RuboCop::CLI.new.run(rc_args + ['--format', 'emacs', file]) }
+          warnings = Utils.capture_stdout { RuboCop::CLI.new.run(rc_args + ['--require', 'rubocop-performance', '--format', 'emacs', file]) }
 
           # collect style warnings
           next PuppetCheck.settings[:warning_files].push("#{file}:\n#{warnings.split("#{File.absolute_path(file)}:").join('')}") unless warnings.empty?

data/lib/puppet-check/tasks.rb

@@ -3,7 +3,7 @@ begin
 rescue LoadError
   raise 'Rake is not installed and you are attempting to execute Rake tasks with Puppet Check. Please install Rake before continuing.'
 end
-require_relative '../puppet-check'
+require_relative '../puppet_check'
 
 # the rake interface for PuppetCheck
 class PuppetCheck::Tasks < ::Rake::TaskLib