puppet-check 1.5.0 → 2.0.1

Sign up to get free protection for your applications and to get access to all the features.
Files changed (25) hide show
  1. checksums.yaml +5 -5
  2. data/CHANGELOG.md +39 -4
  3. data/README.md +35 -50
  4. data/lib/puppet-check.rb +63 -47
  5. data/lib/puppet-check/cli.rb +21 -17
  6. data/lib/puppet-check/data_parser.rb +55 -28
  7. data/lib/puppet-check/output_results.rb +5 -4
  8. data/lib/puppet-check/puppet_parser.rb +31 -16
  9. data/lib/puppet-check/rspec_puppet_support.rb +34 -11
  10. data/lib/puppet-check/ruby_parser.rb +6 -8
  11. data/lib/puppet-check/tasks.rb +17 -13
  12. data/spec/fixtures/manifests/eof_syntax.pp +4 -0
  13. data/spec/fixtures/task_metadata/task_bad.json +10 -0
  14. data/spec/fixtures/task_metadata/task_good.json +16 -0
  15. data/spec/puppet-check/cli_spec.rb +9 -43
  16. data/spec/puppet-check/data_parser_spec.rb +27 -11
  17. data/spec/puppet-check/output_results_spec.rb +9 -18
  18. data/spec/puppet-check/puppet_parser_spec.rb +22 -18
  19. data/spec/puppet-check/regression_check_spec.rb +1 -3
  20. data/spec/puppet-check/rspec_puppet_support_spec.rb +5 -1
  21. data/spec/puppet-check/ruby_parser_spec.rb +8 -4
  22. data/spec/puppet-check/tasks_spec.rb +13 -3
  23. data/spec/puppet-check_spec.rb +11 -12
  24. data/spec/system/system_spec.rb +8 -14
  25. metadata +51 -32
data/spec/system/system_spec.rb CHANGED
@@ -17,15 +17,9 @@ describe PuppetCheck do
17
17
 
18
18
  expect { cli }.not_to raise_exception
19
19
 
20
- expect(PuppetCheck.settings[:error_files].length).to eql(8)
21
- # stupid Puppet deprecation warning
22
- if RUBY_VERSION.to_f < 2.1
23
- expect(PuppetCheck.settings[:warning_files].length).to eql(10)
24
- expect(PuppetCheck.settings[:clean_files].length).to eql(10)
25
- else
26
- expect(PuppetCheck.settings[:warning_files].length).to eql(9)
27
- expect(PuppetCheck.settings[:clean_files].length).to eql(11)
28
- end
20
+ expect(PuppetCheck.settings[:error_files].length).to eql(9)
21
+ expect(PuppetCheck.settings[:warning_files].length).to eql(10)
22
+ expect(PuppetCheck.settings[:clean_files].length).to eql(12)
29
23
  expect(PuppetCheck.settings[:ignored_files].length).to eql(6)
30
24
 
31
25
  expect(cli).to eql(2)
@@ -44,19 +38,19 @@ describe PuppetCheck do
44
38
  PuppetCheck.settings[:warning_files] = []
45
39
  PuppetCheck.settings[:clean_files] = []
46
40
  PuppetCheck.settings[:ignored_files] = []
47
- PuppetCheck.settings[:style_check] = true
41
+ PuppetCheck.settings[:style] = true
48
42
  # see regression_check_spec
49
43
  unless File.directory?('/home/travis')
50
- PuppetCheck.settings[:smoke_check] = true
44
+ PuppetCheck.settings[:smoke] = true
51
45
  PuppetCheck.settings[:octonodes] = %w[good.example.com]
52
46
  PuppetCheck.settings[:octoconfig] = 'spec/octocatalog-diff/octocatalog-diff.cfg.rb'
53
47
  end
54
48
 
55
49
  expect { tasks }.not_to raise_exception
56
50
 
57
- expect(PuppetCheck.settings[:error_files].length).to eql(8)
58
- expect(PuppetCheck.settings[:warning_files].length).to eql(9)
59
- expect(PuppetCheck.settings[:clean_files].length).to eql(11)
51
+ expect(PuppetCheck.settings[:error_files].length).to eql(9)
52
+ expect(PuppetCheck.settings[:warning_files].length).to eql(10)
53
+ expect(PuppetCheck.settings[:clean_files].length).to eql(12)
60
54
  expect(PuppetCheck.settings[:ignored_files].length).to eql(6)
61
55
  end
62
56
  end
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: puppet-check
3
3
  version: !ruby/object:Gem::Version
4
- version: 1.5.0
4
+ version: 2.0.1
5
5
  platform: ruby
6
6
  authors:
7
7
  - Matt Schuchard
8
- autorequire:
8
+ autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2017-11-10 00:00:00.000000000 Z
11
+ date: 2021-03-22 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: puppet
@@ -16,56 +16,76 @@ dependencies:
16
16
  requirements:
17
17
  - - ">="
18
18
  - !ruby/object:Gem::Version
19
- version: '3.4'
19
+ version: '4.0'
20
20
  - - "<"
21
21
  - !ruby/object:Gem::Version
22
- version: '6'
22
+ version: '8'
23
23
  type: :runtime
24
24
  prerelease: false
25
25
  version_requirements: !ruby/object:Gem::Requirement
26
26
  requirements:
27
27
  - - ">="
28
28
  - !ruby/object:Gem::Version
29
- version: '3.4'
29
+ version: '4.0'
30
30
  - - "<"
31
31
  - !ruby/object:Gem::Version
32
- version: '6'
32
+ version: '8'
33
33
  - !ruby/object:Gem::Dependency
34
- name: rubocop
34
+ name: puppet-lint
35
35
  requirement: !ruby/object:Gem::Requirement
36
36
  requirements:
37
37
  - - "~>"
38
38
  - !ruby/object:Gem::Version
39
- version: '0'
39
+ version: '2.0'
40
40
  type: :runtime
41
41
  prerelease: false
42
42
  version_requirements: !ruby/object:Gem::Requirement
43
43
  requirements:
44
44
  - - "~>"
45
45
  - !ruby/object:Gem::Version
46
- version: '0'
46
+ version: '2.0'
47
47
  - !ruby/object:Gem::Dependency
48
- name: puppet-lint
48
+ name: reek
49
49
  requirement: !ruby/object:Gem::Requirement
50
50
  requirements:
51
51
  - - ">="
52
52
  - !ruby/object:Gem::Version
53
- version: 1.1.0
53
+ version: '4.0'
54
54
  - - "<"
55
55
  - !ruby/object:Gem::Version
56
- version: '3'
56
+ version: '7'
57
57
  type: :runtime
58
58
  prerelease: false
59
59
  version_requirements: !ruby/object:Gem::Requirement
60
60
  requirements:
61
61
  - - ">="
62
62
  - !ruby/object:Gem::Version
63
- version: 1.1.0
63
+ version: '4.0'
64
64
  - - "<"
65
65
  - !ruby/object:Gem::Version
66
- version: '3'
66
+ version: '7'
67
67
  - !ruby/object:Gem::Dependency
68
- name: spdx-licenses
68
+ name: rubocop
69
+ requirement: !ruby/object:Gem::Requirement
70
+ requirements:
71
+ - - ">="
72
+ - !ruby/object:Gem::Version
73
+ version: '0.58'
74
+ - - "<"
75
+ - !ruby/object:Gem::Version
76
+ version: '2'
77
+ type: :runtime
78
+ prerelease: false
79
+ version_requirements: !ruby/object:Gem::Requirement
80
+ requirements:
81
+ - - ">="
82
+ - !ruby/object:Gem::Version
83
+ version: '0.58'
84
+ - - "<"
85
+ - !ruby/object:Gem::Version
86
+ version: '2'
87
+ - !ruby/object:Gem::Dependency
88
+ name: rubocop-performance
69
89
  requirement: !ruby/object:Gem::Requirement
70
90
  requirements:
71
91
  - - "~>"
@@ -96,22 +116,16 @@ dependencies:
96
116
  name: rake
97
117
  requirement: !ruby/object:Gem::Requirement
98
118
  requirements:
99
- - - ">="
100
- - !ruby/object:Gem::Version
101
- version: '9'
102
- - - "<"
119
+ - - "~>"
103
120
  - !ruby/object:Gem::Version
104
- version: '13'
121
+ version: '12.0'
105
122
  type: :development
106
123
  prerelease: false
107
124
  version_requirements: !ruby/object:Gem::Requirement
108
125
  requirements:
109
- - - ">="
110
- - !ruby/object:Gem::Version
111
- version: '9'
112
- - - "<"
126
+ - - "~>"
113
127
  - !ruby/object:Gem::Version
114
- version: '13'
128
+ version: '12.0'
115
129
  - !ruby/object:Gem::Dependency
116
130
  name: rspec
117
131
  requirement: !ruby/object:Gem::Requirement
@@ -129,7 +143,7 @@ dependencies:
129
143
  description: Puppet Check is a gem that provides a comprehensive, streamlined, and
130
144
  efficient analysis of the syntax, style, and validity of your entire Puppet code
131
145
  and data.
132
- email:
146
+ email:
133
147
  executables:
134
148
  - puppet-check
135
149
  extensions: []
@@ -167,6 +181,7 @@ files:
167
181
  - spec/fixtures/librarian_good/Puppetfile
168
182
  - spec/fixtures/librarian_style/Puppetfile
169
183
  - spec/fixtures/librarian_syntax/Puppetfile
184
+ - spec/fixtures/manifests/eof_syntax.pp
170
185
  - spec/fixtures/manifests/good.pp
171
186
  - spec/fixtures/manifests/style_lint.pp
172
187
  - spec/fixtures/manifests/style_parser.pp
@@ -178,6 +193,8 @@ files:
178
193
  - spec/fixtures/metadata_syntax/metadata.json
179
194
  - spec/fixtures/spec/facter/facter_spec.rb
180
195
  - spec/fixtures/spec/fixtures/do_not_parse_me
196
+ - spec/fixtures/task_metadata/task_bad.json
197
+ - spec/fixtures/task_metadata/task_good.json
181
198
  - spec/fixtures/templates/good.epp
182
199
  - spec/fixtures/templates/good.erb
183
200
  - spec/fixtures/templates/no_method_error.erb
@@ -204,7 +221,7 @@ homepage: https://www.github.com/mschuchard/puppet-check
204
221
  licenses:
205
222
  - MIT
206
223
  metadata: {}
207
- post_install_message:
224
+ post_install_message:
208
225
  rdoc_options: []
209
226
  require_paths:
210
227
  - lib
@@ -212,16 +229,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
212
229
  requirements:
213
230
  - - ">="
214
231
  - !ruby/object:Gem::Version
215
- version: 2.0.0
232
+ version: 2.2.0
216
233
  required_rubygems_version: !ruby/object:Gem::Requirement
217
234
  requirements:
218
235
  - - ">="
219
236
  - !ruby/object:Gem::Version
220
237
  version: '0'
221
238
  requirements: []
222
- rubyforge_project:
223
- rubygems_version: 2.5.2
224
- signing_key:
239
+ rubygems_version: 3.1.2
240
+ signing_key:
225
241
  specification_version: 4
226
242
  summary: A streamlined comprehensive set of checks for your entire Puppet code and
227
243
  data
@@ -244,6 +260,7 @@ test_files:
244
260
  - spec/fixtures/librarian_good/Puppetfile
245
261
  - spec/fixtures/librarian_style/Puppetfile
246
262
  - spec/fixtures/librarian_syntax/Puppetfile
263
+ - spec/fixtures/manifests/eof_syntax.pp
247
264
  - spec/fixtures/manifests/good.pp
248
265
  - spec/fixtures/manifests/style_lint.pp
249
266
  - spec/fixtures/manifests/style_parser.pp
@@ -255,6 +272,8 @@ test_files:
255
272
  - spec/fixtures/metadata_syntax/metadata.json
256
273
  - spec/fixtures/spec/facter/facter_spec.rb
257
274
  - spec/fixtures/spec/fixtures/do_not_parse_me
275
+ - spec/fixtures/task_metadata/task_bad.json
276
+ - spec/fixtures/task_metadata/task_good.json
258
277
  - spec/fixtures/templates/good.epp
259
278
  - spec/fixtures/templates/good.erb
260
279
  - spec/fixtures/templates/no_method_error.erb