puntopagos 0.0.2 → 0.1.1

data/.gitignore

@@ -2,3 +2,4 @@
 .bundle
 Gemfile.lock
 pkg/*
+config/puntopagos.yml

data/lib/puntopagos/authorization.rb

@@ -0,0 +1,14 @@
+require 'base64'
+require 'openssl'
+
+module PuntoPagos
+  class Authorization
+    def initialize env = nil
+      @@config ||= PuntoPagos::Config.new(env)
+    end
+
+    def sign(string)
+      "PP "+@@config.puntopagos_key+":"+ Base64.encode64(OpenSSL::HMAC.digest('sha1',@@config.puntopagos_secret, string)).chomp
+    end
+  end
+end

data/lib/puntopagos/config.rb

@@ -3,13 +3,13 @@ require 'yaml'
 module PuntoPagos
   class Config
     PUNTOPAGOS_BASE_URL = {
-      :production => "https://www.puntopagos.com",
-      :sandbox => "https://sandbox.puntopagos.com"
+      :production => "https://www.puntopagos.com/",
+      :sandbox => "https://sandbox.puntopagos.com/"
     }
     
     attr_accessor :config_filepath, :puntopagos_base_url, :puntopagos_key, :puntopagos_secret
     
-    def initialize(env = nil, config_override = nil)
+    def initialize env = nil, config_override = nil
       if env
         # For non-rails apps
         @config_filepath = File.join(File.dirname(__FILE__), "..", "..", "config", "puntopagos.yml")

data/lib/puntopagos/executioner.rb

@@ -0,0 +1,32 @@
+require 'json'
+require 'rest_client'
+
+module PuntoPagos
+  class Executioner
+    def initialize env = nil
+      @@config ||= PuntoPagos::Config.new(env)
+      @@puntopagos_base_url ||= @@config.puntopagos_base_url
+    end
+
+    def call_api data, path, method, signature, timestamp
+      #hack fix: JSON.unparse doesn't work in Rails 2.3.5; only {}.to_json does..
+      headers = set_headers(signature, timestamp)
+      api_request_data = JSON.unparse(data) rescue data.to_json
+      resp = RestClient.method(method).call(@@puntopagos_base_url+path, data.to_json, headers)
+      JSON.parse(resp)
+    end
+
+    private
+
+    def set_headers signature, timestamp
+      headers = {
+        'User-Agent' => "puntopagos-ruby-#{PuntoPagos::VERSION}",
+        'Accept' => 'application/json',
+        'Accept-Charset' => 'utf-8',
+        'Content-Type'  => 'application/json; charset=utf-8',
+        'Fecha'         => timestamp,
+        'Autorizacion'  => signature
+      }
+    end
+  end
+end

data/lib/puntopagos/notification.rb

@@ -0,0 +1,22 @@
+module PuntoPagos
+  class Notification
+    def initialize env = nil
+      @env = env
+      @@config ||= PuntoPagos::Config.new(@env)
+      @@function = "transaccion/notificar"
+    end
+
+    def correct? token, trx_id, amount, timestamp, pp_signature
+      message = create_message token, trx_id, amount, timestamp
+      authorization = Authorization.new(@env)
+      signature = authorization.sign(message)
+      signature == pp_signature
+    end
+
+    private
+
+    def create_message token, trx_id, amount, timestamp
+      @@function + "\n" + token + "\n" + trx_id + "\n" + amount + "\n" + timestamp
+    end
+  end
+end

data/lib/puntopagos/request.rb

@@ -5,59 +5,55 @@ require 'rest_client'
 
 
 module PuntoPagos
-  
+
   class NoDataError < Exception
   end
-  
+
   class Request
-    
-      def initialize(env = nil)
-        @env = env
-        @@config ||= PuntoPagos::Config.new(@env)
-        @@puntopagos_base_url ||= @@config.puntopagos_base_url
-      end   
-
-      def validate
-        #TODO validate JSON must have monto and trx_id
-      end
-
-      def create(data)
-        raise NoDataError unless data
-        get_headers("transaccion/crear",data)
-        response_data = call_api(data, "/TransactionService/crear", :post)
-        PuntoPagos::Response.new(response_data, @env)
-      end
-      
-    
+    def initialize env = nil
+      @env = env
+      @@config ||= PuntoPagos::Config.new(@env)
+      @@puntopagos_base_url ||= @@config.puntopagos_base_url
+      @@function = "transaccion/crear"
+    end
+
+    def validate
+      #TODO validate JSON must have monto and trx_id
+    end
+
+    def create trx_id, amount, payment_type = nil
+      raise NoDataError unless trx_id and amount
+      data = create_data trx_id, amount, payment_type
+
+      timestamp = get_timestamp
+
+      message = create_message(data['trx_id'], data['monto'], timestamp)
+      authorization = PuntoPagos::Authorization.new(@env)
+      signature = authorization.sign(message)
+      executioner = PuntoPagos::Executioner.new(@env)
+
+      response_data = executioner.call_api(data, @@function, :post, signature, timestamp)
+      PuntoPagos::Response.new(response_data, @env)
+    end
+
 
 private
 
-      def get_headers(function, data)
-        raise NoDataError unless data
-        
-        timestamp = Time.now.strftime("%a, %d %b %Y %H:%M:%S GMT")
-        message   = function+"\n"+data['trx_id'].to_s+"\n"+data['monto'].to_s+"\n"+timestamp
-        signature = "PP "+@@config.puntopagos_key+":"+sign(message).chomp!
-        @@headers = {
-          'User-Agent' => "puntopagos-ruby-#{PuntoPagos::VERSION}", 
-          'Accept' => 'application/json',
-          'Accept-Charset' => 'utf-8',
-          'Content-Type'  => 'application/json; charset=utf-8',
-          'Fecha'         => timestamp,
-          'Autorizacion'  => signature
-           }
-      end
-
-      def call_api(data, path, method)
-        #hack fix: JSON.unparse doesn't work in Rails 2.3.5; only {}.to_json does..
-        api_request_data = JSON.unparse(data) rescue data.to_json
-        resp = RestClient.method(method).call(@@puntopagos_base_url+path, data.to_json, @@headers)
-        
-        JSON.parse(resp)
-      end
-      
-      def sign(string)
-          Base64.encode64(OpenSSL::HMAC.digest('sha1',@@config.puntopagos_secret, string))
-      end
+    def create_message trx_id, amount, timestamp
+      @@function + "\n" + trx_id + "\n" + amount + "\n" + timestamp
+    end
+
+    def create_data trx_id, amount, payment_type = nil
+      data = {}
+      data['trx_id']      = trx_id
+      data['monto']       = amount
+      data['medio_pago']  = payment_type if payment_type
+      data
     end
+
+    def get_timestamp
+      Time.now.strftime("%a, %d %b %Y %H:%M:%S GMT")
+    end
+
+  end
 end

data/lib/puntopagos/response.rb

@@ -4,25 +4,25 @@ module PuntoPagos
       @@config ||= PuntoPagos::Config.new(env)
       @@puntopagos_base_url ||= @@config.puntopagos_base_url
       @@response = response
-      
+
     end
-    
+
     # TODO validate JSON
     def success?
       @@response["respuesta"] == "00"
     end
-    
+
     def get_token
       @@response["token"]
     end
-    
+
     def get_error
       @@response["error"]
     end
-    
+
     def payment_process_url
       @@puntopagos_base_url + "/transaccion/procesar/"+get_token
     end
-    
+
   end
 end

data/lib/puntopagos/version.rb

@@ -1,3 +1,3 @@
 module PuntoPagos
-  VERSION = "0.0.2"
+  VERSION = "0.1.1"
 end

data/lib/puntopagos.rb

@@ -1,4 +1,6 @@
 require File.join(File.dirname(__FILE__),"puntopagos/config")
+require File.join(File.dirname(__FILE__),"puntopagos/authorization")
+require File.join(File.dirname(__FILE__),"puntopagos/executioner")
 require File.join(File.dirname(__FILE__),"puntopagos/request")
 require File.join(File.dirname(__FILE__),"puntopagos/response")
 require File.join(File.dirname(__FILE__),"puntopagos/version")

data/test/unit/create_request_test.rb

@@ -2,36 +2,37 @@ require 'test_helper'
 
 
 class CreateRequestTest < Test::Unit::TestCase
-  
-  def setup 
-    @req = PuntoPagos::Request.new('test')
+
+  def setup
+    @req = PuntoPagos::Request.new('production')
   end
-  
+
   def test_valid_create
     puts "-------"
     puts "webpay valid"
-    
-    data = { 
+
+    data = {
   		"trx_id" 	=> "#{Time.now.to_i}",
-  		"monto"		=> "100.00"
-  		}    
-  	resp = @req.create(data)
-    
-    assert resp.success? == true
-    
+  		"monto"		=> "100.00",
+  		"medio_pago" => "3"
+  		}
+  	resp = @req.create("#{Time.now.to_i}", "100.00")
+    puts "RESP: #{resp.success?}"
+    assert resp.success? == true, "Pass"
+
 #    payload = YAML.load_file(File.join(File.dirname(__FILE__),"..", "data","webpay_paylaod.yml"))
   end
-  
+
   def test_invalid_webpay_pay
     puts "webpay invalid"
-    
-    data = { 
+
+    data = {
   		'trx_id' 	=> "#{Time.now.to_i}"
-  		}    
-  	resp = @req.create(data)
-    
-    assert resp.success? == false, "Pass"
-    
+  		}
+  	resp = @req.create("#{Time.now.to_i}","10")
+
+    assert resp.success? == false
+
   end
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: puntopagos
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -14,7 +14,7 @@ date: 2012-06-15 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
-  requirement: &2162551120 !ruby/object:Gem::Requirement
+  requirement: &2156966000 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -22,7 +22,7 @@ dependencies:
         version: 1.6.7
   type: :runtime
   prerelease: false
-  version_requirements: *2162551120
+  version_requirements: *2156966000
 description: Ruby wrapper for PuntoPagos Payment API
 email:
 - imella@acid.cl
@@ -35,10 +35,12 @@ files:
 - LICENSE
 - README.textile
 - Rakefile
-- config/puntopagos.yml
 - init.rb
 - lib/puntopagos.rb
+- lib/puntopagos/authorization.rb
 - lib/puntopagos/config.rb
+- lib/puntopagos/executioner.rb
+- lib/puntopagos/notification.rb
 - lib/puntopagos/request.rb
 - lib/puntopagos/response.rb
 - lib/puntopagos/version.rb

data/config/puntopagos.yml

@@ -1,4 +0,0 @@
-test:
-  environment:        "sandbox"
-  puntopagos_key:     "YOUR_API_KEY"
-  puntopagos_secret:  "YOUR_API_SECRET"