punto_pagos_rails 0.2.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 38ee4d459254a4db352d99772377056e970256bd
-  data.tar.gz: cb7cb0328bec57a0d1372a3bd63f1a8afc024937
+  metadata.gz: 766fc75b98ecaeba6d4646dce50a465f01064ba5
+  data.tar.gz: 8fb4e1bde5b72af2bdd901dc6c375cf76ba1a55f
 SHA512:
-  metadata.gz: d0a4dbd040088c855bb2bb90d124cdcfa6f1f4955aa99a7a6ad17faaaa884bc29310bb75a885e80d434e235667c2ee221549e801becca94623a0313ca1c19207
-  data.tar.gz: 25c12ef1d73c0553186b23d97a20594b0952d6fbaa232064a6b1374a870746d7167c4a55dca5e96209f20984bdb0c32c21887f5f67a5c9878c420b8f855a2356
+  metadata.gz: 3df6abc3ae84c6d0248e916932919edc7396f74cb5369a71f9dd32d7a72cfcb53912f5bf933b13963342a8604c656a72ee85172bbd01f1228f6e1c9577a8066e
+  data.tar.gz: 49f400e2ece33976b6516d034bc69faf9ed42721ccf9c99409735fa2cbb9eb4411c20c2f61d7bb2b78e8cffe5117edbeb99f3d996e407c37717b345f8f4bc372

data/app/models/punto_pagos_rails/transaction.rb

@@ -4,32 +4,31 @@ module PuntoPagosRails
   class Transaction < ActiveRecord::Base
     include AASM
 
-    belongs_to :resource, class_name: PuntoPagosRails.resource_class_name
+    belongs_to :payable, polymorphic: true
 
-    delegate :amount, :to => :resource
+    delegate :amount, to: :payable
 
-    aasm :column => :state do
-      state :pending, :initial => true
+    aasm column: :state do
+      state :pending, initial: true
       state :completed
       state :rejected
 
       event :complete do
-        transitions :from => :pending, :to => :completed
+        transitions from: :pending, to: :completed
       end
 
       event :reject do
-        transitions :from => :pending, :to => :rejected
+        transitions from: :pending, to: :rejected
       end
     end
 
     def reject_with(error)
       self.error = error
-      self.reject
+      reject
     end
 
     def amount_to_s
       "%0.2f" % amount.to_i
     end
-
   end
 end

data/config/locales/en.yml

@@ -2,9 +2,6 @@ en:
   punto_pagos_rails:
     success:
       title: Transaction successfully completed
-      detail: "The %{resource} #%{id} for the amount of $%{amount} was made"
-    error:
-      detail: "The payment for %{resource} #%{id} for the amount of $%{amount} was declined"
     errors:
       invalid_puntopagos_response: Invalid PuntoPagos response
       invalid_returned_puntopagos_token: Invalid returned PuntoPagos token

data/config/locales/es.yml

@@ -2,9 +2,6 @@ es:
   punto_pagos_rails:
     success:
       title: Transacción completada con éxito
-      detail: "El pago del %{resource} <b>#%{id}</b> por el valor de <b>$%{amount}</b> fue realizado"
-    error:
-      detail: "El pago del %{resource} <b>#%{id}</b> por el valor de <b>$%{amount}</b> no se realizó"
     errors:
       invalid_puntopagos_response: No se pudo establecer comunicación con PuntoPagos
       invalid_returned_puntopagos_token: Token inválido de PuntoPagos

data/config/routes.rb

@@ -1,7 +1,2 @@
 PuntoPagosRails::Engine.routes.draw do
-  post "transactions/notification", to: 'transactions#notification'
-  get "transactions/notification/:token", to: 'transactions#notification_no_ssl'
-  get "transactions/error/:token", to: 'transactions#error', as: :transaction_error
-  get "transactions/success/:token", to: 'transactions#success', as: :transaction_success
-  post "transactions/create", to: 'transactions#create', as: :transaction_create
 end

data/lib/generators/punto_pagos_rails/install/USAGE

@@ -1,8 +1,5 @@
 Description:
-    Explain the generator
+    Install PuntoPagosRails gem
 
 Example:
-    rails generate punto_pagos_rails:install ResourceModel
-
-    This will create:
-        what/will/it/create
+    rails generate punto_pagos_rails:install

data/lib/generators/punto_pagos_rails/install/install_generator.rb

@@ -1,47 +1,13 @@
-class PuntoPagosRails::InstallGenerator < Rails::Generators::NamedBase
+class PuntoPagosRails::InstallGenerator < Rails::Generators::Base
   source_root File.expand_path('../templates', __FILE__)
 
-  def create_resource_model
-    Rails.application.eager_load!
-    models = ActiveRecord::Base.descendants.map(&:to_s)
-    models.include?(name.classify) ? add_amount_attribute_to_resources : create_resource
-  end
-
-  def extend_resource_abilities
-    line = "class #{name.classify} < ActiveRecord::Base"
-    gsub_file "app/models/#{name}.rb", /(#{Regexp.escape(line)})/mi do |match|
-      "#{match}\n  include PuntoPagosRails::ResourceExtension\n"
-    end
-  end
-
-  def copy_migrations
-    rake "railties:install:migrations"
+  def create_transactions_table
+    generate("migration create_punto_pagos_rails_transactions")
+    new_migration_path = Dir["#{Rails.application.root}/db/migrate/*.rb"].last
+    template "transactions_migration.rb", new_migration_path, force: true
   end
 
   def create_initializer
     template "puntopagos.yml", "config/puntopagos.yml"
-    template "punto_pagos_rails.rb", "config/initializers/punto_pagos_rails.rb"
-  end
-
-  def mount_routes
-    line = "Rails.application.routes.draw do"
-    gsub_file "config/routes.rb", /(#{Regexp.escape(line)})/mi do |match|
-      "#{match}\n mount PuntoPagosRails::Engine => '/'\n"
-    end
   end
-
-  def copy_views
-    copy_file "success.html.erb", "app/views/punto_pagos_rails/transactions/success.html.erb"
-    copy_file "error.html.erb", "app/views/punto_pagos_rails/transactions/error.html.erb"
-  end
-
-  private
-
-    def add_amount_attribute_to_resources
-      generate "migration add_amount_to_#{name.tableize} amount:integer"
-    end
-
-    def create_resource
-      generate "model #{name.classify} amount:integer --no-fixture"
-    end
 end

data/lib/generators/punto_pagos_rails/install/templates/puntopagos.yml

@@ -1,13 +1,12 @@
 development:
-  environment:        "sandbox"
-  puntopagos_key:     "YOUR-API-KEY"
-  puntopagos_secret:  "YOUR-APP-SECRET"
+  environment:        <%= ENV["PUNTOPAGOS_ENV"]%>
+  puntopagos_key:     <%= ENV["PUNTOPAGOS_KEY"]%>
+  puntopagos_secret:  <%= ENV["PUNTOPAGOS_SECRET"]%>
 test:
-  environment:        "sandbox"
-  puntopagos_key:     "YOUR-API-KEY"
-  puntopagos_secret:  "YOUR-APP-SECRET"
+  environment:        <%= ENV["PUNTOPAGOS_ENV_TEST"]%>
+  puntopagos_key:     <%= ENV["PUNTOPAGOS_KEY_TEST"]%>
+  puntopagos_secret:  <%= ENV["PUNTOPAGOS_SECRET_TEST"]%>
 production:
-  environment:        "production"
-  puntopagos_key:     "YOUR-API-KEY"
-  puntopagos_secret:  "YOUR-APP-SECRET"
-
+  environment:        <%= ENV["PUNTOPAGOS_ENV"]%>
+  puntopagos_key:     <%= ENV["PUNTOPAGOS_KEY"]%>
+  puntopagos_secret:  <%= ENV["PUNTOPAGOS_SECRET"]%>

data/lib/generators/punto_pagos_rails/install/templates/transactions_migration.rb

@@ -0,0 +1,18 @@
+class CreatePuntoPagosRailsTransactions < ActiveRecord::Migration
+  def change
+    create_table :punto_pagos_rails_transactions do |t|
+      t.references :payable, polymorphic: true
+      t.string :token
+      t.integer :amount
+      t.string :error
+      t.string :state
+
+      t.timestamps null: false
+    end
+
+    add_index(:punto_pagos_rails_transactions,
+      [:payable_id, :payable_type],
+      name: "index_punto_pagos_rails_transactions_on_payable",
+      unique: true)
+  end
+end

data/lib/generators/punto_pagos_rails/payment_flow/USAGE

@@ -0,0 +1,5 @@
+Description:
+ Add payment flow
+
+Example:
+  rails generate punto_pagos_rails:payment_flow ticket payments

data/lib/generators/punto_pagos_rails/payment_flow/payment_flow_generator.rb

@@ -0,0 +1,80 @@
+class PuntoPagosRails::PaymentFlowGenerator < Rails::Generators::Base
+  source_root File.expand_path("../templates", __FILE__)
+
+  argument(:payable_model_name, type: :string, required: true, banner: "payable_model_name")
+  argument(:payments_controller_name,
+    banner: "payments_controller_name", type: :string, default: "transactions")
+
+  def create_payable_model
+    Rails.application.eager_load!
+    models = ActiveRecord::Base.descendants.map(&:to_s)
+    models.include?(payable_class) ? add_amount_attribute_to_payable : create_payable
+  end
+
+  def extend_payable_abilities
+    line = "class #{payable_class} < ActiveRecord::Base"
+    gsub_file "app/models/#{payable}.rb", /(#{Regexp.escape(line)})/mi do |match|
+      "#{match}\n  include PuntoPagosRails::Payable\n"
+    end
+  end
+
+  def add_controller
+    template("transactions_controller.rb.erb", controller_path)
+  end
+
+  def copy_views
+    copy_file("success.html.erb", "app/views/#{controller_name}/success.html.erb")
+    copy_file("error.html.erb", "app/views/#{controller_name}/error.html.erb")
+  end
+
+  def add_routes
+    line = "Rails.application.routes.draw do"
+    gsub_file "config/routes.rb", /(#{Regexp.escape(line)})/mi do |match|
+      <<-HERE.gsub(/^ {9}/, '')
+         #{match}
+           post "#{controller_name}/notification", to: "#{controller_name}#notification"
+           get "#{controller_name}/error/:token", to: "#{controller_name}#error", as: :#{singular_controller_name}_error
+           get "#{controller_name}/success/:token", to: "#{controller_name}#success", as: :#{singular_controller_name}_success
+           post "#{controller_name}/create", to: "#{controller_name}#create", as: :#{singular_controller_name}_create
+         HERE
+    end
+  end
+
+  private
+
+  def payable
+    payable_table_name.singularize
+  end
+
+  def payable_table_name
+    payable_model_name.tableize
+  end
+
+  def payable_class
+    payable.classify
+  end
+
+  def controller_path
+    "app/controllers/#{controller_name}_controller.rb"
+  end
+
+  def controller_name
+    payments_controller_name.tableize.pluralize
+  end
+
+  def singular_controller_name
+    controller_name.singularize
+  end
+
+  def controller_class
+    "#{payments_controller_name.classify.pluralize}Controller"
+  end
+
+  def add_amount_attribute_to_payable
+    generate "migration add_amount_to_#{payable_table_name} amount:integer"
+  end
+
+  def create_payable
+    generate "model #{payable} amount:integer --no-fixture"
+  end
+end

data/lib/generators/punto_pagos_rails/payment_flow/templates/error.html.erb

@@ -0,0 +1,5 @@
+<div class="puntopagos">
+  <div class="view error">
+    <h2><%= error_message %></h2>
+  </div>
+</div>

data/lib/generators/punto_pagos_rails/payment_flow/templates/success.html.erb

@@ -0,0 +1,5 @@
+<div class="puntopagos">
+  <div class="view success">
+    <h2><%= t("punto_pagos_rails.success.title") %></h2>
+  </div>
+</div>

data/lib/generators/punto_pagos_rails/payment_flow/templates/transactions_controller.rb.erb

@@ -0,0 +1,40 @@
+class <%= controller_class %> < ApplicationController
+  def create
+    @<%= payable %> = <%= payable_class %>.create!(create_params)
+    srv = PuntoPagosRails::TransactionService.new(@<%= payable %>)
+
+    if srv.create
+      redirect_to(srv.process_url)
+    else
+      render_payment_error_view(srv.error)
+    end
+  end
+
+  def notification
+    response = PuntoPagosRails::TransactionService.notificate(params, request.headers)
+    render(json: response)
+  end
+
+  def success
+    @<%= payable %> = <%= payable %>_by_token
+  end
+
+  def error
+    @<%= payable %> = <%= payable %>_by_token
+    render_payment_error_view(I18n.t("punto_pagos_rails.errors.invalid_puntopagos_payment"))
+  end
+
+  private
+
+  def render_payment_error_view(error_message)
+    render("error", locals: { error_message: error_message })
+  end
+
+  def <%= payable %>_by_token
+    @<%= payable %> ||= <%= payable_class %>.by_token(params[:token])
+  end
+
+  def create_params
+    params.require(:<%= payable %>).permit(:amount)
+  end
+end

data/lib/punto_pagos_rails.rb

@@ -1,19 +1,10 @@
 require "punto_pagos_rails/engine"
-require "punto_pagos_rails/resource_extension"
+require "punto_pagos_rails/payable"
 require "punto_pagos_rails/transaction_service"
 
 module PuntoPagosRails
   extend self
 
-  attr_accessor :resource_class_name
-  attr_accessor :success_url
-  attr_accessor :error_url
-
-
-  def resource_class
-    resource_class_name.constantize
-  end
-
   def setup
     yield self
     require "puntopagos"

data/lib/punto_pagos_rails/engine.rb

@@ -4,7 +4,7 @@ module PuntoPagosRails
 
     config.generators do |g|
       g.test_framework :rspec
-      g.fixture_replacement :factory_girl, :dir => 'spec/factories'
+      g.fixture_replacement :factory_girl, dir: "spec/factories"
     end
   end
 end

data/lib/punto_pagos_rails/payable.rb

@@ -0,0 +1,23 @@
+require "active_support/concern"
+
+module PuntoPagosRails
+  module Payable
+    extend ActiveSupport::Concern
+
+    included do
+      has_many :transactions, as: :payable, class_name: "PuntoPagosRails::Transaction"
+
+      def paid?
+        return false unless transactions.any?
+        transactions.last.completed?
+      end
+    end
+
+    module ClassMethods
+      def by_token(token)
+        transaction = Transaction.find_by(token: token)
+        transaction.try(:payable)
+      end
+    end
+  end
+end

data/lib/punto_pagos_rails/transaction_service.rb

@@ -1,18 +1,23 @@
 module PuntoPagosRails
-  class TransactionService < Struct.new(:resource_id)
+  class TransactionService
     attr_accessor :process_url
+    attr_reader :payable
 
     SUCCESS_CODE = "99"
     ERROR_CODE = "00"
 
+    def initialize(payable)
+      @payable = payable
+    end
+
     def create
-      transaction = resource.transactions.create!
+      transaction = payable.transactions.create!
 
       request = PuntoPagos::Request.new
       response = request.create(transaction.id.to_s, transaction.amount_to_s, nil)
 
       if !response.success?
-        resource.errors.add :base, I18n.t("punto_pagos_rails.errors.invalid_puntopagos_response")
+        payable.errors.add :base, I18n.t("punto_pagos_rails.errors.invalid_puntopagos_response")
         return false
       end
 
@@ -21,81 +26,68 @@ module PuntoPagosRails
       end
     end
 
-    def self.notificate(params, headers)
-      notification = PuntoPagos::Notification.new
-      tken = params[:token]
-      err = params[:error]
-
-      if notification.valid?(headers, params)
-        respond_success(tken)
-      else
-        respond_error(tken, err)
-      end
-    end
-
-    def self.validate(token, transaction)
-      status = PuntoPagos::Status.new
-      status.check token, transaction.id.to_s, transaction.amount_to_s
-      if status.valid?
-        respond_success(token)
-      else
-        respond_error(token, status.error)
-      end
-    end
-
     def error
-      resource.errors.messages[:base].first
+      payable.errors.messages[:base].first
     end
 
-  private
-
-    def self.processing_transaction(token)
-      transaction = Transaction.find_by_token(token)
-      return unless transaction
-      return unless transaction.pending?
-      transaction
-    end
-
-    def self.respond_success(token)
-      transaction = processing_transaction(token)
-      return if transaction.nil?
-      transaction.resource.run_callbacks :payment_success do
-        transaction.complete
-        transaction.save
-      end
-      { respuesta: SUCCESS_CODE, token: token }
-    end
-
-    def self.respond_error(token, error)
-      transaction = processing_transaction(token)
-      return if transaction.nil?
-      transaction.resource.run_callbacks :payment_error do
-        transaction.reject_with(error)
-        transaction.save
-      end
-      { respuesta: ERROR_CODE, error: error, token: token }
-    end
+    private
 
     def init_transaction(transaction, token)
       if token.blank?
-        resource.errors.add :base, I18n.t("punto_pagos_rails.errors.invalid_returned_puntopagos_token")
+        payable.errors.add(:base,
+          I18n.t("punto_pagos_rails.errors.invalid_returned_puntopagos_token"))
         return false
       end
 
-      if token_repeated?(token)
-        resource.errors.add :base, I18n.t("punto_pagos_rails.errors.repeated_token_given")
+      if repeated_token?(token)
+        payable.errors.add :base, I18n.t("punto_pagos_rails.errors.repeated_token_given")
         return false
       end
 
-      transaction.update!(token: token, amount: resource.amount)
+      transaction.update!(token: token, amount: payable.amount)
     end
 
-    def token_repeated?(token)
+    def repeated_token?(token)
       Transaction.where(token: token).any?
     end
 
-    def resource
-      @resource ||= PuntoPagosRails.resource_class.find(resource_id)
+    class << self
+      def notificate(params, headers)
+        notification = PuntoPagos::Notification.new
+        tken = params[:token]
+        err = params[:error]
+
+        if notification.valid?(headers, params)
+          respond_success(tken)
+        else
+          respond_error(tken, err)
+        end
+      end
+
+      private
+
+      def processing_transaction(token)
+        transaction = Transaction.find_by_token(token)
+        return unless transaction
+        return unless transaction.pending?
+        transaction
+      end
+
+      def respond_success(token)
+        transaction = processing_transaction(token)
+        return if transaction.nil?
+        transaction.complete
+        transaction.save
+        { respuesta: SUCCESS_CODE, token: token }
+      end
+
+      def respond_error(token, error)
+        transaction = processing_transaction(token)
+        return if transaction.nil?
+        transaction.reject_with(error)
+        transaction.save
+        { respuesta: ERROR_CODE, error: error, token: token }
+      end
     end
   end
 end