punto_pagos_rails 0.2.0 → 1.0.0

data/spec/dummy/spec/controllers/transactions_controller_spec.rb

@@ -0,0 +1,88 @@
+require "rails_helper"
+
+describe TransactionsController do
+  describe "#create" do
+    context "with valid transaction creation" do
+      let(:fake_proccess_url) { "http://puntopagos.cl/process" }
+
+      before do
+        expect_any_instance_of(PuntoPagosRails::TransactionService).to(
+          receive(:create).and_return(true))
+        expect_any_instance_of(PuntoPagosRails::TransactionService).to(
+          receive(:process_url).and_return(fake_proccess_url))
+      end
+
+      subject { post :create, ticket: { amount: 5000 } }
+
+      it "redirects to process url" do
+        expect(subject).to redirect_to(fake_proccess_url)
+      end
+    end
+
+    context "with invalid transaction creation" do
+      render_views
+      let(:fake_error) { "some puntopagos error" }
+
+      before do
+        expect_any_instance_of(PuntoPagosRails::TransactionService).to(
+          receive(:create).and_return(false))
+        expect_any_instance_of(PuntoPagosRails::TransactionService).to(
+          receive(:error).and_return(fake_error))
+      end
+
+      subject { post :create, ticket: { amount: 5000 } }
+
+      it "renders error template" do
+        expect(subject).to render_template(:error)
+      end
+
+      it "shows error in view" do
+        post :create, ticket: { amount: 5000 }
+        expect(response.body).to match /#{fake_error}/im
+        expect(response.body).to match /Error Ticket ##{Ticket.last.id}/im
+      end
+    end
+  end
+
+  describe "#notification" do
+    before do
+      expect(PuntoPagosRails::TransactionService).to(
+        receive(:notificate).and_return(some: "json"))
+    end
+
+    it "renders json response" do
+      post :notification
+      expect(JSON.parse(response.body)).to eq("some" => "json")
+    end
+  end
+
+  describe "#success" do
+    let!(:transaction) { create(:transaction) }
+
+    subject { get :success, token: transaction.token }
+
+    it "renders success template" do
+      expect(subject).to render_template(:success)
+    end
+
+    it "shows success view" do
+      get :success, token: transaction.token
+      expect(response.body).to match /Success Ticket ##{Ticket.last.id}/im
+    end
+  end
+
+  describe "#error" do
+    let!(:transaction) { create(:transaction) }
+
+    subject { get :error, token: transaction.token }
+
+    it "renders error template" do
+      expect(subject).to render_template(:error)
+    end
+
+    it "shows error view" do
+      get :error, token: transaction.token
+      expect(response.body).to match /Error Ticket ##{Ticket.last.id}/im
+    end
+  end
+end

data/spec/dummy/spec/lib/punto_pagos_rails/transaction_service_spec.rb

@@ -1,18 +1,19 @@
-require 'rails_helper'
+require "rails_helper"
 
 include PuntoPagosRails
 
 RSpec.describe TransactionService do
-
   let(:ticket) { Ticket.create amount: 22 }
-  let(:service) { TransactionService.new(ticket.id) }
+  let(:service) { TransactionService.new(ticket) }
   let(:request) { double }
   let(:response) { double }
   let(:token) { 'XXXXX' }
   let(:payment_process_url) { double }
   let(:notification) { double }
   let(:status) { double }
-  let(:transaction) { PuntoPagosRails::Transaction.create(resource: ticket, token: SecureRandom.base64) }
+  let(:transaction) do
+    PuntoPagosRails::Transaction.create(payable: ticket, token: SecureRandom.base64)
+  end
 
   before do
     allow(PuntoPagos::Request).to receive(:new).and_return(request)
@@ -52,7 +53,6 @@ RSpec.describe TransactionService do
       end
 
       context "with unsuccesful initialization" do
-
         it "returns false with invalid token" do
           allow(response).to receive(:get_token).and_return(nil)
           expect(service.create).to eq(false)
@@ -63,68 +63,24 @@ RSpec.describe TransactionService do
           allow(response).to receive(:get_token).and_return('REPEATED_TOKEN')
           expect(service.create).to eq(false)
         end
-
       end
-
     end
 
     context "error" do
-
       it "returns false" do
         expect(service.create).to eq(false)
       end
 
-      it "sets resource error" do
+      it "sets payable error" do
         allow(Ticket).to receive(:find).with(ticket.id).and_return(ticket)
         service.create
         expect(ticket.errors[:base]).to include(
           I18n.t("punto_pagos_rails.errors.invalid_puntopagos_response"))
       end
-
     end
   end
 
-  describe "#validate" do
-
-    before do
-      allow(PuntoPagos::Status).to receive(:new).and_return(status)
-      allow(status).to receive(:check).with(transaction.token, transaction.id.to_s, transaction.amount_to_s)
-    end
-
-    it "creates a status object" do
-      allow(status).to receive(:valid?).and_return(true)
-      TransactionService.validate(transaction.token, transaction)
-      expect(PuntoPagos::Status).to have_received(:new)
-    end
-
-    context "when the token is valid" do
-
-      it "runs callback after successful payment" do
-        allow(status).to receive(:valid?).and_return(true)
-        TransactionService.validate(transaction.token, transaction)
-        ticket.reload
-        expect(ticket.message).to eq("successful payment! #{ticket.id}")
-      end
-
-    end
-
-    context "when the token is invalid" do
-
-      it "runs error callback" do
-        allow(status).to receive(:valid?).and_return(false)
-        allow(status).to receive(:error).and_return("Transaccion Incompleta")
-        TransactionService.validate(transaction.token, transaction)
-        ticket.reload
-        expect(ticket.message).to eq("error paying ticket #{ticket.id}")
-      end
-
-    end
-
-
-  end
-
   describe "#notificate" do
-
     before do
       allow(PuntoPagos::Notification).to receive(:new).and_return(notification)
       allow(notification).to receive(:valid?).with({}, {}).and_return(true)
@@ -137,12 +93,6 @@ RSpec.describe TransactionService do
     end
 
     context "when the notification is valid" do
-
-      it "runs callback after successful payment" do
-        TransactionService.notificate({}, {})
-        expect(ticket.message).to eq("successful payment! #{ticket.id}")
-      end
-
       it "the notification is completed" do
         TransactionService.notificate({}, {})
         expect(transaction.reload.state).to eq('completed')
@@ -158,10 +108,6 @@ RSpec.describe TransactionService do
       it "the notification is rejected" do
         expect(transaction.reload.state).to eq('rejected')
       end
-
-      it "calls error callbacks" do
-        expect(ticket.message).to eq("error paying ticket #{ticket.id}")
-      end
     end
 
     context "when the notification is completed" do

data/spec/dummy/spec/models/punto_pagos_rails/transaction_spec.rb

@@ -1,7 +1,7 @@
-require 'rails_helper'
+require "rails_helper"
 
-RSpec.describe PuntoPagosRails::Transaction, :type => :model do
+RSpec.describe PuntoPagosRails::Transaction, type: :model do
   describe "associations" do
-    it { should belong_to(:resource) }
+    it { should belong_to(:payable) }
   end
 end

data/spec/dummy/spec/models/ticket_spec.rb

@@ -1,6 +1,6 @@
-require 'rails_helper'
+require "rails_helper"
 
-RSpec.describe Ticket, :type => :model do
+RSpec.describe Ticket, type: :model do
   describe "associations" do
     it { should have_many(:transactions) }
   end

data/spec/dummy/tmp/cache/assets/development/sprockets/v3.0/3Fw4ZqAHNcyjp32NvDuTNl_UqelVnkm1oFk6m8TeecE.cache

@@ -0,0 +1 @@
+"%��Rm�v�S3.��O�L���ڹc�ƕq�=_j�

data/spec/dummy/tmp/cache/assets/development/sprockets/v3.0/5X/5XQR5pxibZfdEuTpakchl9HyBfhnPIGcUuB7zJON788.cache

@@ -0,0 +1 @@
+I"
�app/assets/javascripts/application.js?type=application/javascript&pipeline=self&id=4f33a83654a06a7f2eb59d63957c6c4d25a0fd062a80793620e3e5a877963bad:ET

data/spec/dummy/tmp/cache/assets/development/sprockets/v3.0/7q/7qi1bAa7jI04pIaFgMGEMDgWNCI-Q7diVLAm3btoA84.cache

@@ -0,0 +1 @@
+I"}app/assets/stylesheets/application.css?type=text/css&id=8f935d0fc9961e2fd9e2fd589aa71a241f80760bb1e8049b5fa31101b6121bf7:ET

data/spec/dummy/tmp/cache/assets/development/sprockets/v3.0/CduZWIah5G8fpSjD5QO6TFJXr_9TFOHxCbC1Gy8qZxA.cache

@@ -0,0 +1 @@
+I"
�file:///Users/leandro/src/punto_pagos_rails/spec/dummy/app/assets/stylesheets/application.css?type=text/css&pipeline=self&id=bcac671b11df32b847194f8b6008bbb5badd2dcc5faa5fdbe35ac74889257edf:ET

data/spec/dummy/tmp/cache/assets/development/sprockets/v3.0/EN/EN1sgFDBtOLV_nTM5QCygjXFjJjrCwASL91R_jbxJqo.cache

@@ -0,0 +1 @@
+"%��Rm�v�S3.��O�L���ڹc�ƕq�=_j�

data/spec/dummy/tmp/cache/assets/development/sprockets/v3.0/Fv8tnOEJ_LEgSDbDEuTuiPLB-eEYIhxUwZsDBbio46w.cache

@@ -0,0 +1,3 @@
+[o:Set:
+@hash{
+I"environment-version:ETTI"environment-paths;TTI"Zprocessors:type=application/javascript&file_type=application/javascript&pipeline=self;TTI"hfile-digest:///Users/leandro/src/punto_pagos_rails/spec/dummy/app/assets/javascripts/application.js;TTI"Yfile-digest:///Users/leandro/src/punto_pagos_rails/spec/dummy/app/assets/javascripts;TT

data/spec/dummy/tmp/cache/assets/development/sprockets/v3.0/J8/J88DZaT-14iePrHbjUeroRM6XiHxwmMw7k38S1nwR5g.cache

@@ -0,0 +1 @@
+I"
�app/assets/stylesheets/application.css?type=text/css&pipeline=self&id=2229631e3b828ee4822ce343befd9a40117a9904c9bc4b782c33b6a338e5f359:ET

data/spec/dummy/tmp/cache/assets/development/sprockets/v3.0/O8/O8akbUwAbmIKY-AhITimq-JDQ6IgsO3Hvq2v5etufFw.cache

@@ -0,0 +1,2 @@
+[o:Set:
+@hash{I"environment-version:ETTI"environment-paths;TTI"0processors:type=text/css&file_type=text/css;TTI"9file-digest://app/assets/stylesheets/application.css;TTI">processors:type=text/css&file_type=text/css&pipeline=self;TTI")file-digest://app/assets/stylesheets;TT

data/spec/dummy/tmp/cache/assets/development/sprockets/v3.0/Rm/Rmkvmvnp04uG1YyAWhY8BHBd--6SqqV8mNPXCkmCucs.cache

@@ -0,0 +1 @@
+"%]!�K��X�K�֓�ޖ���';�����4x��

data/spec/dummy/tmp/cache/assets/development/sprockets/v3.0/XfKoGAu1QFs7NV03JWa4QQtoTQSkqlJZx05IkDCP3PM.cache

@@ -0,0 +1,2 @@
+[o:Set:
+@hash{I"environment-version:ETTI"environment-paths;TTI"0processors:type=text/css&file_type=text/css;TTI"ifile-digest:///Users/leandro/src/punto_pagos_rails/spec/dummy/app/assets/stylesheets/application.css;TTI">processors:type=text/css&file_type=text/css&pipeline=self;TTI"Yfile-digest:///Users/leandro/src/punto_pagos_rails/spec/dummy/app/assets/stylesheets;TT

data/spec/dummy/tmp/cache/assets/development/sprockets/v3.0/esq8UjWY8tb8I8CizPRT_shPmdQKJYyr2DN19n2klo4.cache

@@ -0,0 +1 @@
+I"
�file:///Users/leandro/src/punto_pagos_rails/spec/dummy/app/assets/javascripts/application.js?type=application/javascript&pipeline=self&id=862a9c78cf156953166744449cee2b97ad84f042558b4ab6df00327c381a59d9:ET

data/spec/dummy/tmp/cache/assets/development/sprockets/v3.0/hj/hj8Ir9wcVSy1KYrnWu9bpD24vDhCG3tvt-nKbNxb1Wg.cache

@@ -0,0 +1,3 @@
+[o:Set:
+@hash{
+I"environment-version:ETTI"environment-paths;TTI"Zprocessors:type=application/javascript&file_type=application/javascript&pipeline=self;TTI"8file-digest://app/assets/javascripts/application.js;TTI")file-digest://app/assets/javascripts;TT

data/spec/dummy/tmp/cache/assets/development/sprockets/v3.0/k7noXdZau3gX1CJSriYJIBcNHPwc3318AUHIWCHXKhg.cache

@@ -0,0 +1,2 @@
+[o:Set:
+@hash{I"environment-version:ETTI"environment-paths;TTI"Lprocessors:type=application/javascript&file_type=application/javascript;TTI"hfile-digest:///Users/leandro/src/punto_pagos_rails/spec/dummy/app/assets/javascripts/application.js;TTI"Zprocessors:type=application/javascript&file_type=application/javascript&pipeline=self;TTI"Yfile-digest:///Users/leandro/src/punto_pagos_rails/spec/dummy/app/assets/javascripts;TT

data/spec/dummy/tmp/cache/assets/development/sprockets/v3.0/oC/oCsZTGZyV4kH8Y4OeSDUdrwfkJFPzTODZjuBKZB8oGQ.cache

@@ -0,0 +1,2 @@
+[o:Set:
+@hash{I"environment-version:ETTI"environment-paths;TTI"Lprocessors:type=application/javascript&file_type=application/javascript;TTI"8file-digest://app/assets/javascripts/application.js;TTI"Zprocessors:type=application/javascript&file_type=application/javascript&pipeline=self;TTI")file-digest://app/assets/javascripts;TT

data/spec/dummy/tmp/cache/assets/development/sprockets/v3.0/ogxRgAPyiZ-Nu3IjkBEw9ruI1Knjq_YU6HyWixUrg7g.cache

@@ -0,0 +1 @@
+I"
�file:///Users/leandro/src/punto_pagos_rails/spec/dummy/app/assets/javascripts/application.js?type=application/javascript&id=1dbf46b3e04cf23d24969e2932c55eee600642217bd7f6dcb248973a908b1472:ET

data/spec/dummy/tmp/cache/assets/development/sprockets/v3.0/om/omKjrYUgD72M_fYBz1rlfZYic0JVNLXPKY8BGn43I5w.cache

@@ -0,0 +1 @@
+I"
�app/assets/javascripts/application.js?type=application/javascript&id=eaf30316c06d166f77be04ec2a6c1898139deb48be6348a447a9d38d73977952:ET

data/spec/dummy/tmp/cache/assets/development/sprockets/v3.0/r0gbTq2v9cKQuG206qQxGolfvjBYw3POwlACk7b41Rg.cache

@@ -0,0 +1 @@
+I"
�file:///Users/leandro/src/punto_pagos_rails/spec/dummy/app/assets/stylesheets/application.css?type=text/css&id=c258ee9b7d8c1bcb1529ad1bf669a1d303b10c98b36ccc4cacf46f492500a277:ET

data/spec/dummy/tmp/cache/assets/development/sprockets/v3.0/rorzxYMlgwKrzjSt_2tNP0StT9Q3pelAqgmVf3YA9SY.cache

@@ -0,0 +1,3 @@
+[o:Set:
+@hash{
+I"environment-version:ETTI"environment-paths;TTI">processors:type=text/css&file_type=text/css&pipeline=self;TTI"ifile-digest:///Users/leandro/src/punto_pagos_rails/spec/dummy/app/assets/stylesheets/application.css;TTI"Yfile-digest:///Users/leandro/src/punto_pagos_rails/spec/dummy/app/assets/stylesheets;TT

data/spec/dummy/tmp/cache/assets/development/sprockets/v3.0/t78LfYaGJpEOdllJ9lsrnLCKTCSkoSJWU17iCNcvy94.cache

@@ -0,0 +1 @@
+"%]!�K��X�K�֓�ޖ���';�����4x��

data/spec/dummy/tmp/cache/assets/development/sprockets/v3.0/tP/tPF6H9NRpGO3whu2y5_e_R_1EACKdCwu5437D83qJT0.cache

@@ -0,0 +1,3 @@
+[o:Set:
+@hash{
+I"environment-version:ETTI"environment-paths;TTI">processors:type=text/css&file_type=text/css&pipeline=self;TTI"9file-digest://app/assets/stylesheets/application.css;TTI")file-digest://app/assets/stylesheets;TT

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/1j/1jUXrYbF7jVcJvYHZHNALKbMrXby0qIkxLwN8tMjdl4.cache

@@ -0,0 +1 @@
+I"}app/assets/stylesheets/application.css?type=text/css&id=ac4682cb37bd663b8c4706e6fddbf19701afd75bb51929d6dff10bdb8a5f1430:ET

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/7b/7bjowlWzolEF985bac_6I5v3HWZiFJRoa-nqHtn-OXY.cache

@@ -0,0 +1 @@
+I"
�/Users/leandro/src/punto_pagos_rails/app/assets/stylesheets/punto_pagos_rails/application.css?type=text/css&pipeline=self&id=a1093c3d434103230d21880331ba4bbe0f7d1de19edbcb9365c89cf9e837456e:ET

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/7i/7io2gyVCCR83Rk6ocF1HUvam1FLz4-Q1MRk6A10JM0M.cache

@@ -0,0 +1 @@
+I"
�/Users/leandro/src/punto_pagos_rails/app/assets/javascripts/punto_pagos_rails/application.js?type=application/javascript&id=aadfe729fbf292033222be375218e9beb5fb152d14e8b04e9f8f79c055054e8b:ET

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/9X/9XlM_JtRmY5gbMkK5gueswD7s_ctcOLacU5VYno5ymw.cache

@@ -0,0 +1 @@
+I"
�app/assets/stylesheets/application.css?type=text/css&pipeline=self&id=1f3c6a6dca44606922cc06c28045078d5e2f2f810970ee2f40e3d5a87a18901f:ET

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/EN/EN1sgFDBtOLV_nTM5QCygjXFjJjrCwASL91R_jbxJqo.cache

@@ -0,0 +1 @@
+"%��Rm�v�S3.��O�L���ڹc�ƕq�=_j�

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/EN/eNStu73G536x1iNq9tePGM6hv5Xa6-5ZsXtfJuiDtfE.cache

@@ -0,0 +1 @@
+I"
�app/assets/javascripts/application.js?type=application/javascript&id=fcbe1cbffc1db2d60b4ba3faf3937285736e8abd041dc060ddf10627c0e6f1e5:ET

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/Fi/FiuTIVrQEp_PZDI6AFR7KQkoUtnCXkFVKyr2aSzCINI.cache

@@ -0,0 +1 @@
+I"
�app/assets/stylesheets/application.css?type=text/css&pipeline=self&id=68c121d9dbb95c23a33bc37fc84997549794f4329c111831cf7213e3fd7daa75:ET

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/LK/LK5DwcQTCssBt2sSq8waYL_2OW6zUuLZoRK4vXkUbx0.cache

@@ -0,0 +1 @@
+I"}app/assets/stylesheets/application.css?type=text/css&id=05580e194e82fc60ac4678aada24abee54ca9dd81e52c82e247bc32c3f422f2b:ET

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/LO/LOIw_QrLu6EqRv2po1AhlmvJ5T0AcIZuJV0rK15RRx0.cache

@@ -0,0 +1,2 @@
+[o:Set:
+@hash{I"environment-version:ETTI"environment-paths;TTI"rails-env;TTI"?processors:type=text/css&file_type=text/css&pipeline=debug;TTI"9file-digest://app/assets/stylesheets/application.css;TTI">processors:type=text/css&file_type=text/css&pipeline=self;TTI")file-digest://app/assets/stylesheets;TT

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/PS/PSM535pl0G8ic1fKKJ0rkGdwrgW8b8OITOW47jl2t1g.cache

@@ -0,0 +1 @@
+"%��Rm�v�S3.��O�L���ڹc�ƕq�=_j�

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/R4/R4lZxKQXv7q9xqB-H6AKh5-KeSELCFkMP12qMQ6dMLI.cache

@@ -0,0 +1 @@
+I"
�/Users/leandro/src/punto_pagos_rails/app/assets/javascripts/punto_pagos_rails/application.js?type=application/javascript&pipeline=self&id=1eb3541765b6ade985b2ac356525282dcda72492d4a61d2ee6cb90bb7b5c705f:ET

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/Rm/Rmkvmvnp04uG1YyAWhY8BHBd--6SqqV8mNPXCkmCucs.cache

@@ -0,0 +1 @@
+"%]!�K��X�K�֓�ޖ���';�����4x��

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/SX/SX0FzvVXLoVzYDZN95Hikfe-1VExx8LZgZh4bam53yE.cache

@@ -0,0 +1 @@
+I"
�app/assets/javascripts/application.js?type=application/javascript&pipeline=debug&id=1172feba7953a0a1c9893021afd318385906fb5be6b923c4718208891b070f62:ET

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/VR/VRC0qpQ2CiJgNEMvtXOvEDluwkaoomyJeAm7Unfrcr0.cache

@@ -0,0 +1 @@
+I"
�/Users/leandro/src/punto_pagos_rails/app/assets/stylesheets/punto_pagos_rails/application.css?type=text/css&pipeline=self&id=4d5369e7d21fe423fa1daeef06216e741bf3a344f14e703ea9658f5b97eb7850:ET

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/bz/bzN6Qn7mi2daF9JkWWFmcv8yPYyWuLQOwlOUre3D-Vg.cache

@@ -0,0 +1 @@
+"%���mB��c�$�8;��8�r�8]R�MQ�c=Ib