punto_pagos_rails 1.1.0 → 1.2.0

data/spec/dummy/spec/controllers/payments_controller_spec.rb

@@ -0,0 +1,17 @@
+require "rails_helper"
+
+describe PaymentsController do
+  describe "#notification" do
+    let!(:transaction) { create(:transaction) }
+
+    before do
+      expect(PuntoPagosRails::TransactionService).to(
+        receive(:complete).and_return(true))
+    end
+
+    it "renders json response" do
+      get :notification, token: transaction.token
+      expect(response.status).to eq(200)
+    end
+  end
+end

data/spec/dummy/spec/lib/punto_pagos_rails/transaction_service_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe TransactionService do
   let(:service) { TransactionService.new(ticket) }
   let(:request) { double }
   let(:response) { double }
-  let(:token) { 'XXXXX' }
+  let(:token) { "XXXXX" }
   let(:payment_process_url) { double }
   let(:notification) { double }
   let(:status) { double }
@@ -59,8 +59,8 @@ RSpec.describe TransactionService do
         end
 
         it "fails with repeated token" do
-          Transaction.create(token: 'REPEATED_TOKEN')
-          allow(response).to receive(:get_token).and_return('REPEATED_TOKEN')
+          Transaction.create(token: "REPEATED_TOKEN")
+          allow(response).to receive(:get_token).and_return("REPEATED_TOKEN")
           expect(service.create).to eq(false)
         end
       end
@@ -99,54 +99,79 @@ RSpec.describe TransactionService do
   end
 
   describe "#notificate" do
-    before do
-      allow(PuntoPagos::Notification).to receive(:new).and_return(notification)
-      allow(notification).to receive(:valid?).with({}, {}).and_return(true)
-      allow(PuntoPagosRails::Transaction).to receive(:find_by_token).and_return(transaction)
-    end
+    let(:params) { { token: transaction.token } }
+    before { allow(PuntoPagos::Notification).to receive(:new).and_return(notification) }
 
-    it "creates a notification" do
-      TransactionService.notificate({}, {})
-      expect(PuntoPagos::Notification).to have_received(:new)
-    end
+    context "with valid notification" do
+      before { allow(notification).to receive(:valid?).with({}, params).and_return(true) }
 
-    context "when the notification is valid" do
-      it "the notification is completed" do
-        TransactionService.notificate({}, {})
-        expect(transaction.reload.state).to eq('completed')
+      it "completes transaction" do
+        expect(TransactionService.notificate(params, {})).to eq(
+          respuesta: "99", token: transaction.token)
+        expect(transaction.reload.state).to eq("completed")
       end
-    end
 
-    context "when the notification is invalid" do
-      before do
-        allow(notification).to receive(:valid?).with({}, {}).and_return(false)
-        TransactionService.notificate({}, {})
+      context "when notification is completed" do
+        before { transaction.update_column(:state, "completed") }
+
+        it "does not change status" do
+          TransactionService.notificate(params, {})
+          expect(transaction.reload.state).to eq("completed")
+        end
       end
 
-      it "the notification is rejected" do
-        expect(transaction.reload.state).to eq('rejected')
+      context "when notification is rejected" do
+        before { transaction.update_column(:state, "rejected") }
+
+        it "does not change status" do
+          TransactionService.notificate(params, {})
+          expect(transaction.reload.state).to eq("rejected")
+        end
       end
     end
 
-    context "when the notification is completed" do
+    context "with invalid notification" do
       before do
-        transaction.update_column :state, 'completed'
+        params[:error] = "error!"
+        allow(notification).to receive(:valid?).with({}, params).and_return(false)
       end
 
-      it "should not be rejectable" do
-        TransactionService.notificate({}, {})
-        expect(transaction.reload.state).to_not eq('rejected')
+      it "rejects the transaction" do
+        expect(TransactionService.notificate(params, {})).to eq(
+          respuesta: "00", error: params[:error], token: transaction.token)
+        expect(transaction.reload.state).to eq("rejected")
+        expect(transaction.error).to eq(params[:error])
+      end
+    end
+  end
+
+  describe "#complete" do
+    let(:params) { { token: transaction.token } }
+    before do
+      allow(PuntoPagos::Status).to receive(:new).and_return(status)
+      allow(status).to receive(:check).with(
+        transaction.token, transaction.id.to_s, transaction.amount_to_s).and_return(true)
+    end
+
+    context "with valid status" do
+      before { allow(status).to receive(:valid?).and_return(true) }
+
+      it "completes transaction" do
+        expect(TransactionService.complete(params)).to be_truthy
+        expect(transaction.reload.state).to eq("completed")
       end
     end
 
-    context "when the notification is rejected" do
+    context "with invalid status" do
       before do
-        transaction.update_column :state, 'rejected'
+        allow(status).to receive(:valid?).and_return(false)
+        allow(status).to receive(:error).and_return("error")
       end
 
-      it "should not be completable" do
-        TransactionService.notificate({}, {})
-        expect(transaction.reload.state).to_not eq('completed')
+      it "completes transaction" do
+        expect(TransactionService.complete(params)).to be_truthy
+        expect(transaction.reload.state).to eq("rejected")
+        expect(transaction.error).to eq("error")
       end
     end
   end

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/Ey/EyWfRmUYoL59k_CqjDAePaOgc1OCqcTmsjJpanercg4.cache

@@ -0,0 +1 @@
+"%��Rm�v�S3.��O�L���ڹc�ƕq�=_j�

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/wt/wt38OlyCBzCYjWbwhzKkVlJAD3_tIepF8hxEzJkiXB4.cache

@@ -0,0 +1,2 @@
+"%�b
+�秐��@�o�	Ep��� Ext���)T

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: punto_pagos_rails
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Leandro Segovia
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-08 00:00:00.000000000 Z
+date: 2016-06-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -188,11 +188,14 @@ files:
 - spec/dummy/app/assets/stylesheets/application.css
 - spec/dummy/app/controllers/application_controller.rb
 - spec/dummy/app/controllers/home_controller.rb
+- spec/dummy/app/controllers/payments_controller.rb
 - spec/dummy/app/controllers/transactions_controller.rb
 - spec/dummy/app/helpers/application_helper.rb
 - spec/dummy/app/models/ticket.rb
 - spec/dummy/app/views/home/index.html.erb
 - spec/dummy/app/views/layouts/application.html.erb
+- spec/dummy/app/views/payments/error.html.erb
+- spec/dummy/app/views/payments/success.html.erb
 - spec/dummy/app/views/transactions/error.html.erb
 - spec/dummy/app/views/transactions/success.html.erb
 - spec/dummy/bin/bundle
@@ -229,6 +232,7 @@ files:
 - spec/dummy/public/422.html
 - spec/dummy/public/500.html
 - spec/dummy/public/favicon.ico
+- spec/dummy/spec/controllers/payments_controller_spec.rb
 - spec/dummy/spec/controllers/transactions_controller_spec.rb
 - spec/dummy/spec/lib/punto_pagos_rails/transaction_service_spec.rb
 - spec/dummy/spec/models/punto_pagos_rails/transaction_spec.rb
@@ -295,6 +299,7 @@ files:
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/AP/AP0_3b5N2aJWVyyANhjLMP7qdpczG_C1lo6AtzELoyU.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/EN/EN1sgFDBtOLV_nTM5QCygjXFjJjrCwASL91R_jbxJqo.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/EN/eNStu73G536x1iNq9tePGM6hv5Xa6-5ZsXtfJuiDtfE.cache
+- spec/dummy/tmp/cache/assets/sprockets/v3.0/Ey/EyWfRmUYoL59k_CqjDAePaOgc1OCqcTmsjJpanercg4.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/Fi/FiuTIVrQEp_PZDI6AFR7KQkoUtnCXkFVKyr2aSzCINI.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/HG/HGWuC1XP4qTav8SMCTMvqubfgC1g-BXJH6zXci4WaI8.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/HT/HT55sL83KvJ-NRz9pru5aQzroueKzMMnMEah6E7MAvY.cache
@@ -334,6 +339,7 @@ files:
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/uJ/uJSI3kUSsbjut4Cwj7WrhGwwnEB1vCd3Pe2fbI5SU4k.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/un/un4CV9-W0TLVlFJFc3m-r9KEyxaymOlHKKpGpPOn37s.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/w_/w_v89Lo_bpb8aAsrFe9y5cBhNobVJ6MwvJqav7plorY.cache
+- spec/dummy/tmp/cache/assets/sprockets/v3.0/wt/wt38OlyCBzCYjWbwhzKkVlJAD3_tIepF8hxEzJkiXB4.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/xU/xU8kTXBeW6eLfp_eNY6xEEideoQNSHIMC9yQ-P1OPO8.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/y8/y8u-QuBe2neNMwhZPDIz3ZE5FqNjBEux-ttpcsU9Qxc.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/yh/yhC-Cty2J5UucXyvUWMfhQRgloZBt67FS7bSQpo7MMk.cache
@@ -371,11 +377,14 @@ test_files:
 - spec/dummy/app/assets/stylesheets/application.css
 - spec/dummy/app/controllers/application_controller.rb
 - spec/dummy/app/controllers/home_controller.rb
+- spec/dummy/app/controllers/payments_controller.rb
 - spec/dummy/app/controllers/transactions_controller.rb
 - spec/dummy/app/helpers/application_helper.rb
 - spec/dummy/app/models/ticket.rb
 - spec/dummy/app/views/home/index.html.erb
 - spec/dummy/app/views/layouts/application.html.erb
+- spec/dummy/app/views/payments/error.html.erb
+- spec/dummy/app/views/payments/success.html.erb
 - spec/dummy/app/views/transactions/error.html.erb
 - spec/dummy/app/views/transactions/success.html.erb
 - spec/dummy/bin/bundle
@@ -414,6 +423,7 @@ test_files:
 - spec/dummy/public/favicon.ico
 - spec/dummy/Rakefile
 - spec/dummy/README.rdoc
+- spec/dummy/spec/controllers/payments_controller_spec.rb
 - spec/dummy/spec/controllers/transactions_controller_spec.rb
 - spec/dummy/spec/lib/punto_pagos_rails/transaction_service_spec.rb
 - spec/dummy/spec/models/punto_pagos_rails/transaction_spec.rb
@@ -484,6 +494,7 @@ test_files:
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/EN/EN1sgFDBtOLV_nTM5QCygjXFjJjrCwASL91R_jbxJqo.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/EN/eNStu73G536x1iNq9tePGM6hv5Xa6-5ZsXtfJuiDtfE.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/es/esYVHbG7qL7AKN3EPN_UFicQM3c0WTcTjqjDGibdz-Y.cache
+- spec/dummy/tmp/cache/assets/sprockets/v3.0/Ey/EyWfRmUYoL59k_CqjDAePaOgc1OCqcTmsjJpanercg4.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/Fi/FiuTIVrQEp_PZDI6AFR7KQkoUtnCXkFVKyr2aSzCINI.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/HG/HGWuC1XP4qTav8SMCTMvqubfgC1g-BXJH6zXci4WaI8.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/hj/hj8Ir9wcVSy1KYrnWu9bpD24vDhCG3tvt-nKbNxb1Wg.cache
@@ -518,6 +529,7 @@ test_files:
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/VR/VRC0qpQ2CiJgNEMvtXOvEDluwkaoomyJeAm7Unfrcr0.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/VY/VYpuh0Ag6L55xqqNJ1mGLQVvGlNNH50DN6HApLtiRSk.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/w_/w_v89Lo_bpb8aAsrFe9y5cBhNobVJ6MwvJqav7plorY.cache
+- spec/dummy/tmp/cache/assets/sprockets/v3.0/wt/wt38OlyCBzCYjWbwhzKkVlJAD3_tIepF8hxEzJkiXB4.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/X7/X7YQ6EHE68K2fFs0F2XPWazA8x8qVSZuaaYjKvgRj7w.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/xU/xU8kTXBeW6eLfp_eNY6xEEideoQNSHIMC9yQ-P1OPO8.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/y8/y8u-QuBe2neNMwhZPDIz3ZE5FqNjBEux-ttpcsU9Qxc.cache