punto_pagos_rails 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c2925e8a7b2c73d9b4cefb455e60c21c2dd7d85a
-  data.tar.gz: 117862cebbbc1a6da832d3527ce0eeab6e66a835
+  metadata.gz: 0802b882684f0f88e366a6286bf88001576d7040
+  data.tar.gz: 0abf35bab91213a7d0e99ecd01a97c825b33cca7
 SHA512:
-  metadata.gz: 6238fc74190358fc857b40ae5ad545ebb25f5b12a932afee5769db43979e86f95f0a586b7e7d62773f34825e4e902aa92515d308f699ba93ba2b8ea6e8a38a11
-  data.tar.gz: 5279ff9e41f03a8a5ab4f9764ae8b8c67e88c1a9beaa68c83534cf5fe4dc9c14cd4fda9b09ada4bf70fb35ac20ad27c5ba7ff90bca4a85c81e3e941d5d51065e
+  metadata.gz: a8c5528f759e9dd8be5c6604d2c1036ae84840f69401f7ce8e18b108b3345371806555d9538d982359cbd6e61ab60aadeb03ae6462b640c31d532a03e75d0de6
+  data.tar.gz: 15942f1a64c89f99f86dc81dc0df429bf1fcbe78d3bcf4398e0565c0d9cb35fdd283e0356df07d461215b8050d73aead3ac846b520e8d75a62e5d6e808a5d6dd

data/lib/punto_pagos_rails/resource_extension.rb

@@ -5,6 +5,10 @@ module PuntoPagosRails
     extend ActiveSupport::Concern
 
     included do
+      include ActiveSupport::Callbacks
+      define_callbacks :payment_error
+      define_callbacks :payment_success
+
       has_many :transactions, class_name: 'PuntoPagosRails::Transaction', foreign_key: :resource_id
 
       def paid?
@@ -15,24 +19,7 @@ module PuntoPagosRails
     end
 
     module ClassMethods
-
-      def on_payment_error(&block)
-        @payment_error_cb = block
-      end
-
-      def on_payment_success(&block)
-        @payment_success_cb = block
-      end
-
-      def notify(resource, type)
-        if type == :error && @payment_error_cb
-          resource.instance_exec(&@payment_error_cb)
-        end
-        if type == :success && @payment_success_cb
-          resource.instance_exec(&@payment_success_cb)
-        end
-      end
-
+      # TODO
     end
   end
 end

data/lib/punto_pagos_rails/transaction_service.rb

@@ -27,10 +27,8 @@ module PuntoPagosRails
       err = params[:error]
 
       if notification.valid?(headers, params)
-        PuntoPagosRails.resource_class.notify(@resource, :success)
         respond_success(tken)
       else
-        PuntoPagosRails.resource_class.notify(@resource, :error)
         respond_error(tken, err)
       end
     end
@@ -51,16 +49,20 @@ module PuntoPagosRails
     def self.respond_success(token)
       transaction = processing_transaction(token)
       return if transaction.nil?
-      transaction.complete
-      transaction.save
+      transaction.resource.run_callbacks :payment_success do
+        transaction.complete
+        transaction.save
+      end
       { respuesta: SUCCESS_CODE, token: token }
     end
 
     def self.respond_error(token, error)
       transaction = processing_transaction(token)
       return if transaction.nil?
-      transaction.reject_with(error)
-      transaction.save
+      transaction.resource.run_callbacks :payment_error do
+        transaction.reject_with(error)
+        transaction.save
+      end
       { respuesta: ERROR_CODE, error: error, token: token }
     end
 

data/lib/punto_pagos_rails/version.rb

@@ -1,3 +1,3 @@
 module PuntoPagosRails
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/spec/dummy/app/models/ticket.rb

@@ -1,4 +1,13 @@
 class Ticket < ActiveRecord::Base
   include PuntoPagosRails::ResourceExtension
 
+  attr_reader :message
+
+  set_callback :payment_success, :after do
+    @message = "successful payment! #{self.id}"
+  end
+
+  set_callback :payment_error, :after do
+    @message = "error paying ticket #{self.id}"
+  end
 end

data/spec/dummy/spec/lib/punto_pagos_rails/transaction_service_spec.rb

@@ -11,7 +11,7 @@ RSpec.describe TransactionService do
   let(:token) { 'XXXXX' }
   let(:payment_process_url) { double }
   let(:notification) { double }
-  let(:transaction) { Transaction.create }
+  let(:transaction) { PuntoPagosRails::Transaction.create(resource: ticket) }
 
   before do
     allow(PuntoPagos::Request).to receive(:new).and_return(request)
@@ -98,6 +98,11 @@ RSpec.describe TransactionService do
 
     context "when the notification is valid" do
 
+      it "runs callback after successful payment" do
+        TransactionService.notificate({}, {})
+        expect(ticket.message).to eq("successful payment! #{ticket.id}")
+      end
+
       it "the notification is completed" do
         TransactionService.notificate({}, {})
         expect(transaction.reload.state).to eq('completed')
@@ -107,12 +112,16 @@ RSpec.describe TransactionService do
     context "when the notification is invalid" do
       before do
         allow(notification).to receive(:valid?).with({}, {}).and_return(false)
+        TransactionService.notificate({}, {})
       end
 
       it "the notification is rejected" do
-        TransactionService.notificate({}, {})
         expect(transaction.reload.state).to eq('rejected')
       end
+
+      it "calls error callbacks" do
+        expect(ticket.message).to eq("error paying ticket #{ticket.id}")
+      end
     end
 
     context "when the notification is completed" do

data/spec/rails_helper.rb

@@ -17,6 +17,8 @@ RSpec.configure do |config|
   config.order = :random
   config.render_views
   config.include FactoryGirl::Syntax::Methods
+  config.filter_run :focus
+  config.run_all_when_everything_filtered = true
 
   FactoryGirl::SyntaxRunner.send(:include, RSpec::Mocks::ExampleMethods)
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: punto_pagos_rails
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Leandro Segovia
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-27 00:00:00.000000000 Z
+date: 2015-08-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails