punchlist 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6b24e5a71761e3b922d69c22ecc75f783b5a1e52
-  data.tar.gz: 774499da75a38f680a5b8576ae46a89ed33c9f33
+  metadata.gz: 1b55daebbda4fa31c4a30fc093c1ae858ef627e9
+  data.tar.gz: 7b8ccb20957e194e5d00a9624d653112b0ae3b47
 SHA512:
-  metadata.gz: 0464696dabb58e2936812720133e0287a5ffa13c806c44ba946860c48f8fec76176ba57db05f2265003945039345c003850dbd260de919074c2163e375701ebe
-  data.tar.gz: f56075dc8576ae3121bb4263545bb46aac9d8a4c128df19c28f47f3a7f37b71f89186fa6c9e760c15969d8d57871fb5aea99409e31a2714a71368c596b385e61
+  metadata.gz: c7d1747d4ce4a85fa0834692b4e196a2f298ec8afd1a733a260812926bc81ed9d798e2762c26979a00ffbbbcb6c36dce4e635a31e407d4ad6fe711cf8aa07f22
+  data.tar.gz: f005b8d0bc9c58fe89c193840535e94bd3396c84c4e657c947de4628ea60a0469c588134849ea7b892b262c4149bed1d3a72d377171a4b307ac4326070dd2bc4

data/bin/punchlist

@@ -2,4 +2,4 @@
 
 require_relative '../lib/punchlist'
 
-Punchlist::Punchlist.new.run
+Punchlist::Punchlist.new(ARGV).run

data/lib/punchlist.rb

@@ -6,14 +6,16 @@ require_relative 'punchlist/options'
 module Punchlist
   # Counts the number of 'todo' comments in your code.
   class Punchlist
-    def initialize(outputter: STDOUT,
-                   globber: Dir,
+    def initialize(args,
+                   outputter: STDOUT,
                    file_opener: File,
-                   options_parser: Options.new(default_punchlist_line_regexp))
+                   options_parser: Options.new(args),
+                   source_file_globber: SourceFinder::SourceFileGlobber.new)
+      @args = args
       @outputter = outputter
-      @globber = globber
       @file_opener = file_opener
       @options_parser = options_parser
+      @source_file_globber = source_file_globber
     end
 
     def run
@@ -24,11 +26,6 @@ module Punchlist
       0
     end
 
-    def source_files_glob
-      @options[:glob] ||
-        '{app,lib,test,spec,feature}/**/*.{rb,swift,scala,js,cpp,c,java,py}'
-    end
-
     def analyze_files
       all_output = []
       source_files.each do |filename|
@@ -38,7 +35,13 @@ module Punchlist
     end
 
     def source_files
-      @globber.glob(source_files_glob)
+      if @options[:glob]
+        @source_file_globber.source_files_glob = @options[:glob]
+      end
+      if @options[:exclude]
+        @source_file_globber.source_files_exclude_glob = @options[:exclude]
+      end
+      @source_file_globber.source_files
     end
 
     def default_punchlist_line_regexp

data/lib/punchlist/options.rb

@@ -1,24 +1,30 @@
 require 'optparse'
+require 'source_finder/option_parser'
 
 module Punchlist
+  # Parse command line options
   class Options
     attr_reader :default_punchlist_line_regexp
 
-    def initialize(default_punchlist_line_regexp)
-      @default_punchlist_line_regexp = default_punchlist_line_regexp
+    def initialize(args,
+                   source_finder_option_parser: SourceFinder::OptionParser.new)
+      @args = args
+      @source_finder_option_parser = source_finder_option_parser
     end
 
-    def setup_options(opts)
-      options = {}
-      opts.banner = 'Usage: punchlist [options]'
-      opts.on('-g', '--glob g', 'Filename glob to identify source files') do |v|
-        options[:glob] = v
-      end
+    def parse_regexp(opts, options)
       opts.on('-r', '--regexp r',
               'Regexp to trigger on - ' \
               'default is XXX|TODO') do |v|
         options[:regexp] = v
       end
+    end
+
+    def setup_options(opts)
+      options = {}
+      opts.banner = 'Usage: punchlist [options]'
+      @source_finder_option_parser.add_options(opts, options)
+      parse_regexp(opts, options)
       options
     end
 
@@ -26,7 +32,7 @@ module Punchlist
       options = nil
       OptionParser.new do |opts|
         options = setup_options(opts)
-      end.parse!
+      end.parse!(@args)
       options
     end
   end

data/lib/punchlist/version.rb

@@ -1,5 +1,5 @@
 # Counts the number of 'todo' comments in your code ('Comment
 # annotations').
 module Punchlist
-  VERSION = '1.0.0'
+  VERSION = '1.1.0'
 end

data/punchlist.gemspec

@@ -26,6 +26,8 @@ Gem::Specification.new do |s|
   s.rubygems_version = '1.3.6'
   s.summary = 'Finds largest source files in a project'
 
+  s.add_dependency('source_finder')
+
   s.add_development_dependency('bundler')
   s.add_development_dependency('rake')
   s.add_development_dependency('quality')

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: punchlist
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Vince Broz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-27 00:00:00.000000000 Z
+date: 2015-09-12 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: source_finder
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement