punching_bag 0.3.4 → 0.3.5

data/spec/lib/punching_bag_spec.rb

@@ -0,0 +1,33 @@
+require 'spec_helper'
+
+describe PunchingBag do
+  let(:article) { Article.create title: 'Hector', content: 'Ding, ding ding... ding. Ding. DING. DING! ' }
+  let(:human_request) { OpenStruct.new(bot?: false) }
+  let(:bot_request) { OpenStruct.new(bot?: true) }
+
+  subject { PunchingBag }
+
+  describe '.punch' do
+    it 'does nothing when the request is from a bot' do
+      expect(PunchingBag.punch(article, bot_request)).to be_false
+    end
+
+    it 'creates a new punch when the request is valid' do
+      expect { PunchingBag.punch(article, human_request) }.to change { Punch.count }.by 1
+    end
+
+    it 'creates a new punch when there is no request' do
+      expect { PunchingBag.punch(article) }.to change { Punch.count }.by 1
+    end
+  end
+
+  describe '.average_time' do
+    let(:time) { Time.zone.now.beginning_of_day }
+    let(:punch_1) { Punch.new(average_time: time + 15.seconds, hits: 2) }
+    let(:punch_2) { Punch.new(average_time: time + 30.seconds, hits: 4) }
+
+    it 'finds an average time for multiple punches' do
+      expect(PunchingBag.average_time(punch_1, punch_2)).to eql (time + 25.seconds)
+    end
+  end
+end

data/spec/models/punch_spec.rb

@@ -0,0 +1,98 @@
+require 'spec_helper'
+
+describe Punch do
+  let(:day) { Time.now.beginning_of_day }
+  let(:month) { Time.now.beginning_of_month }
+  let(:year) { Time.now.beginning_of_year }
+
+  let(:attrs) { {} }
+  let(:article) { Article.create title: 'Bluths', content: "I know, I just call her Annabelle cause she's shaped like a... she's the belle of the ball!" }
+  let(:punch) { Punch.new attrs.merge(punchable: article) }
+
+  subject { punch }
+  before { subject.valid? } # sets default values
+
+  context 'with one hit' do
+    its(:hits) { should eql 1 }
+    its(:jab?) { should be_true }
+    its(:combo?) { should be_false }
+  end
+
+  context 'with two hits' do
+    let(:attrs) { {hits: 2} }
+
+    its(:hits) { should eql 2 }
+    its(:jab?) { should be_false }
+    its(:combo?) { should be_true }
+  end
+
+  context 'with start time same as end time' do
+    its(:timeframe) { should eql :second }
+    its(:day_combo?) { should be_false }
+    its(:month_combo?) { should be_false }
+    its(:year_combo?) { should be_false }
+  end
+
+  context 'with start time in the same day as end time' do
+    let(:attrs) { {starts_at: day + 1.hour, ends_at: day + 2.hours } }
+
+    its(:timeframe) { should eql :day }
+    its(:day_combo?) { should be_true }
+    its(:month_combo?) { should be_false }
+    its(:year_combo?) { should be_false }
+  end
+
+  context 'with start time in the same month as end time' do
+    let(:attrs) { {starts_at: month + 1.day, ends_at: month + 2.days } }
+
+    its(:timeframe) { should eql :month }
+    its(:day_combo?) { should be_false }
+    its(:month_combo?) { should be_true }
+    its(:year_combo?) { should be_false }
+  end
+
+  context 'with start time in the same year as end time' do
+    let(:attrs) { {starts_at: year + 1.month, ends_at: year + 2.months } }
+
+    its(:timeframe) { should eql :year }
+    its(:day_combo?) { should be_false }
+    its(:month_combo?) { should be_false }
+    its(:year_combo?) { should be_true }
+  end
+
+  context 'with another punch on the same day' do
+    let(:attrs) { {hits: 1, starts_at: day + 1.hour } }
+    let!(:other_punch) { Punch.create punchable: article, starts_at: day + 2.hours }
+    let!(:next_week_punch) { Punch.create punchable: article, starts_at: day + 7.days }
+
+    before { punch.save! }
+
+    describe '#combine_with' do
+      it 'destroys the punch' do
+        expect { punch.combine_with other_punch }.to change { punch.destroyed? }.from(false).to true
+      end
+
+      it 'combines the hits' do
+        expect { punch.combine_with other_punch }.to change { other_punch.hits }.from(1).to 2
+      end
+
+      it 'changes starts_at or ends_at' do
+        expect { punch.combine_with other_punch }.to change { other_punch.starts_at }.from(day + 2.hours).to(day + 1.hour)
+      end
+
+      it 'changes the average_time' do
+        expect { punch.combine_with other_punch }.to change { other_punch.average_time }.from(day + 2.hours).to(day + 90.minutes)
+      end
+    end
+
+    describe '#find_combo_for' do
+      it 'finds the other punch in the day' do
+        expect(punch.find_combo_for(:day)).to eql other_punch
+      end
+
+      it "does't find the next week punch" do
+        expect(punch.find_combo_for(:day)).to_not eql next_week_punch
+      end
+    end
+  end
+end

data/spec/models/punchable_spec.rb

@@ -0,0 +1,57 @@
+require 'spec_helper'
+
+describe Article do
+  let(:article_1) { Article.create title: 'Bacon', content: 'Bacon ipsum dolor sit amet turkey short ribs tri-tip' }
+  let(:article_2) { Article.create title: 'Hipsters', content: 'American Apparel aute Banksy officia ugh.' }
+  let(:article_3) { Article.create title: 'Lebowski', content: 'Lebowski ipsum over the line! Dolor sit amet, consectetur adipiscing elit praesent ac.' }
+
+  # Instance methods
+  describe 'Article' do
+    subject { article_1 }
+
+    describe '#hits' do
+      context 'with no hits' do
+        its(:hits) { should eql 0 }
+      end
+
+      context 'with one hit' do
+        before { subject.punch }
+        its(:hits) { should eql 1 }
+      end
+    end
+
+    describe '#punch' do
+      it 'incleases hits by one' do
+        expect { subject.punch }.to change { subject.hits }.by 1
+      end
+    end
+  end
+
+  # Class methods
+  describe 'Article' do
+    subject { Article }
+
+    before do
+      2.times { article_3.punch }
+      article_1.punch
+    end
+
+    describe '.most_hit' do
+      its(:most_hit) { should include article_3 }
+      its(:most_hit) { should include article_1 }
+      its(:most_hit) { should_not include article_2 }
+
+      its('most_hit.first') { should eql article_3 }
+      its('most_hit.second') { should eql article_1 }
+    end
+
+    describe '.sort_by_popularity' do
+      its(:sort_by_popularity) { should include article_1 }
+      its(:sort_by_popularity) { should include article_2 }
+      its(:sort_by_popularity) { should include article_3 }
+
+      its('sort_by_popularity.first') { should eql article_3 }
+      its('sort_by_popularity.second') { should eql article_1 }
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,18 @@
+ENV['RAILS_ENV'] = 'test'
+
+require 'bundler/setup'
+require 'combustion'
+
+Bundler.require :default
+
+Combustion.initialize! :active_record
+
+require 'rspec/rails'
+require 'rspec/autorun'
+
+require 'active_support/time'
+require 'ostruct'
+
+RSpec.configure do |config|
+  config.use_transactional_fixtures = true
+end

metadata

@@ -1,29 +1,99 @@
 --- !ruby/object:Gem::Specification
 name: punching_bag
 version: !ruby/object:Gem::Version
-  version: 0.3.4
+  version: 0.3.5
 platform: ruby
 authors:
 - Adam Crownoble
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-02 00:00:00.000000000 Z
+date: 2013-10-03 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: railties
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: voight_kampff
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 0.1.1
+        version: 0.2.0
   type: :runtime
   prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: 0.2.0
+- !ruby/object:Gem::Dependency
+  name: activerecord
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 4.0.0
+  type: :development
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.1.1
+        version: 4.0.0
+- !ruby/object:Gem::Dependency
+  name: combustion
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: PunchingBag is a hit counting and simple trending engine for Ruby on
   Rails
 email: adam@obledesign.com
@@ -31,6 +101,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- MIT-LICENSE
 - app/models/punch.rb
 - lib/punching_bag/version.rb
 - lib/punching_bag/engine.rb
@@ -40,6 +111,15 @@ files:
 - lib/generators/punching_bag/templates/create_punches_table.rb
 - lib/punching_bag.rb
 - lib/tasks/punching_bag.rake
+- spec/spec_helper.rb
+- spec/lib/punching_bag_spec.rb
+- spec/models/punch_spec.rb
+- spec/models/punchable_spec.rb
+- spec/internal/db/schema.rb
+- spec/internal/db/combustion_test.sqlite
+- spec/internal/config/database.yml
+- spec/internal/app/models/article.rb
+- spec/internal/log/test.log
 homepage: https://github.com/biola/punching_bag
 licenses: []
 metadata: {}
@@ -63,4 +143,13 @@ rubygems_version: 2.0.3
 signing_key: 
 specification_version: 4
 summary: PunchingBag hit conter and trending plugin
-test_files: []
+test_files:
+- spec/spec_helper.rb
+- spec/lib/punching_bag_spec.rb
+- spec/models/punch_spec.rb
+- spec/models/punchable_spec.rb
+- spec/internal/db/schema.rb
+- spec/internal/db/combustion_test.sqlite
+- spec/internal/config/database.yml
+- spec/internal/app/models/article.rb
+- spec/internal/log/test.log