punchblock 2.5.2 → 2.5.3

data/spec/punchblock/translator/freeswitch/component/flite_output_spec.rb

@@ -35,7 +35,7 @@ module Punchblock
           describe '#execute' do
             before { original_command.request! }
             def expect_playback(voice = :kal, doc = "FOO")
-              subject.wrapped_object.should_receive(:application).once.with :speak, "flite|#{voice}|#{doc}"
+              expect(subject.wrapped_object).to receive(:application).once.with :speak, "flite|#{voice}|#{doc}"
             end
 
             let(:command_opts) { {} }
@@ -54,7 +54,7 @@ module Punchblock
                 it "should return an error and not execute any actions" do
                   execute
                   error = ProtocolError.new.setup 'option error', 'An SSML document is required.'
-                  original_command.response(0.1).should be == error
+                  expect(original_command.response(0.1)).to eq(error)
                 end
               end
 
@@ -68,7 +68,7 @@ module Punchblock
                   expect_playback
                   execute
                   subject.handle_es_event RubyFS::Event.new(nil, :event_name => "CHANNEL_EXECUTE_COMPLETE")
-                  original_command.complete_event(0.1).reason.should be_a Punchblock::Component::Output::Complete::Finish
+                  expect(original_command.complete_event(0.1).reason).to be_a Punchblock::Component::Output::Complete::Finish
                 end
               end
 
@@ -96,7 +96,7 @@ module Punchblock
                 it "should return an error and not execute any actions" do
                   execute
                   error = ProtocolError.new.setup 'option error', 'A start_offset value is unsupported.'
-                  original_command.response(0.1).should be == error
+                  expect(original_command.response(0.1)).to eq(error)
                 end
               end
             end
@@ -115,7 +115,7 @@ module Punchblock
                 it "should return an error and not execute any actions" do
                   execute
                   error = ProtocolError.new.setup 'option error', 'A start_paused value is unsupported.'
-                  original_command.response(0.1).should be == error
+                  expect(original_command.response(0.1)).to eq(error)
                 end
               end
             end
@@ -134,7 +134,7 @@ module Punchblock
                 it "should return an error and not execute any actions" do
                   execute
                   error = ProtocolError.new.setup 'option error', 'A repeat_interval value is unsupported.'
-                  original_command.response(0.1).should be == error
+                  expect(original_command.response(0.1)).to eq(error)
                 end
               end
             end
@@ -153,7 +153,7 @@ module Punchblock
                 it "should return an error and not execute any actions" do
                   execute
                   error = ProtocolError.new.setup 'option error', 'A repeat_times value is unsupported.'
-                  original_command.response(0.1).should be == error
+                  expect(original_command.response(0.1)).to eq(error)
                 end
               end
             end
@@ -172,7 +172,7 @@ module Punchblock
                 it "should return an error and not execute any actions" do
                   execute
                   error = ProtocolError.new.setup 'option error', 'A max_time value is unsupported.'
-                  original_command.response(0.1).should be == error
+                  expect(original_command.response(0.1)).to eq(error)
                 end
               end
             end
@@ -209,7 +209,7 @@ module Punchblock
                 it "should return an error and not execute any actions" do
                   execute
                   error = ProtocolError.new.setup 'option error', 'An interrupt-on value of any is unsupported.'
-                  original_command.response(0.1).should be == error
+                  expect(original_command.response(0.1)).to eq(error)
                 end
               end
 
@@ -218,7 +218,7 @@ module Punchblock
                 it "should return an error and not execute any actions" do
                   execute
                   error = ProtocolError.new.setup 'option error', 'An interrupt-on value of dtmf is unsupported.'
-                  original_command.response(0.1).should be == error
+                  expect(original_command.response(0.1)).to eq(error)
                 end
               end
 
@@ -227,7 +227,7 @@ module Punchblock
                 it "should return an error and not execute any actions" do
                   execute
                   error = ProtocolError.new.setup 'option error', 'An interrupt-on value of voice is unsupported.'
-                  original_command.response(0.1).should be == error
+                  expect(original_command.response(0.1)).to eq(error)
                 end
               end
             end
@@ -241,7 +241,7 @@ module Punchblock
 
               it "returns a ProtocolError response" do
                 subject.execute_command command
-                command.response(0.1).should be_a ProtocolError
+                expect(command.response(0.1)).to be_a ProtocolError
               end
             end
 
@@ -256,21 +256,21 @@ module Punchblock
               end
 
               it "sets the command response to true" do
-                subject.wrapped_object.should_receive(:application)
+                expect(subject.wrapped_object).to receive(:application)
                 subject.execute_command command
-                command.response(0.1).should be == true
+                expect(command.response(0.1)).to eq(true)
               end
 
               it "sends the correct complete event" do
-                subject.wrapped_object.should_receive(:application)
-                original_command.should_not be_complete
+                expect(subject.wrapped_object).to receive(:application)
+                expect(original_command).not_to be_complete
                 subject.execute_command command
-                reason.should be_a Punchblock::Event::Complete::Stop
-                original_command.should be_complete
+                expect(reason).to be_a Punchblock::Event::Complete::Stop
+                expect(original_command).to be_complete
               end
 
               it "breaks the current dialplan application" do
-                subject.wrapped_object.should_receive(:application).once.with 'break'
+                expect(subject.wrapped_object).to receive(:application).once.with 'break'
                 subject.execute_command command
               end
             end

data/spec/punchblock/translator/freeswitch/component/input_spec.rb

@@ -88,11 +88,11 @@ module Punchblock
                 end
 
                 it "should send a success complete event with the relevant data" do
-                  reason.should be == expected_event
+                  expect(reason).to eq(expected_event)
                 end
 
                 it "should not process further dtmf events" do
-                  subject.async.should_receive(:process_dtmf).never
+                  expect(subject.async).to receive(:process_dtmf).never
                   send_dtmf 3
                 end
               end
@@ -108,7 +108,7 @@ module Punchblock
                 end
 
                 it "should send a nomatch complete event" do
-                  reason.should be == expected_event
+                  expect(reason).to eq(expected_event)
                 end
               end
             end
@@ -119,7 +119,7 @@ module Punchblock
                 it "should return an error and not execute any actions" do
                   subject.execute
                   error = ProtocolError.new.setup 'option error', 'A grammar document is required.'
-                  original_command.response(0.1).should be == error
+                  expect(original_command.response(0.1)).to eq(error)
                 end
               end
 
@@ -146,7 +146,7 @@ module Punchblock
                 end
 
                 it "should use RubySpeech builtin grammar" do
-                  reason.should be == expected_event
+                  expect(reason).to eq(expected_event)
                 end
               end
 
@@ -173,7 +173,7 @@ module Punchblock
                 end
 
                 it "should use RubySpeech builtin grammar" do
-                  reason.should be == expected_event
+                  expect(reason).to eq(expected_event)
                 end
               end
 
@@ -183,7 +183,7 @@ module Punchblock
                 it "should return an error and not execute any actions" do
                   subject.execute
                   error = ProtocolError.new.setup 'option error', 'foobar is an invalid builtin grammar'
-                  original_command.response(0.1).should be == error
+                  expect(original_command.response(0.1)).to eq(error)
                 end
               end
 
@@ -192,7 +192,7 @@ module Punchblock
                 it "should return an error and not execute any actions" do
                   subject.execute
                   error = ProtocolError.new.setup 'option error', 'Only a single grammar is supported.'
-                  original_command.response(0.1).should be == error
+                  expect(original_command.response(0.1)).to eq(error)
                 end
               end
             end
@@ -203,7 +203,7 @@ module Punchblock
                 it "should return an error and not execute any actions" do
                   subject.execute
                   error = ProtocolError.new.setup 'option error', 'A mode value other than DTMF is unsupported.'
-                  original_command.response(0.1).should be == error
+                  expect(original_command.response(0.1)).to eq(error)
                 end
               end
 
@@ -212,7 +212,7 @@ module Punchblock
                 it "should return an error and not execute any actions" do
                   subject.execute
                   error = ProtocolError.new.setup 'option error', 'A mode value other than DTMF is unsupported.'
-                  original_command.response(0.1).should be == error
+                  expect(original_command.response(0.1)).to eq(error)
                 end
               end
 
@@ -221,7 +221,7 @@ module Punchblock
                 it "should return an error and not execute any actions" do
                   subject.execute
                   error = ProtocolError.new.setup 'option error', 'A mode value other than DTMF is unsupported.'
-                  original_command.response(0.1).should be == error
+                  expect(original_command.response(0.1)).to eq(error)
                 end
               end
             end
@@ -243,7 +243,7 @@ module Punchblock
                   send_dtmf 1
                   sleep 1.5
                   send_dtmf 2
-                  reason.should be_a Punchblock::Component::Input::Complete::Match
+                  expect(reason).to be_a Punchblock::Component::Input::Complete::Match
                 end
 
                 it "should cause a NoInput complete event to be sent after the timeout" do
@@ -251,7 +251,7 @@ module Punchblock
                   sleep 1.5
                   send_dtmf 1
                   send_dtmf 2
-                  reason.should be_a Punchblock::Component::Input::Complete::NoInput
+                  expect(reason).to be_a Punchblock::Component::Input::Complete::NoInput
                 end
               end
 
@@ -259,7 +259,7 @@ module Punchblock
                 let(:original_command_opts) { { :initial_timeout => -1 } }
 
                 it "should not start a timer" do
-                  subject.wrapped_object.should_receive(:begin_initial_timer).never
+                  expect(subject.wrapped_object).to receive(:begin_initial_timer).never
                   subject.execute
                 end
               end
@@ -268,7 +268,7 @@ module Punchblock
                 let(:original_command_opts) { { :initial_timeout => nil } }
 
                 it "should not start a timer" do
-                  subject.wrapped_object.should_receive(:begin_initial_timer).never
+                  expect(subject.wrapped_object).to receive(:begin_initial_timer).never
                   subject.execute
                 end
               end
@@ -279,7 +279,7 @@ module Punchblock
                 it "should return an error and not execute any actions" do
                   subject.execute
                   error = ProtocolError.new.setup 'option error', 'An initial timeout value that is negative (and not -1) is invalid.'
-                  original_command.response(0.1).should be == error
+                  expect(original_command.response(0.1)).to eq(error)
                 end
               end
             end
@@ -294,7 +294,7 @@ module Punchblock
                   send_dtmf 1
                   sleep 0.5
                   send_dtmf 2
-                  reason.should be_a Punchblock::Component::Input::Complete::Match
+                  expect(reason).to be_a Punchblock::Component::Input::Complete::Match
                 end
 
                 it "should cause a InterDigitTimeout complete event to be sent after the timeout" do
@@ -303,7 +303,7 @@ module Punchblock
                   send_dtmf 1
                   sleep 1.5
                   send_dtmf 2
-                  reason.should be_a Punchblock::Component::Input::Complete::NoMatch
+                  expect(reason).to be_a Punchblock::Component::Input::Complete::NoMatch
                 end
               end
 
@@ -311,7 +311,7 @@ module Punchblock
                 let(:original_command_opts) { { :inter_digit_timeout => -1 } }
 
                 it "should not start a timer" do
-                  subject.wrapped_object.should_receive(:begin_inter_digit_timer).never
+                  expect(subject.wrapped_object).to receive(:begin_inter_digit_timer).never
                   subject.execute
                 end
               end
@@ -320,7 +320,7 @@ module Punchblock
                 let(:original_command_opts) { { :inter_digit_timeout => nil } }
 
                 it "should not start a timer" do
-                  subject.wrapped_object.should_receive(:begin_inter_digit_timer).never
+                  expect(subject.wrapped_object).to receive(:begin_inter_digit_timer).never
                   subject.execute
                 end
               end
@@ -331,7 +331,7 @@ module Punchblock
                 it "should return an error and not execute any actions" do
                   subject.execute
                   error = ProtocolError.new.setup 'option error', 'An inter-digit timeout value that is negative (and not -1) is invalid.'
-                  original_command.response(0.1).should be == error
+                  expect(original_command.response(0.1)).to eq(error)
                 end
               end
             end
@@ -357,7 +357,7 @@ module Punchblock
 
               it "returns a ProtocolError response" do
                 subject.execute_command command
-                command.response(0.1).should be_a ProtocolError
+                expect(command.response(0.1)).to be_a ProtocolError
               end
             end
 
@@ -373,8 +373,8 @@ module Punchblock
 
               it "sets the command response to true" do
                 subject.execute_command command
-                command.response(0.1).should be == true
-                reason.should be_a Punchblock::Event::Complete::Stop
+                expect(command.response(0.1)).to eq(true)
+                expect(reason).to be_a Punchblock::Event::Complete::Stop
               end
             end
           end

data/spec/punchblock/translator/freeswitch/component/output_spec.rb

@@ -31,7 +31,7 @@ module Punchblock
           describe '#execute' do
             before { original_command.request! }
             def expect_playback(filename = audio_filename)
-              subject.wrapped_object.should_receive(:application).once.with 'playback', "file_string://#{filename}"
+              expect(subject.wrapped_object).to receive(:application).once.with 'playback', "file_string://#{filename}"
             end
 
             let(:audio_filename) { 'http://foo.com/bar.mp3' }
@@ -59,7 +59,7 @@ module Punchblock
                 it "should return an error and not execute any actions" do
                   subject.execute
                   error = ProtocolError.new.setup 'option error', 'An SSML document is required.'
-                  original_command.response(0.1).should be == error
+                  expect(original_command.response(0.1)).to eq(error)
                 end
               end
 
@@ -78,7 +78,7 @@ module Punchblock
                   expect_playback
                   subject.execute
                   subject.handle_es_event RubyFS::Event.new(nil, :event_name => "CHANNEL_EXECUTE_COMPLETE", :application_response => 'FILE PLAYED')
-                  original_command.complete_event(0.1).reason.should be_a Punchblock::Component::Output::Complete::Finish
+                  expect(original_command.complete_event(0.1).reason).to be_a Punchblock::Component::Output::Complete::Finish
                 end
 
                 context "when playback returns an error" do
@@ -89,8 +89,8 @@ module Punchblock
                     expect_playback
                     subject.execute
                     subject.handle_es_event fs_event
-                    complete_reason.should be_a Punchblock::Event::Complete::Error
-                    complete_reason.details.should == 'Engine error: PLAYBACK ERROR'
+                    expect(complete_reason).to be_a Punchblock::Event::Complete::Error
+                    expect(complete_reason.details).to eq('Engine error: PLAYBACK ERROR')
                   end
                 end
               end
@@ -114,7 +114,7 @@ module Punchblock
                   expect_playback([audio_filename1, audio_filename2].join('!'))
                   subject.execute
                   subject.handle_es_event RubyFS::Event.new(nil, :event_name => "CHANNEL_EXECUTE_COMPLETE", :application_response => "FILE PLAYED")
-                  original_command.complete_event(0.1).reason.should be_a Punchblock::Component::Output::Complete::Finish
+                  expect(original_command.complete_event(0.1).reason).to be_a Punchblock::Component::Output::Complete::Finish
                 end
               end
 
@@ -128,7 +128,7 @@ module Punchblock
                 it "should return an unrenderable document error" do
                   subject.execute
                   error = ProtocolError.new.setup 'unrenderable document error', 'The provided document could not be rendered. See http://adhearsion.com/docs/common_problems#unrenderable-document-error for details.'
-                  original_command.response(0.1).should be == error
+                  expect(original_command.response(0.1)).to eq(error)
                 end
               end
 
@@ -160,7 +160,7 @@ module Punchblock
                 it "should return an error and not execute any actions" do
                   subject.execute
                   error = ProtocolError.new.setup 'option error', 'A start_offset value is unsupported.'
-                  original_command.response(0.1).should be == error
+                  expect(original_command.response(0.1)).to eq(error)
                 end
               end
             end
@@ -179,7 +179,7 @@ module Punchblock
                 it "should return an error and not execute any actions" do
                   subject.execute
                   error = ProtocolError.new.setup 'option error', 'A start_paused value is unsupported.'
-                  original_command.response(0.1).should be == error
+                  expect(original_command.response(0.1)).to eq(error)
                 end
               end
             end
@@ -198,7 +198,7 @@ module Punchblock
                 it "should return an error and not execute any actions" do
                   subject.execute
                   error = ProtocolError.new.setup 'option error', 'A repeat_interval value is unsupported.'
-                  original_command.response(0.1).should be == error
+                  expect(original_command.response(0.1)).to eq(error)
                 end
               end
             end
@@ -217,7 +217,7 @@ module Punchblock
                 it "should return an error and not execute any actions" do
                   subject.execute
                   error = ProtocolError.new.setup 'option error', 'A repeat_times value is unsupported.'
-                  original_command.response(0.1).should be == error
+                  expect(original_command.response(0.1)).to eq(error)
                 end
               end
             end
@@ -236,7 +236,7 @@ module Punchblock
                 it "should return an error and not execute any actions" do
                   subject.execute
                   error = ProtocolError.new.setup 'option error', 'A max_time value is unsupported.'
-                  original_command.response(0.1).should be == error
+                  expect(original_command.response(0.1)).to eq(error)
                 end
               end
             end
@@ -273,7 +273,7 @@ module Punchblock
                 it "should return an error and not execute any actions" do
                   subject.execute
                   error = ProtocolError.new.setup 'option error', 'An interrupt-on value of any is unsupported.'
-                  original_command.response(0.1).should be == error
+                  expect(original_command.response(0.1)).to eq(error)
                 end
               end
 
@@ -282,7 +282,7 @@ module Punchblock
                 it "should return an error and not execute any actions" do
                   subject.execute
                   error = ProtocolError.new.setup 'option error', 'An interrupt-on value of dtmf is unsupported.'
-                  original_command.response(0.1).should be == error
+                  expect(original_command.response(0.1)).to eq(error)
                 end
               end
 
@@ -291,7 +291,7 @@ module Punchblock
                 it "should return an error and not execute any actions" do
                   subject.execute
                   error = ProtocolError.new.setup 'option error', 'An interrupt-on value of voice is unsupported.'
-                  original_command.response(0.1).should be == error
+                  expect(original_command.response(0.1)).to eq(error)
                 end
               end
             end
@@ -305,7 +305,7 @@ module Punchblock
 
               it "returns a ProtocolError response" do
                 subject.execute_command command
-                command.response(0.1).should be_a ProtocolError
+                expect(command.response(0.1)).to be_a ProtocolError
               end
             end
 
@@ -320,21 +320,21 @@ module Punchblock
               end
 
               it "sets the command response to true" do
-                subject.wrapped_object.should_receive(:application)
+                expect(subject.wrapped_object).to receive(:application)
                 subject.execute_command command
-                command.response(0.1).should be == true
+                expect(command.response(0.1)).to eq(true)
               end
 
               it "sends the correct complete event" do
-                subject.wrapped_object.should_receive(:application)
-                original_command.should_not be_complete
+                expect(subject.wrapped_object).to receive(:application)
+                expect(original_command).not_to be_complete
                 subject.execute_command command
-                reason.should be_a Punchblock::Event::Complete::Stop
-                original_command.should be_complete
+                expect(reason).to be_a Punchblock::Event::Complete::Stop
+                expect(original_command).to be_complete
               end
 
               it "breaks the current dialplan application" do
-                subject.wrapped_object.should_receive(:application).once.with 'break'
+                expect(subject.wrapped_object).to receive(:application).once.with 'break'
                 subject.execute_command command
               end
             end