puma 5.2.2-java → 5.4.0-java

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puma might be problematic. Click here for more details.

checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: 560d63fd273aee23f37110caf0011f49ba6bd024c076415d434f4d67ab018d0b
4
- data.tar.gz: 31f20ebfd82a21afdce44c18352bfa08efe8b43589e86a307881ec7ba6617dcd
3
+ metadata.gz: f444ef34d8cafa5f0be5dfea6e4ded00951e68db19f53dbe18439923577b46ec
4
+ data.tar.gz: 7e0f1a76a1b9f643ae1a21cbba578780c0cea60aa63c59b1cf3a3dccb155665d
5
5
  SHA512:
6
- metadata.gz: 55dde02be1029df2192b5e09306d5a738e224f415f9ea288c278fa746c4103cecfd58d0d830ff9a026beb50d1a55ccd9c2e7875235e77e9a30a9df16f781484a
7
- data.tar.gz: 69b8152d773645ffc452f60358cb4453aef2186f94e2075da0a73af57bd0d4b0373ec4b47861bd06b068efea339d4cd2cbd1a593a007e52322605235f402eed7
6
+ metadata.gz: af8a4a9b8b090fb21075b203bfaaa833f41c3a51b55c4ac30026f825832e2eba6faa7c313cf76c4ce2a5f8c44977326a1800815eb78bb560e1e133bfa78f9d74
7
+ data.tar.gz: 2089460d96d088b386d7ac074d7b011cc8c0a74366135c884fc861480bb483076cb6858d256483eadaa66b51a4c44e9f823ed45fd1ea9a8bb2b5ef3e3319dfab
data/History.md CHANGED
@@ -1,3 +1,58 @@
1
+ ## 5.4.0 / 2021-07-28
2
+
3
+ * Features
4
+ * Better/expanded names for threadpool threads ([#2657])
5
+ * Allow pkg_config for OpenSSL ([#2648], [#1412])
6
+ * Add `rack_url_scheme` to Puma::DSL, allows setting of `rack.url_scheme` header ([#2586], [#2569])
7
+
8
+ * Bugfixes
9
+ * `Binder#parse` - allow for symlinked unix path, add create_activated_fds debug ENV ([#2643], [#2638])
10
+ * Fix deprecation warning: minissl.c - Use Random.bytes if available ([#2642])
11
+ * Client certificates: set session id context while creating SSLContext ([#2633])
12
+
13
+ * Refactor
14
+ * Replace `IO.select` with `IO#wait_*` when checking a single IO ([#2666])
15
+
16
+ ## 5.3.2 / 2021-05-21
17
+
18
+ * Bugfixes
19
+ * Gracefully handle Rack not accepting CLI options ([#2630], [#2626])
20
+ * Fix sigterm misbehavior ([#2629])
21
+ * Improvements to keepalive-connection shedding ([#2628])
22
+
23
+ ## 5.3.1 / 2021-05-11
24
+
25
+ * Security
26
+ * Close keepalive connections after the maximum number of fast inlined requests (CVE-2021-29509) ([#2625])
27
+
28
+ ## 5.3.0 / 2021-05-07
29
+
30
+ * Features
31
+ * Add support for Linux's abstract sockets ([#2564], [#2526])
32
+ * Add debug to worker timeout and startup ([#2559], [#2528])
33
+ * Print warning when running one-worker cluster ([#2565], [#2534])
34
+ * Don't close systemd activated socket on pumactl restart ([#2563], [#2504])
35
+
36
+ * Bugfixes
37
+ * systemd - fix event firing ([#2591], [#2572])
38
+ * Immediately unlink temporary files ([#2613])
39
+ * Improve parsing of HTTP_HOST header ([#2605], [#2584])
40
+ * Handle fatal error that has no backtrace ([#2607], [#2552])
41
+ * Fix timing out requests too early ([#2606], [#2574])
42
+ * Handle segfault in Ruby 2.6.6 on thread-locals ([#2567], [#2566])
43
+ * Server#closed_socket? - parameter may be a MiniSSL::Socket ([#2596])
44
+ * Define UNPACK_TCP_STATE_FROM_TCP_INFO in the right place ([#2588], [#2556])
45
+ * request.rb - fix chunked assembly for ascii incompatible encodings, add test ([#2585], [#2583])
46
+
47
+ * Performance
48
+ * Reset peerip only if remote_addr_header is set ([#2609])
49
+ * Reduce puma_parser struct size ([#2590])
50
+
51
+ * Refactor
52
+ * Refactor drain on shutdown ([#2600])
53
+ * Micro optimisations in `wait_for_less_busy_worker` feature ([#2579])
54
+ * Lots of test fixes
55
+
1
56
  ## 5.2.2 / 2021-02-22
2
57
 
3
58
  * Bugfixes
@@ -180,6 +235,11 @@
180
235
  * Support parallel tests in verbose progress reporting ([#2223])
181
236
  * Refactor error handling in server accept loop ([#2239])
182
237
 
238
+ ## 4.3.8 / 2021-05-11
239
+
240
+ * Security
241
+ * Close keepalive connections after the maximum number of fast inlined requests (CVE-2021-29509) ([#2625])
242
+
183
243
  ## 4.3.7 / 2020-11-30
184
244
 
185
245
  * Bugfixes
@@ -1708,8 +1768,51 @@ be added back in a future date when a java Puma::MiniSSL is added.
1708
1768
  * Bugfixes
1709
1769
  * Your bugfix goes here <Most recent on the top, like GitHub> (#Github Number)
1710
1770
 
1771
+ [#2657]:https://github.com/puma/puma/pull/2657 "PR by @olivierbellone, merged 2021-07-13"
1772
+ [#2648]:https://github.com/puma/puma/pull/2648 "PR by @MSP-Greg, merged 2021-06-27"
1773
+ [#1412]:https://github.com/puma/puma/issues/1412 "Issue by @x-yuri, closed 2021-06-27"
1774
+ [#2586]:https://github.com/puma/puma/pull/2586 "PR by @MSP-Greg, merged 2021-05-26"
1775
+ [#2569]:https://github.com/puma/puma/issues/2569 "Issue by @tarragon, closed 2021-05-26"
1776
+ [#2643]:https://github.com/puma/puma/pull/2643 "PR by @MSP-Greg, merged 2021-06-27"
1777
+ [#2638]:https://github.com/puma/puma/issues/2638 "Issue by @gingerlime, closed 2021-06-27"
1778
+ [#2642]:https://github.com/puma/puma/pull/2642 "PR by @MSP-Greg, merged 2021-06-16"
1779
+ [#2633]:https://github.com/puma/puma/pull/2633 "PR by @onlined, merged 2021-06-04"
1780
+ [#2666]:https://github.com/puma/puma/pull/2666 "PR by @MSP-Greg, merged 2021-07-25"
1781
+ [#2630]:https://github.com/puma/puma/pull/2630 "PR by @seangoedecke, merged 2021-05-20"
1782
+ [#2626]:https://github.com/puma/puma/issues/2626 "Issue by @rorymckinley, closed 2021-05-20"
1783
+ [#2629]:https://github.com/puma/puma/pull/2629 "PR by @ye-lin-aung, merged 2021-05-20"
1784
+ [#2628]:https://github.com/puma/puma/pull/2628 "PR by @wjordan, merged 2021-05-20"
1785
+ [#2625]:https://github.com/puma/puma/issues/2625 "Issue by @jarthod, closed 2021-05-11"
1786
+ [#2564]:https://github.com/puma/puma/pull/2564 "PR by @MSP-Greg, merged 2021-04-24"
1787
+ [#2526]:https://github.com/puma/puma/issues/2526 "Issue by @nerdrew, closed 2021-04-24"
1788
+ [#2559]:https://github.com/puma/puma/pull/2559 "PR by @ylecuyer, merged 2021-03-11"
1789
+ [#2528]:https://github.com/puma/puma/issues/2528 "Issue by @cjlarose, closed 2021-03-11"
1790
+ [#2565]:https://github.com/puma/puma/pull/2565 "PR by @CGA1123, merged 2021-03-09"
1791
+ [#2534]:https://github.com/puma/puma/issues/2534 "Issue by @nateberkopec, closed 2021-03-09"
1792
+ [#2563]:https://github.com/puma/puma/pull/2563 "PR by @MSP-Greg, merged 2021-03-06"
1793
+ [#2504]:https://github.com/puma/puma/issues/2504 "Issue by @fsateler, closed 2021-03-06"
1794
+ [#2591]:https://github.com/puma/puma/pull/2591 "PR by @MSP-Greg, merged 2021-05-05"
1795
+ [#2572]:https://github.com/puma/puma/issues/2572 "Issue by @josefbilendo, closed 2021-05-05"
1796
+ [#2613]:https://github.com/puma/puma/pull/2613 "PR by @smcgivern, merged 2021-04-27"
1797
+ [#2605]:https://github.com/puma/puma/pull/2605 "PR by @pascalbetz, merged 2021-04-26"
1798
+ [#2584]:https://github.com/puma/puma/issues/2584 "Issue by @kaorihinata, closed 2021-04-26"
1799
+ [#2607]:https://github.com/puma/puma/pull/2607 "PR by @calvinxiao, merged 2021-04-23"
1800
+ [#2552]:https://github.com/puma/puma/issues/2552 "Issue by @feliperaul, closed 2021-05-24"
1801
+ [#2606]:https://github.com/puma/puma/pull/2606 "PR by @wjordan, merged 2021-04-20"
1802
+ [#2574]:https://github.com/puma/puma/issues/2574 "Issue by @darkhelmet, closed 2021-04-20"
1803
+ [#2567]:https://github.com/puma/puma/pull/2567 "PR by @kddeisz, merged 2021-04-19"
1804
+ [#2566]:https://github.com/puma/puma/issues/2566 "Issue by @kddeisz, closed 2021-04-19"
1805
+ [#2596]:https://github.com/puma/puma/pull/2596 "PR by @MSP-Greg, merged 2021-04-18"
1806
+ [#2588]:https://github.com/puma/puma/pull/2588 "PR by @dentarg, merged 2021-04-02"
1807
+ [#2556]:https://github.com/puma/puma/issues/2556 "Issue by @gamecreature, closed 2021-04-02"
1808
+ [#2585]:https://github.com/puma/puma/pull/2585 "PR by @MSP-Greg, merged 2021-03-26"
1809
+ [#2583]:https://github.com/puma/puma/issues/2583 "Issue by @jboler, closed 2021-03-26"
1810
+ [#2609]:https://github.com/puma/puma/pull/2609 "PR by @calvinxiao, merged 2021-04-26"
1811
+ [#2590]:https://github.com/puma/puma/pull/2590 "PR by @calvinxiao, merged 2021-04-05"
1812
+ [#2600]:https://github.com/puma/puma/pull/2600 "PR by @wjordan, merged 2021-04-30"
1813
+ [#2579]:https://github.com/puma/puma/pull/2579 "PR by @ghiculescu, merged 2021-03-17"
1814
+ [#2553]:https://github.com/puma/puma/pull/2553 "PR by @olivierbellone, merged 2021-02-10"
1711
1815
  [#2557]:https://github.com/puma/puma/pull/2557 "PR by @cjlarose, merged 2021-02-22"
1712
- [#2553]:https://github.com/puma/puma/pull/2553 "PR by @olivierbellone, merged 02-10-22"
1713
1816
  [#2550]:https://github.com/puma/puma/pull/2550 "PR by @MSP-Greg, merged 2021-02-05"
1714
1817
  [#2547]:https://github.com/puma/puma/pull/2547 "PR by @wildmaples, merged 2021-02-03"
1715
1818
  [#2543]:https://github.com/puma/puma/pull/2543 "PR by @MSP-Greg, merged 2021-02-01"
data/README.md CHANGED
@@ -16,7 +16,7 @@ Puma is a **simple, fast, multi-threaded, and highly concurrent HTTP 1.1 server
16
16
 
17
17
  Puma processes requests using a C-optimized Ragel extension (inherited from Mongrel) that provides fast, accurate HTTP 1.1 protocol parsing in a portable way. Puma then serves the request using a thread pool. Each request is served in a separate thread, so truly concurrent Ruby implementations (JRuby, Rubinius) will use all available CPU cores.
18
18
 
19
- Puma was designed to be the go-to server for [Rubinius](https://rubinius.com), but also works well with JRuby and MRI.
19
+ Originally designed as a server for [Rubinius](https://github.com/rubinius/rubinius), Puma also works well with Ruby (MRI) and JRuby.
20
20
 
21
21
  On MRI, there is a Global VM Lock (GVL) that ensures only one thread can run Ruby code at a time. But if you're doing a lot of blocking IO (such as HTTP calls to external APIs like Twitter), Puma still improves MRI's throughput by allowing IO waiting to be done in parallel.
22
22
 
data/docs/architecture.md CHANGED
@@ -6,11 +6,12 @@
6
6
 
7
7
  Puma is a threaded Ruby HTTP application server, processing requests across a TCP or UNIX socket.
8
8
 
9
- Puma processes (there can be one or many) accept connections from the socket via a thread (in the `Reactor` class). The connection, once fully buffered and read, moves in to the `todo` list, where it will be picked up by a free/waiting thread in the threadpool (the `ThreadPool` class).
9
+
10
+ Puma processes (there can be one or many) accept connections from the socket via a thread (in the [`Reactor`](../lib/puma/reactor.rb) class). The connection, once fully buffered and read, moves in to the `todo` list, where it will be picked up by a free/waiting thread in the threadpool (the [`ThreadPool`](../lib/puma/thread_pool.rb) class).
10
11
 
11
12
  Puma works in two main modes: cluster and single. In single mode, only one Puma process is booted. In cluster mode, a `master` process is booted, which prepares (and may boot) the application, and then uses the `fork()` system call to create 1 or more `child` processes. These `child` processes all listen to the same socket. The `master` process does not listen to the socket or process requests - its purpose is mostly to manage and listen for UNIX signals and possibly kill or boot `child` processes.
12
13
 
13
- We sometimes call `child` processes (or Puma processes in `single` mode) _workers_, and we sometimes call the threads created by Puma's `ThreadPool` _worker threads_.
14
+ We sometimes call `child` processes (or Puma processes in `single` mode) _workers_, and we sometimes call the threads created by Puma's [`ThreadPool`](../lib/puma/thread_pool.rb) _worker threads_.
14
15
 
15
16
  ## How Requests Work
16
17
 
@@ -18,8 +19,8 @@ We sometimes call `child` processes (or Puma processes in `single` mode) _worker
18
19
 
19
20
  * Upon startup, Puma listens on a TCP or UNIX socket.
20
21
  * The backlog of this socket is configured (with a default of 1024). This determines the size of the queue for unaccepted connections. Generally, this setting is unimportant and will never be hit in production use. If the backlog is full, the connection will be refused by the operating system.
21
- * This socket backlog is distinct from the `backlog` of work as reported by `Puma.stats` or the control server. The backlog as reported by Puma is the number of connections in the process' `todo` set waiting for a thread from the `ThreadPool`.
22
- * By default, a single, separate thread (created by the `Reactor` class) is used to read and buffer requests from the socket.
22
+ * This socket backlog is distinct from the `backlog` of work as reported by `Puma.stats` or the control server. The backlog as reported by Puma is the number of connections in the process' `todo` set waiting for a thread from the [`ThreadPool`](../lib/puma/thread_pool.rb).
23
+ * By default, a single, separate thread (created by the [`Reactor`](../lib/puma/reactor.rb) class) is used to read and buffer requests from the socket.
23
24
  * When at least one worker thread is available for work, the reactor thread listens to the socket and accepts a request, if one is waiting.
24
25
  * The reactor thread waits for the entire HTTP request to be received.
25
26
  * The time spent waiting for the HTTP request body to be received is exposed to the Rack app as `env['puma.request_body_wait']` (milliseconds).
data/docs/deployment.md CHANGED
@@ -16,7 +16,7 @@ Welcome back!
16
16
 
17
17
  ## Single vs Cluster mode
18
18
 
19
- Puma was originally conceived as a thread-only webserver, but grew the ability to
19
+ Puma was originally conceived as a thread-only web server, but grew the ability to
20
20
  also use processes in version 2.
21
21
 
22
22
  To run `puma` in single mode (e.g. for a development environment) you will need to
@@ -97,20 +97,5 @@ and use `runit` or hell, even `monit`.
97
97
  ## Restarting
98
98
 
99
99
  You probably will want to deploy some new code at some point, and you'd like
100
- puma to start running that new code. Minimizing the amount of time the server
101
- is unavailable would be nice as well. Here's how to do it:
102
-
103
- 1. Don't use `preload!`. This dirties the master process and means it will have
104
- to shutdown all the workers and re-exec itself to get your new code. It is not compatible with phased-restart and `prune_bundler` as well.
105
-
106
- 1. Use `prune_bundler`. This makes it so that the cluster master will detach itself
107
- from a Bundler context on start. This allows the cluster workers to load your app
108
- and start a brand new Bundler context within the worker only. This means your
109
- master remains pristine and can live on between new releases of your code.
110
-
111
- 1. Use phased-restart (`SIGUSR1` or `pumactl phased-restart`). This tells the master
112
- to kill off one worker at a time and restart them in your new code. This minimizes
113
- downtime and staggers the restart nicely. **WARNING** This means that both your
114
- old code and your new code will be running concurrently. Most deployment solutions
115
- already cause that, but it's worth warning you about it again. Be careful with your
116
- migrations, etc!
100
+ puma to start running that new code. There are a few options for restarting
101
+ puma, described separately in our [restart documentation](restart.md).
@@ -1,6 +1,6 @@
1
1
  # Puma as a service using rc.d
2
2
 
3
- Manage multilpe Puma servers as services on one box using FreeBSD's rc.d service.
3
+ Manage multiple Puma servers as services on one box using FreeBSD's rc.d service.
4
4
 
5
5
  ## Dependencies
6
6
 
data/docs/kubernetes.md CHANGED
@@ -61,6 +61,6 @@ For some high-throughput systems, it is possible that some HTTP requests will re
61
61
 
62
62
  There is a subtle race condition between step 2 and 3: The replication controller does not synchronously remove the pod from the Services AND THEN call the pre-stop hook of the pod, but rather it asynchronously sends "remove this pod from your endpoints" requests to the Services and then immediately proceeds to invoke the pods' pre-stop hook. If the Service controller (typically something like nginx or haproxy) receives this request handles this request "too" late (due to internal lag or network latency between the replication and Service controllers) then it is possible that the Service controller will send one or more requests to a Puma process which has already shut down its listening socket. These requests will then fail with 5XX error codes.
63
63
 
64
- The way Kubernetes works this way, rather than handling step 2 synchronously, is due to the CAP theorem: in a distributed system there is no way to guarantuee that any message will arrive promptly. In particular, waiting for all Service controllers to report back might get stuck for an indefinite time if one of them has already been terminated or if there has been a net split. A way to work around this is to add a sleep to the pre-stop hook of the same time as the `terminationGracePeriodSeconds` time. This will allow the Puma process to keep serving new requests during the entire grace period, although it will no longer receive new requests after all Service controllers have propagated the removal of the pod from their endpoint lists. Then, after `terminationGracePeriodSeconds`, the pod receives `SIGKILL` and closes down. If your process can't handle SIGKILL properly, for example because it needs to release locks in different services, you can also sleep for a shorter period (and/or increase `terminationGracePeriodSeconds`) as long as the time slept is longer than the time that your Service controllers take to propagate the pod removal. The downside of this workaround is that all pods will take at minimum the amount of time slept to shut down and this will increase the time required for your rolling deploy.
64
+ The way Kubernetes works this way, rather than handling step 2 synchronously, is due to the CAP theorem: in a distributed system there is no way to guarantee that any message will arrive promptly. In particular, waiting for all Service controllers to report back might get stuck for an indefinite time if one of them has already been terminated or if there has been a net split. A way to work around this is to add a sleep to the pre-stop hook of the same time as the `terminationGracePeriodSeconds` time. This will allow the Puma process to keep serving new requests during the entire grace period, although it will no longer receive new requests after all Service controllers have propagated the removal of the pod from their endpoint lists. Then, after `terminationGracePeriodSeconds`, the pod receives `SIGKILL` and closes down. If your process can't handle SIGKILL properly, for example because it needs to release locks in different services, you can also sleep for a shorter period (and/or increase `terminationGracePeriodSeconds`) as long as the time slept is longer than the time that your Service controllers take to propagate the pod removal. The downside of this workaround is that all pods will take at minimum the amount of time slept to shut down and this will increase the time required for your rolling deploy.
65
65
 
66
66
  More discussions and links to relevant articles can be found in https://github.com/puma/puma/issues/2343.
data/docs/plugins.md CHANGED
@@ -34,5 +34,5 @@ functionality to augment puma.
34
34
  `config` runs when the server is being configured and is passed a `Puma::DSL`
35
35
  object that can be used to add additional configuration.
36
36
 
37
- Any public methods in `Puma::Plugin` are the public API that any plugin may
37
+ Any public methods in [`Puma::Plugin`](../lib/puma/plugin.rb) are the public API that any plugin may
38
38
  use.
data/docs/restart.md CHANGED
@@ -45,7 +45,7 @@ Any of the following will cause a Puma server to perform a phased restart:
45
45
  ### Supported configurations
46
46
 
47
47
  * Works in cluster mode only
48
- * To support upgrading the application that Puma is serving, ensure `prune_bundler` is enabled and that `preload_app` is disabled (it is disabled by default).
48
+ * To support upgrading the application that Puma is serving, ensure `prune_bundler` is enabled and that `preload_app!` is disabled
49
49
  * Supported on all platforms where cluster mode is supported
50
50
 
51
51
  ### Client experience
data/docs/stats.md CHANGED
@@ -53,7 +53,7 @@ end
53
53
 
54
54
  ### single mode and individual workers in cluster mode
55
55
 
56
- When Puma is run in single mode, these stats ar available at the top level. When Puma is run in cluster mode, these stats are available within the `worker_status` array in a hash labeled `last_status`, in an array of hashes, one hash for each worker.
56
+ When Puma is run in single mode, these stats are available at the top level. When Puma is run in cluster mode, these stats are available within the `worker_status` array in a hash labeled `last_status`, in an array of hashes, one hash for each worker.
57
57
 
58
58
  * backlog: requests that are waiting for an available thread to be available. if this is above 0, you need more capacity [always true?]
59
59
  * running: how many threads are running
data/docs/systemd.md CHANGED
@@ -8,7 +8,7 @@ useful features for running Puma in production.
8
8
  ## Service Configuration
9
9
 
10
10
  Below is a sample puma.service configuration file for systemd, which
11
- can be copied or symlinked to /etc/systemd/system/puma.service, or if
11
+ can be copied or symlinked to `/etc/systemd/system/puma.service`, or if
12
12
  desired, using an application or instance specific name.
13
13
 
14
14
  Note that this uses the systemd preferred "simple" type where the
@@ -11,9 +11,18 @@ end
11
11
  unless ENV["DISABLE_SSL"]
12
12
  dir_config("openssl")
13
13
 
14
- if %w'crypto libeay32'.find {|crypto| have_library(crypto, 'BIO_read')} and
14
+ found_ssl = if pkg_config 'openssl'
15
+ puts 'using OpenSSL pkgconfig (openssl.pc)'
16
+ true
17
+ elsif %w'crypto libeay32'.find {|crypto| have_library(crypto, 'BIO_read')} &&
15
18
  %w'ssl ssleay32'.find {|ssl| have_library(ssl, 'SSL_CTX_new')}
19
+ true
20
+ else
21
+ puts '** Puma will be compiled without SSL support'
22
+ false
23
+ end
16
24
 
25
+ if found_ssl
17
26
  have_header "openssl/bio.h"
18
27
 
19
28
  # below is yes for 1.0.2 & later
@@ -25,6 +34,14 @@ unless ENV["DISABLE_SSL"]
25
34
 
26
35
  have_func "X509_STORE_up_ref"
27
36
  have_func("SSL_CTX_set_ecdh_auto(NULL, 0)", "openssl/ssl.h")
37
+
38
+ # Random.bytes available in Ruby 2.5 and later, Random::DEFAULT deprecated in 3.0
39
+ if Random.respond_to?(:bytes)
40
+ $defs.push("-DHAVE_RANDOM_BYTES")
41
+ puts "checking for Random.bytes... yes"
42
+ else
43
+ puts "checking for Random.bytes... no"
44
+ end
28
45
  end
29
46
  end
30
47
 
@@ -29,8 +29,8 @@ typedef void (*field_cb)(struct puma_parser* hp,
29
29
 
30
30
  typedef struct puma_parser {
31
31
  int cs;
32
- size_t body_start;
33
32
  int content_len;
33
+ size_t body_start;
34
34
  size_t nread;
35
35
  size_t mark;
36
36
  size_t field_start;
@@ -208,7 +208,7 @@ sslctx_initialize(VALUE self, VALUE mini_ssl_ctx) {
208
208
  #endif
209
209
  int ssl_options;
210
210
  VALUE key, cert, ca, verify_mode, ssl_cipher_filter, no_tlsv1, no_tlsv1_1,
211
- verification_flags;
211
+ verification_flags, session_id_bytes;
212
212
  DH *dh;
213
213
 
214
214
  #if OPENSSL_VERSION_NUMBER < 0x10002000L
@@ -309,6 +309,21 @@ sslctx_initialize(VALUE self, VALUE mini_ssl_ctx) {
309
309
  } else {
310
310
  SSL_CTX_set_verify(ctx, NUM2INT(verify_mode), engine_verify_callback);
311
311
  }
312
+
313
+ // Random.bytes available in Ruby 2.5 and later, Random::DEFAULT deprecated in 3.0
314
+ session_id_bytes = rb_funcall(
315
+ #ifdef HAVE_RANDOM_BYTES
316
+ rb_cRandom,
317
+ #else
318
+ rb_const_get(rb_cRandom, rb_intern_const("DEFAULT")),
319
+ #endif
320
+ rb_intern_const("bytes"),
321
+ 1, ULL2NUM(SSL_MAX_SSL_SESSION_ID_LENGTH));
322
+
323
+ SSL_CTX_set_session_id_context(ctx,
324
+ (unsigned char *) RSTRING_PTR(session_id_bytes),
325
+ SSL_MAX_SSL_SESSION_ID_LENGTH);
326
+
312
327
  // printf("\ninitialize end security_level %d\n", SSL_CTX_get_security_level(ctx));
313
328
  rb_obj_freeze(self);
314
329
  return self;
data/lib/puma.rb CHANGED
@@ -12,7 +12,7 @@ require 'thread'
12
12
 
13
13
  require 'puma/puma_http11'
14
14
  require 'puma/detect'
15
- require 'puma/json'
15
+ require 'puma/json_serialization'
16
16
 
17
17
  module Puma
18
18
  autoload :Const, 'puma/const'
@@ -23,6 +23,8 @@ module Puma
23
23
  # not in minissl.rb
24
24
  HAS_SSL = const_defined?(:MiniSSL, false) && MiniSSL.const_defined?(:Engine, false)
25
25
 
26
+ HAS_UNIX_SOCKET = Object.const_defined? :UNIXSocket
27
+
26
28
  if HAS_SSL
27
29
  require 'puma/minissl'
28
30
  else
@@ -37,6 +39,20 @@ module Puma
37
39
  HAS_SSL
38
40
  end
39
41
 
42
+ def self.abstract_unix_socket?
43
+ @abstract_unix ||=
44
+ if HAS_UNIX_SOCKET
45
+ begin
46
+ ::UNIXServer.new("\0puma.temp.unix").close
47
+ true
48
+ rescue ArgumentError # darwin
49
+ false
50
+ end
51
+ else
52
+ false
53
+ end
54
+ end
55
+
40
56
  # @!attribute [rw] stats_object=
41
57
  def self.stats_object=(val)
42
58
  @get_stats = val
@@ -44,7 +60,7 @@ module Puma
44
60
 
45
61
  # @!attribute [rw] stats_object
46
62
  def self.stats
47
- Puma::JSON.generate @get_stats.stats
63
+ Puma::JSONSerialization.generate @get_stats.stats
48
64
  end
49
65
 
50
66
  # @!attribute [r] stats_hash
@@ -1,5 +1,5 @@
1
1
  # frozen_string_literal: true
2
- require 'puma/json'
2
+ require 'puma/json_serialization'
3
3
 
4
4
  module Puma
5
5
  module App
@@ -46,17 +46,17 @@ module Puma
46
46
  GC.start ; 200
47
47
 
48
48
  when 'gc-stats'
49
- Puma::JSON.generate GC.stat
49
+ Puma::JSONSerialization.generate GC.stat
50
50
 
51
51
  when 'stats'
52
- Puma::JSON.generate @launcher.stats
52
+ Puma::JSONSerialization.generate @launcher.stats
53
53
 
54
54
  when 'thread-backtraces'
55
55
  backtraces = []
56
56
  @launcher.thread_status do |name, backtrace|
57
57
  backtraces << { name: name, backtrace: backtrace }
58
58
  end
59
- Puma::JSON.generate backtraces
59
+ Puma::JSONSerialization.generate backtraces
60
60
 
61
61
  else
62
62
  return rack_response(404, "Unsupported action", 'text/plain')
data/lib/puma/binder.rb CHANGED
@@ -13,7 +13,7 @@ module Puma
13
13
  require 'puma/minissl'
14
14
  require 'puma/minissl/context_builder'
15
15
 
16
- # Odd bug in 'pure Ruby' nio4r verion 2.5.2, which installs with Ruby 2.3.
16
+ # Odd bug in 'pure Ruby' nio4r version 2.5.2, which installs with Ruby 2.3.
17
17
  # NIO doesn't create any OpenSSL objects, but it rescues an OpenSSL error.
18
18
  # The bug was that it did not require openssl.
19
19
  # @todo remove when Ruby 2.3 support is dropped
@@ -41,6 +41,7 @@ module Puma
41
41
  "rack.multithread".freeze => conf.options[:max_threads] > 1,
42
42
  "rack.multiprocess".freeze => conf.options[:workers] >= 1,
43
43
  "rack.run_once".freeze => false,
44
+ RACK_URL_SCHEME => conf.options[:rack_url_scheme],
44
45
  "SCRIPT_NAME".freeze => ENV['SCRIPT_NAME'] || "",
45
46
 
46
47
  # I'd like to set a default CONTENT_TYPE here but some things
@@ -95,6 +96,7 @@ module Puma
95
96
  # @version 5.0.0
96
97
  #
97
98
  def create_activated_fds(env_hash)
99
+ @events.debug "ENV['LISTEN_FDS'] #{ENV['LISTEN_FDS'].inspect} env_hash['LISTEN_PID'] #{env_hash['LISTEN_PID'].inspect}"
98
100
  return [] unless env_hash['LISTEN_FDS'] && env_hash['LISTEN_PID'].to_i == $$
99
101
  env_hash['LISTEN_FDS'].to_i.times do |index|
100
102
  sock = TCPServer.for_fd(socket_activation_fd(index))
@@ -163,7 +165,7 @@ module Puma
163
165
  ios_len = @ios.length
164
166
  params = Util.parse_query uri.query
165
167
 
166
- opt = params.key?('low_latency')
168
+ opt = params.key?('low_latency') && params['low_latency'] != 'false'
167
169
  bak = params.fetch('backlog', 1024).to_i
168
170
 
169
171
  io = add_tcp_listener uri.host, uri.port, opt, bak
@@ -177,11 +179,20 @@ module Puma
177
179
  @listeners << [str, io] if io
178
180
  when "unix"
179
181
  path = "#{uri.host}#{uri.path}".gsub("%20", " ")
182
+ abstract = false
183
+ if str.start_with? 'unix://@'
184
+ raise "OS does not support abstract UNIXSockets" unless Puma.abstract_unix_socket?
185
+ abstract = true
186
+ path = "@#{path}"
187
+ end
180
188
 
181
189
  if fd = @inherited_fds.delete(str)
190
+ @unix_paths << path unless abstract
182
191
  io = inherit_unix_listener path, fd
183
192
  logger.log "* Inherited #{str}"
184
- elsif sock = @activated_sockets.delete([ :unix, path ])
193
+ elsif sock = @activated_sockets.delete([ :unix, path ]) ||
194
+ @activated_sockets.delete([ :unix, File.realdirpath(path) ])
195
+ @unix_paths << path unless abstract || File.exist?(path)
185
196
  io = inherit_unix_listener path, sock
186
197
  logger.log "* Activated #{str}"
187
198
  else
@@ -205,6 +216,7 @@ module Puma
205
216
  end
206
217
  end
207
218
 
219
+ @unix_paths << path unless abstract || File.exist?(path)
208
220
  io = add_unix_listener path, umask, mode, backlog
209
221
  logger.log "* #{log_msg} on #{str}"
210
222
  end
@@ -258,14 +270,18 @@ module Puma
258
270
  end
259
271
 
260
272
  # Also close any unused activated sockets
261
- @activated_sockets.each do |key, sock|
262
- logger.log "* Closing unused activated socket: #{key.join ':'}"
263
- begin
264
- sock.close
265
- rescue SystemCallError
273
+ unless @activated_sockets.empty?
274
+ fds = @ios.map(&:to_i)
275
+ @activated_sockets.each do |key, sock|
276
+ next if fds.include? sock.to_i
277
+ logger.log "* Closing unused activated socket: #{key.first}://#{key[1..-1].join ':'}"
278
+ begin
279
+ sock.close
280
+ rescue SystemCallError
281
+ end
282
+ # We have to unlink a unix socket path that's not being used
283
+ File.unlink key[1] if key.first == :unix
266
284
  end
267
- # We have to unlink a unix socket path that's not being used
268
- File.unlink key[1] if key[0] == :unix
269
285
  end
270
286
  end
271
287
 
@@ -351,8 +367,6 @@ module Puma
351
367
  # Tell the server to listen on +path+ as a UNIX domain socket.
352
368
  #
353
369
  def add_unix_listener(path, umask=nil, mode=nil, backlog=1024)
354
- @unix_paths << path unless File.exist? path
355
-
356
370
  # Let anyone connect by default
357
371
  umask ||= 0
358
372
 
@@ -369,8 +383,7 @@ module Puma
369
383
  raise "There is already a server bound to: #{path}"
370
384
  end
371
385
  end
372
-
373
- s = UNIXServer.new(path)
386
+ s = UNIXServer.new path.sub(/\A@/, "\0") # check for abstract UNIXSocket
374
387
  s.listen backlog
375
388
  @ios << s
376
389
  ensure
@@ -389,8 +402,6 @@ module Puma
389
402
  end
390
403
 
391
404
  def inherit_unix_listener(path, fd)
392
- @unix_paths << path unless File.exist? path
393
-
394
405
  s = fd.kind_of?(::TCPServer) ? fd : ::UNIXServer.for_fd(fd)
395
406
 
396
407
  @ios << s
@@ -403,24 +414,24 @@ module Puma
403
414
  end
404
415
 
405
416
  def close_listeners
406
- listeners.each do |l, io|
407
- io.close unless io.closed? # Ruby 2.2 issue
408
- uri = URI.parse(l)
417
+ @listeners.each do |l, io|
418
+ io.close unless io.closed?
419
+ uri = URI.parse l
409
420
  next unless uri.scheme == 'unix'
410
421
  unix_path = "#{uri.host}#{uri.path}"
411
- File.unlink unix_path if unix_paths.include? unix_path
422
+ File.unlink unix_path if @unix_paths.include?(unix_path) && File.exist?(unix_path)
412
423
  end
413
424
  end
414
425
 
415
426
  def redirects_for_restart
416
- redirects = listeners.map { |a| [a[1].to_i, a[1].to_i] }.to_h
427
+ redirects = @listeners.map { |a| [a[1].to_i, a[1].to_i] }.to_h
417
428
  redirects[:close_others] = true
418
429
  redirects
419
430
  end
420
431
 
421
432
  # @version 5.0.0
422
433
  def redirects_for_restart_env
423
- listeners.each_with_object({}).with_index do |(listen, memo), i|
434
+ @listeners.each_with_object({}).with_index do |(listen, memo), i|
424
435
  memo["PUMA_INHERIT_#{i}"] = "#{listen[1].to_i}:#{listen[0]}"
425
436
  end
426
437
  end