puma-release 0.1.0

data/test/test_helper.rb

@@ -0,0 +1,72 @@
+# frozen_string_literal: true
+
+require "minitest/autorun"
+require "tmpdir"
+require "ostruct"
+require_relative "../lib/puma_release"
+
+module TestSupport
+  class FakeShell
+    Result = Data.define(:stdout, :stderr, :success?, :exitstatus)
+
+    attr_reader :commands
+
+    def initialize(outputs = {})
+      @outputs = outputs
+      @commands = []
+    end
+
+    def output(*command, **_options)
+      commands << command
+      value = @outputs.fetch(command, "")
+      value.respond_to?(:call) ? value.call : value
+    end
+
+    def run(*command, allow_failure: false, **_options)
+      commands << command
+      value = @outputs.fetch(command, Result.new(stdout: "", stderr: "", success?: true, exitstatus: 0))
+      value = value.call if value.respond_to?(:call)
+      return value if value.success? || allow_failure
+
+      raise PumaRelease::Error, command.join(" ")
+    end
+
+    def stream_output(*command, **options)
+      output(*command, **options)
+    end
+
+    def stream_json_events(*command, **options)
+      output(*command, **options).each_line do |line|
+        next if line.strip.empty?
+        begin
+          yield JSON.parse(line)
+        rescue JSON::ParserError
+        end
+      end
+    end
+
+    def optional_output(*command)
+      output(*command).strip
+    end
+
+    def available?(_command)
+      true
+    end
+
+    def split(command)
+      command.split
+    end
+  end
+
+  def temp_repo
+    Dir.mktmpdir do |dir|
+      repo = Pathname(dir)
+      repo.join("lib/puma").mkpath
+      yield repo
+    end
+  end
+end
+
+class Minitest::Test
+  include TestSupport
+end

data/test/unit/agent_client_test.rb

@@ -0,0 +1,116 @@
+# frozen_string_literal: true
+
+require "stringio"
+require_relative "../test_helper"
+
+class AgentClientTest < Minitest::Test
+  def test_pi_mode_parses_json_from_event_stream_without_printing_json_payload
+    shell = Class.new do
+      attr_reader :command
+
+      def stream_json_events(*command, **)
+        @command = command
+        yield({"type" => "message_update", "assistantMessageEvent" => {"type" => "text_delta", "delta" => "{"}})
+        yield({
+          "type" => "message_end",
+          "message" => {
+            "role" => "assistant",
+            "provider" => "openai-codex",
+            "model" => "gpt-5.4",
+            "content" => [
+              {"type" => "text", "text" => '{"bump_type":"patch","reasoning_markdown":"Because of [this commit](https://github.com/puma/puma/commit/abc)."}'}
+            ]
+          }
+        })
+      end
+
+      def split(command)
+        [command]
+      end
+    end.new
+
+    context = OpenStruct.new(agent_cmd: "/tmp/pi", shell:)
+    original_stdout = $stdout
+    $stdout = StringIO.new
+
+    client = PumaRelease::AgentClient.new(context)
+    result = client.ask_for_json(
+      "Choose a version bump",
+      system_prompt: "Return JSON",
+      schema: {
+        type: "object",
+        required: %w[bump_type reasoning_markdown],
+        properties: {
+          bump_type: {type: "string"},
+          reasoning_markdown: {type: "string"}
+        }
+      }
+    )
+
+    assert_equal "patch", result.fetch("bump_type")
+    assert_includes shell.command, "-p"
+    assert_includes shell.command, "--thinking"
+    assert_includes shell.command, "xhigh"
+    assert_includes shell.command, "--tools"
+    assert_includes shell.command, "read,bash"
+    assert_includes shell.command, "--extension"
+    assert_includes shell.command, File.expand_path("../../config/pi-agent-guard.ts", __dir__)
+    assert_includes shell.command, "--mode"
+    refute_includes shell.command, "--no-tools"
+    refute_includes shell.command, "--no-session"
+    assert_equal "openai-codex/gpt-5.4", client.last_model_name
+    assert_equal ".\n", $stdout.string
+  ensure
+    $stdout = original_stdout
+  end
+
+  def test_pi_mode_uses_final_answer_text_when_commentary_is_present
+    shell = Class.new do
+      def stream_json_events(*, **)
+        yield({"type" => "message_update", "assistantMessageEvent" => {"type" => "text_delta", "delta" => "I"}})
+        yield({
+          "type" => "message_end",
+          "message" => {
+            "role" => "assistant",
+            "provider" => "openai-codex",
+            "model" => "gpt-5.4",
+            "content" => [
+              {
+                "type" => "text",
+                "text" => "I'm thinking through the release range.",
+                "textSignature" => '{"v":1,"phase":"commentary"}'
+              },
+              {
+                "type" => "text",
+                "text" => '{"bump_type":"minor","reasoning_markdown":"Because of [this commit](https://github.com/puma/puma/commit/abc)."}',
+                "textSignature" => '{"v":1,"phase":"final_answer"}'
+              }
+            ]
+          }
+        })
+      end
+
+      def split(command)
+        [command]
+      end
+    end.new
+
+    context = OpenStruct.new(agent_cmd: "pi", shell:)
+
+    client = PumaRelease::AgentClient.new(context)
+    result = client.ask_for_json(
+      "Choose a version bump",
+      system_prompt: "Return JSON",
+      schema: {
+        type: "object",
+        required: %w[bump_type reasoning_markdown],
+        properties: {
+          bump_type: {type: "string"},
+          reasoning_markdown: {type: "string"}
+        }
+      }
+    )
+
+    assert_equal "minor", result.fetch("bump_type")
+  end
+end

data/test/unit/build_command_test.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+require_relative "../test_helper"
+
+class BuildCommandTest < Minitest::Test
+  def test_sync_release_target_to_tag_is_a_no_op_when_release_is_missing
+    git_repo = Object.new
+    git_repo.define_singleton_method(:local_tag_sha) { |_tag| "abc123" }
+
+    github = Object.new
+    calls = []
+    github.define_singleton_method(:release) { |_tag| nil }
+    github.define_singleton_method(:edit_release_target) { |_tag, _sha| calls << :edit_release_target }
+
+    command = PumaRelease::Commands::Build.allocate
+    command.instance_variable_set(:@git_repo, git_repo)
+    command.instance_variable_set(:@github, github)
+
+    command.send(:sync_release_target_to_tag, "v7.2.0")
+
+    assert_empty calls
+  end
+end

data/test/unit/build_support_test.rb

@@ -0,0 +1,6 @@
+# frozen_string_literal: true
+
+require_relative "../test_helper"
+
+class BuildSupportTest < Minitest::Test
+end

data/test/unit/changelog_validator_test.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+require_relative "../test_helper"
+
+class ChangelogValidatorTest < Minitest::Test
+  def test_valid_changelog_has_no_errors
+    changelog = <<~CHANGELOG
+      * Features
+        * Add a nice thing ([#10])
+
+      * Bugfixes
+        * Fix a rough edge ([#11], [#12])
+    CHANGELOG
+
+    assert_empty PumaRelease::ChangelogValidator.new.validate(changelog)
+  end
+
+  def test_rejects_inline_links
+    changelog = <<~CHANGELOG
+      * Features
+        * Add a nice thing [#10](https://example.test)
+    CHANGELOG
+
+    errors = PumaRelease::ChangelogValidator.new.validate(changelog)
+
+    assert_includes errors.join("\n"), "inline markdown links are not allowed"
+  end
+
+  def test_rejects_out_of_order_categories
+    changelog = <<~CHANGELOG
+      * Docs
+        * Update docs ([#10])
+
+      * Features
+        * Add a nice thing ([#11])
+    CHANGELOG
+
+    errors = PumaRelease::ChangelogValidator.new.validate(changelog)
+
+    assert_includes errors.join("\n"), "categories must appear in this order"
+  end
+end

data/test/unit/context_test.rb

@@ -0,0 +1,209 @@
+# frozen_string_literal: true
+
+require_relative "../test_helper"
+
+class ContextTest < Minitest::Test
+  class FakeUI
+    attr_reader :warnings, :confirmations
+    attr_accessor :confirm_result
+
+    def initialize(confirm_result: true)
+      @warnings = []
+      @confirmations = []
+      @confirm_result = confirm_result
+    end
+
+    def warn(message)
+      warnings << message
+    end
+
+    def confirm(message, default: true)
+      confirmations << [message, default]
+      confirm_result
+    end
+  end
+
+  def test_release_repo_prefers_a_fork_remote_when_not_live
+    shell = FakeShell.new(
+      {
+        ["git", "remote"] => "origin\nmine\n",
+        ["git", "remote", "get-url", "origin"] => "https://github.com/puma/puma.git\n",
+        ["git", "remote", "get-url", "mine"] => "git@github.com:nateberkopec/puma.git\n"
+      }
+    )
+
+    context = build_context(shell:, live: false)
+
+    assert_equal "nateberkopec/puma", context.release_repo
+  end
+
+  def test_release_repo_defaults_to_metadata_repo_in_live_mode
+    shell = FakeShell.new(
+      {
+        ["git", "remote"] => "origin\nmine\n",
+        ["git", "remote", "get-url", "origin"] => "https://github.com/puma/puma.git\n",
+        ["git", "remote", "get-url", "mine"] => "git@github.com:nateberkopec/puma.git\n"
+      }
+    )
+
+    context = build_context(shell:, live: true)
+
+    assert_equal "puma/puma", context.release_repo
+  end
+
+  def test_refuses_writes_to_metadata_repo_without_live
+    shell = FakeShell.new
+    context = build_context(shell:, live: false, release_repo: "puma/puma")
+
+    error = assert_raises(PumaRelease::Error) { context.ensure_release_writes_allowed! }
+
+    assert_includes error.message, "without --live"
+  end
+
+  def test_release_repo_prefers_the_authenticated_users_fork_when_multiple_candidates_exist
+    shell = FakeShell.new(
+      {
+        ["git", "remote"] => "backup\norigin\nupstream\n",
+        ["git", "remote", "get-url", "backup"] => "git@github.com:someoneelse/puma.git\n",
+        ["git", "remote", "get-url", "origin"] => "git@github.com:nateberkopec/puma.git\n",
+        ["git", "remote", "get-url", "upstream"] => "https://github.com/puma/puma.git\n",
+        ["gh", "api", "user"] => FakeShell::Result.new(stdout: '{"login":"nateberkopec"}', stderr: "", success?: true, exitstatus: 0)
+      }
+    )
+
+    context = build_context(shell:, live: false)
+
+    assert_equal "nateberkopec/puma", context.release_repo
+  end
+
+  def test_release_repo_falls_back_to_metadata_repo_when_fork_is_ambiguous
+    shell = FakeShell.new(
+      {
+        ["git", "remote"] => "backup\nmirror\norigin\n",
+        ["git", "remote", "get-url", "backup"] => "git@github.com:someoneelse/puma.git\n",
+        ["git", "remote", "get-url", "mirror"] => "git@github.com:anotheruser/puma.git\n",
+        ["git", "remote", "get-url", "origin"] => "https://github.com/puma/puma.git\n",
+        ["gh", "api", "user"] => FakeShell::Result.new(stdout: '{"login":"nateberkopec"}', stderr: "", success?: true, exitstatus: 0)
+      }
+    )
+
+    context = build_context(shell:, live: false)
+
+    assert_equal "puma/puma", context.release_repo
+  end
+
+  def test_announce_live_mode_warns_once
+    shell = FakeShell.new
+    ui = FakeUI.new
+    context = build_context(shell:, live: true, release_repo: "puma/puma", ui:)
+
+    context.announce_live_mode!
+    context.announce_live_mode!
+
+    assert_equal ["LIVE MODE: writes will go to puma/puma"], ui.warnings
+  end
+
+  def test_confirm_live_github_write_prompts_in_live_mode
+    shell = FakeShell.new
+    ui = FakeUI.new(confirm_result: true)
+    context = build_context(shell:, live: true, release_repo: "puma/puma", ui:)
+
+    assert context.confirm_live_github_write!("publish release v7.3.0")
+    assert_equal [["LIVE MODE: publish release v7.3.0 on GitHub for puma/puma. Continue?", true]], ui.confirmations
+  end
+
+  def test_confirm_live_github_write_raises_when_declined
+    shell = FakeShell.new
+    ui = FakeUI.new(confirm_result: false)
+    context = build_context(shell:, live: true, release_repo: "puma/puma", ui:)
+
+    error = assert_raises(PumaRelease::Error) { context.confirm_live_github_write!("publish release v7.3.0") }
+
+    assert_includes error.message, "Aborted live GitHub action"
+  end
+
+  def test_confirm_live_github_write_skips_prompt_when_not_live
+    shell = FakeShell.new
+    ui = FakeUI.new(confirm_result: false)
+    context = build_context(shell:, live: false, release_repo: "nateberkopec/puma", ui:)
+
+    assert context.confirm_live_github_write!("publish release v7.3.0")
+    assert_empty ui.confirmations
+  end
+
+  def test_confirm_live_github_write_skips_prompt_when_yes_is_set
+    shell = FakeShell.new
+    ui = FakeUI.new(confirm_result: false)
+    context = build_context(shell:, live: true, release_repo: "puma/puma", yes: true, ui:)
+
+    assert context.confirm_live_github_write!("publish release v7.3.0")
+    assert_empty ui.confirmations
+  end
+
+  def test_confirm_live_git_command_prompts_in_live_mode_with_the_full_command
+    shell = FakeShell.new
+    ui = FakeUI.new(confirm_result: true)
+    context = build_context(shell:, live: true, release_repo: "puma/puma", ui:)
+
+    assert context.confirm_live_git_command!("git", "push", "origin", "main")
+    assert_equal [["LIVE MODE: about to run git command: git push origin main. Continue?", true]], ui.confirmations
+  end
+
+  def test_confirm_live_git_command_raises_when_declined
+    shell = FakeShell.new
+    ui = FakeUI.new(confirm_result: false)
+    context = build_context(shell:, live: true, release_repo: "puma/puma", ui:)
+
+    error = assert_raises(PumaRelease::Error) { context.confirm_live_git_command!("git", "push", "origin", "main") }
+
+    assert_includes error.message, "Aborted live git action"
+  end
+
+  def test_confirm_live_git_command_skips_prompt_when_yes_is_set
+    shell = FakeShell.new
+    ui = FakeUI.new(confirm_result: false)
+    context = build_context(shell:, live: true, release_repo: "puma/puma", yes: true, ui:)
+
+    assert context.confirm_live_git_command!("git", "push", "origin", "main")
+    assert_empty ui.confirmations
+  end
+
+  def test_confirm_live_gh_command_prompts_in_live_mode_with_the_full_command
+    shell = FakeShell.new
+    ui = FakeUI.new(confirm_result: true)
+    context = build_context(shell:, live: true, release_repo: "puma/puma", ui:)
+
+    assert context.confirm_live_gh_command!("gh", "release", "edit", "v7.3.0", "--repo", "puma/puma", "--draft=false")
+    assert_equal [["LIVE MODE: about to run gh command: gh release edit v7.3.0 --repo puma/puma --draft\\=false. Continue?", true]], ui.confirmations
+  end
+
+  def test_confirm_live_gh_command_raises_when_declined
+    shell = FakeShell.new
+    ui = FakeUI.new(confirm_result: false)
+    context = build_context(shell:, live: true, release_repo: "puma/puma", ui:)
+
+    error = assert_raises(PumaRelease::Error) { context.confirm_live_gh_command!("gh", "release", "edit", "v7.3.0", "--repo", "puma/puma", "--draft=false") }
+
+    assert_includes error.message, "Aborted live gh action"
+  end
+
+  private
+
+  def build_context(shell:, live:, release_repo: nil, yes: false, ui: PumaRelease::UI.new)
+    options = {
+      command: "run",
+      repo_dir: Pathname(Dir.pwd),
+      metadata_repo: "puma/puma",
+      release_repo:,
+      changelog_backend: "auto",
+      allow_unknown_ci: false,
+      yes:,
+      live:,
+      debug: false
+    }
+
+    context = PumaRelease::Context.new(options, env: {}, ui:)
+    context.instance_variable_set(:@shell, shell)
+    context
+  end
+end

data/test/unit/contributor_resolver_test.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+require_relative "../test_helper"
+
+class ContributorResolverTest < Minitest::Test
+  def test_resolves_github_login_from_commit_metadata
+    shell = FakeShell.new(
+      {
+        ["git", "shortlog", "-s", "-n", "-e", "--no-merges", "v7.2.0..HEAD"] => "    10\tNate Berkopec <nate.berkopec@gmail.com>\n",
+        ["git", "log", "--format=%H%x09%aN%x09%aE", "v7.2.0..HEAD"] => [
+          "abc123\tNate Berkopec\tnate.berkopec@gmail.com",
+          "def456\tNate Berkopec\tnate.berkopec@gmail.com"
+        ].join("\n")
+      }
+    )
+
+    context = OpenStruct.new(metadata_repo: "puma/puma")
+    git_repo = PumaRelease::GitRepo.new(OpenStruct.new(shell:))
+    github = Object.new
+    def github.commit_author_login(_repo, sha)
+      {"abc123" => "nateberkopec", "def456" => "nateberkopec"}.fetch(sha)
+    end
+
+    earner = PumaRelease::ContributorResolver.new(context, git_repo:, github:).codename_earner("v7.2.0")
+
+    assert_equal "Nate Berkopec", earner.fetch(:name)
+    assert_equal "nateberkopec", earner.fetch(:login)
+  end
+
+  def test_falls_back_to_github_noreply_email_login
+    shell = FakeShell.new(
+      {
+        ["git", "shortlog", "-s", "-n", "-e", "--no-merges", "v7.2.0..HEAD"] => "    1\tYuki Nishijima <386234+yuki24@users.noreply.github.com>\n",
+        ["git", "log", "--format=%H%x09%aN%x09%aE", "v7.2.0..HEAD"] => "abc123\tYuki Nishijima\t386234+yuki24@users.noreply.github.com"
+      }
+    )
+
+    context = OpenStruct.new(metadata_repo: "puma/puma")
+    git_repo = PumaRelease::GitRepo.new(OpenStruct.new(shell:))
+    github = Object.new
+    def github.commit_author_login(_repo, _sha) = nil
+
+    earner = PumaRelease::ContributorResolver.new(context, git_repo:, github:).codename_earner("v7.2.0")
+
+    assert_equal "yuki24", earner.fetch(:login)
+  end
+end