pulsar 0.3.4 → 0.3.5

data/spec/pulsar/commands/utils_spec.rb

@@ -1,33 +1,33 @@
 require 'spec_helper'
 
 describe Pulsar::UtilsCommand do
-  let(:pulsar) { Pulsar::UtilsCommand.new("") }
+  let(:pulsar) { Pulsar::UtilsCommand.new('') }
 
-  context "--version option" do
+  context '--version option' do
     before do
       begin
-        pulsar.parse(["--version"])
+        pulsar.parse(['--version'])
       rescue SystemExit => e
         @system_exit = e
       end
     end
 
-    it "shows version" do
-      stdout.should include(Pulsar::VERSION)
+    it 'shows version' do
+      expect(stdout).to include(Pulsar::VERSION)
     end
 
-    it "exits with a zero status" do
-      @system_exit.should_not be_nil
-      @system_exit.status.should == 0
+    it 'exits with a zero status' do
+      expect(@system_exit).not_to be_nil
+      expect(@system_exit.status).to be 0
     end
   end
 
-  context "subcommands" do
-    it "should be cap and list and init" do
+  context 'subcommands' do
+    it 'should be cap and list and init' do
       help = pulsar.help
-      help.should =~ /Subcommands:/
-      help.should =~ /list/
-      help.should =~ /init/
+      expect(help).to match(/Subcommands:/)
+      expect(help).to match(/list/)
+      expect(help).to match(/init/)
     end
   end
 end

data/spec/pulsar/helpers/capistrano_spec.rb

@@ -3,62 +3,68 @@ require 'spec_helper'
 describe Pulsar::Helpers::Capistrano do
   include Pulsar::Helpers::Capistrano
 
-  context "load_recipes" do
-    it "loads capistrano recipes from CONFIG_PATH env variable" do
-      ENV['CONFIG_PATH'] = "/config/path"
-      File.stub(:directory?).and_return(true)
-      File.stub(:exists?).and_return(true)
-
-      self.should_receive(:load).with("/config/path/recipes/generic/recipe.rb")
+  context 'load_recipes' do
+    it 'loads capistrano recipes from CONFIG_PATH env variable' do
+      ENV['CONFIG_PATH'] = '/config/path'
+      allow(File).to receive(:directory?).and_return(true)
+      allow(File).to receive(:exist?).and_return(true)
+      allow(self).to receive(:load)
 
       load_recipes { generic :recipe }
+
+      expect(self)
+        .to have_received(:load).with('/config/path/recipes/generic/recipe.rb')
     end
 
-    it "raises a missing recipe type exception when no recipe folder is found" do
-      File.stub(:directory?).and_return(false)
+    it 'raises a missing recipe exception when no recipe folder is found' do
+      allow(File).to receive(:directory?).and_return(false)
 
-      expect { load_recipes { generic :recipe } }.to raise_error(RuntimeError, /no recipes of type generic/)
+      expect { load_recipes { generic :recipe } }
+        .to raise_error(RuntimeError, /no recipes of type generic/)
     end
 
-    it "raises a missing recipe exception when no recipe is found" do
-      File.stub(:directory?).and_return(true)
-      File.stub(:exists?).and_return(false)
+    it 'raises a missing recipe exception when no recipe is found' do
+      allow(File).to receive(:directory?).and_return(true)
+      allow(File).to receive(:exist?).and_return(false)
 
-      expect { load_recipes { generic :missing_recipe } }.to raise_error(RuntimeError, /no missing_recipe recipe/)
+      expect { load_recipes { generic :missing_recipe } }
+        .to raise_error(RuntimeError, /no missing_recipe recipe/)
     end
 
-    it "does not call load if :app_only is true and pulsar is not called from inside application" do
+    it 'does not load if :app_only and pulsar is not inside an application' do
       ENV.delete('APP_PATH')
-      File.stub(:directory?).and_return(true)
-      File.stub(:exists?).and_return(true)
+      allow(File).to receive(:directory?).and_return(true)
+      allow(File).to receive(:exist?).and_return(true)
+      allow(self).to receive(:load)
 
-      self.should_not_receive(:load)
+      load_recipes(app_only: true) { generic :recipe }
 
-      load_recipes(:app_only => true) { generic :recipe }
+      expect(self).not_to have_received(:load)
     end
 
-    it "calls load if :app_only is true and pulsar is called from inside application" do
-      ENV['APP_PATH'] = "/app/path"
-      File.stub(:directory?).and_return(true)
-      File.stub(:exists?).and_return(true)
+    it 'loads if :app_only is true and pulsar is inside an application' do
+      ENV['APP_PATH'] = '/app/path'
+      allow(File).to receive(:directory?).and_return(true)
+      allow(File).to receive(:exist?).and_return(true)
+      allow(self).to receive(:load)
 
-      self.should_receive(:load)
+      load_recipes(app_only: true) { generic :recipe }
 
-      load_recipes(:app_only => true) { generic :recipe }
+      expect(self).to have_received(:load)
     end
   end
 
-  context "from_application_path?" do
-    it "returns true if APP_PATH env variable is set" do
-      ENV['APP_PATH'] = "/app/path"
+  context 'from_application_path?' do
+    it 'returns true if APP_PATH env variable is set' do
+      ENV['APP_PATH'] = '/app/path'
 
-      from_application_path?.should be_true
+      expect(from_application_path?).to be true
     end
 
-    it "returns false if APP_PATH env variable is not set" do
+    it 'returns false if APP_PATH env variable is not set' do
       ENV.delete('APP_PATH')
 
-      from_application_path?.should be_false
+      expect(from_application_path?).to be false
     end
   end
 end

data/spec/pulsar/helpers/clamp_spec.rb

@@ -3,72 +3,103 @@ require 'spec_helper'
 describe Pulsar::Helpers::Clamp do
   include Pulsar::Helpers::Clamp
 
-  context "fetch_repo" do
-    it "supports directories" do
-      File.stub(:directory?).and_return(true)
-      self.stub!(:conf_repo).and_return("conf-repo/path")
-
-      self.should_receive(:fetch_directory_repo).with("conf-repo/path")
+  context 'fetch_repo' do
+    it 'supports directories' do
+      allow(File).to receive(:directory?).and_return(true)
+      allow(self).to receive(:conf_repo).and_return('conf-repo/path')
+      allow(self).to receive(:fetch_directory_repo)
 
       fetch_repo
-    end
 
-    it "supports full git path" do
-      File.stub(:directory?).and_return(false)
-      self.stub!(:conf_repo).and_return("git://github.com/gh_user/pulsar-conf.git")
+      expect(self)
+        .to have_received(:fetch_directory_repo).with('conf-repo/path')
+    end
 
-      self.should_receive(:fetch_git_repo).with("git://github.com/gh_user/pulsar-conf.git")
+    it 'supports full git path' do
+      allow(File).to receive(:directory?).and_return(false)
+      allow(self).to receive(:fetch_git_repo)
+      allow(self)
+        .to receive(:conf_repo)
+        .and_return('git://github.com/gh_user/pulsar-conf.git')
 
       fetch_repo
-    end
 
-    it "supports full git path on ssh" do
-      File.stub(:directory?).and_return(false)
-      self.stub!(:conf_repo).and_return("git@github.com:gh_user/pulsar-conf.git")
+      expect(self)
+        .to have_received(:fetch_git_repo)
+        .with('git://github.com/gh_user/pulsar-conf.git')
+    end
 
-      self.should_receive(:fetch_git_repo).with("git@github.com:gh_user/pulsar-conf.git")
+    it 'supports full git path on ssh' do
+      allow(File).to receive(:directory?).and_return(false)
+      allow(self).to receive(:fetch_git_repo)
+      allow(self)
+        .to receive(:conf_repo)
+        .and_return('git@github.com:gh_user/pulsar-conf.git')
 
       fetch_repo
-    end
 
-    it "supports full git path on http" do
-      File.stub(:directory?).and_return(false)
-      self.stub!(:conf_repo).and_return("https://github.com/gh_user/pulsar.git")
+      expect(self)
+        .to have_received(:fetch_git_repo)
+        .with('git@github.com:gh_user/pulsar-conf.git')
+    end
 
-      self.should_receive(:fetch_git_repo).with("https://github.com/gh_user/pulsar.git")
+    it 'supports full git path on http' do
+      allow(File).to receive(:directory?).and_return(false)
+      allow(self).to receive(:fetch_git_repo)
+      allow(self)
+        .to receive(:conf_repo)
+        .and_return('https://github.com/gh_user/pulsar.git')
 
       fetch_repo
-    end
 
-    it "supports github path" do
-      File.stub(:directory?).and_return(false)
-      self.stub!(:conf_repo).and_return("gh-user/pulsar-conf")
+      expect(self)
+        .to have_received(:fetch_git_repo)
+        .with('https://github.com/gh_user/pulsar.git')
+    end
 
-      self.should_receive(:fetch_git_repo).with("git@github.com:gh-user/pulsar-conf.git")
+    it 'supports github path' do
+      allow(File).to receive(:directory?).and_return(false)
+      allow(self).to receive(:conf_repo).and_return('gh-user/pulsar-conf')
+      allow(self).to receive(:fetch_git_repo)
 
       fetch_repo
+
+      expect(self)
+        .to have_received(:fetch_git_repo)
+        .with('git@github.com:gh-user/pulsar-conf.git')
     end
   end
 
-  context "run_capistrano" do
+  context 'run_capistrano' do
     before do
-      self.stub!(:config_path).and_return(dummy_conf_path)
-      self.stub!(:verbose?).and_return(false)
-      self.stub!(:capfile_path).and_return('/stubbed/capfile')
+      allow(self).to receive(:config_path).and_return(dummy_conf_path)
+      allow(self).to receive(:verbose?).and_return(false)
+      allow(self).to receive(:capfile_path).and_return('/stubbed/capfile')
+      allow(self).to receive(:run_cmd)
     end
 
-    it "runs capistrano when pulsar is invoked from outside the application directory" do
-      self.should_receive(:run_cmd).with("bundle exec cap CONFIG_PATH=#{config_path} --file #{capfile_path} deploy", anything)
+    it 'runs capistrano when pulsar is invoked from outside an application' do
+      cap_cmd    = 'bundle exec cap'
+      env_vars   = "CONFIG_PATH=#{config_path}"
+      cmd_args   = "--file #{capfile_path} deploy"
+      full_cmd   = "#{cap_cmd} #{env_vars} #{cmd_args}"
+
+      run_capistrano('deploy')
 
-      run_capistrano("deploy")
+      expect(self).to have_received(:run_cmd).with(full_cmd, anything)
     end
 
-    it "runs capistrano when pulsar is invoked from inside the application directory" do
-      self.stub!(:application_path).and_return("/app/path")
+    it 'runs capistrano when pulsar is invoked from inside an application' do
+      allow(self).to receive(:application_path).and_return('/app/path')
+
+      cap_cmd    = 'bundle exec cap'
+      env_vars   = "CONFIG_PATH=#{config_path} APP_PATH=#{application_path}"
+      cmd_args   = "--file #{capfile_path} deploy"
+      full_cmd   = "#{cap_cmd} #{env_vars} #{cmd_args}"
 
-      self.should_receive(:run_cmd).with("bundle exec cap CONFIG_PATH=#{config_path} APP_PATH=#{application_path} --file #{capfile_path} deploy", anything)
+      run_capistrano('deploy')
 
-      run_capistrano("deploy")
+      expect(self).to have_received(:run_cmd).with(full_cmd, anything)
     end
   end
 end

data/spec/pulsar/helpers/shell_spec.rb

@@ -3,9 +3,9 @@ require 'spec_helper'
 describe Pulsar::Helpers::Shell do
   include Pulsar::Helpers::Shell
 
-  context "run_cmd" do
-    it "raises exception if command fails" do
-      expect { run_cmd("false", {}) }.to raise_error
+  context 'run_cmd' do
+    it 'raises exception if command fails' do
+      expect { run_cmd('false', {}) }.to raise_error
     end
   end
 end

data/spec/spec_helper.rb

@@ -1,30 +1,31 @@
-require "rspec"
-require "stringio"
-require "fileutils"
-require "coveralls"
-require "pulsar"
-require "pulsar/commands/main"
-require "pulsar/commands/utils"
+require 'rspec'
+require 'stringio'
+require 'fileutils'
+require 'codeclimate-test-reporter'
+require 'pulsar'
+require 'pulsar/commands/main'
+require 'pulsar/commands/utils'
 
 #
 # Code coverage
 #
-Coveralls.wear!
+CodeClimate::TestReporter.start
 
 #
 # Require all helper modules
 #
-Dir[File.join(File.dirname(__FILE__), 'support/modules/**/*.rb')].each { |f| require f }
+Dir[File.join(File.dirname(__FILE__), 'support/modules/**/*.rb')].each do |f|
+  require f
+end
 
 RSpec.configure do |config|
   config.mock_with :rspec
+  config.raise_errors_for_deprecations!
 
   config.include Helpers
   config.include OutputCapture
 
   config.before(:each) do
-    Dir.stub(:home).and_return("/fake/home")
-
     dummy_dotfile_options.keys.each do |variable|
       ENV.delete(variable.to_s)
     end

data/spec/support/dummies/dummy_conf/Gemfile

@@ -1,4 +1,4 @@
 source 'https://rubygems.org'
 
 # Require from local gem
-gem 'pulsar', :path => '../../../../'
+gem 'pulsar', path: '../../../../'

data/spec/support/dummies/dummy_conf/apps/base.rb

@@ -29,18 +29,18 @@ end
 #
 set :scm, :git
 
-set :ssh_options, { :forward_agent => true }
+set :ssh_options, forward_agent: true
 
-set :default_run_options, { :pty => true }
+set :default_run_options, pty: true
 
 set :deploy_to, defer { "/var/www/#{application}" }
 
 set :deploy_via, :remote_cache
 
-set :user, "www-data"
+set :user, 'www-data'
 
 set :use_sudo, false
 
-set :rake, "bundle exec rake"
+set :rake, 'bundle exec rake'
 
-set :rails_env, defer { "#{stage}" }
+set :rails_env, defer { stage }

data/spec/support/dummies/dummy_conf/apps/dummy_app/custom_stage.rb

@@ -1,5 +1,5 @@
 # This is apps/dummy_app/custom_stage.rb
 
-server "dummy.it", :db, :web, :app, :primary => true
+server 'dummy.it', :db, :web, :app, primary: true
 
-set :stage, "custom_stage"
+set :stage, 'custom_stage'

data/spec/support/dummies/dummy_conf/apps/dummy_app/defaults.rb

@@ -1,6 +1,6 @@
 # This is apps/dummy_app/defaults.rb
 
-set :application, "dummy_app"
+set :application, 'dummy_app'
 
 load_recipes do
   generic :recipe

data/spec/support/dummies/dummy_conf/apps/dummy_app/production.rb

@@ -1,5 +1,5 @@
 # This is apps/dummy_app/production.rb
 
-server "dummy.it", :db, :web, :app, :primary => true
+server 'dummy.it', :db, :web, :app, primary: true
 
-set :stage, "production"
+set :stage, 'production'

data/spec/support/dummies/dummy_conf/apps/dummy_app/staging.rb

@@ -1,5 +1,5 @@
 # This is apps/dummy_app/staging.rb
 
-server "staging.dummy.it", :db, :web, :app, :primary => true
+server 'staging.dummy.it', :db, :web, :app, primary: true
 
-set :stage, "staging"
+set :stage, 'staging'

data/spec/support/dummies/dummy_conf/apps/other_dummy_app/custom_stage.rb

@@ -1,5 +1,5 @@
 # This is apps/other_dummy_app/custom_stage.rb
 
-server "dummy.it", :db, :web, :app, :primary => true
+server 'dummy.it', :db, :web, :app, primary: true
 
-set :stage, "custom_stage"
+set :stage, 'custom_stage'

data/spec/support/dummies/dummy_conf/apps/other_dummy_app/defaults.rb

@@ -1,6 +1,6 @@
 # This is apps/other_dummy_app/defaults.rb
 
-set :application, "other_dummy_app"
+set :application, 'other_dummy_app'
 
 load_recipes do
   generic :recipe

data/spec/support/dummies/dummy_conf/apps/other_dummy_app/production.rb

@@ -1,5 +1,5 @@
 # This is apps/other_dummy_app/production.rb
 
-server "other_dummy.it", :db, :web, :app, :primary => true
+server 'other_dummy.it', :db, :web, :app, primary: true
 
-set :stage, "production"
+set :stage, 'production'

data/spec/support/dummies/dummy_conf/apps/other_dummy_app/staging.rb

@@ -1,5 +1,5 @@
 # This is apps/other_dummy_app/staging.rb
 
-server "staging.other_dummy.it", :db, :web, :app, :primary => true
+server 'staging.other_dummy.it', :db, :web, :app, primary: true
 
-set :stage, "staging"
+set :stage, 'staging'