puffing-billy 0.2.3 → 0.3.0

data/spec/lib/billy/handlers/stub_handler_spec.rb

@@ -0,0 +1,71 @@
+require 'spec_helper'
+
+describe Billy::StubHandler do
+  let(:handler) { Billy::StubHandler.new }
+  let(:request) { {
+      method:   'GET',
+      url:      'http://example.test:8080/index?some=param',
+      headers:  {'Accept-Encoding'  => 'gzip',
+                 'Cache-Control'    => 'no-cache' },
+      body:     'Some body'
+  } }
+
+  describe '#handles_request?' do
+    it 'handles the request if it is stubbed' do
+      expect(handler).to receive(:find_stub).and_return("a stub")
+      expect(handler.handles_request?(nil,nil,nil,nil)).to be true
+    end
+
+    it 'does not handle the request if it is not stubbed' do
+      expect(handler).to receive(:find_stub).and_return(nil)
+      expect(handler.handles_request?(nil,nil,nil,nil)).to be false
+    end
+  end
+
+  describe '#handle_request' do
+    it 'returns nil if the request is not stubbed' do
+      expect(handler).to receive(:handles_request?).and_return(false)
+      expect(handler.handle_request(nil,nil,nil,nil)).to be nil
+    end
+
+    it 'returns a response hash if the request is stubbed' do
+      stub = double("stub", :call => [200, {'Content-Type' => 'application/json'}, "Some content"])
+      expect(handler).to receive(:handles_request?).and_return(true)
+      expect(handler).to receive(:find_stub).and_return(stub)
+      expect(handler.handle_request('GET',
+                                    request[:url],
+                                    request[:headers],
+                                    request[:body])).to eql({:status => 200,
+                                                             :headers => {'Content-Type' => 'application/json'},
+                                                             :content => "Some content"})
+    end
+  end
+
+  describe '#reset' do
+    before do
+      # Can't use request params when creating the stub.
+      # See https://github.com/oesmith/puffing-billy/issues/21
+      handler.stub('http://example.test:8080/index')
+    end
+
+    it 'resets the stubs' do
+      expect(handler.handles_request?('GET',
+                                      request[:url],
+                                      request[:headers],
+                                      request[:body])).to be true
+      handler.reset
+      expect(handler.handles_request?('GET',
+                                      request[:url],
+                                      request[:headers],
+                                      request[:body])).to be false
+    end
+  end
+
+  it '#stubs requests' do
+    handler.stub('http://example.test:8080/index')
+    expect(handler.handles_request?('GET',
+                                    request[:url],
+                                    request[:headers],
+                                    request[:body])).to be true
+  end
+end

data/spec/lib/billy/resource_utils_spec.rb

@@ -46,10 +46,10 @@ describe Billy::JSONUtils do
     let(:non_json) { 'Not JSON.' }
 
     it 'identifies JSON' do
-      expect(Billy::JSONUtils::json?(json)).to be_true
+      expect(Billy::JSONUtils::json?(json)).to be true
     end
     it 'identifies non-JSON' do
-      expect(Billy::JSONUtils::json?(non_json)).to be_false
+      expect(Billy::JSONUtils::json?(non_json)).to be false
     end
   end
-end
+end

data/spec/lib/proxy_spec.rb

@@ -129,13 +129,17 @@ shared_examples_for 'a cache' do
   end
 
   context "cache persistence" do
+    let(:cache_path) { Billy.config.cache_path }
     let(:cached_key) { proxy.cache.key('get',"#{url}/foo","") }
     let(:cached_file) do
       f = cached_key + ".yml"
-      File.join(Billy.config.cache_path, f)
+      File.join(cache_path, f)
     end
 
-    before { Billy.config.whitelist = [] }
+    before do
+      Billy.config.whitelist = []
+      Dir.mkdir(cache_path) unless Dir.exist?(cache_path)
+    end
 
     after do
       File.delete(cached_file) if File.exists?(cached_file)
@@ -146,7 +150,7 @@ shared_examples_for 'a cache' do
 
       it 'should persist' do
         r = http.get('/foo')
-        expect(File.exists?(cached_file)).to be_true
+        expect(File.exists?(cached_file)).to be true
       end
 
       it 'should be read initially from persistent cache' do
@@ -211,7 +215,7 @@ shared_examples_for 'a cache' do
 
         it 'should not cache non-successful response when enabled' do
           http_error.get('/foo')
-          expect(File.exists?(cached_file)).to be_false
+          expect(File.exists?(cached_file)).to be false
         end
 
         it 'should cache successful response when enabled' do
@@ -235,6 +239,9 @@ shared_examples_for 'a cache' do
           # 3) Change the test servers to start/stop for each test instead of before all
           # 4) Remove the test server completely and rely on the server instantiated by the app
           pending "Unable to test this without affecting the running test servers"
+          # If the 'pending' continues to execute the spec, 'skip' it to avoid EM errors.
+          # If 'pending' stops the test, 'skip' isn't defined but it won't hit this line.
+          skip "Unable to test this without affecting the running test servers"
           expect{http_error.get('/foo')}.to raise_error(Faraday::Error::ConnectionFailed)
         end
       end
@@ -246,7 +253,7 @@ shared_examples_for 'a cache' do
 
       it 'shouldnt persist' do
         r = http.get('/foo')
-        expect(File.exists?(cached_file)).to be_false
+        expect(File.exists?(cached_file)).to be false
       end
     end
   end
@@ -279,7 +286,7 @@ describe Billy::Proxy do
     # Valid options: :request, :proxy, :ssl, :builder, :url, :parallel_manager, :params, :headers, :builder_class
     faraday_options = {
       :proxy   => { :uri => proxy.url },
-      :request => { :timeout => 0.5 }
+      :request => { :timeout => 1.0 }
     }
 
     @http       = Faraday.new @http_url,  faraday_options
@@ -320,7 +327,7 @@ describe Billy::Proxy do
   context 'caching' do
 
     it 'defaults to nil scope' do
-      expect(proxy.cache.scope).to be_nil
+      expect(proxy.cache.scope).to be nil
     end
 
     context 'HTTP' do
@@ -358,7 +365,7 @@ describe Billy::Proxy do
 
       it 'can be reset to the default scope' do
         proxy.cache.use_default_scope
-        expect(proxy.cache.scope).to be_nil
+        expect(proxy.cache.scope).to be nil
       end
 
       it 'can execute a block against a cache scope' do

data/spec/spec_helper.rb

@@ -1,5 +1,6 @@
 Dir[File.expand_path("../support/**/*.rb", __FILE__)].each {|f| require f}
 
+require 'pry'
 require 'billy/rspec'
 require 'rack'
 require 'logger'
@@ -13,7 +14,6 @@ end
 
 RSpec.configure do |config|
   include Billy::TestServer
-  config.treat_symbols_as_metadata_keys_with_true_values = true
   config.run_all_when_everything_filtered = true
   config.filter_run :focus
   config.order = 'random'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puffing-billy
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.3.0
 platform: ruby
 authors:
 - Olly Smith
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-07 00:00:00.000000000 Z
+date: 2014-12-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -179,7 +179,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: em-http-request
+  name: em-synchrony
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -193,7 +193,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: eventmachine_httpserver
+  name: em-http-request
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -207,7 +207,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: http_parser.rb
+  name: eventmachine_httpserver
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -220,6 +220,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: http_parser.rb
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.6.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.6.0
 - !ruby/object:Gem::Dependency
   name: multi_json
   requirement: !ruby/object:Gem::Requirement
@@ -259,6 +273,8 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - Gemfile.lock
 - Guardfile
@@ -273,6 +289,11 @@ files:
 - lib/billy/cache.rb
 - lib/billy/config.rb
 - lib/billy/cucumber.rb
+- lib/billy/handlers/cache_handler.rb
+- lib/billy/handlers/handler.rb
+- lib/billy/handlers/proxy_handler.rb
+- lib/billy/handlers/request_handler.rb
+- lib/billy/handlers/stub_handler.rb
 - lib/billy/json_utils.rb
 - lib/billy/mitm.crt
 - lib/billy/mitm.key
@@ -292,6 +313,11 @@ files:
 - spec/fixtures/test-server.crt
 - spec/fixtures/test-server.key
 - spec/lib/billy/cache_spec.rb
+- spec/lib/billy/handlers/cache_handler_spec.rb
+- spec/lib/billy/handlers/handler_spec.rb
+- spec/lib/billy/handlers/proxy_handler_spec.rb
+- spec/lib/billy/handlers/request_handler_spec.rb
+- spec/lib/billy/handlers/stub_handler_spec.rb
 - spec/lib/billy/proxy_request_stub_spec.rb
 - spec/lib/billy/resource_utils_spec.rb
 - spec/lib/proxy_spec.rb
@@ -316,7 +342,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Easy request stubs for browser tests.
@@ -326,6 +352,11 @@ test_files:
 - spec/fixtures/test-server.crt
 - spec/fixtures/test-server.key
 - spec/lib/billy/cache_spec.rb
+- spec/lib/billy/handlers/cache_handler_spec.rb
+- spec/lib/billy/handlers/handler_spec.rb
+- spec/lib/billy/handlers/proxy_handler_spec.rb
+- spec/lib/billy/handlers/request_handler_spec.rb
+- spec/lib/billy/handlers/stub_handler_spec.rb
 - spec/lib/billy/proxy_request_stub_spec.rb
 - spec/lib/billy/resource_utils_spec.rb
 - spec/lib/proxy_spec.rb