pubsub_notifier 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7afc8a84729f47928bca7b4b3b432ceba1d98458
-  data.tar.gz: 10c9907f794ebd014e0dbe372b386ca6008f08e6
+  metadata.gz: bbf75609870b5f43818cd6ca1c2b320bbf1ad2fe
+  data.tar.gz: 7ead5b1b9bfe7e0f432bd7267277b38bba21393f
 SHA512:
-  metadata.gz: 4e770a775b9e7f04cb9f59cefb02e845f06dbd2018f199841a35bdb43dd55f11bd2c08c30129a80fe351ac04c7e8c4d754d3e924780999cbd427fc912066b077
-  data.tar.gz: '03547309641d77529300b6b9d3116ba7b924beef44fd9457de49ff50234452fa235f4e6e36005cf4aaab11ab498c14a095b37edb019d63903e2a39c9fc809de2'
+  metadata.gz: 5d39a9e1533fda09d47a66de943b58442d7cff8ea77fd9fcb19a1f9b3f5e0f91cc77a39c948ecbf59526662258a140880768a1623ebb51e756a7097c75586291
+  data.tar.gz: 06e2db840248b5c0f1d84138b8ad50806f3916baf79e01672eda2e9d9c5c35721f12fccd1f2ea6cbbf01c846480382d3f6f9a9cb9c59db6da6f5c576e13cbf04

data/README.md

@@ -1,5 +1,8 @@
 # PubsubNotifier
 
+[![Build Status](https://travis-ci.org/yhirano55/pubsub_notifier.svg?branch=master)](https://travis-ci.org/yhirano55/pubsub_notifier)
+[![Gem Version](https://badge.fury.io/rb/pubsub_notifier.svg)](https://badge.fury.io/rb/pubsub_notifier)
+
 Publish-Subscribe Notifier for Ruby on Rails.
 
 This gem relies on [krisleech/wisper](https://github.com/krisleech/wisper/) provides Pub/Sub capabilities.

data/lib/generators/pubsub_notifier/install/install_generator.rb

@@ -1,13 +1,15 @@
 module PubsubNotifier
-  class InstallGenerator < ::Rails::Generators::Base
-    source_root File.expand_path("../templates", __FILE__)
+  module Generators
+    class InstallGenerator < ::Rails::Generators::Base
+      source_root File.expand_path("../templates", __FILE__)
 
-    def create_initializer_file
-      template "initializer.rb", "config/initializers/pubsub_notifier.rb"
-    end
+      def create_initializer_file
+        template "initializer.tt", "config/initializers/pubsub_notifier.rb"
+      end
 
-    def create_application_notifier_file
-      template "application_notifier.rb", "app/notifiers/application_notifier.rb"
+      def create_application_notifier_file
+        template "application_notifier.tt", "app/notifiers/application_notifier.rb"
+      end
     end
   end
 end

data/lib/generators/pubsub_notifier/install/templates/initializer.tt

@@ -0,0 +1,10 @@
+PubsubNotifier.config.logger = Rails.logger
+
+require "pubsub_notifier/slack_client"
+
+PubsubNotifier::SlackClient.configure do |config|
+  config.default_channel    = ENV["SLACK_DEFAULT_CHANNEL"]
+  config.default_username   = ENV["SLACK_DEFAULT_USERNAME"]
+  config.default_icon_emoji = ENV["SLACK_DEFAULT_ICON_EMOJI"]
+  config.webhook_url        = ENV["SLACK_WEBHOOK_URL"]
+end

data/lib/generators/rails/notifier_generator.rb

@@ -1,10 +1,11 @@
 module Rails
   module Generators
-    class NotifierGenerator < ::Rails::Generators::NamedBase
+    class NotifierGenerator < NamedBase
       source_root File.expand_path("../templates", __FILE__)
+      check_class_collision suffix: "Notifier"
 
       def create_notifier_file
-        template 'notifier.rb', File.join('app/notifiers', class_path, "#{file_name}_notifier.rb")
+        template "notifier.tt", File.join("app/notifiers", class_path, "#{file_name}_notifier.rb")
       end
 
       hook_for :test_framework

data/lib/generators/rails/templates/{notifier.rb → notifier.tt}

@@ -3,13 +3,11 @@ class <%= class_name %>Notifier < ApplicationNotifier
   use :slack
 
   def success(recipient)
-    record = recipient
-    notify_success("#{record} has successfully created.")
+    notify_success("#{self.class}##{__method__} called with #{recipient.class}.")
   end
 
   def failure(recipient)
-    record = recipient
-    notify_failure("#{record} cannot created.")
+    notify_failure("#{self.class}##{__method__} called with #{recipient.class}.")
   end
 end
 <% end -%>

data/lib/generators/rspec/notifier_generator.rb

@@ -1,9 +1,11 @@
 module RSpec
-  class NotifierGenerator < ::Rails::Generators::NamedBase
-    source_root File.expand_path("../templates", __FILE__)
+  module Generators
+    class NotifierGenerator < ::Rails::Generators::NamedBase
+      source_root File.expand_path("../templates", __FILE__)
 
-    def create_spec_file
-      template 'notifier_spec.rb', File.join('spec/notifiers', class_path, "#{file_name}_notifier_spec.rb")
+      def create_spec_file
+        template "notifier_spec.tt", File.join("spec/notifiers", class_path, "#{file_name}_notifier_spec.rb")
+      end
     end
   end
 end

data/lib/generators/rspec/templates/notifier_spec.tt

@@ -0,0 +1,5 @@
+require '<%= File.exists?('spec/rails_helper.rb') ? 'rails_helper' : 'spec_helper' %>'
+
+RSpec.describe <%= class_name %>Notifier do
+  pending "add some examples to (or delete) #{__FILE__}"
+end

data/lib/generators/test_unit/notifier_generator.rb

@@ -1,9 +1,11 @@
 module TestUnit
-  class NotifierGenerator < ::Rails::Generators::NamedBase
-    source_root File.expand_path("../templates", __FILE__)
+  module Generators
+    class NotifierGenerator < ::Rails::Generators::NamedBase
+      source_root File.expand_path("../templates", __FILE__)
 
-    def create_spec_file
-      template 'notifier_test.rb', File.join('test/notifiers', class_path, "#{file_name}_notifier_test.rb")
+      def create_test_file
+        template "notifier_test.tt", File.join("test/notifiers", class_path, "#{file_name}_notifier_test.rb")
+      end
     end
   end
 end

data/lib/generators/test_unit/templates/notifier_test.tt

@@ -0,0 +1,6 @@
+require 'test_helper'
+
+<% module_namespacing do -%>
+class <%= class_name %>NotifierTest < ActiveSupport::TestCase
+end
+<% end -%>

data/lib/pubsub_notifier/acts_as_notifier.rb

@@ -5,12 +5,13 @@ module PubsubNotifier
     end
 
     module ClassMethods
+      # Override ActionMailer::Base.method_missing
+      # https://github.com/rails/rails/blob/master/actionmailer/lib/action_mailer/base.rb#L576
       def acts_as_notifier
         class_eval do
           class << self
             private
-              # Override ActionMailer::Base#method_missing
-              # https://github.com/rails/rails/blob/master/actionmailer/lib/action_mailer/base.rb#L576
+
               def method_missing(method_name, *args)
                 if action_methods.include?(method_name.to_s)
                   ::ActionMailer::MessageDelivery.new(self, method_name, *args).tap(&:deliver)
@@ -18,6 +19,10 @@ module PubsubNotifier
                   super
                 end
               end
+
+              def respond_to_missing?(method_name, include_all = false)
+                action_methods.include?(method_name.to_s) || super
+              end
           end
         end
       end

data/lib/pubsub_notifier/base.rb

@@ -2,7 +2,7 @@ module PubsubNotifier
   class Base
     class << self
       def use(name, options = {})
-        @_client = ( clients[name.to_sym] || clients[:logger] ).new(options)
+        @_client = (clients[name.to_sym] || clients[:logger]).new(options)
       end
 
       def client

data/lib/pubsub_notifier/broadcasters/active_job_broadcaster.rb

@@ -19,12 +19,12 @@ module PubsubNotifier
           { wait: nil, wait_until: nil, queue: :default }
         end
 
-      class BroadcastJob < ::ActiveJob::Base
-        def perform(subscriber_name, event, args)
-          subscriber = subscriber_name.constantize
-          subscriber.public_send(event, *args)
+        class BroadcastJob < ::ActiveJob::Base
+          def perform(subscriber_name, event, args)
+            subscriber = subscriber_name.constantize
+            subscriber.public_send(event, *args)
+          end
         end
-      end
     end
   end
 end

data/lib/pubsub_notifier/client.rb

@@ -9,7 +9,8 @@ module PubsubNotifier
         @_config ||= self::Config.new
       end
 
-      def initialize(options = {}); end
+      def initialize(options = {})
+      end
 
       def notify_success(message)
         raise NotImplementedError, "#{self.class}##{__method__} is not implemented"

data/lib/pubsub_notifier/proxy.rb

@@ -7,7 +7,7 @@ module PubsubNotifier
     module ClassMethods
       def subscribe(subscriber_name, options = {})
         subscriber  = subscriber_name.to_s.constantize
-        broadcaster = ( options.delete(:async) ? broadcasters[:async] : nil ) || broadcasters[:default]
+        broadcaster = (options.delete(:async) ? broadcasters[:async] : nil) || broadcasters[:default]
         broadcaster.configure(options) if broadcaster.respond_to?(:configure)
         pubsub.subscribe(subscriber, broadcaster: broadcaster)
       end
@@ -27,7 +27,7 @@ module PubsubNotifier
       pubsub.call(event, self)
     end
 
-    alias pubilish broadcast
+    alias_method :pubilish, :broadcast
 
     private
 

data/lib/pubsub_notifier/slack_client.rb

@@ -1,6 +1,6 @@
-require 'net/http'
-require 'json'
-require 'uri'
+require "net/http"
+require "json"
+require "uri"
 
 module PubsubNotifier
   class SlackClient < ::PubsubNotifier::Client::Base
@@ -16,8 +16,8 @@ module PubsubNotifier
       post_slack(
         attachments: [{
           text:      message,
-          color:     'good',
-          mrkdwn_in: ['text'],
+          color:     "good",
+          mrkdwn_in: ["text"],
         }],
       )
     end
@@ -26,8 +26,8 @@ module PubsubNotifier
       post_slack(
         attachments: [{
           text:      message,
-          color:     'danger',
-          mrkdwn_in: ['text'],
+          color:     "danger",
+          mrkdwn_in: ["text"],
         }],
       )
     end
@@ -70,16 +70,16 @@ module PubsubNotifier
         config.webhook_url
       end
 
-    class Config
-      attr_accessor :default_channel, :default_username, :default_icon_emoji, :webhook_url
+      class Config
+        attr_accessor :default_channel, :default_username, :default_icon_emoji, :webhook_url
 
-      def initialize
-        @default_channel    = ENV['SLACK_DEFAULT_CHANNEL']
-        @default_username   = ENV['SLACK_DEFAULT_USERNAME']
-        @default_icon_emoji = ENV['SLACK_DEFAULT_ICON_EMOJI']
-        @webhook_url        = ENV['SLACK_WEBHOOK_URL']
+        def initialize
+          @default_channel    = ENV["SLACK_DEFAULT_CHANNEL"]
+          @default_username   = ENV["SLACK_DEFAULT_USERNAME"]
+          @default_icon_emoji = ENV["SLACK_DEFAULT_ICON_EMOJI"]
+          @webhook_url        = ENV["SLACK_WEBHOOK_URL"]
+        end
       end
-    end
   end
 end
 

data/lib/pubsub_notifier/version.rb

@@ -1,3 +1,3 @@
 module PubsubNotifier
-  VERSION = "0.1.0".freeze
+  VERSION = "0.1.1".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pubsub_notifier
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Yoshiyuki Hirano
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-13 00:00:00.000000000 Z
+date: 2017-07-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -63,15 +63,15 @@ files:
 - Rakefile
 - lib/generators/pubsub_notifier/install/USAGE
 - lib/generators/pubsub_notifier/install/install_generator.rb
-- lib/generators/pubsub_notifier/install/templates/application_notifier.rb
-- lib/generators/pubsub_notifier/install/templates/initializer.rb
+- lib/generators/pubsub_notifier/install/templates/application_notifier.tt
+- lib/generators/pubsub_notifier/install/templates/initializer.tt
 - lib/generators/rails/USAGE
 - lib/generators/rails/notifier_generator.rb
-- lib/generators/rails/templates/notifier.rb
+- lib/generators/rails/templates/notifier.tt
 - lib/generators/rspec/notifier_generator.rb
-- lib/generators/rspec/templates/notifier_spec.rb
+- lib/generators/rspec/templates/notifier_spec.tt
 - lib/generators/test_unit/notifier_generator.rb
-- lib/generators/test_unit/templates/notifier_test.rb
+- lib/generators/test_unit/templates/notifier_test.tt
 - lib/pubsub_notifier.rb
 - lib/pubsub_notifier/acts_as_notifier.rb
 - lib/pubsub_notifier/base.rb

data/lib/generators/pubsub_notifier/install/templates/initializer.rb

@@ -1,10 +0,0 @@
-PubsubNotifier.config.logger = Rails.logger
-
-require "pubsub_notifier/slack_client"
-
-PubsubNotifier::SlackClient.configure do |config|
-  config.default_channel    = ENV['SLACK_DEFAULT_CHANNEL']
-  config.default_username   = ENV['SLACK_DEFAULT_USERNAME']
-  config.default_icon_emoji = ENV['SLACK_DEFAULT_ICON_EMOJI']
-  config.webhook_url        = ENV['SLACK_WEBHOOK_URL']
-end

data/lib/generators/rspec/templates/notifier_spec.rb

@@ -1,5 +0,0 @@
-require '<%= File.exists?('spec/rails_helper.rb') ? 'rails_helper' : 'spec_helper' %>'
-
-describe <%= class_name %>Notifier do
-  subject { <%= class_name %>Notifier.new }
-end

data/lib/generators/test_unit/templates/notifier_test.rb

@@ -1,11 +0,0 @@
-require 'test_helper'
-
-class <%= singular_name.camelize %>NotifierTest < ActiveSupport::TestCase
-  def setup
-    @<%= singular_name %> = <%= class_name %>Notifier.new
-  end
-
-  # test "the truth" do
-  #   assert true
-  # end
-end