pubnub 4.2.6 → 4.2.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3f7a81a88398281f6a7aabc7b3a6cfdc12c3f2c69d3f38648f35de7143e325d4
-  data.tar.gz: cc0ceed081a5b115b283fe9ccc0e344e9865b815e3fef4b02ef24c01ea4d9507
+  metadata.gz: fa14ebbc97363da750a96e9a675bd03f8a7308668eb6d6972385348f2fe2a95a
+  data.tar.gz: f5ea4a167bb214814186aa1dd58fc7685bce1c412d4c6d575a92ca6ba17ddf6a
 SHA512:
-  metadata.gz: 1a715e51fcc684a51fb1ef192f95780ebf3c815c6fe0cf2c67df58a38a697be9a80e9a52541abe6a4202ebd2dc0f2b330b7c82ea261230bb95e6c3e73cb4509a
-  data.tar.gz: b4d7f702196a4aa9c32b4ca94c12ec9281ab37ad083175a021ef798f5b3148d3820abde80454b999b9609001e3bc76d61b27d62430c03e2f71166186cc0f91fb
+  metadata.gz: 69688095fd04c3832b6c07fa2ecc734c7f4f6503f85cfdc15138cc3c5e19b1c74b57e2e11fb6545e1f3f4d949360f9ac0618b71348d2751209f2e01c05dc2d2e
+  data.tar.gz: 54aae0e25031a5b5b3daed2ba4ad2385b9697482e7e515576175621bbacf66c32ee022ec7e91d67e1b26801454cc55896e49ea8caefbb21d32e2cbf682c1dfaa

data/.github/CODEOWNERS

@@ -0,0 +1 @@
+*       @parfeon @CraigLn

data/.pubnub.yml

@@ -1,14 +1,24 @@
 ---
-version: "4.2.6"
+version: "4.2.7"
 changelog:
+  -
+    changes:
+      -
+        text: "Don't suppress runtime errors."
+        type: bug
+    date: 14-09-2020
+    version: v4.2.7
   -
     changes:
       -
         text: "History can now respond with message meta information."
         type: feature
       -
-        text: "Added official support for Ruby 2.7X\u2028\u2028fix: Decrypt History messages\u2028\u2028History properly decrypts messages when using the \"include_token\" parameter."
+        text: "Added official support for Ruby 2.7.X"
         type: feature
+      -
+        text: "History properly decrypts messages when using the \"include_token\" parameter."
+        type: bug
     date: 25-08-2020
     version: v4.2.6
   -
@@ -37,7 +47,7 @@ changelog:
         text: "Resolved issue with subscribe loop where the connection was reinitiated after receiving a 4xx error code from the server"
         type: bugfix
     date: 14-02-2020
-    version: "4.2.6"
+    version: "4.2.7"
   -
     changes:
       -

data/CHANGELOG.md

@@ -1,20 +1,25 @@
-##### v4.2.6
+##### v4.2.7
 
-- History can now respond with message meta information. 
-- Added official support for Ruby 2.7X20282028fix: Decrypt History messages20282028History properly decrypts messages when using the "include_token" parameter. 
-
-##### v4.2.5
-
-- Updated Subscribe endpoint tests to use an unsorted channels list.
-- Fixed Message Counts channel timetokens by disabling alphabetic sorting of the channels list.
-
-##### v4.2.4
-
-- Update Grant, Revoke and Audit PAM tests to use v2 paths instead of v1.
-- Replace event name with full endpoint path in PAM signatures, for compatibility with PAM v2 signatures. Addresses the following PRs from [@stefan-qsd](https://github.com/stefan-qsd): [#112](https://github.com/pubnub/ruby/pull/112).
-- Change paths for PAM endpoints from v1 to v2.
-- Update PAM signature generator to correctly sort the query string parameters based on key instead of combined key and value.
+- Don't suppress runtime errors. 
 
+##### v4.2.6
+
+- History can now respond with message meta information. 
+- Added official support for Ruby 2.7.X
+- History properly decrypts messages when using the "include_token" parameter. 
+
+##### v4.2.5
+
+- Updated Subscribe endpoint tests to use an unsorted channels list.
+- Fixed Message Counts channel timetokens by disabling alphabetic sorting of the channels list.
+
+##### v4.2.4
+
+- Update Grant, Revoke and Audit PAM tests to use v2 paths instead of v1.
+- Replace event name with full endpoint path in PAM signatures, for compatibility with PAM v2 signatures. Addresses the following PRs from [@stefan-qsd](https://github.com/stefan-qsd): [#112](https://github.com/pubnub/ruby/pull/112).
+- Change paths for PAM endpoints from v1 to v2.
+- Update PAM signature generator to correctly sort the query string parameters based on key instead of combined key and value.
+
 ##### 4.2.3
 * Resolved issue with subscribe loop where the connection was reinitiated after receiving a 4xx error code from the server
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    pubnub (4.2.6)
+    pubnub (4.2.7)
       addressable (>= 2.0.0)
       concurrent-ruby (~> 1.1.5)
       concurrent-ruby-edge (~> 0.5.0)

data/README.md

@@ -7,7 +7,7 @@
 # Complete Documentation
 Available at https://www.pubnub.com/docs/ruby/pubnub-ruby-sdk-v4 **v4.x**
 
-## PubNub Gem version 4.2.6
+## PubNub Gem version 4.2.7
 
 ##### YOU MUST HAVE A PUBNUB ACCOUNT TO USE THE API.
 ##### http://www.pubnub.com/account

data/VERSION

@@ -1 +1 @@
-4.2.6
+4.2.7

data/lib/pubnub/event/formatter.rb

@@ -10,7 +10,11 @@ module Pubnub
                                 response,
                                 request: request,
                                 response: response)
+        elsif response.is_a?(StandardError)
+          # unexpected error response
+          raise response
         end
+
         parsed_response, error = Formatter.parse_json(response.body)
 
         error = response if parsed_response && response.code.to_i != 200

data/lib/pubnub/subscribe_event/formatter.rb

@@ -148,6 +148,11 @@ module Pubnub
       end
 
       def format_envelopes(response, request)
+        if response.is_a?(StandardError)
+          # unexpected error response
+          raise response
+        end
+
         parsed_response, error = Pubnub::Formatter.parse_json(response.body)
 
         error = response if parsed_response && response.code.to_i != 200

data/lib/pubnub/version.rb

@@ -1,4 +1,4 @@
 # Toplevel Pubnub module.
 module Pubnub
-  VERSION = '4.2.6'.freeze
+  VERSION = '4.2.7'.freeze
 end

data/spec/lib/event/formatter_spec.rb

@@ -0,0 +1,22 @@
+require "spec_helper"
+
+describe "formatter" do
+  around :each do |example|
+    example.run_with_retry retry: 10
+  end
+
+  it "does not hide errors when formatting" do
+    class MockFormatter
+      include Pubnub::Event::EFormatter
+    end
+
+    class TestError < StandardError
+      def message
+        "This is a test"
+      end
+    end
+
+    # ensure the correct error is raised instead of -> NoMethodError: undefined method `body'
+    expect { MockFormatter.new.format_envelopes(TestError.new('error'), nil) }.to raise_error(TestError)
+  end
+end

data/spec/lib/subscribe_event/formatter_spec.rb

@@ -0,0 +1,22 @@
+require "spec_helper"
+
+describe "formatter" do
+  around :each do |example|
+    example.run_with_retry retry: 10
+  end
+
+  it "does not hide errors when formatting" do
+    class MockFormatter
+      include Pubnub::SubscribeEvent::Formatter
+    end
+
+    class TestError < StandardError
+      def message
+        "This is a test"
+      end
+    end
+
+    # ensure the correct error is raised instead of -> NoMethodError: undefined method `body'
+    expect { MockFormatter.new.send(:format_envelopes, TestError.new('error'), nil) }.to raise_error(TestError)
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pubnub
 version: !ruby/object:Gem::Version
-  version: 4.2.6
+  version: 4.2.7
 platform: ruby
 authors:
 - PubNub
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-08-25 00:00:00.000000000 Z
+date: 2020-09-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -129,6 +129,7 @@ extra_rdoc_files: []
 files:
 - ".bundle/config"
 - ".codeclimate.yml"
+- ".github/CODEOWNERS"
 - ".gitignore"
 - ".pubnub.yml"
 - ".rubocop.yml"
@@ -10715,6 +10716,7 @@ files:
 - spec/lib/client_spec.rb
 - spec/lib/connection_callback_spec.rb
 - spec/lib/custom_retries_examples_spec.rb
+- spec/lib/event/formatter_spec.rb
 - spec/lib/event_spec.rb
 - spec/lib/events/audit_spec.rb
 - spec/lib/events/channel_registration_spec.rb
@@ -10743,6 +10745,7 @@ files:
 - spec/lib/pubnub_spec.rb
 - spec/lib/signatures_spec.rb
 - spec/lib/ssl_error_spec.rb
+- spec/lib/subscribe_event/formatter_spec.rb
 - spec/lib/super_admin_spec.rb
 - spec/lib/uuid_spec.rb
 - spec/spec_expectations.rb
@@ -10792,6 +10795,7 @@ test_files:
 - spec/lib/client_spec.rb
 - spec/lib/connection_callback_spec.rb
 - spec/lib/custom_retries_examples_spec.rb
+- spec/lib/event/formatter_spec.rb
 - spec/lib/event_spec.rb
 - spec/lib/events/audit_spec.rb
 - spec/lib/events/channel_registration_spec.rb
@@ -10820,6 +10824,7 @@ test_files:
 - spec/lib/pubnub_spec.rb
 - spec/lib/signatures_spec.rb
 - spec/lib/ssl_error_spec.rb
+- spec/lib/subscribe_event/formatter_spec.rb
 - spec/lib/super_admin_spec.rb
 - spec/lib/uuid_spec.rb
 - spec/spec_expectations.rb