public_uid 2.1.0 → 2.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2feee63566bac287b2b37df241fe9f6d921815a25fa9d8ffda0ec2e51e79da88
-  data.tar.gz: '06879a851089f031f9729d7b9651e32ce5340ab2096db896c9001547b26be866'
+  metadata.gz: b9f535dd58ffefeceb1c162b838cd6bfc152d12d5d0c3036ccf3377d15a5d25f
+  data.tar.gz: a65e4856004a370828706d678a55be3a5940ff7f5a288ba8a4e5849060bc4da4
 SHA512:
-  metadata.gz: 592b580707bcb87cee3c82405b838011524d4197573f7ba3982c7b8cd3982fbd9605123e5b24a05f1c0b11be1bd54083fba0eaec27c47c157c361fb808ff1b90
-  data.tar.gz: c4b47726fd86694bd4213e72749841ba398dd408ed2d239fb749108df89ad93b4601a02eca1eac765b1eb0e17e16d79b9e69146ac552fecde9f237f89f667043
+  metadata.gz: f7ae3ce54c0dfaa21d192937c9c6aec75da1aaae789a2261a55dcfabcfc3e740c43b7ae646f2ca601d9139008108e69d6635eef058c35c18b135496d68a79d07
+  data.tar.gz: b4e1daa515802166ea148c14a1fa3352f871f7a7725e77e74af37ea9d726e365545ad398e23c4e08a7dce06c38f0741513ed12a7ca4c8fdc53b37cdcfe2cf1ed

data/.travis.yml

@@ -1,8 +1,12 @@
 language: ruby
 rvm:
-  - 2.3.8
   - 2.4.5
   - 2.5.3
   - 2.6.5
+  - 2.7.0
+  - 2.7.3
+  - 2.7.5
+  - 3.0.0
+  - 3.1.0
 before_install:
   - gem install bundler

data/README.md

@@ -57,14 +57,28 @@ Create database column for public unique ID.
 class AddPublicUidToUsers < ActiveRecord::Migration
   def change
     add_column :users, :public_uid, :string
-    add_index  :users, :public_uid
+    add_index  :users, :public_uid, unique: true
+  end
+end
+```
+
+or if you are creating table
+
+```ruby
+class CreateEntries < ActiveRecord::Migration[7.1]
+  def change
+    create_table :entries do |t|
+      # ...
+      t.string :public_uid, index: { unique: true }
+      # ...
+    end
   end
 end
 ```
 
 ### Step 2a - Using Rails concern
 
-> a.k.a - the easy way for Rails
+> a.k.a - the easy way for Rails (availible since version 2.1.0)
 
 ```ruby
 class User < ActiveRecord::Base
@@ -72,6 +86,28 @@ class User < ActiveRecord::Base
 end
 ```
 
+Example:
+
+
+```ruby
+user = User.create
+user.public_uid
+# => "xxxxxxxx"
+
+user.to_param
+# => "xxxxxxxx"
+
+User.find_puid('xxxxxxxx')
+# => <#User ...>
+User.find_puid('not_existing')
+# => nil
+
+User.find_puid!('xxxxxxxx')
+# => <#User ...>
+User.find_puid!('not_existing')
+# PublicUid::RecordNotFound (User 'not_existing' not found)
+```
+
 This will automatically:
 
 * assumes your model has `public_uid` column and generate public_uid value for you
@@ -85,6 +121,8 @@ If you need more customization please  follow **Step 2b** instead
 
 ### Step 2b - Using manual generate method
 
+> a.k.a bit harder than `2.a` but more flexible way for Rails
+
 Tell your model to generate the public identifier
 
 ```ruby
@@ -111,7 +149,7 @@ Then you can do more clever things like having urls based on `public_uid` and `t
 class User < ActiveRecord::Base
   generate_public_uid
 
-  def self.find_param(param)
+  def self.find_puid(param)
     find_by! public_uid: param.split('-').first
   end
   
@@ -124,7 +162,7 @@ end
 class UsersController < ActionController::Base
   # ...
   def show
-    @user = User.find_param(param[:id])
+    @user = User.find_puid(param[:id])
     # ...
   end
   # ...
@@ -357,3 +395,12 @@ If anyone want to see public_uid v 2.0 to support other data mappers (e.g. mongo
 
 Sorry for any inconvenience
 
+##### 2022-11-03
+
+Version 2.2.0 released
+
+
+`model.dup` will now not copy the public_uid value (same as `model.id`  )
+
+more: https://github.com/equivalent/public_uid/pull/21
+

data/lib/public_uid/model.rb

@@ -14,6 +14,15 @@ module PublicUid
         pub_uid.generate self.class.public_uid_generator
         pub_uid.set
       end
+
+      def initialize_dup(*)
+        super
+        _clear_public_uid_column
+      end
+
+      def _clear_public_uid_column
+        self.send("#{self.class.public_uid_column}=", nil)
+      end
     end
 
     module ClassMethods

data/lib/public_uid/set_public_uid.rb

@@ -27,7 +27,7 @@ module PublicUid
     private
 
     def similar_uid_exist?
-      @klass.where(@column => new_uid).count > 0
+      @klass.where(@column => new_uid).exists?
     end
 
     def check_column_existance

data/lib/public_uid/version.rb

@@ -1,3 +1,3 @@
 module PublicUid
-  VERSION = "2.1.0"
+  VERSION = "2.2.0"
 end

data/test/models/custom_public_uid_column_test.rb

@@ -3,7 +3,8 @@ require 'test_helper'
 TestConf.orm_modules.each do |orm_module|
   describe orm_module.description do
     context 'Model with custom public uid column' do
-      let(:user) { "#{orm_module}::CustomPublicUidColumnModel".constantize.new }
+      let(:model_class) { "#{orm_module}::CustomPublicUidColumnModel".constantize }
+      let(:user) { model_class.new }
 
       describe '#custom_uid' do
         subject{ user.custom_uid }
@@ -31,6 +32,26 @@ TestConf.orm_modules.each do |orm_module|
           it{ expect(subject.length).must_equal(8) }
         end
       end
+
+      describe '#dup' do
+        let(:user) { model_class.new(:custom_uid => 'abcdefg') }
+
+        it do
+          dup_user = user.dup
+          expect(user.custom_uid).must_equal('abcdefg')
+          expect(dup_user.custom_uid).must_equal(nil)
+        end
+      end
+
+      describe '#clone' do
+        let(:user) { model_class.new(:custom_uid => 'abcdefg') }
+
+        it do
+          clone_user = user.clone
+          expect(user.custom_uid).must_equal('abcdefg')
+          expect(clone_user.custom_uid).must_equal('abcdefg')
+        end
+      end
     end
   end
 end

data/test/models/model_with_generator_defaults_test.rb

@@ -3,7 +3,8 @@ require 'test_helper'
 TestConf.orm_modules.each do |orm_module|
   describe orm_module.description do
     context 'Model with default generator' do
-      let(:user) { "#{orm_module}::ModelWithGeneratorDefaults".constantize.new }
+      let(:model_class) { "#{orm_module}::ModelWithGeneratorDefaults".constantize }
+      let(:user) { model_class.new }
 
       describe '#public_uid' do
         subject{ user.public_uid }
@@ -31,6 +32,26 @@ TestConf.orm_modules.each do |orm_module|
           it{ expect(subject.length).must_equal(8) }
         end
       end
+
+      describe '#dup' do
+        let(:user) { model_class.new(:public_uid => 'abcdefg') }
+
+        it do
+          dup_user = user.dup
+          expect(user.public_uid).must_equal('abcdefg')
+          expect(dup_user.public_uid).must_equal(nil)
+        end
+      end
+
+      describe '#clone' do
+        let(:user) { model_class.new(:public_uid => 'abcdefg') }
+
+        it do
+          clone_user = user.clone
+          expect(user.public_uid).must_equal('abcdefg')
+          expect(clone_user.public_uid).must_equal('abcdefg')
+        end
+      end
     end
   end
 end

data/test/models/model_with_public_uid_concern_test.rb

@@ -44,6 +44,26 @@ TestConf.orm_modules.each do |orm_module|
           end
         end
       end
+
+      describe '#dup' do
+        let(:user) { model_class.new(:public_uid => 'abcdefg') }
+
+        it do
+          dup_user = user.dup
+          expect(user.public_uid).must_equal('abcdefg')
+          expect(dup_user.public_uid).must_equal(nil)
+        end
+      end
+
+      describe '#clone' do
+        let(:user) { model_class.new(:public_uid => 'abcdefg') }
+
+        it do
+          clone_user = user.clone
+          expect(user.public_uid).must_equal('abcdefg')
+          expect(clone_user.public_uid).must_equal('abcdefg')
+        end
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: public_uid
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.2.0
 platform: ruby
 authors:
 - Tomas Valent
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-03-22 00:00:00.000000000 Z
+date: 2022-11-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -165,7 +165,7 @@ homepage: https://github.com/equivalent/public_uid
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -180,8 +180,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.3.7
+signing_key:
 specification_version: 4
 summary: Automatic generates public UID column
 test_files: