public_suffix 4.0.3 → 4.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 62962616c4c61eea8b72706b4f01a7775577f6cf17d38b52fda29fe35809e2c0
-  data.tar.gz: 7d26aed0fb6c50d3d7620330a0bc319fca4a9eb777e526ef87e91019150b53e9
+  metadata.gz: 4024f44e47147f95aacb6e0be5e0d7b9a23e3b2a4ea98c8f4f2bfd3eac65bd08
+  data.tar.gz: 99596dd3d3d98439fed363cfb0d9d1500a7096bf744583625d4ebb8f91d7e8b2
 SHA512:
-  metadata.gz: 5b4feb7c4763a8273e870568bd674d70714a809f9d77c799dd51af3b9f682893924d7a69d79e1d8c231f155fde9637dbba0cfa18009d222ce9f1d459816cd0d9
-  data.tar.gz: a7e2fefbf3c506e88a6a954ae203254bf6426c91385d98ca8759f73e8cc47ad3b8513f19b45af903e624cf8fc983ad0c5044b2a33aa340034072ca25d8859128
+  metadata.gz: 127164c169e2c4cf0b7d640afab77a6fc52772501d9b09ac4c161ede20422e15c58f6a36346a46dffe104d33467915298b4538085ea427682984af914ea0448d
+  data.tar.gz: 6fb21d08ee9c96a78c87e780ee186282aa73d9957b613043b7779dc5a350a69bbee645b267bb462cde7cdf0befbcd037514bc66c28059c6254bfc4476d1e518a

data/.gitignore

@@ -1,11 +1,8 @@
 # Bundler
-.bundle
-Gemfile.lock
-pkg/*
-
-# Rubinius
-*.rbc
+/.bundle
+/Gemfile.lock
+/pkg/*
 
 # YARD
-.yardoc
-yardoc/
+/.yardoc
+/yardoc/

data/.rubocop.yml

@@ -1,5 +1,5 @@
 inherit_from:
-  - .rubocop_defaults.yml
+  - .rubocop_opinionated.yml
 
 AllCops:
   Exclude:

data/{.rubocop_defaults.yml → .rubocop_opinionated.yml}

@@ -14,21 +14,6 @@ Layout/LineLength:
     - 'test/**/*_test.rb'
   Max: 100
 
-# Array indentation should be considered like MultilineMethodCallIndentation indentation
-# and use 4 spaces instead of 2.
-Layout/FirstArrayElementIndentation:
-  IndentationWidth: 4
-
-# Hash indentation should be considered like MultilineMethodCallIndentation indentation
-# and use 4 spaces instead of 2.
-Layout/FirstHashElementIndentation:
-  IndentationWidth: 4
-
-# Multi-line differs from standard indentation, they are indented twice.
-Layout/MultilineMethodCallIndentation:
-  EnforcedStyle: indented
-  IndentationWidth: 4
-
 # [codesmell]
 Metrics/AbcSize:
   Enabled: false
@@ -120,17 +105,6 @@ Style/FormatString:
 Style/FormatStringToken:
   Enabled: false
 
-# Prefer the latest Hash syntax
-Style/HashSyntax:
-  Exclude:
-    # But Rakefiles generally have some definition like
-    #   :default => :test
-    # that looks nicer with the old rocket syntax.
-    - 'Rakefile'
-
-Style/RescueStandardError:
-  Enabled: false
-
 # unless is not always cool.
 Style/NegatedIf:
   Enabled: false
@@ -145,6 +119,9 @@ Style/PercentLiteralDelimiters:
 Style/RescueModifier:
   Enabled: false
 
+Style/SymbolArray:
+  EnforcedStyle: brackets
+
 # Sorry, but using trailing spaces helps readability.
 #
 #   %w( foo bar )
@@ -177,3 +154,21 @@ Style/TrivialAccessors:
   #    end
   #
   IgnoreClassMethods: true
+
+# New cops
+# See https://docs.rubocop.org/en/latest/versioning/
+
+Lint/RaiseException:
+  Enabled: true
+
+Lint/StructNewOverride:
+  Enabled: true
+
+Style/HashEachMethods:
+  Enabled: true
+
+Style/HashTransformKeys:
+  Enabled: true
+
+Style/HashTransformValues:
+  Enabled: true

data/CHANGELOG.md

@@ -3,6 +3,13 @@
 This project uses [Semantic Versioning 2.0.0](https://semver.org/).
 
 
+## 4.0.4
+
+### Changed
+
+- Updated definitions.
+
+
 ## 4.0.3
 
 ### Fixed

data/Gemfile

@@ -4,9 +4,12 @@ source "https://rubygems.org"
 
 gemspec
 
+gem "rake"
+
 gem "codecov", require: false
+gem "memory_profiler", require: false
 gem "minitest"
 gem "minitest-reporters"
-gem "rubocop", require: false
-
-gem "memory_profiler", require: false
+gem "mocha"
+gem "rubocop", "0.81.0", require: false
+gem "yard"

data/README.md

@@ -2,8 +2,8 @@
 
 <tt>PublicSuffix</tt> is a Ruby domain name parser based on the [Public Suffix List](https://publicsuffix.org/).
 
-[![Build Status](https://travis-ci.org/weppos/publicsuffix-ruby.svg?branch=master)](https://travis-ci.org/weppos/publicsuffix-ruby)
-[![Tidelift dependencies](https://tidelift.com/badges/github/weppos/publicsuffix-ruby)](https://tidelift.com/subscription/pkg/rubygems-public-suffix?utm_source=rubygems-public-suffix&utm_medium=referral&utm_campaign=readme)
+[![Build Status](https://travis-ci.com/weppos/publicsuffix-ruby.svg?branch=master)](https://travis-ci.com/weppos/publicsuffix-ruby)
+[![Tidelift dependencies](https://tidelift.com/badges/package/rubygems/public_suffix)](https://tidelift.com/subscription/pkg/rubygems-public-suffix?utm_source=rubygems-public-suffix&utm_medium=referral&utm_campaign=enterprise)
 
 
 ## Links

data/SECURITY.md

@@ -16,7 +16,7 @@ Older major versions are no longer supported.
 
 To make a report, please email weppos@weppos.net.
 
-Please consider encrypting your report with GPG using the key (0x420da82a989398df)[https://keyserver.ubuntu.com/pks/lookup?op=get&search=0x420da82a989398df]
+Please consider encrypting your report with GPG using the key [0x420da82a989398df](https://keyserver.ubuntu.com/pks/lookup?op=get&search=0x420da82a989398df).
 
 ```
 -----BEGIN PGP PUBLIC KEY BLOCK-----
@@ -99,3 +99,6 @@ q59MIs/Fb3SgaO+zN2FZTYp6dyRJHbeEz55JdOu6F+6ihZYH
 ```
 
 
+## Tracking Security Updates
+
+Information about security vulnerabilities are published in the [Security Advisories](https://github.com/weppos/publicsuffix-ruby/security/advisories) page.

data/data/list.txt

@@ -79,7 +79,6 @@ exchange.aero
 express.aero
 federation.aero
 flight.aero
-freight.aero
 fuel.aero
 gliding.aero
 government.aero
@@ -719,11 +718,13 @@ gouv.ci
 *.ck
 !www.ck
 
-// cl : https://en.wikipedia.org/wiki/.cl
+// cl : https://www.nic.cl
+// Confirmed by .CL registry <hsalgado@nic.cl>
 cl
-gov.cl
-gob.cl
+aprendemas.cl
 co.cl
+gob.cl
+gov.cl
 mil.cl
 
 // cm : https://en.wikipedia.org/wiki/.cm plus bug 981927
@@ -982,8 +983,19 @@ fi
 // TODO: Check for updates (expected to be phased out around Q1/2009)
 aland.fi
 
-// fj : https://en.wikipedia.org/wiki/.fj
-*.fj
+// fj : http://domains.fj/
+// Submitted by registry <garth.miller@cocca.org.nz> 2020-02-11
+fj
+ac.fj
+biz.fj
+com.fj
+gov.fj
+info.fj
+mil.fj
+name.fj
+net.fj
+org.fj
+pro.fj
 
 // fk : https://en.wikipedia.org/wiki/.fk
 *.fk
@@ -6508,7 +6520,7 @@ k12.ok.us
 k12.or.us
 k12.pa.us
 k12.pr.us
-k12.ri.us
+// k12.ri.us  Removed at request of Kim Cournoyer <netsupport@staff.ri.net>
 k12.sc.us
 // k12.sd.us  Bug 934131 - Removed at request of James Booze <James.Booze@k12.sd.us>
 k12.tn.us
@@ -6795,8 +6807,13 @@ yt
 مصر
 
 // xn--e1a4c ("eu", Cyrillic) : EU
+// https://eurid.eu
 ею
 
+// xn--qxa6a ("eu", Greek) : EU
+// https://eurid.eu
+ευ
+
 // xn--mgbah1a3hjkrd ("Mauritania", Arabic) : MR
 موريتانيا
 
@@ -7074,7 +7091,7 @@ org.zw
 
 // newGTLDs
 
-// List of new gTLDs imported from https://www.icann.org/resources/registries/gtlds/v2/gtlds.json on 2019-12-25T17:26:24Z
+// List of new gTLDs imported from https://www.icann.org/resources/registries/gtlds/v2/gtlds.json on 2020-04-02T18:20:31Z
 // This list is auto-generated, don't edit it manually.
 // aaa : 2015-02-26 American Automobile Association, Inc.
 aaa
@@ -7196,7 +7213,7 @@ alsace
 // alstom : 2015-07-30 ALSTOM
 alstom
 
-// amazon : 2019-12-19 Amazon EU S.à r.l.
+// amazon : 2019-12-19 Amazon Registry Services, Inc.
 amazon
 
 // americanexpress : 2015-07-31 American Express Travel Related Services Company, Inc.
@@ -7376,7 +7393,7 @@ bcn
 // beats : 2015-05-14 Beats Electronics, LLC
 beats
 
-// beauty : 2015-12-03 L'Oréal
+// beauty : 2015-12-03 XYZ.COM LLC
 beauty
 
 // beer : 2014-01-09 Minds + Machines Group Limited
@@ -7832,7 +7849,7 @@ cuisinella
 // cymru : 2014-05-08 Nominet UK
 cymru
 
-// cyou : 2015-01-22 Beijing Gamease Age Digital Technology Co., Ltd.
+// cyou : 2015-01-22 ShortDot SA
 cyou
 
 // dabur : 2014-02-06 Dabur India Limited
@@ -8399,7 +8416,7 @@ guitars
 // guru : 2013-08-27 Binky Moon, LLC
 guru
 
-// hair : 2015-12-03 L'Oréal
+// hair : 2015-12-03 XYZ.COM LLC
 hair
 
 // hamburg : 2014-02-20 Hamburg Top-Level-Domain GmbH
@@ -8798,9 +8815,6 @@ lexus
 // lgbt : 2014-05-08 Afilias Limited
 lgbt
 
-// liaison : 2014-10-02 Liaison Technologies, Incorporated
-liaison
-
 // lidl : 2014-09-18 Schwarz Domains und Services GmbH & Co. KG
 lidl
 
@@ -8921,7 +8935,7 @@ maif
 // maison : 2013-12-05 Binky Moon, LLC
 maison
 
-// makeup : 2015-01-15 L'Oréal
+// makeup : 2015-01-15 XYZ.COM LLC
 makeup
 
 // man : 2014-12-04 MAN SE
@@ -9080,9 +9094,6 @@ mutual
 // nab : 2015-08-20 National Australia Bank Limited
 nab
 
-// nadex : 2014-12-11 Nadex Domains, Inc.
-nadex
-
 // nagoya : 2013-10-24 GMO Registry, Inc.
 nagoya
 
@@ -9764,7 +9775,7 @@ site
 // ski : 2015-04-09 Afilias Limited
 ski
 
-// skin : 2015-01-15 L'Oréal
+// skin : 2015-01-15 XYZ.COM LLC
 skin
 
 // sky : 2014-06-19 Sky International AG
@@ -10052,7 +10063,7 @@ trading
 // training : 2013-11-07 Binky Moon, LLC
 training
 
-// travel :  Dog Beach, LLC
+// travel : 2015-10-09 Dog Beach, LLC
 travel
 
 // travelchannel : 2015-07-02 Lifestyle Domain Holdings, Inc.
@@ -10160,9 +10171,6 @@ visa
 // vision : 2013-12-05 Binky Moon, LLC
 vision
 
-// vistaprint : 2014-09-18 Vistaprint Limited
-vistaprint
-
 // viva : 2014-11-07 Saudi Telecom Company
 viva
 
@@ -10340,7 +10348,7 @@ xin
 // xn--45q11c : 2013-11-21 Zodiac Gemini Ltd
 八卦
 
-// xn--4gbrim : 2013-10-04 Suhub Electronic Establishment
+// xn--4gbrim : 2013-10-04 Fans TLD Limited
 موقع
 
 // xn--55qw42g : 2013-11-08 China Organizational Name Administration Center
@@ -10400,7 +10408,7 @@ xin
 // xn--cck2b3b : 2015-02-26 Amazon Registry Services, Inc.
 ストア
 
-// xn--cckwcxetd : 2019-12-19 Amazon EU S.à r.l.
+// xn--cckwcxetd : 2019-12-19 Amazon Registry Services, Inc.
 アマゾン
 
 // xn--cg4bki : 2013-09-27 SAMSUNG SDS CO., LTD
@@ -10424,9 +10432,6 @@ xin
 // xn--efvy88h : 2014-08-22 Guangzhou YU Wei Information Technology Co., Ltd.
 新闻
 
-// xn--estv75g : 2015-02-19 Industrial and Commercial Bank of China Limited
-工行
-
 // xn--fct429k : 2015-04-09 Amazon Registry Services, Inc.
 家電
 
@@ -10472,7 +10477,7 @@ xin
 // xn--j1aef : 2015-01-15 VeriSign Sarl
 ком
 
-// xn--jlq480n2rg : 2019-12-19 Amazon EU S.à r.l.
+// xn--jlq480n2rg : 2019-12-19 Amazon Registry Services, Inc.
 亚马逊
 
 // xn--jlq61u9w7b : 2015-01-08 Nokia Corporation
@@ -10535,7 +10540,7 @@ xin
 // xn--nyqy26a : 2014-11-07 Stable Tone Limited
 健康
 
-// xn--otu796d : 2017-08-06 Internet DotTrademark Organisation Limited
+// xn--otu796d : 2017-08-06 Jiang Yu Liang Cai Technology Company Limited
 招聘
 
 // xn--p1acf : 2013-12-12 Rusnames Limited
@@ -10957,8 +10962,9 @@ certmgr.org
 xenapponazure.com
 
 // Civilized Discourse Construction Kit, Inc. : https://www.discourse.org/
-// Submitted by Rishabh Nambiar <rishabh.nambiar@discourse.org>
+// Submitted by Rishabh Nambiar & Michael Brown <team@discourse.org>
 discourse.group
+discourse.team
 
 // ClearVox : http://www.clearvox.nl/
 // Submitted by Leon Rowland <leon@clearvox.nl>
@@ -11688,6 +11694,7 @@ vologda.su
 // Fancy Bits, LLC : http://getchannels.com
 // Submitted by Aman Gupta <aman@getchannels.com>
 channelsdvr.net
+u.channelsdvr.net
 
 // Fastly Inc. : http://www.fastly.com/
 // Submitted by Fastly Security <security@fastly.com>
@@ -11706,6 +11713,10 @@ global.ssl.fastly.net
 // Submitted by Likhachev Vasiliy <lihachev@fastvps.ru>
 fastpanel.direct
 fastvps-server.com
+myfast.space
+myfast.host
+fastvps.site
+fastvps.host
 
 // Featherhead : https://featherhead.xyz/
 // Submitted by Simon Menke <simon@featherhead.xyz>
@@ -11719,6 +11730,13 @@ cloud.fedoraproject.org
 app.os.fedoraproject.org
 app.os.stg.fedoraproject.org
 
+// FearWorks Media Ltd. : https://fearworksmedia.co.uk
+// submitted by Keith Fairley <domains@fearworksmedia.co.uk>
+conn.uk
+copro.uk
+couk.me
+ukco.me
+
 // Fermax : https://fermax.com/
 // submitted by Koen Van Isterdael <k.vanisterdael@fermax.be>
 mydobiss.com
@@ -11739,7 +11757,6 @@ firebaseapp.com
 
 // Flynn : https://flynn.io
 // Submitted by Jonathan Rudenberg <jonathan@flynn.io>
-flynnhub.com
 flynnhosting.net
 
 // Frederik Braun https://frederik-braun.com
@@ -11911,6 +11928,10 @@ publishproxy.com
 withgoogle.com
 withyoutube.com
 
+// Aaron Marais' Gitlab pages: https://lab.aaronleem.co.za
+// Submitted by Aaron Marais <its_me@aaronleem.co.za>
+graphox.us
+
 // Group 53, LLC : https://www.group53.com
 // Submitted by Tyler Todd <noc@nova53.net>
 awsmppl.com
@@ -12228,8 +12249,8 @@ eu.meteorapp.com
 co.pl
 
 // Microsoft Corporation : http://microsoft.com
-// Submitted by Justin Luk <juluk@microsoft.com>
-azurecontainer.io
+// Submitted by Mostafa Elzeiny <moelzein@microsoft.com>
+*.azurecontainer.io
 azurewebsites.net
 azure-mobile.net
 cloudapp.net
@@ -12432,12 +12453,13 @@ pcloud.host
 nyc.mn
 
 // NymNom : https://nymnom.com/
-// Submitted by Dave McCormack <dave.mccormack@nymnom.com>
+// Submitted by NymNom <psl@nymnom.com>
 nom.ae
 nom.af
 nom.ai
 nom.al
 nym.by
+nom.bz
 nym.bz
 nom.cl
 nym.ec
@@ -12459,6 +12481,7 @@ nom.li
 nym.li
 nym.lt
 nym.lu
+nom.lv
 nym.me
 nom.mk
 nym.mn
@@ -12566,6 +12589,12 @@ on-web.fr
 *.platform.sh
 *.platformsh.site
 
+// Platter: https://platter.dev
+// Submitted by Patrick Flor <patrick@platter.dev>
+platter-app.com
+platter-app.dev
+platterp.us
+
 // Port53 : https://port53.io/
 // Submitted by Maximilian Schieder <maxi@zeug.co>
 dyn53.io
@@ -12607,6 +12636,10 @@ pubtls.org
 // Submitted by Xavier De Cock <xdecock@gmail.com>
 qualifioapp.com
 
+// QuickBackend: https://www.quickbackend.com
+// Submitted by Dani Biro <dani@pymet.com>
+qbuser.com
+
 // Redstar Consultants : https://www.redstarconsultants.com/
 // Submitted by Jons Slemmer <jons@redstarconsultants.com>
 instantcloud.cn
@@ -12721,6 +12754,10 @@ my-firewall.org
 myfirewall.org
 spdns.org
 
+// Senseering GmbH : https://www.senseering.de
+// Submitted by Felix Mönckemeyer <f.moenckemeyer@senseering.de>
+senseering.net
+
 // Service Online LLC : http://drs.ua/
 // Submitted by Serhii Bulakh <support@drs.ua>
 biz.ua
@@ -12771,6 +12808,10 @@ static.land
 dev.static.land
 sites.static.land
 
+// Sony Interactive Entertainment LLC : https://sie.com/
+// Submitted by David Coles <david.coles@sony.com>
+playstation-cloud.com
+
 // SourceLair PC : https://www.sourcelair.com
 // Submitted by Antonis Kalipetis <akalipetis@sourcelair.com>
 apps.lair.io
@@ -12945,6 +12986,11 @@ inc.hk
 virtualuser.de
 virtual-user.de
 
+// urown.net : https://urown.net
+// Submitted by Hostmaster <hostmaster@urown.net>
+urown.cloud
+dnsupdate.info
+
 // .US
 // Submitted by Ed Moore <Ed.Moore@lib.de.us>
 lib.de.us
@@ -12988,8 +13034,18 @@ wedeploy.sh
 remotewd.com
 
 // Wikimedia Labs : https://wikitech.wikimedia.org
-// Submitted by Yuvi Panda <yuvipanda@wikimedia.org>
+// Submitted by Arturo Borrero Gonzalez <aborrero@wikimedia.org>
 wmflabs.org
+toolforge.org
+wmcloud.org
+
+// WoltLab GmbH : https://www.woltlab.com
+// Submitted by Tim Düsterhus <security@woltlab.cloud>
+myforum.community
+community-pro.de
+diskussionsbereich.de
+community-pro.net
+meinforum.net
 
 // XenonCloud GbR: https://xenoncloud.net
 // Submitted by Julian Uphoff <publicsuffixlist@xenoncloud.net>
@@ -13053,7 +13109,6 @@ bss.design
 // Submitted by Emil Stahl <esp@zitcom.dk>
 basicserver.io
 virtualserver.io
-site.builder.nu
 enterprisecloud.nu
 
 // ===END PRIVATE DOMAINS===

data/lib/public_suffix/list.rb

@@ -216,7 +216,7 @@ module PublicSuffix
 
       rules
     end
-    private :select # rubocop:disable Style/AccessModifierDeclarations
+    private :select
 
     # Gets the default rule.
     #

data/lib/public_suffix/rule.rb

@@ -22,7 +22,7 @@ module PublicSuffix
   module Rule
 
     # @api internal
-    Entry = Struct.new(:type, :length, :private)
+    Entry = Struct.new(:type, :length, :private) # rubocop:disable Lint/StructNewOverride
 
     # = Abstract rule class
     #

data/lib/public_suffix/version.rb

@@ -9,5 +9,5 @@
 
 module PublicSuffix
   # The current library version.
-  VERSION = "4.0.3"
+  VERSION = "4.0.4"
 end

data/public_suffix.gemspec

@@ -18,8 +18,4 @@ Gem::Specification.new do |s|
   s.files            = `git ls-files`.split("\n")
   s.test_files       = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.extra_rdoc_files = %w( LICENSE.txt )
-
-  s.add_development_dependency "rake"
-  s.add_development_dependency "mocha"
-  s.add_development_dependency "yard"
 end

data/test/acceptance_test.rb

@@ -5,14 +5,14 @@ require "test_helper"
 class AcceptanceTest < Minitest::Test
 
   VALID_CASES = [
-      ["example.com",             "example.com",        [nil, "example", "com"]],
-      ["foo.example.com",         "example.com",        ["foo", "example", "com"]],
+    ["example.com",             "example.com", [nil, "example", "com"]],
+    ["foo.example.com",         "example.com",        ["foo", "example", "com"]],
 
-      ["verybritish.co.uk",       "verybritish.co.uk",  [nil, "verybritish", "co.uk"]],
-      ["foo.verybritish.co.uk",   "verybritish.co.uk",  ["foo", "verybritish", "co.uk"]],
+    ["verybritish.co.uk",       "verybritish.co.uk",  [nil, "verybritish", "co.uk"]],
+    ["foo.verybritish.co.uk",   "verybritish.co.uk",  ["foo", "verybritish", "co.uk"]],
 
-      ["parliament.uk",           "parliament.uk",      [nil, "parliament", "uk"]],
-      ["foo.parliament.uk",       "parliament.uk",      ["foo", "parliament", "uk"]],
+    ["parliament.uk",           "parliament.uk",      [nil, "parliament", "uk"]],
+    ["foo.parliament.uk",       "parliament.uk",      ["foo", "parliament", "uk"]],
   ].freeze
 
   def test_valid
@@ -34,10 +34,10 @@ class AcceptanceTest < Minitest::Test
 
 
   INVALID_CASES = [
-      ["nic.bd",                  PublicSuffix::DomainNotAllowed],
-      [nil,                       PublicSuffix::DomainInvalid],
-      ["",                        PublicSuffix::DomainInvalid],
-      ["  ",                      PublicSuffix::DomainInvalid],
+    ["nic.bd", PublicSuffix::DomainNotAllowed],
+    [nil,                       PublicSuffix::DomainInvalid],
+    ["",                        PublicSuffix::DomainInvalid],
+    ["  ",                      PublicSuffix::DomainInvalid],
   ].freeze
 
   def test_invalid
@@ -49,16 +49,16 @@ class AcceptanceTest < Minitest::Test
 
 
   REJECTED_CASES = [
-      ["www. .com",           true],
-      ["foo.co..uk",          true],
-      ["goo,gle.com",         true],
-      ["-google.com",         true],
-      ["google-.com",         true],
-
-      # This case was covered in GH-15.
-      # I decided to cover this case because it's not easily reproducible with URI.parse
-      # and can lead to several false positives.
-      ["http://google.com",   false],
+    ["www. .com", true],
+    ["foo.co..uk",          true],
+    ["goo,gle.com",         true],
+    ["-google.com",         true],
+    ["google-.com",         true],
+
+    # This case was covered in GH-15.
+    # I decided to cover this case because it's not easily reproducible with URI.parse
+    # and can lead to several false positives.
+    ["http://google.com",   false],
   ].freeze
 
   def test_rejected
@@ -72,9 +72,9 @@ class AcceptanceTest < Minitest::Test
 
 
   CASE_CASES = [
-      ["Www.google.com", %w( www google com )],
-      ["www.Google.com", %w( www google com )],
-      ["www.google.Com", %w( www google com )],
+    ["Www.google.com", %w( www google com )],
+    ["www.Google.com", %w( www google com )],
+    ["www.google.Com", %w( www google com )],
   ].freeze
 
   def test_ignore_case
@@ -90,10 +90,10 @@ class AcceptanceTest < Minitest::Test
 
 
   INCLUDE_PRIVATE_CASES = [
-      ["blogspot.com", true, "blogspot.com"],
-      ["blogspot.com", false, nil],
-      ["subdomain.blogspot.com", true, "blogspot.com"],
-      ["subdomain.blogspot.com", false, "subdomain.blogspot.com"],
+    ["blogspot.com", true, "blogspot.com"],
+    ["blogspot.com", false, nil],
+    ["subdomain.blogspot.com", true, "blogspot.com"],
+    ["subdomain.blogspot.com", false, "subdomain.blogspot.com"],
   ].freeze
 
   def test_ignore_private
@@ -115,14 +115,14 @@ class AcceptanceTest < Minitest::Test
   def valid_uri?(name)
     uri = URI.parse(name)
     !uri.host.nil?
-  rescue
+  rescue StandardError
     false
   end
 
   def valid_domain?(name)
     uri = URI.parse(name)
     !uri.host.nil? && uri.scheme.nil?
-  rescue
+  rescue StandardError
     false
   end
 

data/test/unit/public_suffix_test.rb

@@ -141,13 +141,13 @@ class PublicSuffixTest < Minitest::Test
 
   def test_self_normalize
     [
-        ["com", "com"],
-        ["example.com", "example.com"],
-        ["www.example.com", "www.example.com"],
+      ["com", "com"],
+      ["example.com", "example.com"],
+      ["www.example.com", "www.example.com"],
 
-        ["example.com.",  "example.com"],     # strip FQDN
-        [" example.com ", "example.com"],     # strip spaces
-        ["Example.COM",   "example.com"],     # downcase
+      ["example.com.",  "example.com"],     # strip FQDN
+      [" example.com ", "example.com"],     # strip spaces
+      ["Example.COM",   "example.com"],     # downcase
     ].each do |input, output|
       assert_equal output, PublicSuffix.normalize(input)
     end
@@ -155,9 +155,9 @@ class PublicSuffixTest < Minitest::Test
 
   def test_normalize_blank
     [
-        nil,
-        "",
-        " ",
+      nil,
+      "",
+      " ",
     ].each do |input|
       error = PublicSuffix.normalize(input)
       assert_instance_of PublicSuffix::DomainInvalid, error
@@ -167,7 +167,7 @@ class PublicSuffixTest < Minitest::Test
 
   def test_normalize_scheme
     [
-        "https://google.com",
+      "https://google.com",
     ].each do |input|
       error = PublicSuffix.normalize(input)
       assert_instance_of PublicSuffix::DomainInvalid, error
@@ -177,7 +177,7 @@ class PublicSuffixTest < Minitest::Test
 
   def test_normalize_leading_dot
     [
-        ".google.com",
+      ".google.com",
     ].each do |input|
       error = PublicSuffix.normalize(input)
       assert_instance_of PublicSuffix::DomainInvalid, error

data/test/unit/rule_test.rb

@@ -70,36 +70,36 @@ class PublicSuffix::RuleBaseTest < Minitest::Test
 
   def test_match
     [
-        # standard match
-        [PublicSuffix::Rule.factory("uk"), "uk", true],
-        [PublicSuffix::Rule.factory("uk"), "example.uk", true],
-        [PublicSuffix::Rule.factory("uk"), "example.co.uk", true],
-        [PublicSuffix::Rule.factory("co.uk"), "example.co.uk", true],
-
-        # FIXME
-        # [PublicSuffix::Rule.factory("*.com"), "com", false],
-        [PublicSuffix::Rule.factory("*.com"), "example.com", true],
-        [PublicSuffix::Rule.factory("*.com"), "foo.example.com", true],
-        [PublicSuffix::Rule.factory("!example.com"), "com", false],
-        [PublicSuffix::Rule.factory("!example.com"), "example.com", true],
-        [PublicSuffix::Rule.factory("!example.com"), "foo.example.com", true],
-
-        # TLD mismatch
-        [PublicSuffix::Rule.factory("gk"), "example.uk", false],
-        [PublicSuffix::Rule.factory("gk"), "example.co.uk", false],
-        [PublicSuffix::Rule.factory("co.uk"), "uk", false],
-
-        # general mismatch
-        [PublicSuffix::Rule.factory("uk.co"), "example.co.uk", false],
-        [PublicSuffix::Rule.factory("go.uk"), "example.co.uk", false],
-        [PublicSuffix::Rule.factory("co.uk"), "uk", false],
-
-        # partial matches/mismatches
-        [PublicSuffix::Rule.factory("co"), "example.co.uk", false],
-        [PublicSuffix::Rule.factory("example"), "example.uk", false],
-        [PublicSuffix::Rule.factory("le.it"), "example.it", false],
-        [PublicSuffix::Rule.factory("le.it"), "le.it", true],
-        [PublicSuffix::Rule.factory("le.it"), "foo.le.it", true],
+      # standard match
+      [PublicSuffix::Rule.factory("uk"), "uk", true],
+      [PublicSuffix::Rule.factory("uk"), "example.uk", true],
+      [PublicSuffix::Rule.factory("uk"), "example.co.uk", true],
+      [PublicSuffix::Rule.factory("co.uk"), "example.co.uk", true],
+
+      # FIXME
+      # [PublicSuffix::Rule.factory("*.com"), "com", false],
+      [PublicSuffix::Rule.factory("*.com"), "example.com", true],
+      [PublicSuffix::Rule.factory("*.com"), "foo.example.com", true],
+      [PublicSuffix::Rule.factory("!example.com"), "com", false],
+      [PublicSuffix::Rule.factory("!example.com"), "example.com", true],
+      [PublicSuffix::Rule.factory("!example.com"), "foo.example.com", true],
+
+      # TLD mismatch
+      [PublicSuffix::Rule.factory("gk"), "example.uk", false],
+      [PublicSuffix::Rule.factory("gk"), "example.co.uk", false],
+      [PublicSuffix::Rule.factory("co.uk"), "uk", false],
+
+      # general mismatch
+      [PublicSuffix::Rule.factory("uk.co"), "example.co.uk", false],
+      [PublicSuffix::Rule.factory("go.uk"), "example.co.uk", false],
+      [PublicSuffix::Rule.factory("co.uk"), "uk", false],
+
+      # partial matches/mismatches
+      [PublicSuffix::Rule.factory("co"), "example.co.uk", false],
+      [PublicSuffix::Rule.factory("example"), "example.uk", false],
+      [PublicSuffix::Rule.factory("le.it"), "example.it", false],
+      [PublicSuffix::Rule.factory("le.it"), "le.it", true],
+      [PublicSuffix::Rule.factory("le.it"), "foo.le.it", true],
 
     ].each do |rule, input, expected|
       assert_equal expected, rule.match?(input)

metadata

@@ -1,57 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: public_suffix
 version: !ruby/object:Gem::Version
-  version: 4.0.3
+  version: 4.0.4
 platform: ruby
 authors:
 - Simone Carletti
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-05 00:00:00.000000000 Z
-dependencies:
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: mocha
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: yard
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
+date: 2020-04-05 00:00:00.000000000 Z
+dependencies: []
 description: PublicSuffix can parse and decompose a domain name into top level domain,
   domain and subdomains.
 email:
@@ -64,7 +22,7 @@ files:
 - ".github/FUNDING.yml"
 - ".gitignore"
 - ".rubocop.yml"
-- ".rubocop_defaults.yml"
+- ".rubocop_opinionated.yml"
 - ".travis.yml"
 - ".yardopts"
 - 2.0-Upgrade.md